From 32ae22e4c7bac0fbd0a29ed595f16586318fa589 Mon Sep 17 00:00:00 2001 From: Gregor Schmidt Date: Fri, 7 Oct 2011 17:31:02 +0200 Subject: [PATCH] Adding preventDefault for some onclick handlers this should avoid ugly '#' in the location bar --- public/javascripts/application.coffee | 2 ++ public/javascripts/application.js | 2 ++ 2 files changed, 4 insertions(+) diff --git a/public/javascripts/application.coffee b/public/javascripts/application.coffee index 9acb0d9..0bb364c 100644 --- a/public/javascripts/application.coffee +++ b/public/javascripts/application.coffee @@ -25,6 +25,7 @@ class MailCatcher height: e.clientY - $('#messages').offset().top $('nav.app .clear a').live 'click', (e) => + e.preventDefault() if confirm "You will lose all your received messages.\n\nAre you sure you want to clear all messages?" $.ajax url: '/messages' @@ -37,6 +38,7 @@ class MailCatcher alert 'Error while quitting.' $('nav.app .quit a').live 'click', (e) => + e.preventDefault() if confirm "You will lose all your received messages.\n\nAre you sure you want to quit?" $.ajax type: 'DELETE' diff --git a/public/javascripts/application.js b/public/javascripts/application.js index 509a13a..045eb81 100644 --- a/public/javascripts/application.js +++ b/public/javascripts/application.js @@ -34,6 +34,7 @@ } }); $('nav.app .clear a').live('click', __bind(function(e) { + e.preventDefault(); if (confirm("You will lose all your received messages.\n\nAre you sure you want to clear all messages?")) { return $.ajax({ url: '/messages', @@ -50,6 +51,7 @@ } }, this)); $('nav.app .quit a').live('click', __bind(function(e) { + e.preventDefault(); if (confirm("You will lose all your received messages.\n\nAre you sure you want to quit?")) { return $.ajax({ type: 'DELETE',