moparisthebest
/
mail
mirror of https://github.com/moparisthebest/mail
1
0
Fork 0
Code Issues Releases Wiki Activity

[WO-955] WO-03-023 STARTTLS Setting leads to opportunistic STARTSSL

This commit is contained in:
Felix Hammerl 2015-04-21 18:16:21 +02:00
parent 8b42f83b35
commit b5c917f95a
5 changed files with 14 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
package.json
View File

@ -62,7 +62,7 @@
"grunt-svgmin": "~1.0.0",
"grunt-svgstore": "~0.3.4",
"iframe-resizer": "^2.8.3",
"imap-client": "~0.14.0",
"imap-client": "https://github.com/whiteout-io/imap-client/tarball/dev/WO-955",
"jquery": "~2.1.1",
"mailbuild": "^0.3.7",
"mailreader": "~0.4.0",
@ -70,7 +70,7 @@
"ng-infinite-scroll": "~1.1.2",
"openpgp": "^1.0.0",
"pgpbuilder": "~0.6.0",
"pgpmailer": "~0.9.0",
"pgpmailer": "https://github.com/whiteout-io/pgpmailer/tarball/dev/WO-955",
"sinon": "~1.7.3",
"tcp-socket": "~0.5.0",
"time-grunt": "^1.0.0",

2
src/js/controller/login/login-set-credentials.js
View File

@ -68,12 +68,14 @@ var SetCredentialsCtrl = function($scope, $location, $routeParams, $q, auth, con
host: $scope.imapHost.toLowerCase(),
port: $scope.imapPort,
secure: imapEncryption === ENCRYPTION_METHOD_TLS,
requireTLS: imapEncryption === ENCRYPTION_METHOD_STARTTLS,
ignoreTLS: imapEncryption === ENCRYPTION_METHOD_NONE
},
smtp: {
host: $scope.smtpHost.toLowerCase(),
port: $scope.smtpPort,
secure: smtpEncryption === ENCRYPTION_METHOD_TLS,
requireTLS: smtpEncryption === ENCRYPTION_METHOD_STARTTLS,
ignoreTLS: smtpEncryption === ENCRYPTION_METHOD_NONE
}
};

4
src/js/service/auth.js
View File

@ -94,6 +94,8 @@ Auth.prototype.getCredentials = function() {
var credentials = {
imap: {
secure: self.imap.secure,
requireTLS: self.imap.requireTLS,
ignoreTLS: self.imap.ignoreTLS,
port: self.imap.port,
host: self.imap.host,
ca: self.imap.ca,
@ -105,6 +107,8 @@ Auth.prototype.getCredentials = function() {
},
smtp: {
secure: self.smtp.secure,
requireTLS: self.smtp.requireTLS,
ignoreTLS: self.smtp.ignoreTLS,
port: self.smtp.port,
host: self.smtp.host,
ca: self.smtp.ca,

2
src/js/util/connection-doctor.js
View File

@ -53,6 +53,7 @@ ConnectionDoctor.prototype.configure = function(credentials) {
port: this.credentials.imap.port,
secure: this.credentials.imap.secure,
ignoreTLS: this.credentials.imap.ignoreTLS,
requireTLS: this.credentials.imap.requireTLS,
ca: this.credentials.imap.ca,
tlsWorkerPath: this._workerPath,
auth: {
@ -65,6 +66,7 @@ ConnectionDoctor.prototype.configure = function(credentials) {
this._smtp = new SmtpClient(this.credentials.smtp.host, this.credentials.smtp.port, {
useSecureTransport: this.credentials.smtp.secure,
ignoreTLS: this.credentials.smtp.ignoreTLS,
requireTLS: this.credentials.smtp.requireTLS,
ca: this.credentials.smtp.ca,
tlsWorkerPath: this._workerPath,
auth: {

6
test/unit/controller/login/login-set-credentials-ctrl-test.js
View File

@ -71,13 +71,15 @@ describe('Login (Set Credentials) Controller unit test', function() {
host: scope.imapHost.toLowerCase(),
port: scope.imapPort,
secure: true,
ignoreTLS: false
ignoreTLS: false,
requireTLS: false
},
smtp: {
host: scope.smtpHost.toLowerCase(),
port: scope.smtpPort,
secure: false,
ignoreTLS: false
ignoreTLS: false,
requireTLS: true
}
};