Refactor crypto module

src/js/crypto/crypto.js

@@ -13,27 +13,22 @@ var aes = require('crypto-lib').aes,
  * High level crypto api that invokes native crypto (if available) and
  * gracefully degrades to JS crypto (if unavailable)
  */
-function Crypto() {}
+function Crypto($q) {
+    this._q = $q;
+}
 
 /**
  * Encrypt plaintext using AES-GCM.
  * @param  {String}   plaintext The input string in UTF-16
  * @param  {String}   key The base64 encoded key
  * @param  {String}   iv The base64 encoded IV
- * @param  {Function} callback(error, ciphertext)
  * @return {String} The base64 encoded ciphertext
  */
-Crypto.prototype.encrypt = function(plaintext, key, iv, callback) {
+Crypto.prototype.encrypt = function(plaintext, key, iv) {
-    var ct;
+    return this._q(function(resolve) {
-
+        var ct = aes.encrypt(plaintext, key, iv);
-    try {
+        resolve(ct);
-        ct = aes.encrypt(plaintext, key, iv);
+    });
-    } catch (err) {
-        callback(err);
-        return;
-    }
-
-    callback(null, ct);
 };
 
 /**
@@ -41,34 +36,26 @@ Crypto.prototype.encrypt = function(plaintext, key, iv, callback) {
  * @param  {String}   ciphertext The base64 encoded ciphertext
  * @param  {String}   key The base64 encoded key
  * @param  {String}   iv The base64 encoded IV
- * @param  {Function} callback(error, plaintext)
  * @return {String} The decrypted plaintext in UTF-16
  */
-Crypto.prototype.decrypt = function(ciphertext, key, iv, callback) {
+Crypto.prototype.decrypt = function(ciphertext, key, iv) {
-    var pt;
+    return this._q(function(resolve) {
-
+        var pt = aes.decrypt(ciphertext, key, iv);
-    try {
+        resolve(pt);
-        pt = aes.decrypt(ciphertext, key, iv);
+    });
-    } catch (err) {
-        callback(err);
-        return;
-    }
-
-    callback(null, pt);
 };
 
 /**
  * Do PBKDF2 key derivation in a WebWorker thread
  */
-Crypto.prototype.deriveKey = function(password, salt, keySize, callback) {
+Crypto.prototype.deriveKey = function(password, salt, keySize) {
-    startWorker({
+    return this.startWorker({
         script: config.workerPath + '/pbkdf2-worker.min.js',
         args: {
             password: password,
             salt: salt,
             keySize: keySize
         },
-        callback: callback,
         noWorker: function() {
             return pbkdf2.getKey(password, salt, keySize);
         }
@@ -79,27 +66,25 @@ Crypto.prototype.deriveKey = function(password, salt, keySize, callback) {
 // helper functions
 //
 
-function startWorker(options) {
+Crypto.prototype.startWorker = function(options) {
+    return this._q(function(resolve, reject) {
         // check for WebWorker support
         if (window.Worker) {
             // init webworker thread
             var worker = new Worker(options.script);
             worker.onmessage = function(e) {
-            if (e.data.err) {
-                options.callback(e.data.err);
-                return;
-            }
                 // return result from the worker
-            options.callback(null, e.data);
+                if (e.data.err) {
+                    reject(e.data.err);
+                } else {
+                    resolve(e.data);
+                }
             };
             worker.onerror = function(e) {
                 // show error message in logger
                 axe.error('Error handling web worker: Line ' + e.lineno + ' in ' + e.filename + ': ' + e.message);
                 // return error
-            options.callback({
+                reject(e);
-                errMsg: (e.message) ? e.message : e
-            });
-            return;
             };
             // send data to the worker
             worker.postMessage(options.args);
@@ -107,15 +92,7 @@ function startWorker(options) {
         }
 
         // no WebWorker support... do synchronous call
-    var result;
+        var result = options.noWorker();
-    try {
+        resolve(result);
-        result = options.noWorker();
-    } catch (e) {
-        // return error
-        options.callback({
-            errMsg: (e.message) ? e.message : e
     });
-        return;
+};
-    }
-    options.callback(null, result);
-}

test/unit/crypto/crypto-test.js

@@ -13,7 +13,7 @@ describe('Crypto unit tests', function() {
         ivSize = config.symIvSize;
 
     beforeEach(function() {
-        crypto = new Crypto();
+        crypto = new Crypto(qMock);
     });
 
     afterEach(function() {});
@@ -24,32 +24,27 @@ describe('Crypto unit tests', function() {
             var key = util.random(keySize);
             var iv = util.random(ivSize);
 
-            crypto.encrypt(plaintext, key, iv, function(err, ciphertext) {
+            crypto.encrypt(plaintext, key, iv).then(function(ciphertext) {
-                expect(err).to.not.exist;
                 expect(ciphertext).to.exist;
 
-                crypto.decrypt(ciphertext, key, iv, function(err, decrypted) {
+                return crypto.decrypt(ciphertext, key, iv);
-                    expect(err).to.not.exist;
+            }).then(function(decrypted) {
                 expect(decrypted).to.equal(plaintext);
 
                 done();
             });
         });
     });
-    });
 
     describe("PBKDF2 (Async/Worker)", function() {
         it('should work', function(done) {
             var salt = util.random(keySize);
 
-            crypto.deriveKey(password, salt, keySize, function(err, key) {
+            crypto.deriveKey(password, salt, keySize).then(function(key) {
-                expect(err).to.not.exist;
                 expect(util.base642Str(key).length * 8).to.equal(keySize);
-
                 done();
             });
         });
-
     });
 
 });