moparisthebest/mail
1
0
Fork 0
mirror of https://github.com/moparisthebest/mail synced 2024-11-26 10:52:17 -05:00
Code Issues Releases Wiki Activity

[WO-751] Change naming from favorite to flag

Browse Source
This commit is contained in:
Felix Hammerl 2014-12-03 10:46:42 +01:00
parent 9d8fc023ca
commit 7d3e6b0f2f
5 changed files with 15 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/js/controller/app/action-bar.js
View File

@ -169,7 +169,7 @@ var ActionBarCtrl = function($scope, email, dialog, statusDisplay) {
return; return;
} }
statusDisplay.update(flagged ? 'Adding message to favorites...' : 'Removing message from favorites'); statusDisplay.update(flagged ? 'Adding flag to message...' : 'Removing flag from message');
var originalState = message.flagged; var originalState = message.flagged;
message.flagged = flagged; message.flagged = flagged;
@ -180,7 +180,7 @@ var ActionBarCtrl = function($scope, email, dialog, statusDisplay) {
if (err && err.code === 42) { if (err && err.code === 42) {
// offline, restore // offline, restore
message.unread = originalState; message.unread = originalState;
statusDisplay.update('Unable to ' + (flagged ? 'add message to' : 'remove message from') + ' favorites in offline mode!'); statusDisplay.update('Unable to ' + (flagged ? 'add flag to message' : 'remove flag from message') + ' in offline mode!');
return; return;
} }

4
src/sass/blocks/views/_mail-list.scss
View File

@ -220,7 +220,7 @@
&__flags-checked { &__flags-checked {
display: none; // feature on touch layout not available for now display: none; // feature on touch layout not available for now
} }
&__flags-favorite { &__flags-flagged {
display: none; // feature on touch layout not available for now display: none; // feature on touch layout not available for now
} }
&__flags-encrypted { &__flags-encrypted {
@ -373,7 +373,7 @@
padding: 0.5em 0 0.5em 1em; padding: 0.5em 0 0.5em 1em;
} }
} }
&__flags-favorite { &__flags-flagged {
// add invisible padding to increase clickable area around star // add invisible padding to increase clickable area around star
margin: -0.5em 0 -0.5em; margin: -0.5em 0 -0.5em;
padding: 0.5em 0 0.5em; padding: 0.5em 0 0.5em;

4
src/tpl/action-bar.html
View File

@ -37,7 +37,7 @@
<ul id="dropdown-more" class="dropdown"> <ul id="dropdown-more" class="dropdown">
<li><button wo-touch="state.read.open ? markMessage(state.mailList.selected, false) : markCheckedMessages(false)">Mark as read</button></li> <li><button wo-touch="state.read.open ? markMessage(state.mailList.selected, false) : markCheckedMessages(false)">Mark as read</button></li>
<li><button wo-touch="state.read.open ? markMessage(state.mailList.selected, true) : markCheckedMessages(true)">Mark as unread</button></li> <li><button wo-touch="state.read.open ? markMessage(state.mailList.selected, true) : markCheckedMessages(true)">Mark as unread</button></li>
<li><button wo-touch="state.read.open ? flagMessage(state.mailList.selected, true) : flagCheckedMessages(true)">Flag message</button></li> <li><button wo-touch="state.read.open ? flagMessage(state.mailList.selected, true) : flagCheckedMessages(true)">Add flag</button></li>
<li><button wo-touch="state.read.open ? flagMessage(state.mailList.selected, false) : flagCheckedMessages(false)">Unflag message</button></li> <li><button wo-touch="state.read.open ? flagMessage(state.mailList.selected, false) : flagCheckedMessages(false)">Remove flag</button></li>
</ul><!--/dropdown--> </ul><!--/dropdown-->
</div> </div>

6
src/tpl/mail-list.html
View File

@ -37,9 +37,9 @@
<span><svg role="presentation"><use xlink:href="#icon-check" /></svg></span> <span><svg role="presentation"><use xlink:href="#icon-check" /></svg></span>
</label> </label>
</li> </li>
<li class="mail-list-entry__flags-favorite" wo-touch="flag(email, !email.flagged); $event.stopPropagation()"> <li class="mail-list-entry__flags-flagged" wo-touch="flag(email, !email.flagged); $event.stopPropagation()">
<svg ng-show="email.flagged"><use xlink:href="#icon-star_filled" /><title>Favorited</title></svg> <svg ng-show="email.flagged"><use xlink:href="#icon-star_filled" /><title>Flagged</title></svg>
<svg ng-show="!email.flagged"><use xlink:href="#icon-star" /><title>Not Favorited</title></svg> <svg ng-show="!email.flagged"><use xlink:href="#icon-star" /><title>Not Flagged</title></svg>
</li> </li>
<li class="mail-list-entry__flags-encrypted"> <li class="mail-list-entry__flags-encrypted">
<svg ng-show="email.encrypted"><use xlink:href="#icon-encrypted" /><title>Encrypted</title></svg> <svg ng-show="email.encrypted"><use xlink:href="#icon-encrypted" /><title>Encrypted</title></svg>

12
src/tpl/read.html
View File

@ -16,9 +16,9 @@
<header class="read__header"> <header class="read__header">
<div class="read__controls"> <div class="read__controls">
<span class="u-hidden-lg" ng-controller="ActionBarCtrl"> <span class="u-hidden-lg" ng-controller="ActionBarCtrl">
<button wo-touch="flagMessage(state.mailList.selected, !state.mailList.selected.flagged)" class="btn-icon-light" title="{{state.mailList.selected.flagged ? 'Remove from Favorites' : 'Add to Favorites'}}"> <button wo-touch="flagMessage(state.mailList.selected, !state.mailList.selected.flagged)" class="btn-icon-light" title="{{state.mailList.selected.flagged ? 'Remove Flag' : 'Add Flag'}}">
<svg ng-show="state.mailList.selected.flagged"><use xlink:href="#icon-star_filled" /><title>Favorited</title></svg> <svg ng-show="state.mailList.selected.flagged"><use xlink:href="#icon-star_filled" /><title>Flagged</title></svg>
<svg ng-show="!state.mailList.selected.flagged"><use xlink:href="#icon-star" /><title>Not Favorited</title></svg> <svg ng-show="!state.mailList.selected.flagged"><use xlink:href="#icon-star" /><title>Not Flagged</title></svg>
</button> </button>
<button class="btn-icon-light" title="Move mail" wo-dropdown="#read-dropdown-folder" wo-dropdown-position="center"> <button class="btn-icon-light" title="Move mail" wo-dropdown="#read-dropdown-folder" wo-dropdown-position="center">
<svg><use xlink:href="#icon-folder" /><title>Move mail</title></svg> <svg><use xlink:href="#icon-folder" /><title>Move mail</title></svg>
@ -128,9 +128,9 @@
<div class="toolbar"> <div class="toolbar">
<ul class="toolbar__actions"> <ul class="toolbar__actions">
<li> <li>
<button wo-touch="flagMessage(state.mailList.selected, !state.mailList.selected.flagged)" class="btn-icon-light" title="{{state.mailList.selected.flagged ? 'Remove from Favorites' : 'Add to Favorites'}}"> <button wo-touch="flagMessage(state.mailList.selected, !state.mailList.selected.flagged)" class="btn-icon-light" title="{{state.mailList.selected.flagged ? 'Remove Flag' : 'Add Flag'}}">
<svg ng-show="state.mailList.selected.flagged"><use xlink:href="#icon-star_filled" /><title>Favorited</title></svg> <svg ng-show="state.mailList.selected.flagged"><use xlink:href="#icon-star_filled" /><title>Flagged</title></svg>
<svg ng-show="!state.mailList.selected.flagged"><use xlink:href="#icon-star" /><title>Not Favorited</title></svg> <svg ng-show="!state.mailList.selected.flagged"><use xlink:href="#icon-star" /><title>Not Flagged</title></svg>
</button> </button>
</li> </li>
<li> <li>