mirror of
https://github.com/moparisthebest/k-9
synced 2025-01-30 14:50:14 -05:00
bfb0316583
The problem:
Configure the account (just an example -- problems can occur in other
configurations as well):
Message Format: HTML
Reply quoting style: Prefix
Quote message when replying: yes
Reply after quoted text: yes
Reply to a message that has a large quantity (20+) of \r\n scattered in
the body of its HTML version (not an unusual scenario).
Add a reply. Save the message as a draft. Go back & open the draft
again. A fatal IndexOutOfBoundsException occurs.
The cause:
When the draft was saved, the X-K9mail-Identity header was computed and
added to the message, then the text of the message was processed with
MimeUtility.fixDraftTextBody, replacing all occurrences of \r\n with \n in
the quoted message before being saved in LocalStore, thus invalidating the
X-K9mail-Identity header.
The fix:
Remove MimeUtility.fixDraftTextBody and implement
MessageCompose$EolConvertingEditText instead. Any message text placed in
an EolConvertingEditText widget is assured to have \n line endings. Any
message text extracted from an EolConvertingEditText widget is assured to
have \r\n line endings. The X-K9mail-Identity header will always be
computed correctly.
Issues thought to be related: 4782, 5010, 5634, 5725
As noted in some of the referenced issues, errors didn't always result in
a fatal exception, but instead with mixed up text.
Ref: commit
|
||
|---|---|---|
| assets | ||
| compile-only-libs | ||
| docs | ||
| images | ||
| libs | ||
| plugins | ||
| res | ||
| src | ||
| tests | ||
| tests-on-jvm | ||
| tools | ||
| .gitignore | ||
| .gitmodules | ||
| .project | ||
| ActionBarSherlock.iml | ||
| Android-PullToRefresh.iml | ||
| Android.mk | ||
| AndroidManifest.xml | ||
| ant.properties | ||
| build_common.xml | ||
| build.gradle | ||
| build.xml | ||
| ckChangeLog.iml | ||
| HoloColorPicker.iml | ||
| HTMLCLEANER_LICENSE | ||
| k9mail.iml | ||
| k9mail.ipr | ||
| MODULE_LICENSE_APACHE2 | ||
| NOTICE | ||
| proguard.cfg | ||
| project.properties | ||
| settings.gradle | ||