k-9/src/com/fsck/k9/mail/store
Joe Steele 01d2247ffd Change POP3 error response detection
Instead of interpreting a "-" at the beginning of a line as
an error response, consider the absence of a "+" at the
beginning of a line as an error response.

This is what Thunderbird does.

http://hg.mozilla.org/releases/comm-esr24/file/55e96a433bd1/mailnews/local/src/nsPop3Protocol.cpp#l1177

The problem arises with godaddy servers spewing additional
lines of data upon login failure.  The login was being
interpreted as successful, and a STAT commanded was subsequently
being sent, resulting in a dialog saying 'Cannot connect to
server. (Invalid int: "auth_error:")'.

$ openssl s_client -quiet -crlf -connect pop.secureserver.net:995
...
+OK <24984.1394317012@pop.secureserver.net>
user testuser
+OK
pass testpass
testuser not found in the auth database
warning: auth_error: authorization failed (no such object)
-ERR authorization failed  Check your server settings.
2014-03-11 19:10:14 -04:00
..
imap Change ImapUtility to use 'long' for the values of sequence sets 2012-07-07 16:21:07 +02:00
ImapResponseParser.java Issue 4359: IMAP message UIDs are 32 bit unsigned values and cannot be 2012-07-05 18:00:49 -04:00
ImapStore.java Rework handling of certificate errors while pushing 2014-03-11 19:08:09 -04:00
LocalStore.java Use Locale.US where appropriate 2014-03-03 10:40:23 -05:00
LockableDatabase.java Delete old journals when moving the database 2014-03-03 11:03:16 -05:00
Pop3Store.java Change POP3 error response detection 2014-03-11 19:10:14 -04:00
StorageManager.java replaced entrySet + getKey with keySet 2014-02-15 23:59:23 +01:00
UnavailableAccountException.java Big, scary massive "ant astyle" to get us back to something 2011-02-06 17:09:48 -05:00
UnavailableStorageException.java Big, scary massive "ant astyle" to get us back to something 2011-02-06 17:09:48 -05:00
WebDavSocketFactory.java Remove SimpleX509TrustManager because it's no longer used 2014-03-05 06:03:06 +01:00
WebDavStore.java Merge branch 'pr/453' 2014-03-05 06:19:55 +01:00