1
0
mirror of https://github.com/moparisthebest/k-9 synced 2024-11-10 11:35:11 -05:00
Go to file
Joe Steele 6f14294164 Remove SslHelper. Don't use SecureRandom.
SslHelper has been removed, and its functionality has been transferred
into TrustedSocketFactory.  The added layer of indirection wasn't really
simplifying anything.  It's now easier to see what happens when
createSocket() is invoked.

A new instance of SecureRandom is no longer passed to SSLContext.init().
Instead, null is passed.

The (default) provider of the TLS SSLContext used is OpenSSLProvider,
which provides an SSLSocket instance of type OpenSSLSocketImpl.  The only
use of SecureRandom is in OpenSSLSocketImpl.startHandshake(), where it is
used to seed the OpenSSL PRNG with additional random data.  But if
SecureRandom is null, then /dev/urandom is used for seeding instead.

Meanwhile, the default provider for the SecureRandom service is
OpenSSLRandom, which uses the OpenSSL PRNG as its data source.  So we were
effectively seeding the OpenSSL PRNG with itself.  That's probably okay
(we trust that the OpenSSL PRNG was properly initialized with random data
before first use), but using /dev/urandom would seem like a better source
(or at least as good a source) for the additional seed data added with
each new connection.

Note that our PRNGFixes class replaces the default SecureRandom service
with one whose data source is /dev/urandom for certain vulnerable API
levels anyway.  (It also makes sure that the OpenSSL PRNG is properly
seeded before first use for certain vulnerable API levels.)
2014-09-06 18:15:25 -04:00
.tx Add Transifex config 2014-01-04 01:52:09 +01:00
assets Recreate app icon from SVG file 2013-11-11 01:09:09 +01:00
compile-only-libs upgrade our android-support library in the hopes that the newer version 2013-07-17 18:36:31 -04:00
docs Added diagram that visualizes activity interactions 2011-10-27 19:13:13 +02:00
gradle/wrapper Use latest Gradle Android plugin and build tools 2014-06-14 03:29:44 +02:00
images Change appearance of unread widget 2013-03-16 01:57:21 +01:00
libs upgraded Mime4J 0.7-SNAPSHOT -> 0.7.2 (fixes MimeMultipart parser bug) 2012-08-15 01:47:57 +02:00
plugins Use latest Gradle Android plugin and build tools 2014-07-26 18:06:20 +02:00
res Merge pull request #485 from haselwarter 2014-09-04 23:55:30 +02:00
src/com/fsck/k9 Remove SslHelper. Don't use SecureRandom. 2014-09-06 18:15:25 -04:00
tests Fixes needed after merging in master 2014-07-04 19:23:43 -04:00
tests-on-jvm Fix 'testsOnJVM' Gradle task 2014-06-21 15:33:45 +02:00
tools Add script to fix up the files we pull from Transifex 2014-04-08 18:05:04 +02:00
.gitignore Remove old IntelliJ project files 2014-03-01 05:02:17 +01:00
.gitmodules Kill our use of submodules dead. They're too painful for new contributors 2012-11-24 17:15:01 -05:00
.project Remove ActionBarSherlock 2014-06-21 17:09:45 +02:00
Android.mk Remove ActionBarSherlock 2014-06-21 17:09:45 +02:00
AndroidManifest.xml Bumped manifest to 4.904 2014-04-18 16:55:41 +02:00
build_common.xml fixed location of ant-contrib.jar in build_common.xml when running ant from tests/. 2012-06-07 22:57:41 -05:00
build.gradle Use latest Gradle Android plugin and build tools 2014-07-26 18:06:20 +02:00
build.xml Remove ActionBarSherlock 2014-06-21 17:09:45 +02:00
gradlew Add Gradle wrapper 2013-11-07 06:48:10 +01:00
gradlew.bat Add Gradle wrapper 2013-11-07 06:48:10 +01:00
HTMLCLEANER_LICENSE Merge ashleywillis' changes in https://github.com/k9mail/k-9/pull/97. 2011-11-14 14:00:15 -08:00
lint.xml Fix more Lint warnings 2014-04-08 21:03:33 +02:00
MODULE_LICENSE_APACHE2 Initial commit - This source code should be EXACTLY what the current version of the 'Email' application in the android repo looks like as of this date. 2008-10-28 01:04:44 +00:00
NOTICE Initial commit - This source code should be EXACTLY what the current version of the 'Email' application in the android repo looks like as of this date. 2008-10-28 01:04:44 +00:00
proguard.cfg Remove ActionBarSherlock 2014-06-21 17:09:45 +02:00
project.properties Remove ActionBarSherlock 2014-06-21 17:09:45 +02:00
settings.gradle Remove ActionBarSherlock 2014-06-21 17:09:45 +02:00