k-9/src/com/fsck/k9
Joe Steele 01d2247ffd Change POP3 error response detection
Instead of interpreting a "-" at the beginning of a line as
an error response, consider the absence of a "+" at the
beginning of a line as an error response.

This is what Thunderbird does.

http://hg.mozilla.org/releases/comm-esr24/file/55e96a433bd1/mailnews/local/src/nsPop3Protocol.cpp#l1177

The problem arises with godaddy servers spewing additional
lines of data upon login failure.  The login was being
interpreted as successful, and a STAT commanded was subsequently
being sent, resulting in a dialog saying 'Cannot connect to
server. (Invalid int: "auth_error:")'.

$ openssl s_client -quiet -crlf -connect pop.secureserver.net:995
...
+OK <24984.1394317012@pop.secureserver.net>
user testuser
+OK
pass testpass
testuser not found in the auth database
warning: auth_error: authorization failed (no such object)
-ERR authorization failed  Check your server settings.
2014-03-11 19:10:14 -04:00
..
activity Enable connection security by default when setting up an account 2014-03-05 06:47:59 +01:00
cache Avoid CursorIndexOutOfBoundsException when deleting a message 2013-08-23 04:16:00 +02:00
controller Use the mApplication field in lieu of K9.app 2014-03-11 19:08:49 -04:00
crypto Converted message view to a fragment 2012-10-05 18:14:07 +02:00
fragment Use Locale.US where appropriate 2014-03-03 10:40:23 -05:00
helper Use Locale.US where appropriate 2014-03-03 10:40:23 -05:00
mail Change POP3 error response detection 2014-03-11 19:10:14 -04:00
net/ssl Remove SimpleX509TrustManager because it's no longer used 2014-03-05 06:03:06 +01:00
preferences Use SSL/TLS as fallback when importing server settings 2014-03-05 06:29:56 +01:00
provider Build with SDK 19 2014-02-10 20:43:16 +01:00
remotecontrol astyle-d 2011-02-26 18:39:06 -06:00
search use Set instead of implementation type 2014-02-15 23:59:24 +01:00
security Change LocalKeyStore error reporting 2013-12-04 12:10:12 -05:00
service Some assorted warning fixes. 2013-09-25 15:20:43 +02:00
view Put long-running operation into AsyncTask 2014-03-01 06:04:50 +01:00
Account.java Exclude error folder from unread/starred count 2014-03-09 05:00:42 +01:00
AccountStats.java Grey out unavailable accounts. 2011-03-19 12:36:58 -05:00
BaseAccount.java astyle-d 2011-02-26 18:39:06 -06:00
Clock.java Move AOSP files. 2013-11-05 16:26:27 -05:00
EmailAddressAdapter.java Don't use EmailAddressAdapter as singleton 2012-04-11 03:26:45 +02:00
EmailAddressValidator.java astyle-d 2011-02-26 18:39:06 -06:00
FontSizes.java Remove old setting for message content font size 2014-02-13 04:22:45 +01:00
Identity.java astyle-d 2011-02-26 18:39:06 -06:00
K9.java Fix the K9mail-errors folder 2014-03-03 17:31:23 -05:00
NotificationSetting.java astyle-d 2011-02-26 18:39:06 -06:00
PRNGFixes.java Some assorted warning fixes. 2013-09-25 15:20:43 +02:00
Preferences.java Eliminate the need to pass a context to LocalKeyStore.getInstance 2013-12-03 19:24:37 -05:00
Throttle.java Move AOSP files. 2013-11-05 16:26:27 -05:00