1
0
mirror of https://github.com/moparisthebest/k-9 synced 2024-11-27 19:52:17 -05:00
k-9/res
Joe Steele bfb0316583 Fix fatal IndexOutOfBoundsException
The problem:

Configure the account (just an example -- problems can occur in other
configurations as well):
Message Format: HTML
Reply quoting style: Prefix
Quote message when replying: yes
Reply after quoted text: yes

Reply to a message that has a large quantity (20+) of \r\n scattered in
the body of its HTML version (not an unusual scenario).

Add a reply.  Save the message as a draft.  Go back & open the draft
again.  A fatal IndexOutOfBoundsException occurs.

The cause:

When the draft was saved, the X-K9mail-Identity header was computed and
added to the message, then the text of the message was processed with
MimeUtility.fixDraftTextBody, replacing all occurrences of \r\n with \n in
the quoted message before being saved in LocalStore, thus invalidating the
X-K9mail-Identity header.

The fix:

Remove MimeUtility.fixDraftTextBody and implement
MessageCompose$EolConvertingEditText instead.  Any message text placed in
an EolConvertingEditText widget is assured to have \n line endings.  Any
message text extracted from an EolConvertingEditText widget is assured to
have \r\n line endings.  The X-K9mail-Identity header will always be
computed correctly.

Issues thought to be related:  4782, 5010, 5634, 5725

As noted in some of the referenced issues, errors didn't always result in
a fatal exception, but instead with mixed up text.

Ref:  commit f9a35aeaee
2013-10-11 11:39:15 -04:00
..
anim Tweak animations to use the (Slightly slower) android default animation speed. 2013-02-05 12:04:03 -05:00
drawable Add new multi-select checkboxes to message list 2013-06-07 07:07:27 +02:00
drawable-hdpi Add icon for the copy action 2013-08-29 20:54:36 +02:00
drawable-hdpi-v9 Notification icon update 2013-02-26 20:34:52 +01:00
drawable-hdpi-v11 Notification icon update 2013-02-26 20:34:52 +01:00
drawable-ldpi Add icon for the copy action 2013-08-29 20:54:36 +02:00
drawable-ldpi-v9 Notification icon update 2013-02-26 20:34:52 +01:00
drawable-ldpi-v11 Notification icon update 2013-02-26 20:34:52 +01:00
drawable-mdpi Add icon for the copy action 2013-08-29 20:54:36 +02:00
drawable-mdpi-v9 Notification icon update 2013-02-26 20:34:52 +01:00
drawable-mdpi-v11 Notification icon update 2013-02-26 20:34:52 +01:00
drawable-xhdpi Add icon for the copy action 2013-08-29 20:54:36 +02:00
drawable-xhdpi-v9 Notification icon update 2013-02-26 20:34:52 +01:00
drawable-xhdpi-v11 Notification icon update 2013-02-26 20:34:52 +01:00
layout Fix fatal IndexOutOfBoundsException 2013-10-11 11:39:15 -04:00
layout-land Remove unused stuff 2013-02-21 02:00:12 +01:00
layout-v14 When creating accounts only use 'modern' buttons starting with ICS 2013-05-05 06:17:56 +02:00
menu Remove icons from the "Refile" submenu 2013-08-29 21:13:28 +02:00
values Merge branch 'pick_attachment_fix' 2013-09-25 05:22:00 +02:00
values-ca Added detailed description for narrow devices 2013-09-18 16:52:17 +09:00
values-cs Added detailed description for narrow devices 2013-09-18 16:52:17 +09:00
values-da Added detailed description for narrow devices 2013-09-18 16:52:17 +09:00
values-de Update German translation 2013-09-25 15:26:32 +02:00
values-el Added detailed description for narrow devices 2013-09-18 16:52:17 +09:00
values-es Added detailed description for narrow devices 2013-09-18 16:52:17 +09:00
values-fi Added detailed description for narrow devices 2013-09-18 16:52:17 +09:00
values-fr Added detailed description for narrow devices 2013-09-18 16:52:17 +09:00
values-fr-rCA Convert translations of 'accounts_welcome' to HTML 2012-12-17 19:00:17 +01:00
values-gl Added detailed description for narrow devices 2013-09-18 16:52:17 +09:00
values-hu Added detailed description for narrow devices 2013-09-18 16:52:17 +09:00
values-it Added detailed description for narrow devices 2013-09-18 16:52:17 +09:00
values-iw Added detailed description for narrow devices 2013-09-18 16:52:17 +09:00
values-ja Added detailed description for narrow devices 2013-09-18 16:52:17 +09:00
values-ko Added detailed description for narrow devices 2013-09-18 16:52:17 +09:00
values-land Change appearance of unread widget 2013-03-16 01:57:21 +01:00
values-nl Added detailed description for narrow devices 2013-09-18 16:52:17 +09:00
values-pl Added detailed description for narrow devices 2013-09-18 16:52:17 +09:00
values-pt-rBR Added detailed description for narrow devices 2013-09-18 16:52:17 +09:00
values-ru Merge pull request #390 from bboa/master 2013-09-29 12:57:32 -07:00
values-sk Updated Slovak translation 2013-09-27 19:38:54 +02:00
values-sv Added detailed description for narrow devices 2013-09-18 16:52:17 +09:00
values-sw600dp-land-v14 Change appearance of unread widget 2013-03-16 01:57:21 +01:00
values-sw600dp-port-v14 Change appearance of unread widget 2013-03-16 01:57:21 +01:00
values-tr Added detailed description for narrow devices 2013-09-18 16:52:17 +09:00
values-uk Added detailed description for narrow devices 2013-09-18 16:52:17 +09:00
values-v11 Fixed a bug that caused K-9 to crash on the Accounts page on 4.x if you were using the dark theme 2013-07-01 16:34:43 -04:00
values-v14 The theme changes also crashed Honeycomb devices; more fixing 2013-05-05 06:02:39 +02:00
values-zh-rCN Added detailed description for narrow devices 2013-09-18 16:52:17 +09:00
values-zh-rTW Added detailed description for narrow devices 2013-09-18 16:52:17 +09:00
xml 4.700 changelog 2013-10-10 20:42:22 -04:00
xml-ja Updated Japanese translation of the changelog. 2013-09-19 00:17:21 +09:00