mirror of
https://github.com/moparisthebest/k-9
synced 2024-11-02 00:25:10 -04:00
022940d4f5
This commit addresses 2 issues:
1) Before, a general GestureDetector was registered on the highest level in K9Activity
This resulted in EVERY inherited activity to have a useless, unused gesture detector.
But more than that, in MessageList, a second GestureDetector was assigned to the ListView.
On every fling gesture, both detectors called the onSwipe() methods,
which technically did the following:
- The one directly assigned to the ListView would work corectly by mapping the
(local) event coordinates to the right entry in the ListView
- The global one worked on screen coordinates, so the onSwipe() method would
likely select the wrong ListView entry (system menu bar offset).
- For some reason this "worked" fine, and only the correct entry was selected,
despite two detectors used.
2) The gesture detection for the MessageView caused problems when the message
itself was scrollable, i.e. wide HTML mails. A fling gesture inside the WebView
would scroll the message, but also switch the message.
This commit fixes all those by doing the following:
- Don't register the GestureDetector in K9Activity, instead make the member variable
accessible by subclasses.
- In the subclasses that need a detector register it
- In K9Activity.dispatchTouchEvent() check for mGestureDetector being null
- For MessageList:
* Remove the duplicate gesture detector assigned to the ListView
* in the handleSwipe() methods: calclulate pixel offset of the ListView to make
it work using the global screen coordinates
- For MessageView: Limit sensitive area to the message header, to prevent interference
with the WebView scrolling
- Respect current behavior:
* Force-enable gestures for the MessageList
* Respect user setting in MessageView
- Make sure that after a successful swipe gesture, any pending action is cancelled, to
prevent unwanted things to happen (such as expanding the header after changing
the message, or a context menu popping up in the MessageList).
See http://code.google.com/p/android/issues/detail?id=8497
|
||
|---|---|---|
| assets | ||
| compile-only-libs | ||
| docs | ||
| images | ||
| libs | ||
| res | ||
| src/com/fsck/k9 | ||
| tests | ||
| tools | ||
| .classpath | ||
| .gitignore | ||
| .project | ||
| Android.mk | ||
| AndroidManifest.xml | ||
| ant.properties | ||
| build.xml | ||
| HTMLCLEANER_LICENSE | ||
| k9mail.iml | ||
| MODULE_LICENSE_APACHE2 | ||
| NOTICE | ||
| proguard.cfg | ||
| project.properties | ||