Jesse Vincent
9878b74379
astyle
2010-12-24 18:55:05 +00:00
Fiouz
df44a1f89b
Add @Override annotations (1.6) for safer compile-time checks
2010-12-20 21:34:01 +00:00
Fiouz
0abbeb443e
Batch storing of unsynced messages to speed up DB update (chunk size set to 5).
...
Execution code path is modified since it's not longer handling one message at a time when inserting in DB - might require review.
2010-12-19 11:51:54 +00:00
Jesse Vincent
eda76640c0
When mail is sent successfully, cancel the "couldn't send mail"
...
notification
2010-12-19 01:30:11 +00:00
Jesse Vincent
b59eb6c69f
lift lastFailure up so we can reference it in an outer scope
2010-12-19 01:30:07 +00:00
Jesse Vincent
dbe4bea290
Give our "send failed" notification a contant
2010-12-19 01:30:03 +00:00
Fiouz
c5f7dbf028
Execute LocalMessage.appendMessage() & LocalMessage.setFlag() in the same transaction for small message storing in order to speed up DB update.
...
This is a per message basis optimization. More improved speed could be attained by batching several messages in the same transaction.
2010-12-18 10:12:52 +00:00
Fiouz
63a8197f5a
Don't reference the enclosing type instance when it's not used (memory optimisation)
2010-12-14 19:26:37 +00:00
Marcus Wolschon
f5420ac528
readable thread-name for debugging
...
javadoc
2010-12-06 09:25:23 +00:00
Jesse Vincent
f5eb6e03af
astyle
2010-12-01 06:32:29 +00:00
Jesse Vincent
e44a74c652
Get rid of a whole lot of crazy code that forced repeated attachment
...
downloads with the intent of only having one attachment downloaded at a
time.
2010-12-01 06:04:28 +00:00
Jesse Vincent
35f19abc9f
Improve the "Do what I mean" nature of "Empty trash" - it now syncs the
...
trash folder after deletions to clear out local records of deleted
messages and does a compact operation on the local store.
2010-12-01 06:04:22 +00:00
Jesse Vincent
75ec749ed4
Remove an unused "context" from a private function
2010-12-01 06:04:16 +00:00
Jesse Vincent
78c900b5fe
remove redundant ;s
2010-12-01 03:07:28 +00:00
Jesse Vincent
75aa644a23
Remove a bunch of stringification inside of string appends (per intellij)
2010-12-01 03:06:50 +00:00
Jesse Vincent
cead5c7060
flip some loops to using java internals instead (per intellij)
2010-12-01 03:04:57 +00:00
Jesse Vincent
58e6bd388b
finalize some declarations per IntelliJ
2010-12-01 03:03:22 +00:00
Jesse Vincent
c79ea226a5
Remove "throws" declarations that didn't actually get thrown. Remove a
...
couple of try blocks that only caught throws we didn't throw. IntelliJ
optimization.
2010-12-01 03:02:13 +00:00
Jesse Vincent
15bf83bbe4
preliminary implementation of 'quiet time'
2010-11-29 02:21:16 +00:00
Jesse Vincent
2b8f7c0bbc
unify all our beeping, buzzing and flashing codepaths
2010-11-28 21:48:25 +00:00
Jesse Vincent
70922989d3
genericize configureNotification in preparation for code reuse
2010-11-28 21:48:21 +00:00
Jesse Vincent
64667d03dc
extract vibration pattern metadata out ouf MessagingController into
...
notificationsetting
2010-11-28 20:29:14 +00:00
Jesse Vincent
b7f52a834f
isVibrate -> shouldVibrate to match shouldRing
2010-11-28 20:29:09 +00:00
Jesse Vincent
28c126b8a5
extract notification code from actual "action" code
2010-11-28 20:29:05 +00:00
Jesse Vincent
99d5704b82
extract "sending messages" notification into methods
2010-11-28 20:29:02 +00:00
Jesse Vincent
9784d0e943
remove 100loc by replacing a pattern with a method.
2010-11-28 20:28:58 +00:00
Jesse Vincent
fa64f4c3a8
Minor refactoring for readability
2010-11-28 20:28:53 +00:00
Jesse Vincent
b7617a3497
extract "determine what to do with a new message" out of
...
downloadMessages Probably wants a better name
2010-11-28 20:28:50 +00:00
Jesse Vincent
3404edca28
extract the "synchronize one folder" method
2010-11-28 20:28:46 +00:00
Jesse Vincent
36bb10fb2c
extract out "sync one account"
2010-11-28 20:28:42 +00:00
Jesse Vincent
7291486ca0
No longer delete the Outbox every time it's empty - it makes it somewhat
...
more difficult to work with. If we want to hide it when it's empty,
that's fine. but it's not necessary to delete it.
2010-11-17 03:41:37 +00:00
Jesse Vincent
36714d3b4a
astyle
2010-11-15 01:31:11 +00:00
Jesse Vincent
32ea04a5b3
kill a temporary variable
2010-11-14 00:49:21 +00:00
Jesse Vincent
6a6c86d117
Kill a once-used temporary variable
2010-11-14 00:49:18 +00:00
Jesse Vincent
945d4d7c32
a slight cleanup for message deletioon policy logic.
2010-11-14 00:49:15 +00:00
Jesse Vincent
0eee80f08b
renamed deleteMessagesOlderThan to clearMessagesOlderThan to better
...
reflect that it just nukes local copies rather than the synced copies
2010-11-14 00:49:08 +00:00
Jesse Vincent
14055691a3
Merge branch 'mail-on-sd'
...
* mail-on-sd: (40 commits)
Added more comments to explain how the locking mecanism works for LocalStore
Fixed wrong method being called during experimental provider initialization (since provider isn't enabled, that didn't harm)
Add more comments about how the various StorageProviders work and how they're enabled
find src/com/fsck/ -name \*.java|xargs astyle --style=ansi --mode=java --indent-switches --indent=spaces=4 --convert-tabs
French localization for storage related settings
Remove unused SD card strings (replaced with storage indirection)
Merge mail-on-sd branch from trunk
Reset mail service on storage mount (even if no account uses the storage, to be improved)
find src/com/fsck/ -name \*.java|xargs astyle --style=ansi --mode=java --indent-switches --indent=spaces=4 --convert-tabs
Migraion -> Migration
move the Storage location preference into preferences rather than the wizard.
Made LocalStore log less verbose Added @Override compile checks
Added ACTION_SHUTDOWN broadcast receiver to properly initiate shutdown sequence (not yet implemented) and cancel any scheduled Intent
Be more consistent about which SQLiteDatabase variable is used (from instance variable to argument variable) to make code more refactoring-friendly (class is already big, code extraction should be easier if not referencing the instance variable).
Added transaction timing logging
Factorised storage lock/transaction handling code for regular operations.
Use DB transactions to batch modifications (makes code more robust / could improve performances)
Merge mail-on-sd branch from trunk
Update issue 888 Added DB close on unmount / DB open on mount
Update issue 888 Back to account list when underlying storage not available/unmounting in MessageView / MessageList
...
2010-11-13 21:40:56 +00:00
Jesse Vincent
a8de2d0000
astyle
2010-11-13 01:47:08 +00:00
Jesse Vincent
a551dc8dff
Replace the old "record a message in K9 Errors and give up"
...
failed-message scheme with an actual android notification that opens the
outbox
2010-11-13 01:47:02 +00:00
Jesse Vincent
4fb338d8a9
Disable "don't send messages in the outbox if they're flagged" - users
...
really don't like their mail just getting stuck
2010-11-13 01:46:55 +00:00
Jesse Vincent
af5f78928c
Add a "fetch all messages" visible limit
2010-11-12 23:41:43 +00:00
Jesse Vincent
9f695eb4ed
extract the per-account "reset visible limits" method
2010-11-12 23:41:33 +00:00
Jesse Vincent
2d8a8998b0
factor out a "destroy" method for local messages
2010-11-12 21:38:02 +00:00
Jesse Vincent
1292a10ac2
When a message has been deleted on the server and we want to sync remote
...
deletions, we don't care whether it was flagged as deleted ocally - we definitely
want to destroy it.
2010-11-12 21:37:58 +00:00
cketti
5b88a99de0
Got rid of some compiler warnings.
2010-11-04 03:11:34 +00:00
Jesse Vincent
c5cf9e5c8c
message_to_label and message_to_fmt were used from places that weren't
...
their original sources. rename them to lie less.
2010-10-29 22:34:59 +00:00
Jesse Vincent
724169e982
astyle
2010-10-25 03:20:03 +00:00
Jesse Vincent
f6f9d35430
unify two codepaths that sent unsent messages, one of them without a notification
2010-10-25 03:19:19 +00:00
Jesse Vincent
968fb8c508
add a variant of sendPendingMessages that will send pending messages in all accounts
2010-10-25 03:18:51 +00:00
Jesse Vincent
1d6caa5c0a
Never show an undismissable "new email" notification for a null account (like used to happen during setup)
2010-10-24 02:01:13 +00:00