moparisthebest
/
k-9
mirror of https://github.com/moparisthebest/k-9
1
0
Fork 0
Code Issues Releases Wiki Activity
5,487 Commits 36 Branches 329 Tags 887 MiB
Commit Graph

61 Commits

Author SHA1 Message Date
cketti f0e1b14b58 Merge pull request #567 
Move NetworkType to k9mail-library, use on StoreConfig
 2015-03-16 13:39:59 +01:00
cketti 494b16196d Rename AccountCreator.calculateDefaultDeletePolicy() 2015-03-16 13:28:11 +01:00
cketti 5f14e3b4e1 Use switch statement inside calculateDefaultDeletePolicy() 
With this - at least in theory  - the JIT compiler can produce better code
than is possible with the static HashMap.
 2015-03-16 13:26:44 +01:00
cketti f733cc38ba Merge pull request #566 
Rationalize default ports
 2015-03-16 13:15:43 +01:00
cketti 00528f5d24 Move throw statement outside of switch body 
This way static analysis can detect when we're missing a switch case.
 2015-03-16 13:11:01 +01:00
cketti 855da35f3a Code style fixes 2015-03-16 13:06:40 +01:00
cketti 08beb212c2 Fix crashes when selecting messages in the message list 
Throughout the code we make the assumption that onPrepareActionMode() is
called right after starting the action mode. However, this is not the case on
Android 5.1.
With this change we call ActionMode.invalidate() right after starting the
action mode which causes onPrepareActionMode() to be invoked.
 2015-03-13 21:12:21 +01:00
Art O Cathain 110400a85b move NetworkType to k9mail-library, use on StoreConfig 2015-03-08 12:59:15 +00:00
Art O Cathain 520e327775 remove duplication 2015-03-08 11:26:54 +00:00
Art O Cathain 810d0cf6b4 Move default port and default TLS port to a single location 2015-03-08 11:05:53 +00:00
cketti 147db8cc5e Configure 'developer mode' via BuildConfig 2015-03-07 00:30:50 +01:00
cketti 2f832e5fa4 Merge pull request #562 from artbristol/art/tidy-check-settings-async-task 
Refactor to make code more readable
 2015-03-06 23:52:22 +01:00
cketti 46bac187d5 Merge pull request #557 from artbristol/art/account-creation-refactor-2 
Remove duplication, enum-ify String
 2015-03-06 23:47:46 +01:00
cketti 67404b1883 Merge pull request #553 
Remove redundant variable assignments
Minimize scope of local variables
 2015-03-06 23:13:54 +01:00
cketti abd2b20850 Minimize scope of local variables 2015-03-06 23:12:28 +01:00
cketti 29f7552c3a Merge pull request #548 
Rename Searchfield to SearchField
 2015-03-06 23:00:18 +01:00
cketti b826d4e98d Use imports for inner classes 2015-03-06 21:19:27 +01:00
Art O Cathain d0fa82269f review comments 2015-02-23 17:28:42 +00:00
cketti 737e0d2ac8 Minor code style fixes 2015-02-23 03:36:34 +01:00
Art O Cathain 5035e7e3d1 review comments, also use == in preference to equals for enums 2015-02-22 21:30:26 +00:00
Art O Cathain a656a61c65 tidy method 2015-02-22 17:01:14 +00:00
Art O Cathain d5d42469b0 Avoid confusing reuse of local variables 2015-02-22 16:03:58 +00:00
Art O Cathain 492d65feed reduce duplication 2015-02-22 15:52:16 +00:00
Art O Cathain 1a706c3113 formatting 2015-02-18 19:48:17 +00:00
Art O Cathain 583a637d79 Remove duplication, enum-ify String 2015-02-18 19:42:33 +00:00
cketti ebef8eccb9 Add missing placeholder for application ID 2015-02-17 00:45:36 +01:00
Art O Cathain ffb4507776 Enums instead of int/String constants (#547) 
simplify and add logging

simplify

use == for enum comparison to avoid type mistakes

enum name needs to match previous constant

simplify

Address review comments - formatting, and remove superfluous comment

Shorten DeletePolicy values since not used in settings strings; import enums to reduce clutter

fix whitespace

remove comment per review

address review comment

review comments

remove another superfluous qualification

Last changes
 2015-02-16 22:22:05 +00:00
cketti 24e6b39dc0 Stop using Intent.setClassName() 
Use the type-safe Intent constructor to reference internal classes.
 2015-02-16 22:44:55 +01:00
cketti 461778ed11 Merge branch 'configurable_application_id' 2015-02-16 21:53:44 +01:00
cketti d703ac9148 Revert substitution of "com.fsck.k9" in implementation details 
We don't need to change strings that are not exposed to the system/users.
 2015-02-16 21:02:52 +01:00
cketti 9f1ecf7220 Merge pull request #555 from BombTeam/UnusedImportsRemoval 
Remove unused import
 2015-02-16 19:47:38 +01:00
Valentin CAULIER 80f8e4a81d Removing java.util.Arrays import 2015-02-16 17:37:15 +01:00
Levrifon 0d0b80f142 Added placeholder for application ID 2015-02-16 16:53:38 +01:00
Marine c4e202ecd9 remove redundant assignment to FolderSettings 
removed null affectation because it’s done automatically
 2015-02-16 15:31:03 +01:00
Marine 9bf546b33b removed redundant assignment to AccountSetupBasics 
removed null affectation because it’s done automatically
 2015-02-16 15:25:36 +01:00
Marine f5cac2c71f remove redundant cast Button to WelcomeMessage 
findViewById(R.id.next) and
findViewById(R.id.import_settings)
are Button so it’s redundant to cast it to Button
 2015-02-16 15:10:34 +01:00
Marine 63047e0ac6 remove redundant cast (Button) 
findViewById(R.id.pop) ,
findViewById(R.id.imap) and
findViewById(R.id.webdav)
are Button so it’s redundant to cast it to Button
 2015-02-16 15:03:11 +01:00
Marine 980d799087 Rename from Searchfield to SearchField 2015-02-16 14:07:41 +01:00
cketti aae71125c6 Merge pull request #523 
Make sure to keep font meta info on view recycling
 2015-02-15 17:43:11 +01:00
cketti 9df1a3ee80 Potentially avoid creating new Typeface instances 2015-02-15 17:38:10 +01:00
Gabriel Burca 9ba2725ab1 Fixes issue 6703 
- onPrepareActionMode must be called before computeBatchDirection
  because computeBatchDirection ends up referencing mMarkAsRead /
  mMarkAsUnread and mFlag / mUnflag which could be null otherwise.
 2015-02-12 21:27:44 -06:00
cketti 74fdbb7859 Update openpgp-api-library to latest version 2015-01-27 12:15:47 +01:00
Jan Berkel 4808406739 Make deleteCertificate null-safe 2015-01-14 03:45:09 +01:00
Jan Berkel f7da704007 WS 2015-01-13 09:34:13 +01:00
Jan Berkel 7958467503 Convert from thread to AsyncTask for espresso tests 2015-01-13 01:11:09 +01:00
cketti 63abf05776 Sanitize HTML to remove meta refresh 
Using
  <meta http-equiv="Refresh" content="1; URL=http://example.com/">
in a HTML message causes WebView to load the URL in the default browser.
Overriding WebViewClient.shouldOverrideUrlLoading() allows us to cancel
loading this URL. Sadly, I found no way to find out whether the method was
called because of a meta refresh or because the user clicked on a link.

So now we're using HtmlCleaner to parse the HTML and remove all "meta" elements
containing an "http-equiv" attribute with a value of "refresh".
 2015-01-11 11:29:53 +01:00
cketti ad8da49991 Remove unused code 2015-01-03 04:27:27 +01:00
cketti b6315b15b0 Fix equals() method to work with all objects 2015-01-03 04:10:15 +01:00
cketti 6804ee04e3 Fix some MS_SHOULD_BE_FINAL Findbugs warnings 2015-01-03 03:51:47 +01:00
cketti 65d2de0fcc Fix bug caused by edge case of Math.abs() 2015-01-03 03:51:47 +01:00