cketti
222cd43c80
Some code cleanup. No functional changes.
2011-06-17 04:13:32 +02:00
Marcus Wolschon
5eec09d37a
Merge branch 'refs/heads/master' of git@github.com:k9mail/k-9.git
2011-06-14 15:23:20 +02:00
Marcus Wolschon
b8f04b8a4f
typo
2011-06-14 15:22:45 +02:00
Jesse Vincent
a558466c36
ant astyle
2011-06-13 19:49:06 -04:00
Jesse Vincent
379a8dfa9e
It turns out that 79a96952f2
has caused a
...
lot of messages to be unreadable in K-9 3.8. (see mailing list
threads)
2011-06-09 21:54:22 -04:00
Fiouz
c416f02d52
Improve BACK button handling for MessageView
...
Remove memory leak from referencing MessageView context from the
Intent that is created to go back to MessageList. MessageView is no
longer hardcoded to go back to MessageList, it instead uses an Intent
given at creation to get back to the originating Activity.
Try our best to restore the MessageList in its previous state when
"Manage BACK button" option is enabled:
Since MessageList lives in its own task, we look for the previous
active task and check whether its top activity matches it. If it does,
we just finish MessageView and Android will automatically restore the
previous task. If it doesn't, we launch the originating Intent (and
MessageList state will be lost).
If option is off, we get the regular Android behavior: got back to the
previous screen, whenever it's the MessageList or another application
if the user long-pressed HOME.
The consequence of this is the need for a new permission in order to
check the previous active task: android.permission.GET_TASKS
2011-06-08 22:53:23 +02:00
Fiouz
5ee63c47fe
Implemented BACK handling for MessageView
...
Implemented because MessageList is now in singleInstance launchMode so
the default behavior may not match user options.
2011-06-08 08:42:40 +02:00
Fiouz
9b0ce3c75a
Remove no longer used references on confirmation dialog disapproval
2011-06-07 01:25:38 +02:00
Fiouz
fc4dd077e4
Don't attempt to configure a dismissed dialog during Android activity
...
reloading
As part of automatic activity reloading following a configuration
change, Android invokes Activity#onPrepareDialog() even for dismissed
dialogs. Consequently, one can't make the assumption that this method
is only invoked by explicit calls to Activity#showDialog() from our
code.
The actual problem here was the mActiveMessages member being null
at such times.
2011-06-07 01:15:04 +02:00
Fiouz
72870174ce
Pluralize the "Move to spam" confirmation dialog since code paths were
...
unified in MessageList and multi-selection is now subject to this
dialog.
2011-06-05 01:35:11 +02:00
Fiouz
de7b75a1df
Properly keep selection in case of a
...
configuration change (orientation, keyboard, etc.) during user
interaction (e.g. a dialog)
2011-06-05 01:16:34 +02:00
Fiouz
5366a07f28
Add @Override compiler check
2011-06-04 23:55:48 +02:00
Fiouz
190d028669
Javadoc fix
2011-06-04 23:17:47 +02:00
Fiouz
821a00e727
MessageList refactoring to remove duplicate code paths.
...
Message operations should be more consistent now, regardless of how
the messages are selected (long click, checkbox+Menu, future group selection).
This is a backport of the modifications made on the issue258 branch,
without the threading specific features (no new feature introduced).
2011-06-04 23:01:34 +02:00
Fiouz
40546edcf7
Remove local.properties, new default projection column introduced by merge d3cf49a5e4
2011-06-02 20:30:10 +02:00
Fiouz
d3cf49a5e4
Merge remote-tracking branch 'refs/remotes/unread/master' into unread
2011-06-02 20:20:56 +02:00
João Pedro Taveira
503b88e2fd
Merge remote branch 'k-9/master'
2011-06-02 14:39:58 +01:00
Jesse Vincent
31adcd2ed8
Revert " http://code.google.com/p/k9mail/issues/detail?id=3408&sort=-id&colspec=ID%20Product%20Type%20Status%20Priority%20Milestone%20Owner%20Summary "
...
This reverts commit 0c2e06133c
.
The patch would cause an extra SMTP connection on _any_ meesage with
attachments. Marcus is headed away on holiday and asked me to revert it
for him (after I asked him to revert it) - With luck, we'll talk through
a design to work around this issue on the list
Conflicts:
src/com/fsck/k9/mail/transport/SmtpTransport.java
2011-06-02 09:35:03 -04:00
Jesse Vincent
3d583da450
ant astyle
2011-06-01 16:03:56 -04:00
Marcus Wolschon
0c2e06133c
http://code.google.com/p/k9mail/issues/detail?id=3408&sort=-id&colspec=ID%20Product%20Type%20Status%20Priority%20Milestone%20Owner%20Summary
...
Issue 3408: SMTP timeouts while calculating message size
2011-06-01 09:13:16 +02:00
Marcus Wolschon
0b6f0a09bb
http://code.google.com/p/k9mail/issues/detail?id=3407&sort=-id&colspec=ID%20Product%20Type%20Status%20Priority%20Milestone%20Owner%20Summary
...
Issue 3407: Handling of SMTP 5xx error codes unclean
fix part one: 5xx error codes are detected in SMTP-code and reported as permanent failures.
2011-06-01 09:07:05 +02:00
Andrew Gaul
2fd9bd5a03
Cleanup Utility.combine()
...
Fix spelling mistakes, simplify adding separators, use unsynchronized
StringBuilder, and fix Javadoc.
2011-05-31 15:11:36 +02:00
cketti
c5342472f2
Load AbsoluteSizeSpan(int,boolean) constructor via reflection
...
This will allow us to run on Android 1.5/1.6 devices.
2011-05-26 23:43:35 -04:00
Jesse Vincent
a9b28d62d7
Fix a NPE
2011-05-26 22:59:50 -04:00
cketti
30d31c7074
Explicitly use Locale.US when dealing with dates in message headers
2011-05-26 04:32:26 +02:00
cketti
de4abf87cb
Respect "move/copy destination folders" setting in ChooseFolder
...
Fixes issue 2664
2011-05-26 04:11:09 +02:00
Jesse Vincent
92239739b0
microoptimize peekableInputStream's peek method to not do an extra
...
method dispatch and boolean check on every peek.
2011-05-24 21:35:18 -04:00
Jesse Vincent
29117ae7a6
Switch a StringBuffer to StringBuilder, which replaced it
2011-05-24 21:21:03 -04:00
Koji Arai
b4f3712246
Should retrieve just visibleLimit messages when the local folder is cleared.
2011-05-25 00:37:51 +09:00
Koji Arai
cb46f170cd
Should reset visibleLimit on clear messages.
2011-05-25 00:37:49 +09:00
Koji Arai
a4f7288d37
Avoid NullPointerException.
...
The name parameter in Content-Type may be not set.
2011-05-25 00:37:46 +09:00
Koji Arai
90a5ca8ec2
Merge pull request #34 from jca02266/possible-to-toggle-quoted-text-display
...
Possible to toggle quoted text display
2011-05-24 08:33:53 -07:00
Koji Arai
7f93cfcbca
Refactoring
2011-05-25 00:25:23 +09:00
Koji Arai
33a92b11a2
Use the Button instead of the ImageButton.
2011-05-22 04:12:41 +09:00
Koji Arai
ce9b280746
Added account preference to display quoted text.
2011-05-22 03:56:51 +09:00
Koji Arai
5d6df85aac
possible to toggle to display the quoted message to send.
2011-05-22 03:55:50 +09:00
cketti
4f67a6be24
Fixed counting of new unread messages
2011-05-21 00:33:43 +02:00
cketti
6c1b1ebf32
Moved checks from notifyAccount() to shouldNotifyForMessage()
...
This should fix the "notification count" for cases where messages
passed the shouldNotifyForMessage() checks but not the ones in
notifyAccount().
2011-05-20 23:00:48 +02:00
cketti
2d7fad1fa9
Use InetAddress.getCanonicalHostName() instead of getHostName()
...
This should always return a FQDN.
2011-05-19 00:55:34 +02:00
cketti
8fc714ac4a
Don't show "null" for partially downloaded messages with empty text body
2011-05-16 00:36:46 +02:00
cketti
41b039b691
Fix bug introduced with commit b7a6dbd973
...
Fixes issue 3297
2011-05-15 16:23:53 +02:00
cketti
95288b37d7
Removed unnecessary method implementation
...
Make Pop3Folder.setFlags(Flag[],boolean) throw an
UnsupportedOperationException instead of calling a method that does
just that.
2011-05-14 23:46:26 +02:00
cketti
dc96bf3186
Only mark all messages as read on the server if that's supported
...
This change prevents K-9 Mail from establishing a connection to the
server when all messages are marked as read on a POP3 account.
2011-05-14 23:30:47 +02:00
cketti
ba9bc2f8e9
Added method Folder.isFlagSupported(Flag)
2011-05-14 23:19:24 +02:00
cketti
e90a479384
Renamed member variables to match code style guidelines
2011-05-14 22:17:15 +02:00
cketti
92b17ec2e2
Hide "Show only subscribed folders" checkbox for POP3 accounts
2011-05-14 22:15:39 +02:00
cketti
86fca9c1f2
POP3: Check for support of the TOP command (if CAPA isn't supported)
...
This will allow to download partial messages if the server doesn't
support the CAPA command but supports the TOP command (e.g. Hotmail).
Fixes issue 2042
2011-05-14 21:40:21 +02:00
cketti
969e2d93fd
Don't use the "owner name" as default value for the email name
...
Get rid of Contacts.getOwnerName() and associated permissions.
Fixes issue 3331
2011-05-14 04:53:17 +02:00
Andrew Chen
e5d952bff4
Save and restore the cursor position when saving or loading a draft. This is the first step in making "resume composition on context switch" a reality.
2011-05-10 15:23:25 -07:00
Marcus Wolschon
e0ef94f64b
Issue 3319: unseen message count can add up to infinity
2011-05-09 11:21:24 +02:00