Jesse Vincent
4723ea0ae5
Possible to select email addresses from the ContactPicker
...
Conflicts:
src/com/fsck/k9/activity/MessageCompose.java
src/com/fsck/k9/helper/ContactsSdk3_4.java
2012-04-08 12:29:08 -04:00
cketti
0caac114a6
Added some error checks when processing IMAP FETCH responses
2012-04-03 07:55:52 +02:00
Koji Arai
10c37942a6
Added two domains handle docomo emoji
2012-03-17 23:24:12 +09:00
Koji Arai
f9fb74241a
avoid NPE. address may be null when the parser is failed.
2012-03-17 23:23:27 +09:00
cketti
f9a35aeaee
Replace CRLF with LF when loading drafts
...
This is necessary because we save the offset and length of the user-
supplied text in the identity header. These values are then later used
to split the draft in user text and quoted message.
When calculating these values we operate on a string with LF line
endings. Ideally we want to do the reverse operation on the same
string, but when saving the message to the server LF is converted to
CRLF to create RFC-conforming messages.
This is only a hack and will probably be the cause of more trouble in
the future. A better solution would be to make the identity header more
robust or get rid of it entirely.
2012-03-17 04:15:30 +01:00
cketti
3fa8081e88
Fixed MimeUtility.extractTextual() when loading messages from the server
2012-03-17 03:19:09 +01:00
cketti
dbf38dae65
Fixed the change of the previous commit
2012-03-17 00:30:40 +01:00
cketti
a48adafbbc
Don't use null for 'text' and 'html' in ViewableContainer
2012-03-16 22:56:09 +01:00
cketti
f181e923ca
Don't modify draft messages when storing them in the database
2012-03-15 21:21:00 +01:00
cketti
aeb0220e56
Fixed MimeUtility.getHeaderParameter() to not crash on unexpected input
2012-03-12 17:45:34 +01:00
cketti
0cb4207ef7
IMAP: don't create the destination folder when copying messages
2012-03-09 21:51:48 +01:00
cketti
7163d39091
Change ImapException to always be a permanent error
...
This way IMAP commands that get anything but an "OK" response are never
tried again (pending actions).
2012-03-09 21:50:26 +01:00
cketti
5591865f17
Merge branch 'uidplus'
2012-02-29 14:09:41 +01:00
cketti
e72afc1641
Set content type of attachment even when no file name was found
2012-02-27 23:20:30 +01:00
cketti
2cb31a2fac
Added button to show unnamed and inline attachments
2012-02-27 21:45:46 +01:00
cketti
fbc187a3e2
IMAP: Send the Message-ID as quoted string in getUidFromMessageId()
2012-02-19 19:51:06 +01:00
cketti
4adfc51339
Use HtmlConverter.convertEmoji2Img() in LocalFolder.updateMessage()
2012-02-18 00:44:24 +01:00
cketti
b9803ece19
Fixed divider before text part with filename
2012-02-18 00:05:56 +01:00
cketti
8ce78408c2
Fixed HTML generation in MimeUtility.extractTextAndAttachments()
2012-02-17 19:42:35 +01:00
cketti
5083b8f1e8
Use newly imported AOSP code instead of ImapStore.parseSequenceSet()
2012-02-17 15:01:30 +01:00
cketti
deb01bcd16
Imported ImapUtility.java from AOSP Email
...
Modified it to fit our needs.
2012-02-17 14:59:50 +01:00
cketti
c3885bc475
Cleaned up LocalFolder.appendMessages() a bit
2012-02-16 23:52:44 +01:00
cketti
023c60513e
Fixed UID mapping return value of LocalStore.moveMessages()
2012-02-16 23:37:44 +01:00
cketti
3e4e6c72fd
Cleaned up ImapStore.ImapFolder.copyMessages()
2012-02-16 22:12:44 +01:00
cketti
396005974a
Cleaned up ImapStore.ImapFolder.appendMessages()
2012-02-16 21:33:53 +01:00
cketti
8e1627e1b9
Merge branch 'master' into uidplus
...
Conflicts:
src/com/fsck/k9/controller/MessagingController.java
src/com/fsck/k9/mail/store/WebDavStore.java
2012-02-16 19:57:24 +01:00
cketti
cf9631d481
Changed the way we decide what message parts to display
2012-02-13 23:11:59 +01:00
cketti
7a252bf002
Changed method to update the unread widget
2012-02-13 12:16:20 +01:00
cketti
29e1a68288
Added widget to display the unread count for an account
2012-02-13 12:16:18 +01:00
cketti
e8eae37389
Reset unread/flagged count on "empty trash"
2012-01-27 00:51:18 +01:00
cketti
4e5d116713
Delete attachment metadata and thumbnails when deleting attachments
2012-01-24 16:15:45 +01:00
cketti
bddacf6b64
Use database ID to keep track of the current draft
...
By using the database ID we avoid having to deal with the problem of
changing UIDs. First the message has a local UID, then, when the upload
to the server is completed, it gets a remote UID.
2012-01-22 05:20:41 +01:00
cketti
96f827d291
Modified LocalStore to use UPDATE when replacing existing messages
...
This way we can later use the database ID to keep track of drafts.
2012-01-22 05:20:41 +01:00
cketti
32a29f131b
Make sure an IOException is always passed through as MessagingException
...
This is important for the code handling pending actions in
MessagingController. If a non-permantent MessagingException is
encountered, the pending action is retried later.
Fixes issue 3696
2012-01-20 19:50:07 +01:00
cketti
258b0039d5
IMAP: also get the Message-ID when fetching the message "envelope"
...
This should fix issue 3994
2012-01-14 06:30:22 +01:00
cketti
66b7805a57
Fixed a bug in the IMAP response parser
...
Also got rid of ImapResponse.more() which isn't necessary anymore.
2012-01-12 07:56:52 +01:00
cketti
d848b434f5
Fall back to HELO command if the server doesn't know EHLO (SMTP)
...
Fixes issue 2704
2012-01-05 03:53:23 +01:00
cketti
71174417ce
Clone Message object to avoid ConcurrentModificationExceptions
...
Fixes issue 3953
2012-01-04 03:57:53 +01:00
edpeur
daeedc2222
Close resources properly
2011-12-31 17:38:41 +00:00
wongk
fb3cd234fa
Merge branch 'master' of github.com:k9mail/k-9
2011-12-28 14:04:37 -05:00
wongk
b2d5ea3ce2
Fixed the parsing of response data for WebDAV requests.
2011-12-28 14:03:44 -05:00
cketti
852dca4124
Removed unused import
2011-12-26 02:30:59 +01:00
András Veres-Szentkirályi
cea6f4468d
Removed unused private field
2011-12-26 02:28:31 +01:00
cketti
6de081c5b0
Minor cleanup
2011-12-19 02:21:27 +01:00
mwolschon
696666ca5e
Issue 1303: can't send mail get "no route to host" error
2011-12-19 02:10:17 +01:00
cketti
63605b65b6
Add support for new auto-detect namespace setting to ImapStore
2011-12-01 06:30:47 +01:00
cketti
75cdbd860e
Only save IMAP path prefix in store URI if auto-detection isn't used
2011-12-01 05:58:44 +01:00
cketti
f2253a95d7
Modified ServerSettings to be able to create instances with "extras"
2011-12-01 02:57:53 +01:00
cketti
cb7b88680b
Use Store.decodeStoreUri() in AccountSetupIncoming
2011-12-01 02:28:57 +01:00
cketti
9e0ea7dd79
Extended ImapStore URI to support empty IMAP path prefix
2011-12-01 01:57:50 +01:00
cketti
d6fbeb2913
Fixed creation of store URIs when a "path" was used.
2011-11-29 21:45:52 +01:00
cketti
9350a3b1b6
Merge pull request #105 from andrewgaul/writer-string-concatenation
...
Avoid string concatenation in Writer.write
2011-11-27 16:32:25 -08:00
cketti
23c72cd181
FixedLengthInputStream - code cleanup
...
Inspired by andrewgaul
2011-11-28 01:21:50 +01:00
cketti
798d6753dd
FixedLengthInputStream - implement skip which honors mLength
...
Patch by andrewgaul
2011-11-28 01:14:49 +01:00
cketti
e145a621c7
FixedLengthInputStream - increment mCount only when read() succeeds
...
Patch by andrewgaul
2011-11-28 01:10:41 +01:00
Andrew Gaul
e93510b4b3
Avoid string concatenation in Writer.write
2011-11-27 13:57:11 -08:00
Andrew Gaul
057b316bcb
Avoid NPE in getOldestMessageDate
...
Caused by autounboxing a possibly null Long into a long.
2011-11-27 10:35:06 -08:00
cketti
20eab9c812
Rewrite application/x-zip-compressed to application/zip
2011-11-21 11:49:03 +01:00
Apoorv Khatreja
4b0d3ccf21
Removed an unnecessary portion of code that attempted to handle command continuation requests after a UID COPY command. Also removed some extraneous test code that mysteriously creeped into the repo.
2011-11-17 02:46:01 +05:30
cketti
4f060642ee
Merge branch 'imap_parser'
2011-11-16 04:52:05 +01:00
cketti
99163dc9b9
Removed isSizeOrExpungeResponse()
...
I don't understand what the purpose of this code was. It stopped parsing
before the end of the line was reached, thus causing problems with
parsing subsequent lines of the response.
2011-11-16 04:48:50 +01:00
cketti
8cdd283bb8
Added Javadoc comment
2011-11-16 03:59:27 +01:00
cketti
e9b0f82c11
Minor code cleanup
2011-11-16 03:23:59 +01:00
cketti
f8779095d9
Parse resp-text on command continuation requests
2011-11-16 03:17:36 +01:00
cketti
43f5cbb361
Renamed parseStatusResponse() to parseResponseText()
2011-11-16 03:11:35 +01:00
cketti
727c8564ec
Cleaned up readTokens()
2011-11-16 03:10:26 +01:00
cketti
688db057ac
Removed unused imports
2011-11-16 02:51:46 +01:00
Jesse Vincent
a8ef6594ec
Preserve header order (with the exception of duplicate headers like
...
"received" they all show up where the first one did
2011-11-15 00:00:42 -05:00
Andrew Chen
7ca438669e
Add theoretical support for RFC6154 SPECIAL-USE for auto-configuration.
2011-11-14 18:55:11 -08:00
Andrew Chen
95215f00b7
Kerio also supports auto-configuration; remove the gmail.com requirement to use XLIST for auto-configuration.
2011-11-14 18:27:08 -08:00
Andrew Chen
2f3565d180
Implement Gmail's XLIST IMAP command to determine Gmail-specific folders.
2011-11-14 18:15:32 -08:00
cketti
6497ac4cf4
Default authentication type for SMTP is automatic
2011-11-07 01:58:38 +01:00
cketti
70dc27c481
Make MimeUtility.getMimeTypeForViewing() return lower case MIME types
...
MIME type matching in Android is case-sensitive. So we convert the MIME
types we read from the email to lower case.
2011-11-06 02:05:47 +01:00
cketti
88a2dd6289
Merge branch 'issue549'
...
Conflicts:
src/com/fsck/k9/Account.java
src/com/fsck/k9/mail/store/WebDavStore.java
2011-11-05 18:47:55 +01:00
Andrew Chen
4a1046a893
Merge pull request #93 from andrewgaul/cursor-close-quietly
...
Introduce and use Utility.closeQuietly(Cursor)
2011-11-04 16:20:22 -07:00
Andrew Gaul
39aa577651
Introduce and use Utility.closeQuietly(Cursor)
...
This helper is in the same spirit as IOUtils.closeQuietly.
2011-11-04 09:58:55 -07:00
Andrew Gaul
d301089f3c
Avoid string concatenation in String.format
2011-11-03 18:47:34 -07:00
Andrew Chen
57e0abbf8f
Merge pull request #84 from andrewgaul/api7
...
Use LinkedList instead of Deque.
2011-11-03 07:41:09 -07:00
Andrew Chen
7f046e5f0a
Merge pull request #91 from andrewgaul/findbugs-stream-close
...
Improve the way we open/close streams.
2011-11-03 06:40:07 -07:00
Andrew Chen
d80e5bfbd0
Merge pull request #90 from andrewgaul/close-quietly
...
Call IOUtils.closeQuietly instead of using empty try/catch block.
2011-11-03 06:35:42 -07:00
Andrew Chen
64b299ebec
Merge pull request #89 from andrewgaul/is-empty
...
Prefer Collection.isEmpty over size
2011-11-03 06:34:15 -07:00
Andrew Chen
9e74f9ffcf
Merge pull request #88 from andrewgaul/log-throwable
...
Log Throwables instead of concatenating
2011-11-03 06:32:20 -07:00
Andrew Chen
64e2247e8f
Merge pull request #87 from andrewgaul/map-initialization
...
Optimize static map, remove unneeded inner class, and use unmodifiable map.
2011-11-03 06:31:32 -07:00
Andrew Chen
8dccc7a996
Merge pull request #86 from andrewgaul/findbugs-concatenation
...
Prefer StringBuilder.append over String.concat
2011-11-03 06:28:51 -07:00
Andrew Gaul
b53b0d33ba
Close streams on exceptional paths
...
Addresses FindBugs complaints.
2011-11-02 22:48:37 -07:00
Andrew Gaul
b1a807a712
Call IOUtils.closeQuietly where appropriate
2011-11-02 22:22:15 -07:00
Andrew Gaul
2599bdcc75
Log Throwable instead of concatenating
2011-11-02 22:18:30 -07:00
Andrew Gaul
70b635ec30
Initialize static map optimally
...
Remove unneeded inner class, use unmodifiable map, and mark as static.
2011-11-02 22:16:12 -07:00
Andrew Gaul
cb14cd9d78
Prefer StringBuilder.append over String.concat
...
Addresses FindBugs complaints.
2011-11-02 22:10:02 -07:00
Andrew Gaul
61c850e077
Remove dead stores
...
Addresses FindBugs complaints.
2011-11-02 22:02:41 -07:00
Andrew Gaul
98d0b61890
API 7 fixes
2011-11-02 20:47:48 -07:00
Andrew Gaul
647ae0a31c
Prefer Collection.isEmpty over size
2011-11-02 20:03:07 -07:00
Andrew Chen
1e9a40ffd2
Merge pull request #81 from aatdark/issue3814
...
Improve handling of From: Headers without parseable email addresses (fixes 3814)
2011-11-02 17:55:58 -07:00
Bernhard Redl
68cecb168e
added testcases for address#parse function,changed empty to null (conforms to existing code)
2011-11-03 01:36:57 +01:00
Andrew Chen
b5dca5cf68
Merge pull request #76 from sunglim/string_util
...
Added StringUtils.isNullOrEmpty().
2011-11-02 10:50:52 -07:00
Andrew Chen
66881c0f2b
Merge branch 'master' of git@github.com:k9mail/k-9.git
...
* 'master' of git@github.com:k9mail/k-9.git:
Optimize java.util.* imports.
2011-11-02 08:37:12 -07:00
Andrew Chen
f884e967c9
Use MimeHeader.* constants when referring to content headers. Minor whitespace changes.
2011-11-02 08:34:06 -07:00
Bernhard Redl
6a76b073c3
Improve handling of From: Headers without parseable email addresses (fixes 3814)
2011-11-02 02:08:06 +01:00
Andrew Chen
406aae6e61
Optimize java.util.* imports.
...
Conflicts:
src/com/fsck/k9/mail/store/WebDavStore.java
2011-11-01 13:54:55 -07:00
Andrew Chen
ea05f3b5d0
Merge branch 'legacy-collections' of https://github.com/andrewgaul/k-9 into andrewgaul
...
* 'legacy-collections' of https://github.com/andrewgaul/k-9 :
Prefer unsynchronized Collection types
2011-11-01 13:26:54 -07:00
Andrew Chen
4395da270d
Merge pull request #77 from andrewgaul/findbugs-entryset
...
Prefer entrySet over keySet and get
2011-11-01 12:44:26 -07:00
Andrew Gaul
773f2e8870
Prefer Integer.valueOf over explicit boxing
...
Addresses a FindBugs complaint.
2011-10-31 21:58:32 -07:00
Andrew Gaul
bfd11c444f
Prefer entrySet over keySet and get
...
Addresses FindBugs complaints.
2011-10-31 21:42:12 -07:00
Lim Sungguk
8ab10a7586
applied StringUtils.isNullOrEmpty()
2011-10-29 15:12:49 +09:00
cketti
807907cb9e
Merge branch 'master' into issue549
...
Conflicts:
res/values/strings.xml
src/com/fsck/k9/service/MailService.java
2011-10-29 05:22:07 +02:00
Andrew Chen
f24d4c9155
Merge pull request #72 from andrewgaul/remove-literal
...
Remove unused literal methods
2011-10-27 23:32:28 -07:00
cketti
e3f6561008
Don't crash when trying to connect to an non-SSL service using SSL
...
Fixes issue 3798
2011-10-28 04:59:08 +02:00
cketti
91ee21bb2d
Use "String.length() == 0" instead of String.isEmpty() [API 9+]
2011-10-27 19:11:44 +02:00
cketti
b69d6cb64c
Use Locale.US with toUpperCase() and toLowerCase() where appropriate
2011-10-27 17:17:43 +02:00
cketti
9327c86fe7
Use Locale.US when calling toUpperCase() on the generated MIME boundary
...
Fixes issue 3733
2011-10-27 16:52:27 +02:00
Andrew Chen
b6cdec43e9
Merge pull request #73 from andrewgaul/address-parse-npe
...
Fix NPE in Address.Parse
2011-10-26 18:15:40 -07:00
Andrew Gaul
ad5676ed28
Fix NPE in Address.Parse
...
Found by FindBugs. Also avoid an allocation in the uncommon case.
2011-10-25 21:24:38 -07:00
Andrew Gaul
e394924ce4
Prefer Random.nextInt over Math.random
...
Addresses a FindBugs complaint.
2011-10-25 21:21:23 -07:00
Andrew Gaul
a2d0f9ccb7
Remove unused literal methods
2011-10-25 13:56:07 -07:00
Jesse Vincent
ae3f098b4a
Merge pull request #64 from andrewgaul/typesafe-set
...
Avoid type-unsafe Set
2011-10-20 05:34:48 -07:00
Andrew Gaul
5b9f542bd7
Avoid type-unsafe Set
2011-10-19 23:05:34 -07:00
Andrew Gaul
ce4b42f66b
Remove duplicated combine flags code
2011-10-19 22:04:57 -07:00
Andrew Gaul
80d9246130
Prefer unsynchronized Collection types
2011-10-19 21:56:20 -07:00
cketti
dd8cd33c5a
Fixed decoding of store URIs with empty passwords
2011-10-18 05:05:40 +02:00
cketti
6b5b4e474e
Fixed store URI encoding/decoding in Pop3Store
2011-10-17 05:59:36 +02:00
cketti
d87e25dde1
Added new authentication methods to SmtpTransport.createUri()
2011-10-17 04:57:01 +02:00
cketti
52a92d93a1
Add dialog to ask for server passwords after import
2011-10-17 04:34:26 +02:00
cketti
fc8d2e9979
Merge branch 'master' into issue549
...
Conflicts:
res/menu/accounts_context.xml
res/menu/accounts_option.xml
res/values/strings.xml
src/com/fsck/k9/Account.java
src/com/fsck/k9/activity/Accounts.java
src/com/fsck/k9/activity/AsyncUIProcessor.java
src/com/fsck/k9/activity/FolderList.java
src/com/fsck/k9/activity/ImportListener.java
src/com/fsck/k9/activity/K9Activity.java
src/com/fsck/k9/activity/K9ListActivity.java
src/com/fsck/k9/activity/MessageView.java
src/com/fsck/k9/mail/store/ImapStore.java
src/com/fsck/k9/mail/store/Pop3Store.java
src/com/fsck/k9/mail/store/WebDavStore.java
src/com/fsck/k9/mail/transport/SmtpTransport.java
2011-10-14 20:33:25 +02:00
cketti
b05750c245
Better input validation in *Store.createUri()
2011-10-13 02:35:08 +02:00
cketti
1ab7dbae54
Added input validation for folder settings
2011-10-08 21:30:45 +02:00
Andrew Gaul
57be9e3ee3
Make sets immutable
...
Use final and unmodifiable and avoid anonymous inner classes.
2011-10-06 20:22:18 -07:00
cketti
2e2428b093
Merge pull request #55 from andrewgaul/stringbuilder
...
Prefer StringBuilder over StringBuffer
2011-10-06 09:04:43 -07:00
cketti
31af4526ab
Merge pull request #58 from andrewgaul/spelling
...
Spelling corrections
2011-10-06 09:01:37 -07:00
Andrew Gaul
220e55603d
Spelling corrections
2011-10-05 22:04:39 -07:00
Andrew Gaul
dad0332667
Make an inner class static
2011-10-05 22:01:53 -07:00
Andrew Gaul
47eb0fa2e1
Prefer StringBuilder over StringBuffer
...
The former is unsynchronized and slightly faster.
2011-10-05 21:50:31 -07:00
cketti
0619eaf79c
Catch NumberFormatException when parsing disposition size parameter
...
Fixes issue 3712
2011-10-01 21:17:00 +02:00
Jesse Vincent
fd61b4f20b
Merge pull request #52 from andrewgaul/peekable-bad-offset
...
Fix bad offset in PeekableInputStream
2011-09-28 21:10:41 -07:00
Andrew Gaul
7cf1bfcc98
Fix bad offset in PeekableInputStream
2011-09-20 21:21:50 -07:00
Jesse Vincent
1b7481f854
optimize cketti's pop3 space-splitting code to not make lots of extra
...
copies of responses.
2011-09-04 15:53:12 -04:00
Jesse Vincent
1ac652dc5f
Small bug introduced during a refactoring "Extracted POP3 commands and capabilities to constants" introduced a typo that broke interactions wit some POP3 servers.
2011-08-28 18:28:12 -04:00
Apoorv Khatreja
47bedec410
Fixed an issue which caused space characters to throw exceptions when being parsed. Some cosmetic changes, and context sensitivity for EXISTS, RECENT and EXPUNGE responses which have empty token lists.
2011-08-04 23:30:27 +05:30
Apoorv Khatreja
9335dacd46
Added a separate handler for status responses to parse the resp-text tokens contained in these responses.
2011-08-02 02:19:12 +05:30
Adam
be1be56e3a
Fixed bug where uid in response was truncated
...
The SAX parser returns chunks of text to the
WebDavHandler. Other tags were correctly appending
values while the special cased <uid> tag was
simply assigned the value it was given, which would
result in the last chunk assigned to it and not
the whole string of text.
2011-07-28 15:08:00 -04:00
Apoorv Khatreja
cf39070048
Whitespaces :/
2011-07-25 18:56:21 +05:30
Jesse Vincent
3679b31b12
Workaround for market-reported error:
...
java.lang.Error: org.apache.james.mime4j.io.MaxHeaderLimitException: Maximum header limit exceeded
at com.kaitenmail.mail.internet.MimeMessage.parse(MimeMessage.java:85)
at com.kaitenmail.mail.store.Pop3Store$Pop3Message.parse(Pop3Store.java:932)
at com.kaitenmail.mail.store.Pop3Store$Pop3Folder.fetchBody(Pop3Store.java:714)
at com.kaitenmail.mail.store.Pop3Store$Pop3Folder.fetch(Pop3Store.java:579)
at com.kaitenmail.controller.MessagingController.downloadSmallMessages(MessagingController.java:1562)
at com.kaitenmail.controller.MessagingController.downloadMessages(MessagingController.java:1288)
at com.kaitenmail.controller.MessagingController.synchronizeMailboxSynchronous(MessagingController.java:1031)
at com.kaitenmail.controller.MessagingController.access$400(MessagingController.java:81)
at com.kaitenmail.controller.MessagingController$8.run(MessagingController.java:823)
at com.kaitenmail.controller.MessagingController.run(MessagingController.java:276)
at java.lang.Thread.run(Thread.java:1096)
Caused by: org.apache.james.mime4j.io.MaxHeaderLimitException: Maximum header limit exceeded
at org.apache.james.mime4j.stream.AbstractEntity.parseField(AbstractEntity.java:153)
at org.apache.james.mime4j.stream.MimeEntity.advance(MimeEntity.java:120)
at org.apache.james.mime4j.stream.MimeTokenStream.next(MimeTokenStream.java:351)
at org.apache.james.mime4j.parser.MimeStreamParser.parse(MimeStreamParser.java:179)
at com.kaitenmail.mail.internet.MimeMessage.parse(MimeMessage.java:83)
... 10 more
2011-07-25 01:49:42 -04:00
Apoorv Khatreja
da9a5e6c17
Made some cosmetic changes for clarity, added debug messages for erroneous conditions. Fixed potential NPE in ImapFolder.parseSequenceSet().
2011-07-25 06:50:26 +05:30
Jesse Vincent
0543183b11
Work around a weird NPE in WebDAV sync reported by Jon Blow
2011-07-19 22:43:32 -04:00
cketti
2acd55a9ef
Implemented work-around to handle malformed UIDL responses (POP3).
...
Fixes issue 3546
2011-07-17 14:37:21 +02:00
cketti
9f581cb6f3
Extracted POP3 commands and capabilities to constants
2011-07-17 14:13:04 +02:00
Apoorv Khatreja
adc7d65d09
Newline :/
2011-07-17 01:42:12 +05:30
Apoorv Khatreja
c6a2cb48b1
Added method to check for status response.
2011-07-17 01:41:14 +05:30
Apoorv Khatreja
021d5641e5
ant astyle
2011-07-17 01:40:20 +05:30
Jesse Vincent
b85c9b7b0e
Work around the fact that when we can't get read status for a message,
...
we'd end up with an NPE as we then queried the hashmap
2011-07-11 11:08:20 -04:00
Jesse Vincent
98ae8cf2be
refactoring to use the object we extracted from the array
2011-07-11 11:08:20 -04:00
Jesse Vincent
d7dfba15cf
It appears that Exchange is returning responses
...
without a visiblecount element for empty folders
Which resulted in this code returning -1 (as that was
the previous default.)
-1 is an error condition. Now the default is empty
2011-07-09 17:00:35 -04:00
Jesse Vincent
220be75473
Add a bit of logging to find out what webdav servers tell us about how
...
many messages they have in debug mode
2011-07-09 16:24:18 -04:00
Jesse Vincent
8cffc5b682
Bullet proofing for user-reported exceptions in WebDAV sync:
...
E/k9 ( 5735): java.lang.NullPointerException
E/k9 ( 5735): at
com.kaitenmail.mail.store.WebDavStore$WebDavMessage.setNewHeaders(WebDavStore.java:1903)
E/k9 ( 5735): at
com.kaitenmail.mail.store.WebDavStore$WebDavFolder.fetchEnvelope(WebDavStore.java:1655)
E/k9 ( 5735): at
com.kaitenmail.mail.store.WebDavStore$WebDavFolder.fetchEnvelope(WebDavStore.java:1627)
E/k9 ( 5735): at
com.kaitenmail.mail.store.WebDavStore$WebDavFolder.fetchEnvelope(WebDavStore.java:1627)
E/k9 ( 5735): at
com.kaitenmail.mail.store.WebDavStore$WebDavFolder.fetchEnvelope(WebDavStore.java:1627)
E/k9 ( 5735): at
com.kaitenmail.mail.store.WebDavStore$WebDavFolder.fetchEnvelope(WebDavStore.java:1627)
E/k9 ( 5735): at
com.kaitenmail.mail.store.WebDavStore$WebDavFolder.fetch(WebDavStore.java:1404)
E/k9 ( 5735): at
com.kaitenmail.controller.MessagingController.fetchUnsyncedMessages(MessagingController.java:1418)
E/k9 ( 5735): at
com.kaitenmail.controller.MessagingController.downloadMessages(MessagingController.java:1253)
E/k9 ( 5735): at
com.kaitenmail.controller.MessagingController.synchronizeMailboxSynchronous(MessagingController.java:1031)
E/k9 ( 5735): at
com.kaitenmail.controller.MessagingController.access$400(MessagingController.java:81)
E/k9 ( 5735): at
com.kaitenmail.controller.MessagingController$30.run(MessagingController.java:3768)
E/k9 ( 5735): at
com.kaitenmail.controller.MessagingController.run(MessagingController.java:276)
E/k9 ( 5735): at java.lang.Thread.run(Thread.java:1096)
2011-07-09 15:26:30 -04:00
cketti
d310167b99
Rewrite mime type image/pjpeg to image/jpeg
...
Fixes issue 1712
2011-07-07 03:05:12 +02:00
Jesse Vincent
b02b895aaf
Add 2MB, 5MB and "All" message download options
2011-07-02 15:29:49 -04:00
Jesse Vincent
2a698f1ab9
ant astyle
2011-07-02 15:18:43 -04:00
Apoorv Khatreja
bc9b7030d7
COPYUID implementation now in place and working, restructured appendMessages, copyMessages and moveMessages globally to return a Map of srcUids -> destUids rather than returning nothing. This is now used to bring local and remote UIDs upto speed without the need for additional requests.
2011-06-28 16:50:48 +05:30
Apoorv Khatreja
0ba7f20622
Attempt to implement COPYUID, works for the most part except for updation of the LocalStore with freshly copied messages.
2011-06-24 02:54:12 +05:30
Apoorv Khatreja
970271dbf9
If the response for an APPEND command contains the APPENDUID response code, read the UID of the newly appended message from there.
2011-06-21 04:34:57 +05:30
Apoorv Khatreja
6c84e196aa
Astyle is seriously getting on my nerves. I'm committing this with nothing but astyle changes so that forthcoming commits are clean.
2011-06-21 02:56:53 +05:30
cketti
1bdf7095a7
Delete the old localized outbox. Fixes the "two outboxes" problem.
...
Rename the "new" hardcoded outbox to "K9MAIL_INTERNAL_OUTBOX". This
is done to avoid collisions with folders named "OUTBOX" in a remote
store. See
https://groups.google.com/group/k-9-mail/browse_thread/thread/cbb1c77abba84695
Fixes issue 3411
2011-06-17 06:17:01 +02:00
cketti
222cd43c80
Some code cleanup. No functional changes.
2011-06-17 04:13:32 +02:00
Jesse Vincent
379a8dfa9e
It turns out that 79a96952f2
has caused a
...
lot of messages to be unreadable in K-9 3.8. (see mailing list
threads)
2011-06-09 21:54:22 -04:00
cketti
ded489daab
Add support for incoming-server and outgoing-server elements on import
2011-06-09 05:50:43 +02:00
cketti
4a807e33d9
Decode transport URIs into ServerSettings objects
2011-06-07 16:39:41 +02:00
cketti
bccf0b5546
Renamed class StoreSettings to ServerSettings
2011-06-07 16:09:15 +02:00
cketti
f4bcb4d923
Extracted inner class Store.StoreSettings
2011-06-07 15:59:23 +02:00
cketti
f6de6f8e42
Save name of the store type in StoreSettings
2011-06-07 04:07:50 +02:00
cketti
25c1a565e7
WebDavStore cleanup
...
Store port number so we can throw away the store URI once decoded
2011-06-07 03:01:02 +02:00
cketti
29738993d9
Added function to decode store URIs into a container object
...
This will later be used by the export code to make exporting the
password optional (and the XML output "pretty").
It's also the first step to get away from store URIs towards something
more easily extensible, like Store.StoreSettings.
2011-06-07 00:08:43 +02:00
cketti
0e2afc38ef
Cosmetic changes
...
- Grouped static fields and functions
- Renamed static fields to match code standard
2011-06-06 21:10:14 +02:00
Jesse Vincent
31adcd2ed8
Revert " http://code.google.com/p/k9mail/issues/detail?id=3408&sort=-id&colspec=ID%20Product%20Type%20Status%20Priority%20Milestone%20Owner%20Summary "
...
This reverts commit 0c2e06133c
.
The patch would cause an extra SMTP connection on _any_ meesage with
attachments. Marcus is headed away on holiday and asked me to revert it
for him (after I asked him to revert it) - With luck, we'll talk through
a design to work around this issue on the list
Conflicts:
src/com/fsck/k9/mail/transport/SmtpTransport.java
2011-06-02 09:35:03 -04:00
Jesse Vincent
3d583da450
ant astyle
2011-06-01 16:03:56 -04:00
Marcus Wolschon
0c2e06133c
http://code.google.com/p/k9mail/issues/detail?id=3408&sort=-id&colspec=ID%20Product%20Type%20Status%20Priority%20Milestone%20Owner%20Summary
...
Issue 3408: SMTP timeouts while calculating message size
2011-06-01 09:13:16 +02:00
Marcus Wolschon
0b6f0a09bb
http://code.google.com/p/k9mail/issues/detail?id=3407&sort=-id&colspec=ID%20Product%20Type%20Status%20Priority%20Milestone%20Owner%20Summary
...
Issue 3407: Handling of SMTP 5xx error codes unclean
fix part one: 5xx error codes are detected in SMTP-code and reported as permanent failures.
2011-06-01 09:07:05 +02:00
cketti
30d31c7074
Explicitly use Locale.US when dealing with dates in message headers
2011-05-26 04:32:26 +02:00
Jesse Vincent
92239739b0
microoptimize peekableInputStream's peek method to not do an extra
...
method dispatch and boolean check on every peek.
2011-05-24 21:35:18 -04:00
Jesse Vincent
29117ae7a6
Switch a StringBuffer to StringBuilder, which replaced it
2011-05-24 21:21:03 -04:00
Koji Arai
b4f3712246
Should retrieve just visibleLimit messages when the local folder is cleared.
2011-05-25 00:37:51 +09:00
Koji Arai
cb46f170cd
Should reset visibleLimit on clear messages.
2011-05-25 00:37:49 +09:00
Koji Arai
a4f7288d37
Avoid NullPointerException.
...
The name parameter in Content-Type may be not set.
2011-05-25 00:37:46 +09:00
cketti
2d7fad1fa9
Use InetAddress.getCanonicalHostName() instead of getHostName()
...
This should always return a FQDN.
2011-05-19 00:55:34 +02:00
cketti
8fc714ac4a
Don't show "null" for partially downloaded messages with empty text body
2011-05-16 00:36:46 +02:00
cketti
41b039b691
Fix bug introduced with commit b7a6dbd973
...
Fixes issue 3297
2011-05-15 16:23:53 +02:00
cketti
95288b37d7
Removed unnecessary method implementation
...
Make Pop3Folder.setFlags(Flag[],boolean) throw an
UnsupportedOperationException instead of calling a method that does
just that.
2011-05-14 23:46:26 +02:00
cketti
dc96bf3186
Only mark all messages as read on the server if that's supported
...
This change prevents K-9 Mail from establishing a connection to the
server when all messages are marked as read on a POP3 account.
2011-05-14 23:30:47 +02:00
cketti
ba9bc2f8e9
Added method Folder.isFlagSupported(Flag)
2011-05-14 23:19:24 +02:00
cketti
86fca9c1f2
POP3: Check for support of the TOP command (if CAPA isn't supported)
...
This will allow to download partial messages if the server doesn't
support the CAPA command but supports the TOP command (e.g. Hotmail).
Fixes issue 2042
2011-05-14 21:40:21 +02:00
cketti
8e1c4acef9
Get rid of constant K9.OUTBOX
...
Use Account.getOutboxFolderName() instead (still hardcoded, though)
2011-05-08 02:22:38 +02:00
cketti
92ea452163
Restore hardcoded Outbox
2011-05-07 23:57:47 +02:00
cketti
33c0bf9e31
Avoid NullPointerException for messages with html_content = NULL in DB
...
Fixes issue 3302
2011-05-06 20:02:55 +02:00
Jesse Vincent
8a907f9be7
remove a pointless extra assignment
2011-05-05 12:47:57 -04:00
Jesse Vincent
196a9c167d
comment some preview regexes
2011-05-05 12:47:39 -04:00
Andrew Chen
3fcca67ae5
Preserve legacy SMTP authentication behavior for PLAIN by trying LOGIN if supported.
2011-05-04 23:34:02 -07:00
Bernhard Redl
f2283aa91e
Catch IllegalCharsetNameException causing force-close on unsupported japanese charsets (issue 3272)
2011-05-01 04:32:10 +02:00
cketti
b7a6dbd973
Skip IMAP folders with names that are not correctly encoded.
...
Configure the CharsetDecoder to throw an exception if malformed input
is encountered. Not doing this can cause an endless loop that
allocates memory until the application dies with an OutOfMemory error.
Until we have support for both a folder display name and a raw folder
name we simply ignore folders with names that aren't correctly encoded
with the modified UTF-7 variant.
Fixes issue 3268
Credits: Bernhard Redl (aatdark) analysed the problem and wrote the
initial version of the fix.
2011-04-28 04:46:01 +02:00
cketti
037b0ff64d
Fix automatic authentication method selection for SMTP
...
Only use automatic authentication method selection if none was
explicitly selected in outgoing server settings.
2011-04-26 18:23:41 +02:00
cketti
e8a1a9a466
Restored semantics of auth*Supported in SMTP authentication code
...
Also, display a debug message if a certain authentication method was
selected by the user but the server didn't advertise support for it in
the EHLO response.
2011-04-26 17:49:40 +02:00
Jonas Hurrelmann
da38149091
Support for SMTP authentication methods that are not announced by the server.
...
- Added AUTOMATIC as a new authentication method that will automatically choose the best authentication method (basically old behavior with CRAM_MD5). All other options will now enforce the selected authentication method.
- Added LOGIN as selectable option.
- Cleaned up code so strings to the different authentication methods are only defined once.
2011-04-25 22:32:48 +02:00
cketti
4b2fe6efab
Removed unused imports
2011-04-21 00:00:16 +02:00
cketti
49308922d9
Refactored code to calculate number of unread messages some more
2011-04-20 23:58:10 +02:00
Bernhard Redl
92f7c3a19f
Refactored the code to calculate the number of unread messages in an account
2011-04-20 23:35:02 +10:00
Bernhard Redl
415c11d712
"When calculating the number of unread messages shown in the account list, INBOX now is always counted, even if a "special" folder has been set to INBOX (issue 3074)
2011-04-20 23:09:02 +10:00
Jesse Vincent
d3848d352d
astyle
2011-04-12 22:17:22 +10:00
bitblaster
d2c56edbd2
Restored original imports, added comments, changed method createFolder
2011-04-12 22:17:11 +10:00
bitblaster
0a5d7ba953
In getPersonalNameSpaces now we ask the server for the real folder names corresponding to the special folders ids (for which we have constants), so we can map the account folders using the real names.
2011-04-12 22:17:11 +10:00
bitblaster
c46372b58c
Replaced references to K9.INBOX with account.getInboxFolderName()
2011-04-12 22:17:11 +10:00
bitblaster
59b1d57658
Replaced references to K9.INBOX with account.getInboxFolderName()
2011-04-12 22:17:11 +10:00
bitblaster
20a9043a13
Replaced references to K9.INBOX with account.getInboxFolderName()
2011-04-12 22:17:11 +10:00
Jesse Vincent
0174988d27
astyle
2011-04-12 22:16:22 +10:00
Sander Bogaert
c283449d04
Added another badDateTimeFormat to ImapResponseParser.
...
Some IMAP servers generate timestamps without timezones. :/
Fixes gcode issue 3179
2011-04-12 21:34:22 +10:00
cketti
939660faf4
Quote CID before using it in a regular expression
...
Fixes issue 3227
2011-04-10 20:39:40 +02:00
Koji Arai
2cd178e684
Fixed NullPointerException
2011-04-10 01:10:25 +09:00
Koji Arai
79a96952f2
Correct encoding and decoding for the filename parameter in the Content-Disposition.
2011-04-08 00:58:53 +09:00
cketti
2cadff74b1
Extracted CRAM-MD5 computation into separate class.
...
This gets rid of duplicated code in ImapStore, Pop3Store, and
SmtpTransport.
2011-04-07 17:11:32 +02:00
Will Hawkins
d881832eca
Made the minor modifications to support CRAM-MD5 authentication
...
in POP3 accounts.
2011-04-06 11:42:37 -04:00
Koji Arai
37303d69d8
Should store the disposition-type without Content-Disposition parameters.
2011-04-04 00:58:59 +09:00
Jesse Vincent
39e3aecf73
Unify two IMAP date parsing paths, improving the exception so we can
...
learn what date format we don't cope with.
2011-04-03 14:56:12 +10:00
cketti
867b251e6d
Added @Override annotations to fix warnings
2011-04-01 04:36:29 +02:00
DraSine on Rails
e698c78190
Fixed gcode #3182
...
Sending mail (SMTP) doesn’t work is the SMTP server is picky about RFC
conformance of envelope dialogue.
k9mail:
MAIL FROM: <sender@dom.ain>
RCPT TO: <receiver@dom.ain>
rfc:
MAIL FROM:<sender@dom.ain>
RCPT TO:<receiver@dom.ain>
2011-03-31 21:41:03 +08:00
cketti
29c42eb1a3
More structure for the XML export (folder settings)
2011-03-30 04:57:05 +02:00
Jesse Vincent
03d05e9331
If an SMTP server tells us how big the biggest message they accept is,
...
don't even try to deliver it to them
2011-03-27 23:09:41 +08:00
Jesse Vincent
97ec38d03f
Move our IMAP Store to using a message's sizing method
2011-03-27 23:09:41 +08:00
Jesse Vincent
4f63a3de24
Add a pair of methods to help optimize countingmessagestream
2011-03-27 23:08:25 +08:00
Jesse Vincent
604e532879
Add a method to calculate a message's serialized size
2011-03-27 23:08:25 +08:00
Jesse Vincent
c8d38da568
Pull out the maximum acceptable message size from SMTP servers that tell
...
us when we EHLO.
Next step is to _use_ this data.
2011-03-27 23:08:25 +08:00
cketti
26258d7666
Removed unused imports
2011-03-26 06:43:39 +01:00
cketti
c9510f8f16
Merge branch 'mime_type_rewriting'
2011-03-25 01:31:27 +01:00
cketti
0aa03ccdc4
Extract MIME type fixup code to method MimeUtility.getMimeTypeForViewing()
2011-03-25 00:37:53 +01:00
cketti
7c5c29e87e
Move MIME type fixing to AttachmentProvider
2011-03-24 23:07:46 +01:00
cketti
f3e4618702
Cosmetic + documentation changes
2011-03-24 23:04:58 +01:00
Apoorv Khatreja
168f6277da
Mime type rewriting must be done only when an attachment is viewed. Therefore, removed conflicting references to rewriting code from LocalStore.
2011-03-25 05:46:11 +08:00
Apoorv Khatreja
80d99baf29
Implemented table lookup for mime type replacement (issue 873 and similar), added javadocs, moved to MimeUtility.java.
2011-03-25 05:46:11 +08:00
cketti
83451cff10
Merge branch 'remove_non_api_dependencies'
2011-03-24 19:35:12 +01:00
Jesse Vincent
e19162cb86
ant astyle
2011-03-22 18:07:47 +11:00
danapple
8e5c50a8ef
astyle
2011-03-20 15:21:24 -05:00
HIRANO Takahito
6c37741e63
Could not handle iso-2022-jp streams which contain continuous escape
...
sequences.
Signed-off-by: HIRANO Takahito <hiranotaka@zng.info>
2011-03-19 18:05:07 +09:00
cketti
330737c4c6
Fix length-check of BODYSTRUCTURE reply
...
Fixes issue 3116
2011-03-15 08:34:38 +01:00
cketti
a753f1ce5c
Removed unused import
2011-03-14 00:35:03 +01:00
danapple
a8440032e9
Fixes Issue 3102 in cooperation with vincent...@gmail.com
...
Reset service enablement and MailService scheduling whenever a storage
medium is mounted or unmounted.
2011-03-12 12:27:11 -06:00
danapple
7891b24c31
Fixes Issue 3102 in cooperation with vincent...@gmail.com
...
Reset service enablement and MailService scheduling whenever a storage
medium is mounted or unmounted.
2011-03-09 23:04:05 -06:00
cketti
171711fa9c
Remove trailing space from IMAP command
...
This could be the cause of the error reported in issue 3089.
2011-03-04 03:36:52 +01:00
danapple
fdb38da2e5
Discourage accidental deletion of essential mime types.
2011-03-02 19:28:36 -06:00
danapple
32b5afc702
astyle
2011-03-02 07:34:54 -06:00
danapple
107408c0d9
K-9 Mail now opens the Accounts Activity when started with an Intent
...
with an enclosed URI with a content type of application/x-k9settings.
This allows a user to bootstrap K-9 Mail configuration by email a
settings file from one device to another, perhaps using a GMail
account on the receiving end.
2011-03-01 22:34:41 -06:00
danapple
88f6034cbb
When emailing a K-9 settings export file, use specific special content type.
2011-03-01 21:43:11 -06:00
Koji Arai
da34a5ec8c
Avoid IllegalArgumentException for Charset.forName(null).
2011-03-02 00:59:20 +09:00
cketti
766674c27c
Code/comment cleanup
2011-02-26 23:04:49 +01:00
Jesse Vincent
c7a3b28289
Change our technique for sending \r\n at the end of smtp commands to
...
deal with a weird failure on honeycomb
2011-02-26 16:53:53 -05:00
cketti
6f90d791b5
Removed dependency on (external) commons-codec and commons-logging
2011-02-26 17:36:18 +01:00