cketti
a79b7ea93c
Inlined methods that were extracted to use
...
@SuppressWarnings("unchecked"). That's now unnecessary after the
Serializable -> Parcelable switch
2011-02-20 06:23:06 +01:00
cketti
bb40049212
Remove unused imports
2011-02-20 05:31:35 +01:00
Jan Berkel
685df0ff67
Perf improvement: use parcels instead of serializable
...
Standard Java serialization is slow on Android. Replacing it w/
parcelable makes it around 10x faster (on a N1, with ~ 500 messages
in the list).
To avoid further confusion and potential bugs MessageReference was
made no longer implement Serializable.
2011-02-19 15:24:53 -05:00
Jesse Vincent
8a778a0222
reformatting
2011-02-14 20:45:08 -05:00
Jesse Vincent
fb663508e0
remove an unused method
2011-02-14 20:44:53 -05:00
Jesse Vincent
143ca4df26
replace redundant calls with a helper
2011-02-14 20:26:00 -05:00
Jesse Vincent
ea6e5e0e62
Lifting more of the "Show this message" over to the SingleMessageView
2011-02-14 13:40:49 -05:00
Jesse Vincent
dc1444d1ac
Rename a method that was confusingly similar to another method
2011-02-14 13:32:30 -05:00
Jesse Vincent
10da146e93
clean up unused imports
2011-02-14 13:32:25 -05:00
Jesse Vincent
5aad882976
Move the "isScreenReader" active code down into the MessageView
2011-02-14 13:32:14 -05:00
Jesse Vincent
04bc32db9e
move a call to setLoadPictures down
2011-02-14 13:31:43 -05:00
Jesse Vincent
043535f7a5
Migrate a method into SingleMessageView
2011-02-14 13:31:34 -05:00
Jesse Vincent
abc921093c
refactor display of the download button
2011-02-11 12:11:21 -05:00
Jesse Vincent
9deea33426
re-enable setOnFlagListener
2011-02-11 12:10:45 -05:00
Jesse Vincent
06baf3f602
simplify the "load a url for the message body" signature
2011-02-11 12:09:47 -05:00
Jesse Vincent
111b9a6305
remove a pointless indirection and an extra method call to set the
...
options menu when we didn't need to
2011-02-11 11:16:50 -05:00
Jesse Vincent
49b35f9236
More reshuffling toward having a reusable "Show a message" widget - what
...
should eventually be a Fragment.
Lifted part of the cryptoView back up to the activity since the
factoring felt forced.
2011-02-11 10:59:31 -05:00
Jesse Vincent
015baa06b4
Renamed "next" and "previous" buttons to match code style
2011-02-10 16:39:49 -05:00
Jesse Vincent
fe21d6951f
remove unused method
2011-02-10 16:39:49 -05:00
Jesse Vincent
98f3909ecc
Split out a "clear the current message view" method
2011-02-10 14:56:56 -05:00
Jesse Vincent
850aee9008
Move as much of the Apg code as possible to its own "view" class
...
(should eventually be a fragment?)
2011-02-10 14:02:21 -05:00
Jesse Vincent
12d1097a24
Big, scary massive "ant astyle" to get us back to something
...
approximating AOSP coding standards.
2011-02-06 17:09:48 -05:00
Jesse Vincent
4a558c5ac5
Revert the active part of "Update issue 848"
...
This reverts commit 9fc94115adb58dcd8a64227a93d0e6e707d7752d.
It turns out that disabling the "View attachment" button (rather than
giving a useful error message telling the user what mime type the app
needs to support) was confusing to users.
2011-01-28 03:33:49 +00:00
cketti
f5bb836087
Fix code that was broken when fixing warnings.
2011-01-19 21:00:28 +00:00
cketti
7119c7165f
Removed unnecessary type casts
2011-01-19 01:21:27 +00:00
cketti
365b106753
Fixed warnings about unchecked casts by extracting the code to methods and using the @SuppressWarnings annotation on them.
2011-01-19 00:36:15 +00:00
cketti
8279092070
Fixed lots of warnings (unused imports/variables, missing annotations, etc.)
2011-01-18 23:54:49 +00:00
Jesse Vincent
d59600653c
astyle
2011-01-18 00:04:11 +00:00
Marcus Wolschon
fc4b64c559
Update issue 848
...
"view" only enabled for attachments if there is an actual
application on the phone to view this kind of file.
2011-01-17 10:41:48 +00:00
Jesse Vincent
9d5704c0f5
Split the Header view out from the MessageView activity
2011-01-10 17:47:28 +00:00
Jesse Vincent
b2c44579d2
lift "displayMessage" out of a callback
2011-01-06 16:56:55 +00:00
Jesse Vincent
39ef6584a8
continue to extract attachment code out to AttachmentView
2011-01-06 16:56:37 +00:00
Jesse Vincent
19c5324316
Extract AttachmentView and MediaScannerNotifier into their own classes
2011-01-06 16:56:20 +00:00
Jesse Vincent
ed60cdfa5a
replace constant lookups of the MessagingController instance with a locally cached one
2011-01-06 16:56:02 +00:00
Jesse Vincent
299c057cd4
minor code cleanup
2011-01-06 16:55:48 +00:00
Jesse Vincent
9c847d3e9d
minor code cleanup
2011-01-06 16:55:34 +00:00
Jesse Vincent
de806f7715
astyle
2011-01-06 16:55:08 +00:00
Andrew Chen
605a0bdc93
Add more comments about LocalTextBody.
...
Display decrypted PGP data as text/plain (content type was being set, but not being passed to WebViews).
2010-12-29 07:34:57 +00:00
Jesse Vincent
8bc984f440
APG-related messageview bugfixes
2010-12-28 09:11:35 +00:00
Jesse Vincent
0c426c9c4b
Round our color chips, clean up color hcip rendering a bit
2010-12-28 09:11:10 +00:00
Jesse Vincent
4c9c478d8d
minor code and doc cleanups as recommended by IntelliJ
2010-12-28 09:10:50 +00:00
Jesse Vincent
b166cf03e8
split apart attachment view creation a bit
2010-12-28 09:09:52 +00:00
Jesse Vincent
3c9eb2c004
Further refactoring of message display
2010-12-28 09:09:33 +00:00
Jesse Vincent
9fe56831bf
finish removing setHeaders as a layer of indirection
2010-12-28 09:09:15 +00:00
Jesse Vincent
8116a0f39f
lift some gpg code into the crypto initializer
2010-12-28 09:08:58 +00:00
Jesse Vincent
3ffa28fa02
we import so we don't need to qualify
2010-12-28 09:08:40 +00:00
Jesse Vincent
85a7a08e9a
Rename our attachment view holder from Attachment to AttachmentViewHolder
2010-12-28 09:08:18 +00:00
Jesse Vincent
6a04afb758
extract "does it have html images" out of MessageView. really, it should
...
end up in LocalMessage somewhere
2010-12-28 09:07:59 +00:00
Jesse Vincent
7623a02852
lift the "get display text" code out of the messageview and into
...
localmessage
2010-12-28 09:07:39 +00:00
Jesse Vincent
84f6e546d2
setLoadPictures sets mShowPictures. We don't need to set it again
2010-12-28 09:07:19 +00:00
