Commit Graph

5332 Commits

Author SHA1 Message Date
cketti 6a1905b7b7 If we can't find an app to view an attachment try again with a file:// URI
Sadly, some apps only support the 'file' scheme in their intent filters. Among
them is Android's own package installer.
2014-11-10 05:37:22 +01:00
cketti 44ecf5d588 Use MIME type used for intent resolution in content provider 2014-11-10 03:12:28 +01:00
cketti f87ab53b9b Try original and inferred MIME type to find best viewer for attachment
In order for Android to find apps that are capable of opening an attachment for
viewing the ACTION_VIEW Intent needs to contain an appropriate MIME type.
Ideally, we'd use the MIME type specified for the attachment in the message.
But often the supplied MIME type is wrong/useless. So we look at the file
extension to try to come up with a sensible MIME type on our own. We then go
on to ask Android which of the two MIME types leads to more apps claiming to
be able to open our attachment for viewing and use that one.
2014-11-10 03:10:09 +01:00
cketti 11a9eff109 Extract intent creation code to method 2014-11-09 20:46:46 +01:00
cketti 6cb3c991db No longer pretend there are attachment types we don't care about 2014-10-20 21:26:18 -04:00
cketti 3c4ad91614 Fix method names/visibility 2014-10-20 21:24:18 -04:00
cketti d3073be89a Rearrange fields/methods 2014-10-20 21:21:09 -04:00
cketti 83d876f246 Inline method 2014-10-20 21:16:31 -04:00
cketti f6822c973d Clean up comments 2014-10-20 21:13:58 -04:00
cketti 1e89314f3e Remove "m" prefix for field names 2014-10-20 21:09:23 -04:00
cketti b3bc85ba10 Split 'populateFromPart' into multiple methods 2014-10-20 21:06:31 -04:00
cketti ca88f59c05 Create named class for loading and displaying attachment thumbnails 2014-10-20 20:46:46 -04:00
cketti 4299eb9771 Rename method and improve documentation 2014-10-20 20:28:38 -04:00
cketti 4a6c52947d Make all fields of AttachmentView private 2014-10-20 20:14:04 -04:00
cketti 0ced8746af Remove old/unused code from click handler 2014-10-20 20:05:21 -04:00
cketti 33d12e4169 Fix russian translation of 'message_view_no_viewer' 2014-10-20 19:52:42 -04:00
cketti 187d760e5f Extract code to display error/status messages to a separate method 2014-10-20 19:50:41 -04:00
cketti dfe1771fcb Fix formatting 2014-10-20 19:39:16 -04:00
cketti b7a8c9b707 Remove unused code 2014-10-20 19:34:16 -04:00
tobiasbaum 3dab8a2ad1 Merge pull request #14 from k9mail/art/tidy-application-ref
remove unnecessary method parameters
2014-10-19 21:53:42 +02:00
Art O Cathain 438a350f55 remove unnecessary method parameters 2014-10-19 18:40:17 +01:00
Art O Cathain a9b0907c31 further simplification 2014-10-12 09:24:08 +01:00
Art O Cathain ba26cfce90 remove controversial methods 2014-10-12 08:54:44 +01:00
Art O Cathain 5dc1b82340 address review comments 2014-10-11 23:52:48 +01:00
Boris Kraut aa959f4457 Get more dependencies from jCenter 2014-10-11 18:03:57 +02:00
Art O Cathain e592aff437 fix test that failed due to certificate expiry 2014-10-11 16:34:58 +01:00
Art O Cathain d980e49fd1 chain the exception 2014-10-11 16:11:12 +01:00
Art O Cathain c6df8f1ba1 warn if not serializable, also add basic unit test 2014-10-11 12:37:36 +01:00
Art O Cathain dd1ec5f47b add unit test 2014-10-11 12:13:07 +01:00
Art O Cathain 668ee71b6c fix tests on JVM 2014-10-11 12:10:07 +01:00
cketti 4aad31e05a Bump version to 5.101 2014-10-10 13:42:52 -04:00
cketti d2bfcab939 Update changelog for 5.101 2014-10-10 13:39:30 -04:00
cketti c3c8221d4a Set minSdkVersion + targetSdkVersion via build.gradle
Without this building with Gradle adds a 'maxSdkVersion' attribute to the manifest. This seems to cause the targetSdkVersion value being ignored. And with a targetSdkVersion value lower than 16 the permissions READ_CONTACTS/WRITE_CONTACTS imply READ_CALL_LOG/WRITE_CALL_LOG. But we don't need/want those permissions.
2014-10-10 13:15:48 -04:00
cketti 7945aab8a7 Merge pull request #9 from k9mail/art/interface-not-impl
use interfaces, not implementions
2014-10-07 23:00:11 -04:00
cketti 0f844fd4d2 Bump version to 5.100 2014-10-07 21:50:15 -04:00
cketti 270160e65a Support reading signing config values from Gradle properties 2014-10-07 21:40:42 -04:00
cketti 87acbb7cac Update changelog for 5.100 2014-10-07 21:30:55 -04:00
cketti 06d1a2471a Change text in feature graphic 2014-10-07 21:27:45 -04:00
Joe Steele a141457886 Revert "Implement SSL file-based session caching"
This reverts commit 43c38a047f.
2014-10-07 21:23:04 -04:00
Art O Cathain 40102d560d Set interface makes more sense for flags 2014-10-05 12:40:35 +01:00
Art O Cathain 195f28db00 Revert accidental change 2014-10-05 12:23:43 +01:00
Art O Cathain 444756839c EnumSet is more efficient than HashSet 2014-10-05 12:08:55 +01:00
Art O Cathain fe7c0ebfac simplify following code review 2014-10-05 11:57:11 +01:00
Art O Cathain 159017e91d removed unneeded variables and clarified names 2014-10-05 11:50:04 +01:00
Art O Cathain d38f21265d use isEmpty instead of size() == 0 for clarify 2014-10-05 10:37:50 +01:00
Art O Cathain 02c0b5f2a3 Use collections instead of arrays to enable stronger typing and reduce cruft 2014-10-05 10:37:36 +01:00
Art O Cathain 203dcfe2c3 use interfaces, not implementions 2014-10-04 12:00:48 +01:00
tobiasbaum dadf5e0865 Merge pull request #7 from artbristol/art/tidying
Art/tidying
2014-09-29 22:15:59 +02:00
Art O Cathain 010d8c9f7e always use import for UrlEncodingHelper 2014-09-29 18:06:21 +01:00
tobiasbaum b8870493cd Merge pull request #6 from tobiasbaum/master
More small refactorings
2014-09-28 20:10:37 +02:00