moparisthebest/k-9
1
0
Fork 0
mirror of https://github.com/moparisthebest/k-9 synced 2024-11-11 03:55:04 -05:00
Code Issues Releases Wiki Activity
2,646 Commits 36 Branches 329 Tags 887 MiB
d80e5bfbd0
Commit Graph

543 Commits

Author SHA1 Message Date
Andrew Chen
d80e5bfbd0 Merge pull request #90 from andrewgaul/close-quietly 
Call IOUtils.closeQuietly instead of using empty try/catch block.
 2011-11-03 06:35:42 -07:00
Andrew Chen
64b299ebec Merge pull request #89 from andrewgaul/is-empty 
Prefer Collection.isEmpty over size
 2011-11-03 06:34:15 -07:00
Andrew Chen
9e74f9ffcf Merge pull request #88 from andrewgaul/log-throwable 
Log Throwables instead of concatenating
 2011-11-03 06:32:20 -07:00
Andrew Chen
64e2247e8f Merge pull request #87 from andrewgaul/map-initialization 
Optimize static map, remove unneeded inner class, and use unmodifiable map.
 2011-11-03 06:31:32 -07:00
Andrew Chen
8dccc7a996 Merge pull request #86 from andrewgaul/findbugs-concatenation 
Prefer StringBuilder.append over String.concat
 2011-11-03 06:28:51 -07:00
Andrew Gaul
b1a807a712 Call IOUtils.closeQuietly where appropriate 2011-11-02 22:22:15 -07:00
Andrew Gaul
2599bdcc75 Log Throwable instead of concatenating 2011-11-02 22:18:30 -07:00
Andrew Gaul
70b635ec30 Initialize static map optimally 
Remove unneeded inner class, use unmodifiable map, and mark as static.
 2011-11-02 22:16:12 -07:00
Andrew Gaul
cb14cd9d78 Prefer StringBuilder.append over String.concat 
Addresses FindBugs complaints.
 2011-11-02 22:10:02 -07:00
Andrew Gaul
61c850e077 Remove dead stores 
Addresses FindBugs complaints.
 2011-11-02 22:02:41 -07:00
Andrew Gaul
647ae0a31c Prefer Collection.isEmpty over size 2011-11-02 20:03:07 -07:00
Andrew Chen
1e9a40ffd2 Merge pull request #81 from aatdark/issue3814 
Improve handling of From: Headers without parseable email addresses (fixes 3814)
 2011-11-02 17:55:58 -07:00
Bernhard Redl
68cecb168e added testcases for address#parse function,changed empty to null (conforms to existing code) 2011-11-03 01:36:57 +01:00
Andrew Chen
b5dca5cf68 Merge pull request #76 from sunglim/string_util 
Added StringUtils.isNullOrEmpty().
 2011-11-02 10:50:52 -07:00
Andrew Chen
66881c0f2b Merge branch 'master' of git@github.com:k9mail/k-9.git 
* 'master' of git@github.com:k9mail/k-9.git:
  Optimize java.util.* imports.
 2011-11-02 08:37:12 -07:00
Andrew Chen
f884e967c9 Use MimeHeader.* constants when referring to content headers. Minor whitespace changes. 2011-11-02 08:34:06 -07:00
Bernhard Redl
6a76b073c3 Improve handling of From: Headers without parseable email addresses (fixes 3814) 2011-11-02 02:08:06 +01:00
Andrew Chen
406aae6e61 Optimize java.util.* imports. 
Conflicts:

	src/com/fsck/k9/mail/store/WebDavStore.java
 2011-11-01 13:54:55 -07:00
Andrew Chen
ea05f3b5d0 Merge branch 'legacy-collections' of https://github.com/andrewgaul/k-9 into andrewgaul 
* 'legacy-collections' of https://github.com/andrewgaul/k-9:
  Prefer unsynchronized Collection types
 2011-11-01 13:26:54 -07:00
Andrew Chen
4395da270d Merge pull request #77 from andrewgaul/findbugs-entryset 
Prefer entrySet over keySet and get
 2011-11-01 12:44:26 -07:00
Andrew Gaul
773f2e8870 Prefer Integer.valueOf over explicit boxing 
Addresses a FindBugs complaint.
 2011-10-31 21:58:32 -07:00
Andrew Gaul
bfd11c444f Prefer entrySet over keySet and get 
Addresses FindBugs complaints.
 2011-10-31 21:42:12 -07:00
Lim Sungguk
8ab10a7586 applied StringUtils.isNullOrEmpty() 2011-10-29 15:12:49 +09:00
Andrew Chen
f24d4c9155 Merge pull request #72 from andrewgaul/remove-literal 
Remove unused literal methods
 2011-10-27 23:32:28 -07:00
cketti
e3f6561008 Don't crash when trying to connect to an non-SSL service using SSL 
Fixes issue 3798
 2011-10-28 04:59:08 +02:00
cketti
91ee21bb2d Use "String.length() == 0" instead of String.isEmpty() [API 9+] 2011-10-27 19:11:44 +02:00
cketti
b69d6cb64c Use Locale.US with toUpperCase() and toLowerCase() where appropriate 2011-10-27 17:17:43 +02:00
cketti
9327c86fe7 Use Locale.US when calling toUpperCase() on the generated MIME boundary 
Fixes issue 3733
 2011-10-27 16:52:27 +02:00
Andrew Chen
b6cdec43e9 Merge pull request #73 from andrewgaul/address-parse-npe 
Fix NPE in Address.Parse
 2011-10-26 18:15:40 -07:00
Andrew Gaul
ad5676ed28 Fix NPE in Address.Parse 
Found by FindBugs.  Also avoid an allocation in the uncommon case.
 2011-10-25 21:24:38 -07:00
Andrew Gaul
e394924ce4 Prefer Random.nextInt over Math.random 
Addresses a FindBugs complaint.
 2011-10-25 21:21:23 -07:00
Andrew Gaul
a2d0f9ccb7 Remove unused literal methods 2011-10-25 13:56:07 -07:00
Jesse Vincent
ae3f098b4a Merge pull request #64 from andrewgaul/typesafe-set 
Avoid type-unsafe Set
 2011-10-20 05:34:48 -07:00
Andrew Gaul
5b9f542bd7 Avoid type-unsafe Set 2011-10-19 23:05:34 -07:00
Andrew Gaul
ce4b42f66b Remove duplicated combine flags code 2011-10-19 22:04:57 -07:00
Andrew Gaul
80d9246130 Prefer unsynchronized Collection types 2011-10-19 21:56:20 -07:00
Andrew Gaul
57be9e3ee3 Make sets immutable 
Use final and unmodifiable and avoid anonymous inner classes.
 2011-10-06 20:22:18 -07:00
cketti
2e2428b093 Merge pull request #55 from andrewgaul/stringbuilder 
Prefer StringBuilder over StringBuffer
 2011-10-06 09:04:43 -07:00
cketti
31af4526ab Merge pull request #58 from andrewgaul/spelling 
Spelling corrections
 2011-10-06 09:01:37 -07:00
Andrew Gaul
220e55603d Spelling corrections 2011-10-05 22:04:39 -07:00
Andrew Gaul
dad0332667 Make an inner class static 2011-10-05 22:01:53 -07:00
Andrew Gaul
47eb0fa2e1 Prefer StringBuilder over StringBuffer 
The former is unsynchronized and slightly faster.
 2011-10-05 21:50:31 -07:00
cketti
0619eaf79c Catch NumberFormatException when parsing disposition size parameter 
Fixes issue 3712
 2011-10-01 21:17:00 +02:00
Jesse Vincent
fd61b4f20b Merge pull request #52 from andrewgaul/peekable-bad-offset 
Fix bad offset in PeekableInputStream
 2011-09-28 21:10:41 -07:00
Andrew Gaul
7cf1bfcc98 Fix bad offset in PeekableInputStream 2011-09-20 21:21:50 -07:00
Jesse Vincent
1b7481f854 optimize cketti's pop3 space-splitting code to not make lots of extra 
copies of responses.
 2011-09-04 15:53:12 -04:00
Jesse Vincent
1ac652dc5f Small bug introduced during a refactoring "Extracted POP3 commands and capabilities to constants" introduced a typo that broke interactions wit some POP3 servers. 2011-08-28 18:28:12 -04:00
Adam
be1be56e3a Fixed bug where uid in response was truncated 
The SAX parser returns chunks of text to the
WebDavHandler. Other tags were correctly appending
values while the special cased <uid> tag was
simply assigned the value it was given, which would
result in the last chunk assigned to it and not
the whole string of text.
 2011-07-28 15:08:00 -04:00
Jesse Vincent
3679b31b12 Workaround for market-reported error: 
java.lang.Error: org.apache.james.mime4j.io.MaxHeaderLimitException: Maximum header limit exceeded
at com.kaitenmail.mail.internet.MimeMessage.parse(MimeMessage.java:85)
at com.kaitenmail.mail.store.Pop3Store$Pop3Message.parse(Pop3Store.java:932)
at com.kaitenmail.mail.store.Pop3Store$Pop3Folder.fetchBody(Pop3Store.java:714)
at com.kaitenmail.mail.store.Pop3Store$Pop3Folder.fetch(Pop3Store.java:579)
at com.kaitenmail.controller.MessagingController.downloadSmallMessages(MessagingController.java:1562)
at com.kaitenmail.controller.MessagingController.downloadMessages(MessagingController.java:1288)
at com.kaitenmail.controller.MessagingController.synchronizeMailboxSynchronous(MessagingController.java:1031)
at com.kaitenmail.controller.MessagingController.access$400(MessagingController.java:81)
at com.kaitenmail.controller.MessagingController$8.run(MessagingController.java:823)
at com.kaitenmail.controller.MessagingController.run(MessagingController.java:276)
at java.lang.Thread.run(Thread.java:1096)
Caused by: org.apache.james.mime4j.io.MaxHeaderLimitException: Maximum header limit exceeded
at org.apache.james.mime4j.stream.AbstractEntity.parseField(AbstractEntity.java:153)
at org.apache.james.mime4j.stream.MimeEntity.advance(MimeEntity.java:120)
at org.apache.james.mime4j.stream.MimeTokenStream.next(MimeTokenStream.java:351)
at org.apache.james.mime4j.parser.MimeStreamParser.parse(MimeStreamParser.java:179)
at com.kaitenmail.mail.internet.MimeMessage.parse(MimeMessage.java:83)
... 10 more
 2011-07-25 01:49:42 -04:00
Jesse Vincent
0543183b11 Work around a weird NPE in WebDAV sync reported by Jon Blow 2011-07-19 22:43:32 -04:00