Commit Graph

474 Commits

Author SHA1 Message Date
Bao-Long Nguyen-Trong c2ca739293 . Added defensive code against empty self BCC address
This fixed issues 639 & 646
2009-09-25 17:02:50 +00:00
Daniel Applebaum f3312eb064 Eliminate failing Toast. Perhaps it can be restored, if the Toast is
generated in the message handling thread.
2009-09-24 02:09:57 +00:00
Daniel Applebaum b4b1b081a7 Issue 624
Don't bother going to server while creating an ImapMessage from a UID
2009-09-24 01:06:24 +00:00
Bao-Long Nguyen-Trong 75636b697c Display 'Downloading...' instead of 'Loading...' when we are fetching a message from remote store 2009-09-17 17:40:05 +00:00
Daniel Applebaum 08cd19e5a8 svn merge -x -w -c 760 ../issue4-1.X/ .
Improve reliability of message viewing and composing while still using
MessagingController worker queues

svn merge -x -w -c 761 ../issue4-1.X/ .

Put loading a message from the LocalStore into a ThreadPool executor,
like was done previously in MessageView.  Remote loading still goes
through the work queue.
2009-09-17 03:43:02 +00:00
Daniel Applebaum 5d5c65bee3 svn merge -x -w -c 756 ../issue4-1.X/ .
Increase reliability of MessageView when it is paused then resumed
2009-09-16 12:31:52 +00:00
Bao-Long Nguyen-Trong d61c7a192c Removed some logging (too verbose) 2009-09-15 05:20:12 +00:00
Daniel Applebaum ac6358ec5c svn merge -c 749 ../issue4-1.X .
ImapStore.ImapFolder is not thread-safe, so all access to the remote
folders must be done through the work processing of the
MessagingController.
2009-09-15 04:28:37 +00:00
Bao-Long Nguyen-Trong a4965f042c Fixed issue with encoding of email addresses in the header with non ascii characters. The way were doing it was only compatible with certain email clients (Thunderbird) but not with K-9 itself 2009-09-10 17:33:19 +00:00
Bao-Long Nguyen-Trong 736d330e38 Fixed issue 560: This was happening only when the user has only one account 2009-09-10 17:31:11 +00:00
Bao-Long Nguyen-Trong c11c484718 Fixed issue 261:Commas within diplay names were considered as delimiters
--> Using built in Rfc822Tokenizer
2009-09-08 07:31:02 +00:00
Daniel Applebaum 3ca12e2bb9 Issue 478 2009-09-03 16:13:00 +00:00
Daniel Applebaum e9a17ada17 Prevent crashes if user attempts to sort while folder is loading. 2009-08-29 23:08:07 +00:00
Daniel Applebaum 44a52d54a7 Don't crash when no suitable intent found 2009-08-29 22:55:14 +00:00
Daniel Applebaum d50a16c6b4 Issue 530 2009-08-29 22:40:52 +00:00
Daniel Applebaum 65d7f2180a Issue 505 2009-08-29 22:17:49 +00:00
Daniel Applebaum 8785762986 Issue 575
Partially the patch supplied by mpredosin.

Partially restoration of other lost code.
2009-08-29 22:11:13 +00:00
Daniel Applebaum 033632b3ba Issue 503
Restore lost confirmation dialog.
2009-08-29 21:49:19 +00:00
Daniel Applebaum 280ed0dadd Issue 530
This new method will be useful later.
2009-07-24 05:12:17 +00:00
Daniel Applebaum f6c6012e11 Issue 553 2009-07-24 03:55:54 +00:00
Daniel Applebaum f1232a119a Addresses mpredosin's comments on r420 2009-07-24 03:48:49 +00:00
Jesse Vincent 16a31428b5 patch from typester to fix UTF8 headers (such as subject) Resolves issue 534 2009-07-02 05:49:09 +00:00
Bao-Long Nguyen-Trong 6c820c9f75 Removed image/gif from exclusion list so that the images can be viewed and save to SD card 2009-07-02 00:27:17 +00:00
Bao-Long Nguyen-Trong a912f7aed5 Cleaned up message loading threading solving issues 249 and 524 2009-07-01 21:31:51 +00:00
Bao-Long Nguyen-Trong 2521e032a7 Fixed issue 522 and some minor navigation issue 2009-06-26 18:15:41 +00:00
Bao-Long Nguyen-Trong c1ec077720 Added comment to document why we override MimeMessage.setRecipients() 2009-06-26 07:03:25 +00:00
Bao-Long Nguyen-Trong 6f8c83e8e3 Restored LocalMessage.setRecipients() and added checks for null and empty address list that allow to unset a recipient list 2009-06-26 06:55:32 +00:00
Bao-Long Nguyen-Trong 99562b8e01 Fixed issue 499 by removing LocalMessage.setRecipients() method to use the super implementation instead.
Anyone knows why was this method overridden in the first place?
2009-06-25 20:25:05 +00:00
Bao-Long Nguyen-Trong b572c8e065 Fixed issue 497 2009-06-25 17:05:50 +00:00
Bao-Long Nguyen-Trong 3707e0e666 Fixed issue 519 and more navigation issues 2009-06-24 17:51:41 +00:00
Bao-Long Nguyen-Trong 9bf3c9b45a . Fixed navigation issue when going back from message 2009-06-23 16:48:08 +00:00
Bao-Long Nguyen-Trong e6132286a0 FIxed issue 501 2009-06-23 14:57:16 +00:00
Bao-Long Nguyen-Trong 13cc3899d6 . Fixed issue 504: Added feedback (spinning progress on top right) when checking email in message list
. Added error message toast when checking email fails in message list
2009-06-21 17:20:37 +00:00
Bao-Long Nguyen-Trong 47a8537f08 . Clicking on the new mail notification gets you to the default folder if any else to the folder list 2009-06-20 04:06:44 +00:00
Jesse Vincent 2cb5bdebb3 Set the MessageId header, rather than Adding it when restoring from the local store. Hopefully, this will fix issue 498 2009-06-18 14:54:06 +00:00
Bao-Long Nguyen-Trong 98fe0cc25f Fixed issue 476
TODO: Add confirm dialog
2009-06-16 15:05:11 +00:00
Bao-Long Nguyen-Trong 3ea149bd37 Fixed issue 496
Note: No putting 'Account Settints' and 'Accounts' menu option on MessageList as it does not belong there
TODO: Add more menu options: Mark All As Read, Folder Settings, etc...
2009-06-16 13:58:27 +00:00
Bao-Long Nguyen-Trong 33b1d1b04f Fixed issue 496
Note: No putting 'Account Settints' and 'Accounts' menu option on MessageList as it does not belong there
TODO: Add more menu options: Mark All As Read, Folder Settings, etc...
2009-06-16 13:55:49 +00:00
Bao-Long Nguyen-Trong c6f6e995f6 . Fixed issue 77 and issue 489: It was a bug in Cc and Reply-To header parsing 2009-06-15 05:04:03 +00:00
Bao-Long Nguyen-Trong 9dfe3d8f7b Fixed issue 126
+ display both date and time on old emails
2009-06-14 14:03:30 +00:00
Daniel Applebaum 339c8e247b Restore case-insensitive sort, but fall back on case sensitive, just
in case the case-insensitive version returns that the two folders are
equal during the insensitive comparison.
2009-06-09 04:01:04 +00:00
Daniel Applebaum 770032d960 Issue 481
When in MessageList, Check mail should only sync the displayed folder.
2009-06-09 03:23:07 +00:00
Daniel Applebaum 10b9b0a05b Issue 117
Issue 30

Provide support for multiple identities.  Identities can be managed in
the Account Settings.  While composing a message, an identity can be
chosen for sending.  Identity information and signature edits are
saved in a header field, so that they survive being synced to the
server and back.

Provide support for editing the quoted text, either for replies or
forwards.  The quoted text is immediately editable, in a separate
editor from the main body.  When saved in a draft, the two are
contatenated, but the length of the main body is saved with the
identity information, and is used to split the two parts again, when
opening the draft.
2009-06-09 03:11:35 +00:00
Daniel Applebaum 8e52a4efed Fix for my comment on r581 2009-06-09 02:10:49 +00:00
Bao-Long Nguyen-Trong b7a846492a Minor performance optimization 2009-06-08 00:41:29 +00:00
Bao-Long Nguyen-Trong 84d7e0081b . Fixed 'Compose' and 'Accounts' menu options 2009-06-07 23:43:42 +00:00
Bao-Long Nguyen-Trong b20649f2ad Added 'add to contact' feature when one clicks on the from address in message view (code taken from AOSP) 2009-06-06 15:55:26 +00:00
Bao-Long Nguyen-Trong 2a7c2fcfb2 Removed some commented out code no longuer needed 2009-06-06 15:50:06 +00:00
Bao-Long Nguyen-Trong f6b4cbc43e . Fixed sdk 1.5 build and made it the default one
. Imported JARs for classes not exposed in teh sdk anymore
  . Imported src code from Android core for for classes not exposed in the sdk anymore
  . Updated MessageView implementation of UrlInterceptHandler modified in sdk 1.5 (pls review)
2009-06-06 15:46:17 +00:00
Bao-Long Nguyen-Trong 5e28b65c76 . Choosing '-NONE-' as default folder, was opening the MessageList of the '-NONE-' folder
--> It now opens, the FolderList
TODO: Externalize the '-NONE-' string
2009-06-06 15:42:33 +00:00
Jesse Vincent a7d316ecdd Fix for Issue 328 and 332
Contributed by: Ludovic LANGE / ludovic.lange.android
2009-06-01 01:55:39 +00:00
Jesse Vincent 7d47328b2e Bring MIME4J current to match AOSP upstream as of 9e5757b5316f88d252b5d80fab1e3964ce19bbdf - Thanks to Ludovic LANGE / ludovic.lange.android 2009-06-01 01:53:13 +00:00
Jesse Vincent 909f677f91 r62972@17h: jesse | 2009-05-07 10:49:32 -0400
First stab at a folderlist that doesn't know or care about messages
r62973@17h:  jesse | 2009-05-07 10:50:11 -0400
A very broken first stab at a message list that only knows about one folder.
r62974@17h:  jesse | 2009-05-07 10:50:44 -0400
When you go from an account list to an individual account, open a folderlist, not an fml
r62975@17h:  jesse | 2009-05-07 10:51:24 -0400
Update Welcome activity to open an ml instead of an fml
r62976@17h:  jesse | 2009-05-07 10:51:59 -0400
When setting up accounts is over, open an fl instead of an fml
r62977@17h:  jesse | 2009-05-07 10:52:51 -0400
Update MessageView to use folderinfoholders and messageinfoholders from the 'correct' classes.
r62978@17h:  jesse | 2009-05-07 10:59:07 -0400
MailService now notifies the fl instead of the fml. Not sure if it should also notify the ml. - will require testing
r62979@17h:  jesse | 2009-05-07 11:01:09 -0400
Switch MessagingController's notifications from notifying the FML to notifying an ML
r62980@17h:  jesse | 2009-05-07 11:25:22 -0400
Update AndroidManifest to know about the new world order
r62981@17h:  jesse | 2009-05-07 11:26:11 -0400
Try to follow the android sdk docs for intent creation
r62982@17h:  jesse | 2009-05-07 11:28:30 -0400
reset MessageList for another try at the conversion
r62983@17h:  jesse | 2009-05-07 11:47:33 -0400
This version doesn't crash and has a working 'folder' layer. now to clean up the message list layer
r62984@17h:  jesse | 2009-05-07 15:18:04 -0400
 move step 1
r62985@17h:  jesse | 2009-05-07 15:18:37 -0400
move step 1
r62986@17h:  jesse | 2009-05-07 15:22:47 -0400
rename step 1
r62987@17h:  jesse | 2009-05-07 17:38:02 -0400
 checkpoint to move
r62988@17h:  jesse | 2009-05-07 17:40:01 -0400
checkpointing a state with a working folder list and a message list that doesn't explode
r62989@17h:  jesse | 2009-05-07 17:40:26 -0400
Remove debugging cruft from Welcome
r62990@17h:  jesse | 2009-05-07 22:00:12 -0400
Basic functionality works.
r62991@17h:  jesse | 2009-05-08 04:19:52 -0400
added a tool to build a K-9 "Beta" 
r62992@17h:  jesse | 2009-05-08 04:20:03 -0400
remove a disused file
r62993@17h:  jesse | 2009-05-09 06:07:02 -0400
upgrading build infrastructure for the 1.5 sdk
r62994@17h:  jesse | 2009-05-09 06:22:02 -0400
further refine onOpenMessage, removing more folder assumptions 
r62995@17h:  jesse | 2009-05-09 20:07:20 -0400
Make the Welcome activity open the autoexpandfolder rather than INBOX
r62996@17h:  jesse | 2009-05-09 20:14:10 -0400
MessageList now stores the Folder name it was working with across pause-reload
r62997@17h:  jesse | 2009-05-09 20:14:26 -0400
Removing dead code from FolderList
r63060@17h:  jesse | 2009-05-10 00:07:33 -0400
Replace the old message list refreshing code which cleared and rebuilt the list from scratch with code which updates or deletes existing messages.
Add "go back to folder list" code
r63061@17h:  jesse | 2009-05-10 00:07:50 -0400
fix message list menus for new world order
r63062@17h:  jesse | 2009-05-10 00:08:11 -0400
Remove message list options from folder list menus
r63063@17h:  jesse | 2009-05-10 00:10:02 -0400
remove more message list options from the folder list
r63064@17h:  jesse | 2009-05-10 00:10:19 -0400
fix build.xml for the new android world order
r63065@17h:  jesse | 2009-05-10 00:39:23 -0400
reformatted in advance of bug tracing
r63066@17h:  jesse | 2009-05-10 05:53:28 -0400
fix our 'close' behavior to not leave extra activities around
clean up more vestigal code
r63067@17h:  jesse | 2009-05-10 18:44:25 -0400
Improve "back button / accounts" workflow from FolderList -> AccountList
r63068@17h:  jesse | 2009-05-10 19:11:47 -0400
* Add required code for the 'k9beta' build
r63069@17h:  jesse | 2009-05-10 19:12:05 -0400
Make the folder list white backgrounded.
r63070@17h:  jesse | 2009-05-10 19:12:26 -0400
* Include our required libraries in build.xml 
r63071@17h:  jesse | 2009-05-10 19:13:07 -0400
Added directories for our built code and our generated code
r63072@17h:  jesse | 2009-05-10 19:13:36 -0400
Added a "back" button image
r63073@17h:  jesse | 2009-05-10 20:13:50 -0400
Switch next/prev buttons to triangles for I18N and eventual "more easy-to-hit buttons" win
r63074@17h:  jesse | 2009-05-10 20:17:18 -0400
Tidy Accounts.java for some perf hacking.
r63081@17h:  jesse | 2009-05-10 22:13:33 -0400
First pass reformatting of the MessagingController
r63082@17h:  jesse | 2009-05-10 23:50:28 -0400
MessageList now correctly updates when a background sync happens
r63083@17h:  jesse | 2009-05-10 23:50:53 -0400
Tidying FolderList
r63084@17h:  jesse | 2009-05-10 23:51:09 -0400
tidy
r63085@17h:  jesse | 2009-05-10 23:51:27 -0400
tidy
r63086@17h:  jesse | 2009-05-11 00:17:06 -0400
Properly update unread counts in the FolderList after sync

r63087@17h:  jesse | 2009-05-11 01:38:14 -0400
Minor refactoring for readability. replace a boolean with a constant.
r63090@17h:  jesse | 2009-05-11 02:58:31 -0400
 now that the foreground of message lists is light, we don't need the light messagebox
r63091@17h:  jesse | 2009-05-11 17:15:02 -0400
Added a string for "back to folder list"
r63092@17h:  jesse | 2009-05-11 17:15:24 -0400
Added a message list header with a back button
r63093@17h:  jesse | 2009-05-11 17:15:54 -0400
Remove the "folder list" button from the options menu. no sense duplicating it
r63094@17h:  jesse | 2009-05-11 17:17:06 -0400
Refactored views, adding our replacement scrollable header 
r63184@17h:  jesse | 2009-05-12 07:07:15 -0400
fix weird bug where message lists could show a header element for a child
r63185@17h:  jesse | 2009-05-12 07:08:12 -0400
Add new-style headers to folder lists. reimplement "get folder by name" to not use a bloody for loop
r63211@17h:  jesse | 2009-05-12 18:37:48 -0400
Restore the former glory of the "load more messages"  widget.  it still needs an overhaul
r63296@17h:  jesse | 2009-05-12 23:23:21 -0400
Get the indeterminate progress bar to show up again when you click "get more messages"
r63297@17h:  jesse | 2009-05-13 02:40:39 -0400
Fixed off-by-one errors in click and keybindings for messagelist
r63298@17h:  jesse | 2009-05-13 06:04:01 -0400
Put the folder title in the name of the folderSettings popup
r63299@17h:  jesse | 2009-05-13 06:04:49 -0400
Reformatting. Removing debug logging
r63300@17h:  jesse | 2009-05-13 06:05:32 -0400
Fixing "wrong item selected" bugs in the FolderList 
r63328@17h:  jesse | 2009-05-13 13:20:00 -0400
Update MessageView for 1.5
r63329@17h:  jesse | 2009-05-13 13:50:29 -0400
A couple fixes to "picking the right item"
Titles on the message context menu
r63330@17h:  jesse | 2009-05-13 13:58:37 -0400
Added an "open" context menu item to the folder list
r63347@17h:  jesse | 2009-05-13 18:00:02 -0400
Try to get folderlists to sort in a stable way, so they jump around less in the ui
r63349@17h:  jesse | 2009-05-13 20:37:19 -0400
Switch to using non-message-passing based notifications for redisplay of message lists, cut down redisplay frequency to not overload the display
r63432@17h:  jesse | 2009-05-16 13:38:49 -0400
Android 1.5 no longer gives us apache.commons.codec by default and apache.commons.logging by default. Import them so we have em.
There's probably something smarter to do here.
r63438@17h:  jesse | 2009-05-16 14:12:06 -0400
removed dead code
r63439@17h:  jesse | 2009-05-16 14:30:57 -0400
Minor tidy
r63440@17h:  jesse | 2009-05-16 14:39:34 -0400
First pass implementation making MessageList streamy for faster startup
r63441@17h:  jesse | 2009-05-16 21:57:41 -0400
There's no reason for the FolderList to list local messages
r63442@17h:  jesse | 2009-05-16 21:58:57 -0400
Switch to actually refreshing the message list after each item is loaded
r63450@17h:  jesse | 2009-05-16 22:34:18 -0400
Default to pulling items out of the LocalStore by date, descending. (since that's the uneditable default ordering)
This makes our messages come out of the store in the order the user should see them
r63451@17h:  jesse | 2009-05-16 22:34:44 -0400
Set some new defaults for the FolderList
r63452@17h:  jesse | 2009-05-16 22:35:43 -0400
set some new message list item defaults
r63456@17h:  jesse | 2009-05-17 12:56:10 -0400
It's not clear that Pop and WebDav actually set us an InternalDate. I'd rather use that so that spam doesn't topsort. But I also want this to _work_
r63457@17h:  jesse | 2009-05-17 12:56:47 -0400
actually check to make sure we have a message to remove before removing it.
r63458@17h:  jesse | 2009-05-17 13:10:07 -0400
Flip "security type" to before the port number, since changing security type is the thing more users are likely to know/care about and resets port number
r63469@17h:  jesse | 2009-05-17 18:42:39 -0400
Provisional fix for "see the FoldeRList twice" bug
r63471@17h:  jesse | 2009-05-17 20:47:41 -0400
Remove title bar from the message view
r63544@17h:  jesse | 2009-05-20 23:53:38 -0400
folderlist tidying before i dig into the jumpy ordering bug
r63545@17h:  jesse | 2009-05-20 23:56:00 -0400
Killing dead variables
r63546@17h:  jesse | 2009-05-21 00:58:36 -0400
make the whole title section clicky
r63556@17h:  jesse | 2009-05-21 01:48:13 -0400
Fix where we go when someone deletes a message 
r63558@17h:  jesse | 2009-05-21 22:44:46 -0400
Working toward switchable themes
r63563@17h:  jesse | 2009-05-21 23:53:09 -0400
Make the MessageList's colors actually just inherit from the theme, rather than hardcoding black

r63567@17h:  jesse | 2009-05-22 10:14:13 -0400
Kill a now-redundant comment
r63571@17h:  jesse | 2009-05-22 19:43:30 -0400
further theme-independence work
r63572@17h:  jesse | 2009-05-22 19:55:23 -0400
gete -> get (typo fix)
r63573@17h:  jesse | 2009-05-22 22:48:49 -0400
First cut of a global prefs system as well as a theme preference. not that it works yet
r63577@17h:  jesse | 2009-05-24 14:49:52 -0400
Once a user has actually put in valid user credentials, start syncing mail and folders in the background instantly.
This gives us a much better "new startup" experience
r63578@17h:  jesse | 2009-05-24 14:55:00 -0400
MessageList doesn't need FolderUpdateWorker
r63579@17h:  jesse | 2009-05-24 17:57:15 -0400
Fix "get message by uid"
Switch to showing messages 10 by 10, rather than 1 by 1 for huge loadtime performance improvements
r63587@17h:  jesse | 2009-05-24 19:19:56 -0400
Cut down LocalMessage creation to not generate a MessageId or date formatter.
r63589@17h:  jesse | 2009-05-24 22:22:32 -0400
Switch to null-escaping email address boundaries, rather than a VERY expensive URL-encoding
r63590@17h:  jesse | 2009-05-24 22:23:21 -0400
Clean up our "auto-refresh the list when adding messages after a sync"
r63593@17h:  jesse | 2009-05-24 22:53:45 -0400
replace isDateToday with a "rolling 18 hour window" variant that's more likely to give the user a useful answer and is 30x faster.
r63595@17h:  jesse | 2009-05-24 23:54:14 -0400
When instantiating messges from the LocalStore, there's no need to clear headers before setting them, nor is there a need to set a generated message id
r63596@17h:  jesse | 2009-05-24 23:54:39 -0400
make an overridable setGeneratedMessageId
r63597@17h:  jesse | 2009-05-24 23:54:55 -0400
Remove new lies from comments
r63598@17h:  jesse | 2009-05-24 23:55:35 -0400
Replace insanely expensive message header "name" part quoting with something consistent and cheap that does its work on the way INTO the database
r63605@17h:  jesse | 2009-05-25 17:28:24 -0400
bring back the 1.1 sdk build.xml
r63606@17h:  jesse | 2009-05-25 22:32:11 -0400
Actually enable switchable themese and compilation on 1.1
r63692@17h:  jesse | 2009-05-29 23:55:17 -0400
Switch back to having titles for folder and message lists.
Restore auto-open-folder functionality
r63694@17h:  jesse | 2009-05-30 18:50:39 -0400
Remove several off-by-one errors introduced by yesterday's return to android titlebars
r63696@17h:  jesse | 2009-05-30 23:45:03 -0400
use convertView properly for performance and memory imrpovement in FolderList and MessageList
r63698@17h:  jesse | 2009-05-31 19:42:59 -0400
Switch to using background shading to indicate "not yet fetched"
r63701@17h:  jesse | 2009-05-31 21:28:47 -0400
Remving code we don't actually need these bits of apache commons on 1.1
2009-06-01 01:35:05 +00:00
Bao-Long Nguyen-Trong 93b95b85b2 Fixed NullPointerException when trying to send message with to text body (attachment only for example). The message would end up being stuck in the outbox. 2009-05-22 05:42:16 +00:00
Bao-Long Nguyen-Trong f64de34d2f Made MAX_SMALL_MESSAGE_SIZE match Store.FETCH_BODY_SANE_SUGGESTED_SIZE for consistency. See r623 2009-05-21 20:02:44 +00:00
Bao-Long Nguyen-Trong 49426f3107 Removed some logging that should not have made it to SVN 2009-05-21 18:53:27 +00:00
Bao-Long Nguyen-Trong f4d7b54fb6 Bumped back FETCH_BODY_SANE_SUGGESTED_SIZE to 50K 2009-05-21 18:49:39 +00:00
Bao-Long Nguyen-Trong 73ded7170b . Greying out partially downloaded messages
--> All messages that will require download in order to be read are now "greyed" out
2009-05-20 04:46:55 +00:00
Bao-Long Nguyen-Trong bae5fba355 Better HTMLization of plain text emails using <pre>: spaces / identation are now properly displayed 2009-05-20 04:44:45 +00:00
Bao-Long Nguyen-Trong d8724784dd . Minor memory usage optimization of how we HTMLize plain text emails 2009-05-20 04:39:51 +00:00
Bao-Long Nguyen-Trong 23797b62ee . Fixed issue 423:
. HTMLized version of plain text email is not loaded up as a MIME part of the message anymore. We use a custom seperate variable in the text body class.
2009-05-20 04:36:20 +00:00
Bao-Long Nguyen-Trong 435e2c3532 Fixed issue 404:
. Free up memory as we go in MessagingController.synchronizeMailboxSynchronous()
  . IMAP: We only do a partial fetch of the text body of large messages during background sync. This allow for faster syncs and avoid expensive parsing that lead to OutOfMemoryError
2009-05-20 04:27:51 +00:00
Daniel Applebaum 130e00d72a Reflect Seen and Flag states while messages are not fully downloaded 2009-05-18 04:40:24 +00:00
Bao-Long Nguyen-Trong d222a48a18 Added option setting/preference to specify the signature location. This fixed issue 74 2009-05-17 06:02:02 +00:00
Bao-Long Nguyen-Trong 42194562c1 Minor optimization to avoid the OutOfMemoryError we have been getting 2009-05-17 05:59:28 +00:00
Daniel Applebaum 8e51d6cf14 Issue 418
When no accounts are set for automatic sync, the MailService is
stopped.  When the MailService is stopped, the Android platform is
given greater leeway in killing the entire K9 process in order to free
system resources.
2009-05-14 02:26:23 +00:00
Bao-Long Nguyen-Trong 4a6f2e419b . Fixed bug where always BCC address is added again when editing a draft 2009-05-14 00:09:43 +00:00
Bao-Long Nguyen-Trong 536133daf1 . Fixed issue 419
. Moved signature to the bottom of the message body view so that it is not editable
TODO: Add signature location preference / settings
2009-05-14 00:03:19 +00:00
Bao-Long Nguyen-Trong 724c0aed31 Minor optiomization to help with the OutOfMemoryError pbs we have been getting 2009-05-12 05:31:21 +00:00
Bao-Long Nguyen-Trong 6caccc4ead . Rolled back some code from r505 that are not usefull. The code that really prevents the double message in POP3 is when we set the X_DOWNLOADED_FULL in the POP3 folder class 2009-05-11 23:31:59 +00:00
Bao-Long Nguyen-Trong 5ab77dcd64 Refactored message loading for view
--> Perfomance improvement: the code was doing duplicates calls to the server to set SEEN flag and duplicate access to the db.
2009-05-11 04:39:03 +00:00
Bao-Long Nguyen-Trong 7d98ed60ad Reverted signature formatting code that was not meant to be committed 2009-05-10 13:55:28 +00:00
Bao-Long Nguyen-Trong bb8629abe8 . Potential fix for issue 404: now doing all HTMLization in one pass to minimize the amount of String objects 2009-05-10 07:05:24 +00:00
Bao-Long Nguyen-Trong 5b0dee8cc0 . Large messages are now only retrieved once for POP3 servers that don't support the TOP command 2009-05-10 05:47:26 +00:00
Bao-Long Nguyen-Trong e844f4ab0c Fixed issue 191 2009-05-10 05:39:47 +00:00
Daniel Applebaum 97a4f97b64 Issue 234
Fix POP3 deletes.  Verizon uses - in their POP3 UIDs, and K9 was
assuming that only Local UIDs have -.  Removed that assumption.  Also,
after issuing DELE on POP3 connection, need to also issue a QUIT.  The
delete code in MessagingController now closes the folder after
deleting a message, which will slow down IMAP deletes, but also
conserve connections, so is probably a net benefit.
2009-05-09 15:22:36 +00:00
Jesse Vincent 718e27dab9 WebDavStore updates to fix authentication issues - based on design and counselling from ismarc31 2009-05-07 03:17:26 +00:00
Daniel Applebaum 96c98e3070 Reformat executeSimpleCommand 2009-05-06 00:16:47 +00:00
Daniel Applebaum 27e0ec1b80 Decrement mMessageCount when an untagged EXPUNGE is received 2009-05-06 00:12:30 +00:00
Bao-Long Nguyen-Trong 5be7ee8517 . Added Z as keyboard shortcut to toggle read flag
. Removed duplicate adapter notification and hence data reload
2009-05-05 16:26:04 +00:00
Jesse Vincent 1d7fdbeb92 expose download status of messages. slightly grey out messages that haven't yet been downloaded fully 2009-05-05 04:51:11 +00:00
Daniel Applebaum aac64b03a5 Make sure not to lose an untagged EXISTS, even if it came during a
command that we didn't handle properly.
2009-05-05 04:03:56 +00:00
Jesse Vincent 4ed1c82855 Proposed fix for "unreopenable" folders bug 2009-05-05 03:15:07 +00:00
Jesse Vincent d20fbc09fc Stop using a custom WebViewClient - it caused keybinding and url-opening bugs.
If anything the new version feels a bit faster
2009-05-05 02:13:02 +00:00
Jesse Vincent 7dcd346e0f MessageView shouldn't swallow keybindings 2009-05-05 01:56:41 +00:00
Daniel Applebaum 651642faeb Automatically re-synchronize the IMAP protocol. Previously, losses of
synchronization could happen if an Exception was thrown while parsing
an untagged response without using executeSimpleCommand.  For
instance, while doing a fetch.  Once synchronization was lost, later
commands would fail in surprising ways.  One manifestation of such
failures was spontaneously emptying of folders when search results
were not returned properly.  The new code makes sure to only accept OK
responses with the tag of the command, and discards the untagged
responses from previous command.
2009-05-05 00:42:05 +00:00
Jesse Vincent 7daf4ef1e6 We don't actually want to clear out the plaintext version of the message. K-9 uses that for replies 2009-05-05 00:29:15 +00:00
Jesse Vincent dec4a6371f Fix auto-open of INBOX per danapple0 2009-05-05 00:24:18 +00:00
Jesse Vincent 323c294250 Move our linkification and htmlification of mesages from on-display to on-sync.
There's no need to defer this work until the user is waiting for it
2009-05-03 20:52:32 +00:00
Jesse Vincent f2fa5ae2f6 FolderMessageList performance improvement from debauchedsloth++ (Partial application of his patch from Issue 285) 2009-05-03 04:39:13 +00:00
Jesse Vincent 2dda469255 MessageView performance improvlements by debauchedsloth++ (This includes all changes from Issue 285's MessageView.java patch) 2009-05-03 04:36:33 +00:00
Jesse Vincent 4b444b2bcf don't try to recreate the indexes on every db update as it will surely fail 2009-05-03 04:22:34 +00:00
Jesse Vincent 46eef4589d Fixed issue 160 - Applied a patch to enable K9 to respond to addtional SEND intents 2009-05-02 22:30:08 +00:00
Jesse Vincent ab82b10918 Add a few indexes to the message and folder lists 2009-05-02 22:14:45 +00:00
Jesse Vincent d185adfc27 Fix up text/plain message view to escape < and > and & when converting plain text to html for display 2009-05-02 22:06:42 +00:00
Daniel Applebaum 0ffe1621a2 Issue 394
Issue 252

394: Replace code change lost with move of DAmail MailService.java to
K-9.  Eliminate the stopSelfs.  Without the stopSelfs, the Service
remains active and the Android platform is far less likely to kill the
process, although not absolutely forbidden from doing so.  Better will
be to implement the full BroadcastReceiver methodology referred to in
Issue 394, which would allow replacing the stopSelfs, which would make
K-9 a better good citizen.

252: Fix logic for raising and canceling notifications based on number
of new unread messages and total unread messages.
2009-05-02 14:49:29 +00:00
Daniel Applebaum b603d899db Issue 395
Fix database connection leak
2009-05-02 00:37:22 +00:00
Daniel Applebaum 509fa8c8d3 Issue 386 2009-04-28 12:23:57 +00:00
Daniel Applebaum d1661ee1f5 Reset mMessageCount before executing SELECT. Only handle untagged
responses to SELECT once.
2009-04-21 05:34:57 +00:00
Daniel Applebaum f0f07c36de Issue 63
Issue 201
Issue 224
Issue 342

Handle untagged EXISTS messages at any time.  Should increase
synchronization speed and accuracy.

Handle IMAP servers that send a NIL where a literal is normally.
Avoids failure to sync when folder contains certain messages.

Throw Exception if folder message count is less than 0, avoiding
accidentally emptying a folder.
2009-04-21 04:22:02 +00:00
Jesse Vincent b0a295e1a3 Re-add the code I removed twice, now that dan explained what it works around 2009-04-20 06:27:51 +00:00
Jesse Vincent d0d6eb5442 Set the landscape-mode text colors to something more reasonable (and really "default") in the landscape xml layout templates
Re-remove the explicit subject color hardcoding in FolderMessageList.java
2009-04-20 00:58:50 +00:00
Daniel Applebaum c00eb30524 Restore text color handling 2009-04-19 14:59:18 +00:00
Jesse Vincent 64eda5106c Switch to a light visual theme more in keeping with every other mail client on the planet.
Start to improve padding/spacing/layout
2009-04-19 09:10:32 +00:00
Jesse Vincent e24b3429dc Allow the user to continue setup, even if their server settings don't work 2009-04-19 07:20:38 +00:00
Daniel Applebaum 47f5230bed Issue 248
Issue 192

Do not remove markers for deleted messages, even if the corresponding
remote message is not returned by the remote store.  The remote
message may not be returned simply because the query did not encompass
it on this run.  If the account's delete policy is set to "Do not
delete from server", or the delete hasn't succeeded before a folder
refresh, a message for which the deleted marker has been removed can
errorneously reappear.

This will lead to the local store eventually having a large number of
deleted message markers.  In the long term, we'll need a way to manage
and possibly automatically remove them.
2009-04-17 03:22:45 +00:00
Daniel Applebaum 4ad4216de5 Fix problems connecting to POP3 servers which lack the CAPA command. 2009-04-15 13:05:29 +00:00
Daniel Applebaum 03dd89b3f9 Get rid of @Overrides that cause compilation failures with Java 1.5 2009-04-12 01:51:54 +00:00
Daniel Applebaum aa4a92a541 Application of patch submitted by cnehren for Issue 356, with
generalization.
2009-04-11 15:24:22 +00:00
Daniel Applebaum 932adf5ed2 Issue 143
Merged from branch issue143 @ revision 426:

Complete replacement for SharedPreferences.  Uses SQLite database
stored in application's databases folder.

Will load from legacy preferences if DB-backed preferences are empty.

Editor conforms to atomic commit contract.
2009-04-11 14:33:54 +00:00
Daniel Applebaum 5711abdee5 Issue 234 Issue 366 Issue 329
Hardening of POP3 and SMTP communication:

SMTP: Decrement failure counter when no possible message send
occurred.  This way, K-9 will only stop attempting to send messages
for which a possible successful send occurred, but K-9 could not
detect.  Any message that is known to have completely failed to send
will be reattempted indefinitely.

POP3: Some reworking of Exception handling.  Also, if it is not
possible to get a "message number" for the UID of the message that is
being deleted, conclude that the message has already been deleted on
the server.  Mark this as a permanent error, so that it gets removed
from the pending actions queue.

MessagingController: Look for the permanentFailure flag on the
MessagingException, and if a pending action raised a permanent
failure, remove the pending action from the queue so that it will not
be re-attempted nor block later requests.
2009-04-11 02:11:17 +00:00
Daniel Applebaum 388969d76c Automatically fix folder selections. 2009-04-11 01:26:44 +00:00
Daniel Applebaum bf98b5c2af Issue 366
Significant hardening of the email sending process.

A given message in the Outbox is only attempted to be sent 5 times.
Once the threshold is reached, the message is flagged.  asses through
the Outbox skip flagged messages.  The message can be tried again by
manually unflagging.  When any messages are flagged during a pass
through the Outbox, K-9 raises a notification with a fast flashing red
LED, alerting the user to the failure to send.  A note is also placed
in the K9mail-errors.

The read timeout on SMTP connections has been changed to 300000ms (5
minutes)

The send attempt counter is kept in memory, not stored with the
message, so a phone or application restart will clear the counters,
but not the flagged state.  As the intent of this revision is to avoid
runaway message sending, this is deemed to be acceptable for now.

The moving of messages from the Outbox to the Sent folder has been
changed to an atomic move.

Extra error checking has been added to the SMTP communication code.

The flashing LED may be excessive.
2009-04-09 17:48:05 +00:00
Daniel Applebaum e92ac38052 Fix for empty real folder name issue identified in Comment 10 of Issue
366

Affected POP3 and WebDAV accounts
2009-04-09 15:05:24 +00:00
Daniel Applebaum ee4ac07788 Issue 364
Provide preference for which folder is automatically expanded when
entering the Folder/Message list.

Can be set to -NONE-, so that no folder is automatically expanded.

Defaults to Inbox, which is like the default behavior of the core
Android Email.

Fails to move the automatically opened folder to the top of the
screen.  This needs more work.

The already selected folder should be highlighted (or otherwise
indicated) in the ChooseFolder Activity.  This needs more work.
2009-04-08 18:14:52 +00:00
Daniel Applebaum f307bfc1eb Issue 235
Added dialog box for confirmation for "Mark all messages as read"
2009-04-06 01:37:35 +00:00
Matthew Brace 1b5fdb99d9 Fix for authentication issue describe in issue 359. 2009-04-02 01:52:00 +00:00
Daniel Applebaum b210762ac7 Revert unintentional change 2009-04-01 03:38:55 +00:00
Daniel Applebaum 8ca1830afb Add "Check mail" menu items:
Accounts: Option menu->Check mail = check mail in all
   folders of all accounts
Accounts: Context (long-press on account) menu->Check mail = check mail
   in all folders of this account

Folder/Message List: Option menu->Check mail = check mail in all
   folders of this account
Folder/Message List: Contet (long-press on folder) menu->Check mail = check mail in this
   folder*

*All "Check mail" options, except for the long-press on an individual
folder, respect the normal synchronization class settings.

Eliminate all Refresh menu items.

Add progress indicators to Accounts activity.  Indeterminite progress
indicator while email checking is in progress.  Determinite progress
indicator while fetching unread counts.
2009-04-01 03:25:16 +00:00
Matthew Brace f699361390 Prevent multiple appendages of the email signature (Issue 66). 2009-03-26 06:06:04 +00:00
Robert Jacob b0cf11d64c IMAP "system" folders can be selected with pick list (Patch for Issue 182) 2009-03-24 18:20:16 +00:00
Daniel Applebaum 9f7a4b05d8 Elminate harmful selection of delete policy on Incoming settings page. 2009-03-12 01:50:06 +00:00
Daniel Applebaum 272bb699c9 Use format, instead of hardcoded concatenation, for formatting
recipient display.  (suggested by dumbfile in Comment 12 of Issue 10)
2009-03-12 01:31:55 +00:00
Daniel Applebaum 49c2708f4c Patch ImapFolders.r389.patch submitted in Comment 3 of Issue 214 by
dumbfile on Feb 28, 2009.

One change of my own, putting the actual folders name outside the
parentheses, and the functional/special name inside the parentheses.
2009-03-12 01:13:26 +00:00
Daniel Applebaum 45227e2708 Delete now uses LocalFolder.moveMessages
Copy now copied body (but attachments might not work right).

Move is now reliable (needed to open the destination folder), and
leaves a placeHolder message behind in the source folder so that
messages are not resynced.
2009-03-07 07:20:15 +00:00
Daniel Applebaum 6d5b158787 Restore ability to delete server-side messages for POP3 and WebDAV 2009-03-05 13:43:05 +00:00
Daniel Applebaum 014691bac9 Fix reverse sorting when in sort-by-date mode. 2009-03-05 08:08:37 +00:00
Daniel Applebaum 7b2a754009 Cleanup of minor issues with r395. r395 and this revision are to
address Issue 2, not Issue 3 as previously stated.
2009-03-05 07:50:53 +00:00
Daniel Applebaum 15e5cb4eaf Provides the ability to move and copy messages between folders. Issue
3.

Each remote Store (IMAP, POP3, WebDAV) can provide indications to the
higher level classes as to whether copy and move are implemented.
Currently, copy and move are only provided by ImapStore.java.  When
the facilities are not available, the user interface suppresses the
menu options.

The available destination folders can be configured using folder
classes.

Copy results in null message bodies in the destination copy of the
message until the next sync.  This is a problem that occurred with
deletes previously, and is likely a fault with the copyMessages method
of LocalStore.java.

Utilizes a modified version of the ChooseFolder.java Activity that
debuachedsloth contributed in a patch attached to Issue 285 on 16 Feb
2008.
2009-03-05 07:32:45 +00:00
Bao-Long Nguyen-Trong db426c44b7 . Applied patch from dumbfile which fixes issue 307 and issue 265 related to date format when running on a device with a non US locale 2009-03-04 19:49:39 +00:00
Daniel Applebaum 73d5e16178 Fix for problem with r386 found by kanisdragon. 2009-03-02 00:47:27 +00:00
Daniel Applebaum 19c93d1816 Issue 10
All messages in all folders that were sent from the email address
associated with the account display the recipient, preceeded by To:,
instead of the sender.
2009-02-28 17:40:39 +00:00
Matthew Brace 91573e19ac Fix for null pointer exception when there is an exception thrown and the caught in processRequest without properly terminating checks (ie, during the recursive calls, resulting in a null data set being returned). 2009-02-26 06:56:30 +00:00
Daniel Applebaum 6f8a243bcc Issue 318
When performing a database upgrade, clear all cached attachments and
attachment thumbnails
2009-02-25 03:35:25 +00:00
Daniel Applebaum 2615d70a1d Issue 321
Add null checks around more uses of mMessage
2009-02-25 02:32:20 +00:00
Daniel Applebaum 2d31b4e52d Issue 179 and Issue 320
Puts quotes around username and password for IMAP authentication.

Also, if authentication fails, closes the connection so that it will
be retried.  Otherwise, there is no way to fix the problem, say, by
changing the password in the Incoming Settings.
2009-02-25 01:50:20 +00:00
Daniel Applebaum 0e9d1f195e Issue 319
Do not reset all folder settings when a database upgrade occurs. (Or
any other event that wipes all of the local folders.
2009-02-24 05:03:28 +00:00
Matthew Brace acea3ab3b5 Pull destination url from OWA login page. Order of priority for destination is: User specified mailbox path, destination form value on OWA login page, "/" character. 2009-02-19 04:35:15 +00:00
Bradley Young 16252e4ad4 Removed @Override flag from compareTo method, since it isn't in the superclass. 2009-02-15 16:30:37 +00:00
Matthew Brace 7e492a0505 Prevent needlessly downloading every message > 5K the first time it's opened (affected POP3 and WebDav) 2009-02-12 22:59:02 +00:00
Daniel Applebaum 0bf5dcf95b Required for r371 2009-02-12 21:49:20 +00:00
Bradley Young 61aba8fa78 Changed host from static to instance. Should help to prevent conflicts with multiple accounts. 2009-02-11 21:07:25 +00:00
Daniel Applebaum ca9d220a52 Issue 262
ConcurrentHashMap seems to serialize as a HashMap.  Not sure why or
how.

This change has re-enabled the saving of the unread counts during an
orientation change, giving somewhat fast response.  If it fails again,
just comment out the block of code.
2009-02-10 04:11:34 +00:00
Daniel Applebaum 3e4843e756 Issue 131
Provide two options for each Account:
Compact (which VACUUMs the accounts and prunes recreatable
attachments)

Clear all data (danger!) (which wipes all messages and attachments in
the account, except placeholder deleted messages)

Displays a Toast when the Compact or Clear is queued, and another
Toast with the shrinkage results.

(Also, a small change to increase probability of seeing messages after
a sync, by setting the needsRefresh on all folders when a sync is done.)
2009-02-10 03:18:42 +00:00
Matthew Brace 8c466c35ba Add proper handling for relative paths from initial login page for WebDav. Provides support for Exchange 2007. 2009-02-09 06:48:57 +00:00
Matthew Brace da46773f74 Fix potential index issues when less than 10 emails are in the folder when fetching messages in WebDavStore. 2009-02-09 01:50:31 +00:00
Daniel Applebaum 7a5b4d27e1 Changed terminology from Thread to Sort. Added sorting on sender,
flag, unread and attachments.

Really, really, needs better icons.
2009-02-07 19:41:33 +00:00
Daniel Applebaum cd386b17b3 Didn't mean to undo Bao-Long's change 2009-02-07 19:36:30 +00:00
Daniel Applebaum c0b3c9dafa Disable restoring unread message counts on Accounts page after
orientation change (onResume) until I figure out the
ClassCastException

Will slow down display of unread message counts, but they will show up
after a slight delay.
2009-02-07 03:11:58 +00:00
Daniel Applebaum 98ff7af644 Just can't believe the prior code was right. Possible fix for Issue 234. 2009-02-06 20:11:36 +00:00
Daniel Applebaum 465172f1c7 Fix threading in Accounts main screen. Move all UI updates to UI
thread.  

Push unread message counting into the background.

Should increase startup performance and reduce black-screens-of-death
that some Market "commentators" report.

Also, updates the per-account unread message count when email account
is finished synchronizing.
2009-02-06 04:28:29 +00:00
Daniel Applebaum 8fd9c4e77c Get rid of suppression logging 2009-02-04 04:56:11 +00:00
Bao-Long Nguyen-Trong c78db1c327 . Automatically open inbox folder when opening an account 2009-02-01 07:22:26 +00:00
Bao-Long Nguyen-Trong 8721b64e66 . Nofifications are not cancelled anymore when viewing account screen 2009-02-01 07:21:30 +00:00
Bao-Long Nguyen-Trong f4c8f88251 . Now displays the number of new messages on the new email notification icon 2009-02-01 07:20:49 +00:00
Bao-Long Nguyen-Trong 41dc1ca8d8 Now display a new email notification per account. Each notification now opens the account (does not go to the Accounts screen anymore)
Note: Notifications are displayed after all accounts are sync'ed but are delayed to be 1sec. apart
TODO: Display notifications at the end of each individual sync
2009-02-01 07:19:08 +00:00
Daniel Applebaum 3dfabbbd0c Provide folder threading support. When threading is on, messages in
folders are sorted first by subject, then by date.  Subject sorting is
case insensitive and disregards leading re:, fw: and fwd: prefixes.

Threading can be toggled via the T hotkey or the option menu.

The icons could use improvement.

Threading state is maintained during a run of K-9, among all
accounts.
2009-02-01 00:08:14 +00:00
Matthew Brace f184350aec Fix for index out of bounds exception (regression) from r330 2009-01-31 22:09:16 +00:00
Daniel Applebaum fe2dfb76d0 Refactor suppression of deleted messages into MessagingController.
Re-enable instant deletes in MessageView

Deleted message suppression should be generalized into a flag cache,
serving Seen, Flagged, and Answered flags, as well.

Copy message to Trash still needs work, so that no duplicates are ever
visible and server-sync is more clean.  This will be especially
important, as the same code will be needed for the future "message
copy/move" facility.
2009-01-29 13:35:43 +00:00
Matthew Brace 0a6bc9bdd4 Changed authentication method. Added support for authentication if the server returns a 401 status code. No longer requires form based authentication. 2009-01-27 05:39:41 +00:00
Daniel Applebaum 1bd3f31b95 Attempt to fix Issue 192; making deleted messages stay deleted. 2009-01-27 03:13:54 +00:00
Matthew Brace de24b6a166 Added support for optional Form Based Authentication login path and user mailbox path in account settings. 2009-01-25 07:37:10 +00:00
Daniel Applebaum 7d5d473563 Fix for Issue 238
Only fixes display of attachment filenames for newly downloaded
messages.  Will not correct display for message already in the
LocalStore.
2009-01-24 19:35:57 +00:00
Daniel Applebaum cf359c95ad Major ergonomic re-work of MessageView controls. Provide options (in
Account settings) for scrolling the navigation buttons with the
message, or keeping the buttons on screen.  Scrolling mode can be
automatically switched based on availability of keyboard. (Issue 197
and Issue 194)

Add ability to flag/unflag message from options menu
2009-01-24 18:58:40 +00:00
Daniel Applebaum b6e9910e00 Needed for r326 Issue 91 2009-01-24 18:54:47 +00:00
Daniel Applebaum e1da49109f Flag "Sent" messages as Seen Issue 91
"Instant" Empty trash
2009-01-24 18:52:58 +00:00
Bradley Young b4ea7f34a4 catch Throwable, rather than MessagingException, to prevent a crash on stray exceptions. 2009-01-23 23:17:21 +00:00
Matthew Brace 483857ed74 A missed hardcoded value. This should resolve most 400 Bad Request issues. It is unknown if this affects the Invalid Verb responses. 2009-01-22 03:53:09 +00:00
Matthew Brace 357418a396 Removed ability to add slashes/url type parameters onto the server. 2009-01-21 05:33:27 +00:00
Matthew Brace 1cda221fa3 Added support for Exchange path. This is not specifying the path for authentication or for the mailbox. This is support for situations like "https://www.myserver.com/owapath" for authentication. 2009-01-21 05:27:22 +00:00
Daniel Applebaum b7ad91b7a5 Eliminate "space" as an alias for Next. I didn't realize it was used
by WebKit for scrolling down, and there are already two other Next
hotkeys
2009-01-19 16:09:06 +00:00
Daniel Applebaum 4f5ed839ff Major ergonomic changes to control buttons in the MessageView
1) Eliminate the top row Next Message and Previous Message

2) In the bottom buttons for portrait mode, replace Reply and Forward
   with Prev and Next
   Justification: if you're going to be replying or forwarding, you're
   about to embark on a lot of typing, anyway.  Having to hit Menu
   isn't an undue burden.

3) Prev goes to the adjacent *older* message, next goes to the
   adjacent *newer* message

4) In the bottom buttons for landscape mode, added Prev and Next as the
   outer buttons

5) Add Account option for hiding the bottom buttons when the keyboard
   is available.

Also, temporarily (hopefully!) reverted the instant delete from the
MessageView because it isn't working right.  The method here is slower
but safer.
2009-01-19 14:54:05 +00:00
Matthew Brace 7f2601df17 Updated regular expression to allow directory path in server field. Some whitespace cleanup (tabs to spaces). 2009-01-19 00:48:20 +00:00
Daniel Applebaum a5de5ceb0e Eliminate use of Android-private APIs for getting user-selected
date/time formats.  With this change, K-9 can run on original master
or cupcake versions for the platform.

This seems like an excessive amount of code.  Perhaps there is a
public API that accomplishes this work.  Alternatively, the code in
MessageView.java and FolderMessageList.java should be consolidated
into a utility class used by both of the classes needing this
functionality.
2009-01-18 16:46:08 +00:00
Daniel Applebaum 0706b7de45 Patch from debauchedsloth for issue 190 that makes the ongoing
notifications duing email send/receive optional.
2009-01-18 16:42:55 +00:00
Daniel Applebaum dc40026b31 Meant to add to revision 313 notes:
Patches were handling uppercase MIME types were submitted by gwillen
in K-9 issue 94 (MimeBodyPart.java and MimeMessage.java)
and
Josh Guilfoyle as part of Android patch 1539 (MimeUtility.java)

Sorry for missing the attribution on the original commit
2009-01-18 16:35:47 +00:00
Daniel Applebaum 2c51862087 Issue 190
Handle uppercase MIME type sent by non-compliant MUAs such as Pine.
2009-01-18 16:31:37 +00:00
Matthew Brace b50a782c1c New DataSet data model for XML parses from HTTP responses. Much less memory used for a negligible hit in processor usage. Some additional whitespace cleanup. 2009-01-18 02:43:15 +00:00
Daniel Applebaum 172adeee22 Add ability to Flag/Unflag messages. Flagged messages are shown with
a red/bold subject.  Can be done in the FolderMessageList using the
hotkey G (toggle) or by long-pressing the message to bring up the
message context menu.  Can be done while viewing an individual message
by using the hotkey G (toggle).  To-do: add a Flag/Unflag option to a
menu in the individual message view.

Add sending the Answered flag to the IMAP server when replying to a
message.  This is currently done as soon as the reply is started.
Perhaps it would be better to wait until the reply is sent, but that
would require keeping additional state with the draft.  Messages to
which the user has replied are indicated with a white arrow next to
the subject.

To-do: In the MessageView, provide visual indication of Flagged and
Answered states.
2009-01-13 05:52:37 +00:00
Daniel Applebaum 5b49112a98 Fix linkification of text/plain messages with URLs starting at index 0
of the body.

Possibly the fix for issue 213 and maybe also issue 55
2009-01-13 03:39:59 +00:00
Daniel Applebaum 65bbc7e68a Improved synchronization timing and WakeLock algorithm. This new
approach should guarantee that the syncing never stalls just because a
single attempt exceeds the (currently 10 minute) WakeLock timeout.  At
the sync frequency, K-9 will wakeup again and refresh the WakeLock for
another go at syncing.  This should make synchronization much more
reliable in the face of slow or unavailable connections, in particular
ones which hit the socket read timeouts.

Also, fixed the audible notifications so that the ringtone selected
is always for one of the accounts with new unread mail.

Developers now have the option to turn on a fast-flashing LED during
synchronization in order to observe whether synchronization is
happening while the handset is apparently asleep.  I think this option
would be aggravating to non-developer users.  See
Email.NOTIFICATION_LED_WHILE_SYNCING


Issue 175
Issue 170
2009-01-11 23:43:32 +00:00
Daniel Applebaum f0867387c8 Eliminated redundant commit of Preferences 2009-01-09 06:13:28 +00:00
Daniel Applebaum 1f9bf1ec50 Issues 199 & 201
No fixes, just extra details in thrown Exceptions to try to track down
problems.
2009-01-09 05:42:59 +00:00
Daniel Applebaum 95c47fcddc Restore ability for FolderMessageList "Refresh" to get a new list of
folders

Automatically clean up deleted messages in Outbox (make deleted
messages destroyed); don't try to send deleted messages, destroy
messages in outbox when deleting.  (Yep, the first and third items are
redundant, but will automatically clean up damaged outboxes)
2009-01-09 05:39:43 +00:00
Daniel Applebaum a81facc6e7 Issue 192
Keep deleteUid in list until confirmation that message has been
deleted from LocalStore
2009-01-09 05:03:55 +00:00
Daniel Applebaum d0a354ead0 Delete needs to know how to use Imap prefix 2009-01-09 05:01:05 +00:00
Matthew Brace 7d5d29e078 Added support for non-Exchange 2003 standard login paths (web scraping for login URL).
Added support for default mailbox path setting if we can't automatically determine what it is.
Fixed a bug exposed by changes relating to a fix for non-relative email paths being returned.
2009-01-08 05:47:10 +00:00
Daniel Applebaum 7954b02da6 Experimental deletedUids list in FolderInfoHolder to avoid race
conditions when using instance delete
2009-01-08 04:42:56 +00:00
Daniel Applebaum 1bc879c30c Eliminate assumption that item 1 will be a String 2009-01-07 06:37:44 +00:00
Daniel Applebaum 2eaa99bb3a Do not delete remote messages during sync. Trust the delete routines
to send the proper delete requests (delete, mark read, nothing).
Otherwise, this code will delete on the server any message deleted on
the handset, no matter option the user selects.
2009-01-07 06:36:46 +00:00
Daniel Applebaum 3a3dc2da43 Instant deletes from FolderMessageList. Faster deletes from
MessageView

Deleting a message in Trash deletes it for real (permanently)

All message operations are allowed on messages in the Outbox.  Special
handling for deleting, so that the message is copied to Trash, then
copied asynchronously to the remote Trash.

Add some more items to the hotkey help
2009-01-07 06:02:04 +00:00
Brock Tice efb2801bab Updated Debug screen to pull version number from the package info.
Fixed "loading more messages" to use the cleaner String.format way of doing things, and changed the corresponding entries in strings.xml.
Deleted the now-unused build_number.xml file.
2009-01-07 05:20:03 +00:00
Brock Tice 0ac17da6cd Added help 'Toasts' to the message and folder message list views. Pressing 'h' brings up a list of shortcut keys. 2009-01-07 04:43:25 +00:00
Brock Tice 7df272d161 Externalized load up to $number more message to strings.xml 2009-01-07 04:20:23 +00:00
Bradley Young 2e4ee5b59f Fix for sending mail; additional logging when there is an invalid (non-http-2xx) response. 2009-01-06 01:31:57 +00:00
Bradley Young 8221094570 self-signed cert support for WebDav. 2009-01-05 00:05:43 +00:00
Daniel Applebaum d9dd06a620 Make folder unread counters work properly with new faster delete and
marking
2009-01-03 14:35:41 +00:00
Bradley Young 73006c65a3 Disabling self-signed certs for webdav (not IMAP); they are currently causing issues. 2009-01-03 10:15:56 +00:00
Bradley Young b2b9d8d624 remove @Override : this causes breakage in jdk 1.5. 2009-01-03 04:55:16 +00:00
Daniel Applebaum 828ceba503 Set to use new folder display and sync class defaults.
Accounts are now set:
Folder display mode = All except 2nd Class
Folder sync mode = Only 1st Class

Only the Inbox is set for:
Folder sync class = 1st Class
All other folders have class set to None for sync and display

Also restored an optimization on opening local folders that I
removed.  It is now optimistic, and in the normal case does not have
to make an explicit existence check
2009-01-03 01:47:24 +00:00