Jesse Vincent
8488b55e09
remove some duplicated code
2010-12-26 03:49:13 +00:00
Jesse Vincent
8c6df94739
remove some temp variables
2010-12-26 03:49:09 +00:00
Jesse Vincent
877427f110
cut down a couple overly verbose conditionals
2010-12-26 03:49:06 +00:00
Jesse Vincent
daf5a9d704
lift emulateShiftHeld to our custom WebView subclass
2010-12-25 22:30:34 +00:00
Jesse Vincent
8e2e4e515f
simplify MessageView's setHeaders
2010-12-25 22:30:31 +00:00
Jesse Vincent
8b52aac135
remove unused imports
2010-12-25 22:30:27 +00:00
Jesse Vincent
76fd8e9939
extract animation code from MessageView
2010-12-25 22:30:22 +00:00
Jesse Vincent
5f9eae1580
Extract MessageWebView specific code into a new class
2010-12-25 22:30:16 +00:00
Jesse Vincent
ea4e0aa61f
remove a bunch of extraneous code and variables
2010-12-25 19:29:02 +00:00
Jesse Vincent
9f24ea2b03
minor code cleanup
2010-12-25 19:28:58 +00:00
Jesse Vincent
91ab617807
rename "hide buttons" to "scroll buttons" because that's what it does
2010-12-25 19:28:54 +00:00
Andrew Chen
dc5616c4b6
Add a space between recipients when doing toString().
2010-12-25 01:36:48 +00:00
Andrew Chen
77c01c65dd
Refactor network data blocking out of the main K9 class and into the MessageView class.
2010-12-25 01:26:47 +00:00
Jesse Vincent
f14c7ecd9b
doc & comment updates from achen.code
2010-12-25 00:27:09 +00:00
Jesse Vincent
c361c0e63c
Extract a method to set up our MessageView WebView
2010-12-25 00:27:05 +00:00
Jesse Vincent
1fae914efb
tiny doc update from achen.code
2010-12-25 00:26:59 +00:00
Jesse Vincent
db7649c9af
move folderlist initialization into an asynctask, so it's not so slow to populate
2010-12-24 22:48:29 +00:00
Jesse Vincent
b99eb47d15
extract folder preference setup to a method, so we can push it onto a thread
2010-12-24 22:48:26 +00:00
Jesse Vincent
4a97f4a1a0
astyle
2010-12-24 22:48:22 +00:00
Jesse Vincent
fa510f2dab
Turns out that UUID generation is expensive. deferring it until first access improves startup performance.
2010-12-24 22:48:19 +00:00
Jesse Vincent
d64d9c460a
Disable webview cache and javascript. (Mail + Javascript == scary)
2010-12-24 22:48:17 +00:00
Jesse Vincent
df96d0fbe0
avoid use of a temp variable
2010-12-24 22:48:14 +00:00
Jesse Vincent
30b7402569
We shouldn't be resetting visible limits every time K-9 is opened, only when the user changes
...
how many messages they want to be synced, otherwise the "fetch more messages" option is session-only, which is really, really wasteful of network. (and "session" is poorly defined, since android manages our lifecycle.)
Additionally, doing this at startup has huge overhead. If this functionality is ever restored, we should make it asynchronous
2010-12-24 22:48:11 +00:00
Jesse Vincent
9878b74379
astyle
2010-12-24 18:55:05 +00:00
Jesse Vincent
c49a856046
Enable Strict Mode when a new "developer mode" is enabled and we're running on 2.3 or newer
2010-12-24 18:55:01 +00:00
Jesse Vincent
0b3dc2840b
Bump us up to android-9 so we can have strict mode for development
2010-12-24 18:54:56 +00:00
Andrew Chen
2806c267c9
Remove unreadable characters from message previews.
2010-12-23 23:16:54 +00:00
Andrew Chen
302339545b
Try using IP address for EHLO if hostname is unavailable. Only use a default hostname if the IP address is unavailable. ref r2958, issue 2750.
2010-12-23 17:43:57 +00:00
Andrew Chen
6c52c8d927
Set a default hostname if we can't get the local hostname. Fixes issue 2750.
2010-12-23 17:15:20 +00:00
Andrew Chen
f5421f32b8
Fix bug where replaceAll result was being discarded.
...
Fix javadoc.
2010-12-22 22:08:15 +00:00
Fiouz
df44a1f89b
Add @Override annotations (1.6) for safer compile-time checks
2010-12-20 21:34:01 +00:00
Fiouz
0abbeb443e
Batch storing of unsynced messages to speed up DB update (chunk size set to 5).
...
Execution code path is modified since it's not longer handling one message at a time when inserting in DB - might require review.
2010-12-19 11:51:54 +00:00
Jesse Vincent
eda76640c0
When mail is sent successfully, cancel the "couldn't send mail"
...
notification
2010-12-19 01:30:11 +00:00
Jesse Vincent
b59eb6c69f
lift lastFailure up so we can reference it in an outer scope
2010-12-19 01:30:07 +00:00
Jesse Vincent
dbe4bea290
Give our "send failed" notification a contant
2010-12-19 01:30:03 +00:00
Fiouz
ab5caba92c
Factor out store locking code in an intermediate DB access layer.
2010-12-18 22:56:40 +00:00
Fiouz
c5f7dbf028
Execute LocalMessage.appendMessage() & LocalMessage.setFlag() in the same transaction for small message storing in order to speed up DB update.
...
This is a per message basis optimization. More improved speed could be attained by batching several messages in the same transaction.
2010-12-18 10:12:52 +00:00
Kris Wong
bb5052f848
Fix possible NPE.
2010-12-17 17:25:27 +00:00
Kris Wong
623217f6d0
Improved fallback authentication methods + ran source formatter.
2010-12-17 14:40:19 +00:00
Jesse Vincent
0778c8ea17
Provisional fix for Issue 2760 in k9mail: New NPE from market. showing up a lot on 3.400
2010-12-16 02:38:54 +00:00
Kris Wong
33f5a42562
Fix usage of 'advanced' exchange settings.
2010-12-15 17:00:54 +00:00
Fiouz
f8f2169643
Don't reference the enclosing type instance when it's not used (memory optimisation)
2010-12-14 19:27:11 +00:00
Fiouz
caabbd735a
Don't reference the enclosing type instance when it's not used (memory optimisation)
2010-12-14 19:27:04 +00:00
Fiouz
0d23157e3b
Don't reference the enclosing type instance when it's not used (memory optimisation)
2010-12-14 19:26:57 +00:00
Fiouz
05a8a31d4a
Don't reference the enclosing type instance when it's not used (memory optimisation)
2010-12-14 19:26:51 +00:00
Fiouz
fb348449c3
Don't reference the enclosing type instance when it's not used (memory optimisation)
2010-12-14 19:26:44 +00:00
Fiouz
63a8197f5a
Don't reference the enclosing type instance when it's not used (memory optimisation)
2010-12-14 19:26:37 +00:00
Fiouz
64b5655d7c
Don't reference the enclosing type instance when it's not used (memory optimisation)
2010-12-14 19:26:31 +00:00
Fiouz
36858f53de
Don't reference the enclosing type instance when it's not used (memory optimisation)
2010-12-14 19:26:25 +00:00
Fiouz
9d01876481
Don't reference the enclosing type instance when it's not used (memory optimisation)
2010-12-14 19:26:18 +00:00
Fiouz
dcbfd332ab
Don't reference the enclosing type instance when it's not used (memory optimisation)
2010-12-14 19:26:09 +00:00
Fiouz
a667a72585
Don't reference the enclosing type instance when it's not used (memory optimisation)
2010-12-14 19:26:02 +00:00
Fiouz
4024ddd384
Don't reference the enclosing type instance when it's not used (memory optimisation)
2010-12-14 19:25:56 +00:00
Kris Wong
2b56464ad9
Fix form based re-authentication when logon cookies had expired.
2010-12-14 18:02:39 +00:00
Jesse Vincent
5e7257492d
small cleanups to messageview code
2010-12-13 01:56:57 +00:00
Jesse Vincent
063bbb904f
Extract SizeFormatter into helpers
2010-12-13 01:02:39 +00:00
Jesse Vincent
23b57b4502
remove a duplicated and divergent size formatter
2010-12-13 01:02:35 +00:00
Jesse Vincent
936b2779d6
fixup onNext was overloaded (due to the flinger) - at least unify the
...
protection level
2010-12-13 01:02:31 +00:00
Jesse Vincent
2451dde1bc
simplify our "should we animate" checks in messageview (also, we now
...
honor the animation preference when using the volume keys to navigate)
2010-12-13 00:37:31 +00:00
Andrew Chen
b0e4d9cdff
Try calculating content preview from HTML part if text part is unsuccessful on appendMessages.
2010-12-13 00:33:00 +00:00
Jesse Vincent
26712ed84a
reshuffle color views into view/
2010-12-13 00:18:00 +00:00
Jesse Vincent
76b6fa696b
Move the ToggleScrollView into the view/ hierarchy
2010-12-13 00:17:54 +00:00
Jesse Vincent
aa2960eb04
move the AccessibleEmailContentActivity into activity/
2010-12-13 00:17:49 +00:00
Jesse Vincent
f97d4289ca
Start moving custom views into the view/ hierarchy
2010-12-13 00:17:44 +00:00
Jesse Vincent
4bb5acb51c
Revert "stop fading the chip if a message is read. we already change text"
...
It's contentious to change, apparently. So, revert until it's a setting
This reverts commit a6060fa66c8ae6001c402b0f3ac3d240b7348b8e.
2010-12-07 01:22:35 +00:00
Marcus Wolschon
f5420ac528
readable thread-name for debugging
...
javadoc
2010-12-06 09:25:23 +00:00
cketti
9f7b447181
POP3: Ignore messages without unique-id when parsing UIDL response
...
Fixes issue 2731
2010-12-01 18:14:12 +00:00
Jesse Vincent
f5eb6e03af
astyle
2010-12-01 06:32:29 +00:00
Jesse Vincent
e44a74c652
Get rid of a whole lot of crazy code that forced repeated attachment
...
downloads with the intent of only having one attachment downloaded at a
time.
2010-12-01 06:04:28 +00:00
Jesse Vincent
35f19abc9f
Improve the "Do what I mean" nature of "Empty trash" - it now syncs the
...
trash folder after deletions to clear out local records of deleted
messages and does a compact operation on the local store.
2010-12-01 06:04:22 +00:00
Jesse Vincent
75ec749ed4
Remove an unused "context" from a private function
2010-12-01 06:04:16 +00:00
Jesse Vincent
02acea3bbf
replying to a message you sent shouldn't end up sending mail only to you
2010-12-01 06:04:12 +00:00
Jesse Vincent
1898ceee71
Remove two retundant variables
2010-12-01 03:08:36 +00:00
Jesse Vincent
f4a54b9ecb
fix a numeric equality bug spotted by intellij
2010-12-01 03:08:09 +00:00
Jesse Vincent
78c900b5fe
remove redundant ;s
2010-12-01 03:07:28 +00:00
Jesse Vincent
75aa644a23
Remove a bunch of stringification inside of string appends (per intellij)
2010-12-01 03:06:50 +00:00
Jesse Vincent
0677bd9e77
Get rid of some redundant casts (Per IntelliJ)
2010-12-01 03:06:12 +00:00
Jesse Vincent
fde438fbfb
Get rid of some unnecessary stringification (Per IntelliJ)
2010-12-01 03:05:40 +00:00
Jesse Vincent
cead5c7060
flip some loops to using java internals instead (per intellij)
2010-12-01 03:04:57 +00:00
Jesse Vincent
5485d0faf1
switch over some for loops to enhanced for loop syntax per intellij
2010-12-01 03:04:07 +00:00
Jesse Vincent
58e6bd388b
finalize some declarations per IntelliJ
2010-12-01 03:03:22 +00:00
Jesse Vincent
c79ea226a5
Remove "throws" declarations that didn't actually get thrown. Remove a
...
couple of try blocks that only caught throws we didn't throw. IntelliJ
optimization.
2010-12-01 03:02:13 +00:00
Jesse Vincent
81f12f0e05
clean up a couple null checks
2010-12-01 03:01:20 +00:00
Jesse Vincent
43d9c0a6d4
Eliminate some redundant assignments
2010-12-01 03:00:36 +00:00
Jesse Vincent
2ecdc22111
simplify static final methods to just be static. (IntelliJ inspection)
2010-12-01 02:59:50 +00:00
Jesse Vincent
1ce9021ecd
Fix pinch-to-zoom. Patch by achen.code. Fixes isue 2720
2010-11-30 01:42:00 +00:00
Jesse Vincent
174a62536e
Resolves Issue 2719: Message List Previews: Read message senders are shown in bold patch from achen.code
2010-11-30 01:04:24 +00:00
Jesse Vincent
f98a2db2ab
stop fading the chip if a message is read. we already change text
...
weight
2010-11-29 03:24:57 +00:00
Jesse Vincent
dbc07d14ee
Revert " http://code.google.com/p/k9mail/issues/detail?id=2682 " until we
...
can make it configurable, per discussion with Marcus
This reverts commit 1436eeefa292f64c8c9aa6ec9fa2daaeafeb93fd.
2010-11-29 02:21:27 +00:00
Jesse Vincent
15bf83bbe4
preliminary implementation of 'quiet time'
2010-11-29 02:21:16 +00:00
Jesse Vincent
fb6dfb3bde
removed a commented-out method to show notifications on changes to
...
system connectivity
2010-11-28 21:48:29 +00:00
Jesse Vincent
2b8f7c0bbc
unify all our beeping, buzzing and flashing codepaths
2010-11-28 21:48:25 +00:00
Jesse Vincent
70922989d3
genericize configureNotification in preparation for code reuse
2010-11-28 21:48:21 +00:00
Jesse Vincent
64667d03dc
extract vibration pattern metadata out ouf MessagingController into
...
notificationsetting
2010-11-28 20:29:14 +00:00
Jesse Vincent
b7f52a834f
isVibrate -> shouldVibrate to match shouldRing
2010-11-28 20:29:09 +00:00
Jesse Vincent
28c126b8a5
extract notification code from actual "action" code
2010-11-28 20:29:05 +00:00
Jesse Vincent
99d5704b82
extract "sending messages" notification into methods
2010-11-28 20:29:02 +00:00
Jesse Vincent
9784d0e943
remove 100loc by replacing a pattern with a method.
2010-11-28 20:28:58 +00:00
Jesse Vincent
fa64f4c3a8
Minor refactoring for readability
2010-11-28 20:28:53 +00:00
Jesse Vincent
b7617a3497
extract "determine what to do with a new message" out of
...
downloadMessages Probably wants a better name
2010-11-28 20:28:50 +00:00
