Andrew Chen
9e74f9ffcf
Merge pull request #88 from andrewgaul/log-throwable
...
Log Throwables instead of concatenating
2011-11-03 06:32:20 -07:00
Andrew Gaul
2599bdcc75
Log Throwable instead of concatenating
2011-11-02 22:18:30 -07:00
Andrew Gaul
cb14cd9d78
Prefer StringBuilder.append over String.concat
...
Addresses FindBugs complaints.
2011-11-02 22:10:02 -07:00
Andrew Gaul
647ae0a31c
Prefer Collection.isEmpty over size
2011-11-02 20:03:07 -07:00
Andrew Chen
763ff2752d
Scroll to the last known position in the MessageView when rotating the screen.
2011-11-02 16:39:23 -07:00
ashley willis
a021ab71de
Override onStop() to save email as draft when activity is changed (go to home screen, call received)
2011-11-01 22:12:51 -05:00
Andrew Chen
30151f1a70
Add parameter to MyGestureDetector to enable gestures for a specific detector, even if system-wide gestures are disabled.
2011-11-01 17:25:49 -07:00
Andrew Chen
edd78ea10c
Make the K9Activity GestureDetector more generic so that it can be used by both MessageList and MessageView.
...
Make the mTopView a ToggleScrollView. The only consumer is currently the MessageView, which uses a ToggleScrollView anyway. This should make it easier to reuse the anti-scrolling features in ToggleScrollView for ListView later on.
2011-11-01 16:55:13 -07:00
Andrew Chen
ea05f3b5d0
Merge branch 'legacy-collections' of https://github.com/andrewgaul/k-9 into andrewgaul
...
* 'legacy-collections' of https://github.com/andrewgaul/k-9 :
Prefer unsynchronized Collection types
2011-11-01 13:26:54 -07:00
ashley willis
57b9321a1e
issue-1424: saving duplicate or similar drafts fixed.
2011-11-01 03:02:29 -05:00
cketti
807907cb9e
Merge branch 'master' into issue549
...
Conflicts:
res/values/strings.xml
src/com/fsck/k9/service/MailService.java
2011-10-29 05:22:07 +02:00
cketti
e3f6561008
Don't crash when trying to connect to an non-SSL service using SSL
...
Fixes issue 3798
2011-10-28 04:59:08 +02:00
cketti
b69d6cb64c
Use Locale.US with toUpperCase() and toLowerCase() where appropriate
2011-10-27 17:17:43 +02:00
cketti
d3baa299f1
Use "reply after quoted text" value when editing drafts
2011-10-27 08:20:03 +02:00
Sven-Hendrik Haase
f4f726ae67
Fixed restoring drafts saved with "reply after quoted text" enabled
...
Fixes issue 2568
2011-10-27 07:23:01 +02:00
Andrew Gaul
80d9246130
Prefer unsynchronized Collection types
2011-10-19 21:56:20 -07:00
cketti
afd355f83c
Use Preferences.getAvailableAccounts() where appropriate
2011-10-18 05:09:20 +02:00
cketti
4d6946f47c
Start services and list folders after account has been activated
2011-10-18 05:06:32 +02:00
cketti
3967654a3e
Show short message when moving accounts
2011-10-17 04:34:26 +02:00
cketti
52a92d93a1
Add dialog to ask for server passwords after import
2011-10-17 04:34:26 +02:00
cketti
fc8d2e9979
Merge branch 'master' into issue549
...
Conflicts:
res/menu/accounts_context.xml
res/menu/accounts_option.xml
res/values/strings.xml
src/com/fsck/k9/Account.java
src/com/fsck/k9/activity/Accounts.java
src/com/fsck/k9/activity/AsyncUIProcessor.java
src/com/fsck/k9/activity/FolderList.java
src/com/fsck/k9/activity/ImportListener.java
src/com/fsck/k9/activity/K9Activity.java
src/com/fsck/k9/activity/K9ListActivity.java
src/com/fsck/k9/activity/MessageView.java
src/com/fsck/k9/mail/store/ImapStore.java
src/com/fsck/k9/mail/store/Pop3Store.java
src/com/fsck/k9/mail/store/WebDavStore.java
src/com/fsck/k9/mail/transport/SmtpTransport.java
2011-10-14 20:33:25 +02:00
cketti
effb45c463
Cleaned up success message after settings import
2011-10-14 06:19:30 +02:00
cketti
f5e684310e
Renamed StorageImportExportException to SettingsImportExportException
2011-10-14 06:00:10 +02:00
cketti
c835bb757a
Renamed StorageImporter to SettingsImporter
2011-10-14 05:58:55 +02:00
cketti
cf8bdef0a8
Renamed StorageExporter to SettingsExporter
2011-10-14 05:58:15 +02:00
cketti
470ba8bb03
Removed everything related to settings file encryption
...
The plan is to (re)add this feature later. With a proven method to
encrypt files; maybe OpenPGP.
2011-10-14 05:38:27 +02:00
cketti
fd16ff8fe6
Remove reference to NonConfigurationInstance when no longer needed
2011-10-14 04:15:45 +02:00
cketti
5b81dbc2ed
Use resource strings instead of hardcoding things
2011-10-14 03:42:04 +02:00
cketti
b146fcb2fd
Improved handling of object retention on configuration changes
2011-10-14 02:52:32 +02:00
ashley willis
2058fc378d
Option to show next message after delete by default instead of previous.
2011-10-12 17:50:24 +02:00
Andrew Gaul
9b27aba2ba
Avoid concatenation in StringBuilder append
2011-10-06 09:20:11 -07:00
cketti
2e2428b093
Merge pull request #55 from andrewgaul/stringbuilder
...
Prefer StringBuilder over StringBuffer
2011-10-06 09:04:43 -07:00
Andrew Gaul
220e55603d
Spelling corrections
2011-10-05 22:04:39 -07:00
Andrew Gaul
47eb0fa2e1
Prefer StringBuilder over StringBuffer
...
The former is unsynchronized and slightly faster.
2011-10-05 21:50:31 -07:00
cketti
644571cfe5
Make sure the InputStream of the import file is always closed
2011-10-04 00:48:43 +02:00
cketti
dfa97cd878
Handle activity restarts due to configuration changes
...
Close existing dialogs before the activity is destroyed. Recreate them
and rewire AsyncTasks to the new activity instance after its creation.
2011-10-01 20:11:14 +02:00
Koji Arai
f3795f3df5
Search same sender from searchable folders instead of the unified inbox
2011-09-16 01:33:51 +09:00
Andrew Chen
dd1334b874
Add some JavaDoc to SearchAccount stuff; astyle.
2011-09-12 15:08:34 -07:00
danapple
7d5bb99dbd
Add progress indicator during account move.
2011-09-05 12:45:53 -05:00
danapple
2867a90286
Disable account move menu items when account is at an end of the list.
...
Conflicts:
src/com/fsck/k9/activity/Accounts.java
2011-09-05 12:45:33 -05:00
danapple
06cabdbde1
Working version of moving accounts within the Accounts view.
2011-09-05 12:38:03 -05:00
danapple
c67ac4735f
Fixes Issue 3177
...
Dynamically update the FolderList titlebar when the unread state of a
listed folder changes. This implementation applies the folder unread
count delta to the account-level unread count, to avoid the expense of
recomputing the entire account's unread count. If no FolderInfoHolder
for this folder already exists, skip the recomputation of the
account-level unread message count.
2011-09-05 11:20:57 -05:00
cketti
f6a647d7b0
Cosmetic changes
2011-08-31 02:17:45 +02:00
cketti
e9e9d5afcb
Removed unused method
2011-08-31 02:12:01 +02:00
cketti
dfc370c057
Merge pull request #42 from jca02266/wip-fix-activity-switching-for-message-view
...
Fix for message list opening the wrong message view
Fixes issue 3592
2011-08-30 17:09:11 -07:00
Andrew Chen
16c1f9c35b
Add the remaining two return receipt headers upon request.
2011-08-28 16:08:41 -07:00
Alessandro Russo
f5c679fb95
Added support for requesting read receipts
2011-08-27 20:46:04 -04:00
Jesse Vincent
7b7601082b
the refactoring to combine batch and record logic added an extra check
...
that broke delete of single messages from message list.
2011-07-23 18:45:43 -04:00
Koji Arai
fda43206a3
Fixed the below issue for GalaxyS and S2.
...
When scrolling a ListView, all items turn black.
it was reproduced on FolderList, MessageList and Accounts, other views were not.
2011-07-20 22:13:20 +09:00
Koji Arai
8d264b159e
Workaround for below issue.
...
1. Show a message in MessageView.
2. Press HOME button to back home.
3. Re-launch the K-9 and select another message.
4. Show first selected message.
See also: https://github.com/k9mail/k-9/commit/fix_activity_stack
2011-07-18 00:59:30 +09:00
Koji Arai
45e29ccba4
Fixed issue 3530.
...
Should not HTMLify the message when it is sent without quoted message.
The problem is:
1. set MessageFormat in Account setting to the TEXT.
2. reply a message without quoted text.
3. it is sent with HTML tags.
2011-07-17 08:56:28 +09:00
Apoorv Khatreja
021d5641e5
ant astyle
2011-07-17 01:40:20 +05:30
Jesse Vincent
2e173150d5
Rather than disabling imap-specific preferences on POP3, hide em
2011-07-13 22:15:36 -04:00
Jesse Vincent
87640719dd
Disable "download by date range" for webdav and pop3.
...
The previous behavior caused catastrophic network abuse, downloading
messages outside the date range over and over.
2011-07-12 22:05:49 -04:00
cketti
a60a2a4295
Changed code to show/hide the correct views for CC/BCC
...
Fixes issue 3509
2011-07-07 04:59:45 +02:00
Jesse Vincent
2a698f1ab9
ant astyle
2011-07-02 15:18:43 -04:00
Jesse Vincent
2f48309f82
We forgot to HTML markup the body of the message in cases where we
...
weren't quoting any text
2011-06-20 18:26:19 -07:00
Jesse Vincent
a558466c36
ant astyle
2011-06-13 19:49:06 -04:00
Jesse Vincent
379a8dfa9e
It turns out that 79a96952f2
has caused a
...
lot of messages to be unreadable in K-9 3.8. (see mailing list
threads)
2011-06-09 21:54:22 -04:00
Fiouz
c416f02d52
Improve BACK button handling for MessageView
...
Remove memory leak from referencing MessageView context from the
Intent that is created to go back to MessageList. MessageView is no
longer hardcoded to go back to MessageList, it instead uses an Intent
given at creation to get back to the originating Activity.
Try our best to restore the MessageList in its previous state when
"Manage BACK button" option is enabled:
Since MessageList lives in its own task, we look for the previous
active task and check whether its top activity matches it. If it does,
we just finish MessageView and Android will automatically restore the
previous task. If it doesn't, we launch the originating Intent (and
MessageList state will be lost).
If option is off, we get the regular Android behavior: got back to the
previous screen, whenever it's the MessageList or another application
if the user long-pressed HOME.
The consequence of this is the need for a new permission in order to
check the previous active task: android.permission.GET_TASKS
2011-06-08 22:53:23 +02:00
cketti
4d11c80f65
Fix account selection on import if file doesn't contain global settings
2011-06-08 22:28:34 +02:00
Fiouz
5ee63c47fe
Implemented BACK handling for MessageView
...
Implemented because MessageList is now in singleInstance launchMode so
the default behavior may not match user options.
2011-06-08 08:42:40 +02:00
Fiouz
9b0ce3c75a
Remove no longer used references on confirmation dialog disapproval
2011-06-07 01:25:38 +02:00
Fiouz
fc4dd077e4
Don't attempt to configure a dismissed dialog during Android activity
...
reloading
As part of automatic activity reloading following a configuration
change, Android invokes Activity#onPrepareDialog() even for dismissed
dialogs. Consequently, one can't make the assumption that this method
is only invoked by explicit calls to Activity#showDialog() from our
code.
The actual problem here was the mActiveMessages member being null
at such times.
2011-06-07 01:15:04 +02:00
Fiouz
72870174ce
Pluralize the "Move to spam" confirmation dialog since code paths were
...
unified in MessageList and multi-selection is now subject to this
dialog.
2011-06-05 01:35:11 +02:00
Fiouz
de7b75a1df
Properly keep selection in case of a
...
configuration change (orientation, keyboard, etc.) during user
interaction (e.g. a dialog)
2011-06-05 01:16:34 +02:00
Fiouz
5366a07f28
Add @Override compiler check
2011-06-04 23:55:48 +02:00
Fiouz
190d028669
Javadoc fix
2011-06-04 23:17:47 +02:00
Fiouz
821a00e727
MessageList refactoring to remove duplicate code paths.
...
Message operations should be more consistent now, regardless of how
the messages are selected (long click, checkbox+Menu, future group selection).
This is a backport of the modifications made on the issue258 branch,
without the threading specific features (no new feature introduced).
2011-06-04 23:01:34 +02:00
Jesse Vincent
3d583da450
ant astyle
2011-06-01 16:03:56 -04:00
cketti
c5342472f2
Load AbsoluteSizeSpan(int,boolean) constructor via reflection
...
This will allow us to run on Android 1.5/1.6 devices.
2011-05-26 23:43:35 -04:00
Jesse Vincent
a9b28d62d7
Fix a NPE
2011-05-26 22:59:50 -04:00
cketti
de4abf87cb
Respect "move/copy destination folders" setting in ChooseFolder
...
Fixes issue 2664
2011-05-26 04:11:09 +02:00
Koji Arai
7f93cfcbca
Refactoring
2011-05-25 00:25:23 +09:00
Koji Arai
33a92b11a2
Use the Button instead of the ImageButton.
2011-05-22 04:12:41 +09:00
Koji Arai
ce9b280746
Added account preference to display quoted text.
2011-05-22 03:56:51 +09:00
Koji Arai
5d6df85aac
possible to toggle to display the quoted message to send.
2011-05-22 03:55:50 +09:00
cketti
e90a479384
Renamed member variables to match code style guidelines
2011-05-14 22:17:15 +02:00
cketti
92b17ec2e2
Hide "Show only subscribed folders" checkbox for POP3 accounts
2011-05-14 22:15:39 +02:00
cketti
969e2d93fd
Don't use the "owner name" as default value for the email name
...
Get rid of Contacts.getOwnerName() and associated permissions.
Fixes issue 3331
2011-05-14 04:53:17 +02:00
Andrew Chen
e5d952bff4
Save and restore the cursor position when saving or loading a draft. This is the first step in making "resume composition on context switch" a reality.
2011-05-10 15:23:25 -07:00
Marcus Wolschon
e0ef94f64b
Issue 3319: unseen message count can add up to infinity
2011-05-09 11:21:24 +02:00
cketti
f4931a3167
Get rid of constant K9.INBOX
...
Use Account.getInboxFolderName() instead
2011-05-08 02:17:23 +02:00
cketti
92ea452163
Restore hardcoded Outbox
2011-05-07 23:57:47 +02:00
Koji Arai
870791958f
Refresh folder list when folder is cleared
2011-05-05 07:08:33 +09:00
cketti
01937d4ab8
Don't crash if "footer view" is clicked in search results
...
Fixes issue 3071
2011-05-01 05:34:17 +02:00
cketti
7e24377bb8
Return detailed information on imported accounts
2011-04-29 04:29:16 +02:00
cketti
80f60a06ca
Merged pull request #21 from jott/master.
...
Support for SMTP authentication methods that are not announced by the server.
2011-04-26 08:18:49 -07:00
Koji Arai
9b2e4c43a9
Fixed default sender color in the MessageList
2011-04-26 23:49:25 +09:00
Jonas Hurrelmann
da38149091
Support for SMTP authentication methods that are not announced by the server.
...
- Added AUTOMATIC as a new authentication method that will automatically choose the best authentication method (basically old behavior with CRAM_MD5). All other options will now enforce the selected authentication method.
- Added LOGIN as selectable option.
- Cleaned up code so strings to the different authentication methods are only defined once.
2011-04-25 22:32:48 +02:00
Bernhard Redl
f90fccbfa7
fix NullPtr Exception when there is no Sent Mail folder on the imap server
2011-04-24 14:19:58 +10:00
Bernhard Redl
ab4bae214f
Make attachment saving respect the new preference. Allow long-press to
...
choose a folder.
(new constant renamed from CHOOSE_FOLDER to CHOOSE directory for
clarity)
2011-04-24 14:01:03 +10:00
Bernhard Redl
e278ea23e9
Add a preference for selecting a default folder in which to save attachments
2011-04-24 13:55:25 +10:00
cketti
4b2fe6efab
Removed unused imports
2011-04-21 00:00:16 +02:00
cketti
237302cc2b
Changed import code to set "defaultAccountUuid" if necessary
2011-04-19 23:04:43 +02:00
Marcus Wolschon
6f4bef3530
Issue 3259: Show SubjectAltNames in acceptKeyDialog
2011-04-19 10:46:17 +02:00
Koji Arai
659a5d36b2
Fixed issue 2991: Should display colorized name in the message list.
2011-04-16 18:16:33 +09:00
cketti
12d87854ac
First version of the import code that reads the new file format
2011-04-13 03:37:44 +02:00
Jesse Vincent
d3848d352d
astyle
2011-04-12 22:17:22 +10:00
bitblaster
879d872616
Replaced references to K9.INBOX with account.getInboxFolderName()
2011-04-12 22:17:11 +10:00
bitblaster
3290166749
Replaced references to K9.INBOX with account.getInboxFolderName() and disabled the call to reverseTranslateFolder in case of WebDav account
2011-04-12 22:17:11 +10:00
bitblaster
ccc79f62b9
Replaced references to K9.INBOX with account.getInboxFolderName()
2011-04-12 22:17:11 +10:00
bitblaster
236226858c
Replaced references to K9.INBOX with account.getInboxFolderName()
2011-04-12 22:17:11 +10:00
bitblaster
680e2e4191
Replaced references to K9.INBOX with account.getInboxFolderName()
2011-04-12 22:17:11 +10:00
Jesse Vincent
0174988d27
astyle
2011-04-12 22:16:22 +10:00
Sander Bogaert
17cb5106f6
The date format preference is now refreshed each time the messages get listed.
...
Previously, changes to the date format preference weren't noticed until
the app restarted.
2011-04-12 21:44:51 +10:00
Koji Arai
79a96952f2
Correct encoding and decoding for the filename parameter in the Content-Disposition.
2011-04-08 00:58:53 +09:00
Jesse Vincent
e3818e7739
Merge branch 'master' of https://github.com/dnet/k-9 into dnet-master
...
* 'master' of https://github.com/dnet/k-9 :
Added SHA-1 checksum to acceptKeyDialog
2011-04-07 15:44:09 +10:00
Will Hawkins
d881832eca
Made the minor modifications to support CRAM-MD5 authentication
...
in POP3 accounts.
2011-04-06 11:42:37 -04:00
András Veres-Szentkirályi
dcf5d150a6
Added SHA-1 checksum to acceptKeyDialog
2011-04-04 18:14:46 +02:00
cketti
8a112f04f9
Disable "Enable refile buttons" preference for POP3 users
2011-04-01 06:44:50 +02:00
cketti
4aec4b096c
Added option to disable confirmation dialog for "mark all as read"
...
Fixes issue 1415
2011-04-01 05:34:27 +02:00
cketti
aa4c970baa
Added "move to spam folder" confirmation dialog to MessageList
2011-04-01 04:21:27 +02:00
cketti
e3e31062ad
Only keep reference to selected message if necessary
...
Only keep mSelectedMessage pointing to the currently selected message
if we use the spam action and ask for confirmation before moving.
2011-04-01 03:45:50 +02:00
cketti
ea9213cd4d
Converted some more confirmation dialogs to use ConfirmationDialog
2011-04-01 03:40:08 +02:00
cketti
ac148a1ef7
Extracted confirmation dialog creation to ConfirmationDialog
...
Confirmation dialogs in MessageList and MessageView now use the new
ConfirmationDialog class.
2011-04-01 03:17:47 +02:00
cketti
449d4df2a9
Minor code cleanup
2011-04-01 03:13:23 +02:00
Archibald Sheran
80f055a0a7
Issue 2296 Spam message
2011-04-01 05:54:51 +08:00
cketti
d5197fdc56
Put all import code in StorageImporter
...
Get rid of StorageImporterEncryptedXml and IStorageImporter. Also
AsyncUIProcessor is now obsolete.
2011-03-30 21:00:34 +02:00
cketti
81931967a9
Fix code so accounts are exported when exporting everything
2011-03-29 06:59:02 +02:00
cketti
0ac406d3cd
Removed per key/value encryption on export
2011-03-29 06:15:58 +02:00
cketti
84f4331766
Disable import for now
2011-03-28 08:12:12 +02:00
cketti
6510919eee
Moved export to file code from Accounts activity into StorageExporter
2011-03-28 08:04:43 +02:00
cketti
f5c153b405
Get rid of StorageFormat
2011-03-28 07:25:07 +02:00
cketti
97f493c881
Get rid of ExportListener
2011-03-28 07:18:47 +02:00
cketti
1d146278b0
Moved password input dialog for export to Accounts activity.
2011-03-28 01:55:46 +02:00
cketti
a559a35249
Use AsyncTask instead of AsyncUIProcessor for export
2011-03-28 01:18:36 +02:00
Jesse Vincent
0bded12843
Kill off ExportHelper. It had become clutter that was only used once
2011-03-27 13:09:26 +08:00
Jesse Vincent
b3b8302c52
Remove some vestiges of HashSet
2011-03-27 12:40:00 +08:00
Jesse Vincent
9deeaf9c11
No longer export global settings when exporting one account
2011-03-27 12:03:23 +08:00
Jesse Vincent
52825f409f
As suggested by cketti, HashSet -> Set in our method signature
...
definition
2011-03-27 11:37:37 +08:00
cketti
087feb478b
First step at replacing the term "version" with "storageFormat"
2011-03-26 07:19:20 +01:00
cketti
4bdc20c127
Rename StorageVersioning to StorageFormat
2011-03-26 07:00:53 +01:00
cketti
18cefedf32
Get rid of the STORAGE_VERSION enum in StorageVersioning
2011-03-26 06:59:45 +01:00
cketti
26258d7666
Removed unused imports
2011-03-26 06:43:39 +01:00
Jesse Vincent
b4a43893a3
Lift the choice of which accounts to export all the way up to
...
Accounts.java in advance of adding a dialog
2011-03-25 16:28:14 +11:00
Jesse Vincent
b8949abaca
Kill some now-dead and duplicate code
2011-03-25 15:56:25 +11:00
danapple
fd468e95fb
Specify a particular mime type. Although the K-9 settings file mime
...
type will not be generally known, specifying something in particular
means that only file browsers that can handle */* will used as options
in the chooser. In my tests, OI File Manager responds immediately (and
the chooser is bypassed) and the camera, music and ringtone selectors
are not provided as options.
2011-03-23 00:00:24 -05:00
danapple
0a0cfac1cb
Better internationalization, using real Android pluralization API.
2011-03-22 22:59:30 -05:00
Jesse Vincent
e19162cb86
ant astyle
2011-03-22 18:07:47 +11:00
Jesse Vincent
81644d0f4b
Initial support for a button to look up contacts in a contact provider
2011-03-22 18:07:47 +11:00
danapple
3f45df2bd4
Astyle recent changes for StorageManager listener.
2011-03-20 15:37:51 -05:00
danapple
8e5c50a8ef
astyle
2011-03-20 15:21:24 -05:00
danapple
89bdbdce94
Build a structure to allow for more easily creating new versions of
...
preferences Storage importers/exporters. Password/encryption key
prompting is now down in centralized place. On import, the password
prompt is given if the file to be imported uses an importer
implementation that requires a password and no password is provided.
On export, the password prompt is given if the chosen version is for
an exporter that requires a password and no password was provided.
For instance, for automatic backups, a password could be stored in
preferences and provided to the exporter, so no password prompt would
be given.
2011-03-20 11:52:13 -05:00
danapple
90fc3d2c8d
Grey out unavailable accounts.
...
Display a short toast when attempting to open an unavailable account.
Conflicts:
res/values/strings.xml
src/com/fsck/k9/activity/Accounts.java
2011-03-19 12:36:58 -05:00
danapple
c3cc43675b
Grey out unavailable accounts.
...
Display a short toast when attempting to open an unavailable account.
2011-03-16 17:05:41 -05:00
steiler
e2a7a55cf3
Issue 3104: Can't bcc to more than 1 address
2011-03-14 19:28:44 -04:00
mwolschon
6fa1f39fcc
merging refs/remotes/origin/master into HEAD
2011-03-14 13:38:08 +01:00
mwolschon
0be4f95430
update issue 3130
...
"Allow filtering in FolderList"
2011-03-14 13:37:22 +01:00
Jesse Vincent
9996d80080
When making sure not to offer up the outbox as a potential folder for
...
things like Drafts or Inbox, use a case-insensitive comparison
2011-03-09 16:32:25 -05:00
Jesse Vincent
79a4557500
Switch K-9 to using the SMTP submission port rather than the regular
...
server-to-server transport port.
2011-03-09 00:21:16 -05:00
baolongnt
06ecc11ee7
Merge commit '4586ba560e3498ead43fc4eacb7a92a3ce62de75'
...
Merged branch issue-3060 to master: Option to hide special accounts
2011-03-06 16:53:21 -08:00
danapple
32b5afc702
astyle
2011-03-02 07:34:54 -06:00
danapple
107408c0d9
K-9 Mail now opens the Accounts Activity when started with an Intent
...
with an enclosed URI with a content type of application/x-k9settings.
This allows a user to bootstrap K-9 Mail configuration by email a
settings file from one device to another, perhaps using a GMail
account on the receiving end.
2011-03-01 22:34:41 -06:00
danapple
9cd5f61539
Change import/export completion Toasts to Dialogs.
2011-03-01 21:21:00 -06:00
cketti
203dab5c64
Revert changes for issue 549 (import/export settings).
...
The feature will be polished in branch "issue549".
2011-02-28 22:55:34 +01:00
danapple
a7e134164f
Handle pluralization of import toasts.
2011-02-27 13:35:59 -06:00
danapple
932d178679
Merge branch 'issue549'
...
Conflicts:
src/com/fsck/k9/Account.java
src/com/fsck/k9/K9.java
src/com/fsck/k9/Preferences.java
src/com/fsck/k9/activity/Accounts.java
src/com/fsck/k9/activity/ActivityListener.java
src/com/fsck/k9/activity/ChooseFolder.java
src/com/fsck/k9/activity/FolderInfoHolder.java
src/com/fsck/k9/activity/FolderList.java
src/com/fsck/k9/activity/K9Activity.java
src/com/fsck/k9/activity/K9ListActivity.java
src/com/fsck/k9/activity/MessageList.java
src/com/fsck/k9/activity/MessageReference.java
src/com/fsck/k9/activity/MessageView.java
src/com/fsck/k9/activity/setup/AccountSettings.java
src/com/fsck/k9/controller/MessagingController.java
src/com/fsck/k9/crypto/Apg.java
src/com/fsck/k9/helper/DateFormatter.java
src/com/fsck/k9/helper/DomainNameChecker.java
src/com/fsck/k9/mail/Address.java
src/com/fsck/k9/mail/internet/MimeHeader.java
src/com/fsck/k9/mail/internet/MimeMessage.java
src/com/fsck/k9/mail/internet/MimeUtility.java
src/com/fsck/k9/mail/store/ImapStore.java
src/com/fsck/k9/mail/store/LocalStore.java
src/com/fsck/k9/mail/store/WebDavStore.java
src/com/fsck/k9/mail/transport/SmtpTransport.java
src/com/fsck/k9/view/AttachmentView.java
2011-02-27 13:09:38 -06:00
danapple
ad3dd07a7a
astyle-d
2011-02-26 18:39:06 -06:00
cketti
4724848a5a
Merge branch 'focus_to_box'
2011-02-27 01:26:04 +01:00
danapple
6dc94fb78e
First mostly working copy of export/import. Committing while I sort
...
out how to use git.
2011-02-26 11:31:56 -06:00
baolongnt
fce2fc12d0
Implemented option to hide special accounts (issue 3060)
2011-02-25 12:36:47 -08:00
cketti
0c02fb1027
Merge branch 'open-attachment'
2011-02-20 19:31:42 +01:00
cketti
d354905f21
Cosmetic changes
2011-02-20 19:18:17 +01:00
cketti
5f0e51caa9
Added a comment
2011-02-20 19:02:42 +01:00
Jan Berkel
41378188f9
Updates to the view need to happen on the UI thread
...
Fixes downloading attachments (would just fail silently)
Also added a ProgressDialog since progress() just asks for
progress to displayed in the title bar. Since there is no title bar,
no progress is shown at all.
2011-02-20 18:49:55 +01:00
Jan Berkel
cc0b935b38
Performance fix: Use ListView#addFooterView to add the footer
...
The previous approach (generating the view in the adapter) kills performance
because list views cannot be recycled anymore, as soon as the user scrolls to
the bottom of the list. The Android ListView widget already provides support
for list header/footers, so use them.
2011-02-20 17:47:06 +01:00
cketti
a79b7ea93c
Inlined methods that were extracted to use
...
@SuppressWarnings("unchecked"). That's now unnecessary after the
Serializable -> Parcelable switch
2011-02-20 06:23:06 +01:00
cketti
bb40049212
Remove unused imports
2011-02-20 05:31:35 +01:00
cketti
ad159b3093
Merge branch 'hardcoded_outbox' into HEAD
2011-02-20 05:14:22 +01:00
cketti
737cff0612
Hardcode folder name for (local) outbox and don't show outbox when
...
only being allowed to select remote folders.
2011-02-20 04:47:28 +01:00
HIRANO Takahito
580d19ec17
Allow emoji input in subjects.
...
Signed-off-by: HIRANO Takahito <hiranotaka@zng.info>
2011-02-20 10:15:50 +09:00
Jan Berkel
685df0ff67
Perf improvement: use parcels instead of serializable
...
Standard Java serialization is slow on Android. Replacing it w/
parcelable makes it around 10x faster (on a N1, with ~ 500 messages
in the list).
To avoid further confusion and potential bugs MessageReference was
made no longer implement Serializable.
2011-02-19 15:24:53 -05:00
Jesse Vincent
8a778a0222
reformatting
2011-02-14 20:45:08 -05:00
Jesse Vincent
fb663508e0
remove an unused method
2011-02-14 20:44:53 -05:00
Jesse Vincent
143ca4df26
replace redundant calls with a helper
2011-02-14 20:26:00 -05:00
Jesse Vincent
ea6e5e0e62
Lifting more of the "Show this message" over to the SingleMessageView
2011-02-14 13:40:49 -05:00
Jesse Vincent
dc1444d1ac
Rename a method that was confusingly similar to another method
2011-02-14 13:32:30 -05:00
Jesse Vincent
10da146e93
clean up unused imports
2011-02-14 13:32:25 -05:00
Jesse Vincent
5aad882976
Move the "isScreenReader" active code down into the MessageView
2011-02-14 13:32:14 -05:00
Jesse Vincent
04bc32db9e
move a call to setLoadPictures down
2011-02-14 13:31:43 -05:00
Jesse Vincent
043535f7a5
Migrate a method into SingleMessageView
2011-02-14 13:31:34 -05:00
cketti
e70d091433
Explicitly set focus to "To:" input field when composing or forwarding
...
a message.
2011-02-14 08:28:03 +01:00
Jesse Vincent
260b933a3b
Move the "update the title" code from almost every single
...
ActivityListener callback to the superclass, removing the need for many
sublcass methods
2011-02-13 21:20:22 -05:00
Jesse Vincent
4e48366243
Remove more redundant checks
2011-02-13 21:20:21 -05:00
Jesse Vincent
be106c21a1
remove completely redundant code from batch archive/spam codepaths. (It
...
duplicated code in the batch move codepath)
2011-02-13 21:20:21 -05:00
Jesse Vincent
abc921093c
refactor display of the download button
2011-02-11 12:11:21 -05:00
Jesse Vincent
9deea33426
re-enable setOnFlagListener
2011-02-11 12:10:45 -05:00
Jesse Vincent
06baf3f602
simplify the "load a url for the message body" signature
2011-02-11 12:09:47 -05:00
Jesse Vincent
111b9a6305
remove a pointless indirection and an extra method call to set the
...
options menu when we didn't need to
2011-02-11 11:16:50 -05:00
Jesse Vincent
49b35f9236
More reshuffling toward having a reusable "Show a message" widget - what
...
should eventually be a Fragment.
Lifted part of the cryptoView back up to the activity since the
factoring felt forced.
2011-02-11 10:59:31 -05:00
Jesse Vincent
015baa06b4
Renamed "next" and "previous" buttons to match code style
2011-02-10 16:39:49 -05:00
Jesse Vincent
fe21d6951f
remove unused method
2011-02-10 16:39:49 -05:00
Jesse Vincent
98f3909ecc
Split out a "clear the current message view" method
2011-02-10 14:56:56 -05:00
Jesse Vincent
a3793ac651
Merge branch 'crypto-view'
...
* crypto-view:
Move as much of the Apg code as possible to its own "view" class (should eventually be a fragment?)
Bumped manifest to 3.702
2011-02-10 14:20:09 -05:00
Jesse Vincent
850aee9008
Move as much of the Apg code as possible to its own "view" class
...
(should eventually be a fragment?)
2011-02-10 14:02:21 -05:00
mwolschon
673b1fdf94
bugfix for
...
2e981afaed
( forgot a call to finish() )
2011-02-10 07:59:29 +01:00
Marcus Wolschon
2e981afaed
if account is not ready (sd-card removed), fall through to the
...
"else"-case, so onItemClick -handler still gets registred.
Else inserting the SD-card without leaving the activity,
THEN clicking the account will not do anything.
2011-02-08 08:56:08 +01:00
Jesse Vincent
2aee63e242
make it possible to define Providers that don't require
...
username+password auth
2011-02-07 22:07:31 -05:00
Jesse Vincent
12d1097a24
Big, scary massive "ant astyle" to get us back to something
...
approximating AOSP coding standards.
2011-02-06 17:09:48 -05:00
Andrew Chen
cc9d6ac5ea
Add button to allow editing of quoted message in HTML mode by dropping user back to text mode. Fixes issue 2959.
2011-02-05 15:14:02 -08:00
Dan Applebaum
4842051de6
Immediately update the title bar when the syncing status changes due to external events.
2011-02-04 23:19:06 -05:00
Andrew Chen
1b37fc69f6
Another potential NPE fix.
2011-02-04 23:19:06 -05:00
Dan Applebaum
e31d218dc5
At Jesse's suggestion, avoid the use of the Android term-of-art "density". Instead use "Compact layouts" to refer, both internally and externally, to the feature of elminating minimum sizes on UI elements and other minor layout changes for maximizing information quantity to be displayed on a page.
...
Others are free to adjust the user-facing text further.
2011-02-04 23:19:06 -05:00
Andrew Chen
66f6999c53
Fix for NPE introduced in r3258.
2011-02-04 23:19:06 -05:00
Dan Applebaum
40bdf99925
Fixes Issue 2934 Fixes Issue 2935
...
Provides for storing Folder Settings in the central Preferences
Storage as a back-up to the settings stored on each folder. In this
way, even if the LocalStore DB is recreated or otherwise lost, Folder
Settings can be recovered.
1) Does not change the methodology used to read settings while
running, nor the changes in r3107 & r3116 which tremendously improve
Accounts list loading time.
2) Loads Folder Settings from Preferences and stores on the folder
only when creating a new LocalFolder
3) Saves Folder Settings to Preferences and the DB row every time the
Folder Settings are changed.
4) When upgrading from DB version 41 to 42 or later, copies all
settings for existing folders from the DB storage to the Preferences
Storage.
5) Transactional bulk folder creation and single pass local folder
existence check during "Refresh folders" operation drastically reduces
time spent when refreshing folders from the remote store.
6) Uses prepared statement during Editor commit to reduce Preference
storing time.
Probably needs a reversion of r3239, but I'm unfamiliar with
translations, so am leaving that to others' discretion.
2011-02-04 23:19:06 -05:00
Dan Applebaum
ea3619b733
Display a message in the titlebar when K-9 Mail is not performing any message synchronization. This state will happen when no network is available, when background ops/background data/auto-sync settings turn off synchronization, or when no account is set for polling or pushing.
...
This revision respects the intention of r3011 that when K-9 Mail is
set for pushing only no message is displayed, as that condition is a
normal state. However, it provides valuable feedback in other cases
that synchronization is off-line, as was done in r1433.
Although the case when the user has intentionally set no account for
polling or pushing can be considered "normal" and therefore unworthy
of a message, it turns out to be a significant burden to detect that
situation when the network is offline, since we normally do not even
try to figure out the account configurations in that case. Therefore,
without making substantial, otherwise unwarranted, changes to
MailService.java, "Syncing off" would be displayed sometimes to such a
user, and sometimes not. Since it is presumably a rare case, and
there is minimal harm to display the "Syncing off" message, the
message will be consistently displayed when no account is set for
polling or pushing.
Note to translators:
"Syncing off" is different than "Polling off". The new phrase "Syncing
off" means that K-9 Mail is not performing any synchronization with
any mail server. The prior non-English phrases for "Polling off" are
currently in-place as translations for "Syncing off", as it seems that
the meanings are close enough that it would be better to show the
obsolete translations that to fallback to the English "Syncing off".
However, better translations of "Syncing off" would be welcome.
2011-02-04 23:19:06 -05:00
Andrew Chen
33e5520a9d
Mark messages as ANSWERED only on send. Save a reference to the message in the identity so that loading a draft of a reply also marks the referenced message correctly.
2011-02-03 06:32:29 +00:00
Daniel Applebaum
6c03c968ef
Provide for users with good eyesight to completely take advantage of the
...
"smaller" (and smaller) fonts by allowing the Accounts and Folder List
items to have a height smaller than the normal Android minimum. This
option is off by default to maintain existing behavior for
uninterested parties. The preferences text is not especially
compelling so could certainly be changed if better phrasing is found.
2011-02-03 03:42:45 +00:00
Jesse Vincent
3d090e9626
astyle
2011-01-31 23:45:23 +00:00
Jesse Vincent
6550151684
Add serialVersionUID to Serializable classes to make eclipse happy
2011-01-31 23:45:14 +00:00
Jesse Vincent
65dc3c7d1b
Fix display of icon in About box on Android 2.1 and earlier
2011-01-30 15:11:16 +00:00
cketti
555e6431b2
Add credits for third-party libraries and emoji icons to about box
2011-01-29 02:49:39 +00:00
Kris Wong
88d0af16a5
Updated Exchange setup view.
2011-01-28 22:45:10 +00:00
Andrew Chen
13898f7edf
Fix the way newlines are added in HTML mode.
2011-01-28 21:41:06 +00:00
Jesse Vincent
5e7982a31b
first pass at a better about box
2011-01-28 18:30:35 +00:00
Jesse Vincent
4a558c5ac5
Revert the active part of "Update issue 848"
...
This reverts commit 9fc94115adb58dcd8a64227a93d0e6e707d7752d.
It turns out that disabling the "View attachment" button (rather than
giving a useful error message telling the user what mime type the app
needs to support) was confusing to users.
2011-01-28 03:33:49 +00:00
Andrew Chen
ba1709770e
Issue 854 - Fix reply after quote in HTML mode.
2011-01-25 03:56:19 +00:00
Jesse Vincent
098851684f
astyle
2011-01-23 00:56:01 +00:00
Jesse Vincent
c06643bd47
Add a preference to allow users to always show email addresses instead
...
of the "friendly" parts of email addresses.
2011-01-23 00:55:46 +00:00
cketti
f5bb836087
Fix code that was broken when fixing warnings.
2011-01-19 21:00:28 +00:00
cketti
22834d6998
Removed unnecessary null pointer checks
2011-01-19 01:30:13 +00:00
cketti
7119c7165f
Removed unnecessary type casts
2011-01-19 01:21:27 +00:00
cketti
365b106753
Fixed warnings about unchecked casts by extracting the code to methods and using the @SuppressWarnings annotation on them.
2011-01-19 00:36:15 +00:00
cketti
d48ec4892a
Added missing annotation
2011-01-19 00:33:19 +00:00
cketti
a9cee7a6ad
Rewrote code to get rid of return statement in finally block (which generated a warning).
2011-01-19 00:23:56 +00:00
cketti
8279092070
Fixed lots of warnings (unused imports/variables, missing annotations, etc.)
2011-01-18 23:54:49 +00:00
Marcus Wolschon
60ea4c6ce7
Update issue 2479
...
possible fix for "The content of the adapter has changed but ListView did not receive a notification."
2011-01-18 15:34:41 +00:00
Jesse Vincent
d59600653c
astyle
2011-01-18 00:04:11 +00:00
Jesse Vincent
bd66315375
Visual cleanup of messageview. Clean up of icon display codepaths
2011-01-17 17:25:00 +00:00
Marcus Wolschon
fc4b64c559
Update issue 848
...
"view" only enabled for attachments if there is an actual
application on the phone to view this kind of file.
2011-01-17 10:41:48 +00:00
Jesse Vincent
4d0f489ab4
Initial implementation of folder attributes on the folder, rather than in preferences
2011-01-16 04:23:03 +00:00
Jesse Vincent
aacb414004
astyle
2011-01-14 01:37:52 +00:00
Andrew Chen
e56b044bbc
Add support for HTML composition with text alternative.
...
Revamp K9 Identity string.
Quote names in Address only when needed.
Remove quoted text bar and move button to quoted text area.
2011-01-12 23:48:28 +00:00
Andrew Chen
c07c7052dc
Add Notification setting to disable unread count in notification bar.
2011-01-12 01:23:17 +00:00
Andrew Chen
b4635e53b5
When editing a draft, only show the BCC field if it has entries other than the auto-bcc for that account.
...
This makes draft editing behavior the same as new composition.
2011-01-11 02:49:00 +00:00
Andrew Chen
e19f742678
Consolidate exception catching in processSourceMessage into a single try/catch block.
...
Add error logging if we do have an exception.
2011-01-10 20:12:08 +00:00
Jesse Vincent
9d5704c0f5
Split the Header view out from the MessageView activity
2011-01-10 17:47:28 +00:00
Jesse Vincent
0ca6adfbf8
move DateFormatter from Activity to Helper
2011-01-10 17:47:16 +00:00
Jesse Vincent
b2c44579d2
lift "displayMessage" out of a callback
2011-01-06 16:56:55 +00:00
Jesse Vincent
39ef6584a8
continue to extract attachment code out to AttachmentView
2011-01-06 16:56:37 +00:00
Jesse Vincent
19c5324316
Extract AttachmentView and MediaScannerNotifier into their own classes
2011-01-06 16:56:20 +00:00
Jesse Vincent
ed60cdfa5a
replace constant lookups of the MessagingController instance with a locally cached one
2011-01-06 16:56:02 +00:00
Jesse Vincent
299c057cd4
minor code cleanup
2011-01-06 16:55:48 +00:00
Jesse Vincent
9c847d3e9d
minor code cleanup
2011-01-06 16:55:34 +00:00
Jesse Vincent
de806f7715
astyle
2011-01-06 16:55:08 +00:00
Andrew Chen
aa0eeac736
Show the correct quote style options at preference load time.
2011-01-06 07:05:57 +00:00
Andrew Chen
f9ddc7eb06
Remove extraneous colon.
2011-01-06 01:34:08 +00:00
Andrew Chen
74e6384236
Fix potential NPE.
2011-01-06 01:31:28 +00:00
Andrew Chen
5fef7f3b07
Add support for Outlook-style quote headers as a preference under Account Settings -> Sending Mail.
...
Refactor forwarding header (header-style quote header) into individual string pieces that are assembled in code to accommodate future HTML version of headers.
Introduced four new strings for translation.
2011-01-05 23:58:14 +00:00
Jesse Vincent
2daf8eaec8
Allow emoji input.
...
Signed-off-by: HIRANO Takahito <hiranotaka@zng.info>
2011-01-04 13:25:59 +00:00
Jesse Vincent
d25f12fa16
Switch K-9 from generating X-User-Agent to User-Agent headers.
...
Fixes issue 1917
2011-01-04 08:33:12 +00:00
cketti
a1e059e871
Introduced setting to change the font size of the message preview in the message list.
...
Fixes issue 2788
2010-12-30 00:52:00 +00:00
Andrew Chen
605a0bdc93
Add more comments about LocalTextBody.
...
Display decrypted PGP data as text/plain (content type was being set, but not being passed to WebViews).
2010-12-29 07:34:57 +00:00
cketti
cb97c312fc
Move ColorChip to the correct directory
2010-12-28 23:37:47 +00:00
Jesse Vincent
777f75b5c4
Stop showing "Not polling" in the status header. Most of the time, this
...
is because we're pushing.
2010-12-28 09:12:02 +00:00
Jesse Vincent
8bc984f440
APG-related messageview bugfixes
2010-12-28 09:11:35 +00:00
Jesse Vincent
0c426c9c4b
Round our color chips, clean up color hcip rendering a bit
2010-12-28 09:11:10 +00:00
Jesse Vincent
4c9c478d8d
minor code and doc cleanups as recommended by IntelliJ
2010-12-28 09:10:50 +00:00
Jesse Vincent
b166cf03e8
split apart attachment view creation a bit
2010-12-28 09:09:52 +00:00
Jesse Vincent
3c9eb2c004
Further refactoring of message display
2010-12-28 09:09:33 +00:00
Jesse Vincent
9fe56831bf
finish removing setHeaders as a layer of indirection
2010-12-28 09:09:15 +00:00
Jesse Vincent
8116a0f39f
lift some gpg code into the crypto initializer
2010-12-28 09:08:58 +00:00
Jesse Vincent
3ffa28fa02
we import so we don't need to qualify
2010-12-28 09:08:40 +00:00
Jesse Vincent
85a7a08e9a
Rename our attachment view holder from Attachment to AttachmentViewHolder
2010-12-28 09:08:18 +00:00
Jesse Vincent
6a04afb758
extract "does it have html images" out of MessageView. really, it should
...
end up in LocalMessage somewhere
2010-12-28 09:07:59 +00:00
Jesse Vincent
7623a02852
lift the "get display text" code out of the messageview and into
...
localmessage
2010-12-28 09:07:39 +00:00
Jesse Vincent
84f6e546d2
setLoadPictures sets mShowPictures. We don't need to set it again
2010-12-28 09:07:19 +00:00
Jesse Vincent
f292251b78
lift createUniqueFile to a Utility class
2010-12-28 09:06:57 +00:00
Jesse Vincent
570dbf7126
split apart onCreate into bite-sized pieces
2010-12-26 03:51:33 +00:00
Jesse Vincent
43e3e860f8
doc fix
2010-12-26 03:49:52 +00:00
Jesse Vincent
d352b8a4a5
whitespace
2010-12-26 03:49:23 +00:00
Jesse Vincent
f2b2fddd5a
onRefile removes code duplication
2010-12-26 03:49:20 +00:00
Jesse Vincent
db02383d4a
whitespace cleanups
2010-12-26 03:49:16 +00:00
Jesse Vincent
8488b55e09
remove some duplicated code
2010-12-26 03:49:13 +00:00
Jesse Vincent
8c6df94739
remove some temp variables
2010-12-26 03:49:09 +00:00
Jesse Vincent
877427f110
cut down a couple overly verbose conditionals
2010-12-26 03:49:06 +00:00
Jesse Vincent
daf5a9d704
lift emulateShiftHeld to our custom WebView subclass
2010-12-25 22:30:34 +00:00
Jesse Vincent
8e2e4e515f
simplify MessageView's setHeaders
2010-12-25 22:30:31 +00:00
Jesse Vincent
8b52aac135
remove unused imports
2010-12-25 22:30:27 +00:00
Jesse Vincent
76fd8e9939
extract animation code from MessageView
2010-12-25 22:30:22 +00:00
Jesse Vincent
5f9eae1580
Extract MessageWebView specific code into a new class
2010-12-25 22:30:16 +00:00
Jesse Vincent
ea4e0aa61f
remove a bunch of extraneous code and variables
2010-12-25 19:29:02 +00:00
Jesse Vincent
9f24ea2b03
minor code cleanup
2010-12-25 19:28:58 +00:00
Jesse Vincent
91ab617807
rename "hide buttons" to "scroll buttons" because that's what it does
2010-12-25 19:28:54 +00:00
Andrew Chen
77c01c65dd
Refactor network data blocking out of the main K9 class and into the MessageView class.
2010-12-25 01:26:47 +00:00
Jesse Vincent
f14c7ecd9b
doc & comment updates from achen.code
2010-12-25 00:27:09 +00:00
Jesse Vincent
c361c0e63c
Extract a method to set up our MessageView WebView
2010-12-25 00:27:05 +00:00
Jesse Vincent
1fae914efb
tiny doc update from achen.code
2010-12-25 00:26:59 +00:00
Jesse Vincent
db7649c9af
move folderlist initialization into an asynctask, so it's not so slow to populate
2010-12-24 22:48:29 +00:00
Jesse Vincent
b99eb47d15
extract folder preference setup to a method, so we can push it onto a thread
2010-12-24 22:48:26 +00:00
Jesse Vincent
4a97f4a1a0
astyle
2010-12-24 22:48:22 +00:00
Jesse Vincent
d64d9c460a
Disable webview cache and javascript. (Mail + Javascript == scary)
2010-12-24 22:48:17 +00:00
Jesse Vincent
9878b74379
astyle
2010-12-24 18:55:05 +00:00
Fiouz
64b5655d7c
Don't reference the enclosing type instance when it's not used (memory optimisation)
2010-12-14 19:26:31 +00:00
Fiouz
36858f53de
Don't reference the enclosing type instance when it's not used (memory optimisation)
2010-12-14 19:26:25 +00:00
Fiouz
9d01876481
Don't reference the enclosing type instance when it's not used (memory optimisation)
2010-12-14 19:26:18 +00:00
Fiouz
dcbfd332ab
Don't reference the enclosing type instance when it's not used (memory optimisation)
2010-12-14 19:26:09 +00:00
Fiouz
a667a72585
Don't reference the enclosing type instance when it's not used (memory optimisation)
2010-12-14 19:26:02 +00:00
Jesse Vincent
5e7257492d
small cleanups to messageview code
2010-12-13 01:56:57 +00:00