Daniel Applebaum
a5166e3c2d
Fixes Issue 963
...
MessagingController was calling the MessagingListener twice for
deleted messages. By the time the second call was made, some
Activities already had removed the message holder, so a null holder
was being put on the list.
This change should prevent the double calls, and adds protection
against have the MessageList MessagingListener called with a message
that is no longer in the MessageList.
Also, some logical cleanups.
2010-01-06 04:54:24 +00:00
Daniel Applebaum
2b37fe6864
Restore long-lost debugging line
2010-01-06 03:44:23 +00:00
Daniel Applebaum
29947ef3c9
Delete obsolete commented out code.
2010-01-06 03:40:24 +00:00
Jesse Vincent
a4510696aa
It turns out that blindly enabling/disabling views is _Very_ expensive.
...
Now we only do it when switching messageview entries if it's actually
necessary
2010-01-04 02:11:33 +00:00
Jesse Vincent
a926086f4b
Replace old message passing code with more modern runonuithread code
2010-01-04 02:06:40 +00:00
Daniel Applebaum
60a2ceb604
Fixes Issue 934 by removing excess calls to finish()
2010-01-04 00:50:19 +00:00
Daniel Applebaum
d58d1c60c0
Proper super call
2010-01-04 00:48:33 +00:00
Daniel Applebaum
c86a46deb1
Preparatory for more BroadcastReceivers
2010-01-04 00:47:11 +00:00
Daniel Applebaum
33495135ac
Respect account ring setting for notifications
2010-01-04 00:41:26 +00:00
Daniel Applebaum
41729af9b2
Add explicit ring setting for notifications
2010-01-04 00:40:41 +00:00
Jesse Vincent
6caec1100c
Incorrect (and ancient code) would accidentally clobber the wrong attachment
...
(and only one, rather than all) when deleting a message.
2010-01-03 23:23:13 +00:00
Jesse Vincent
483655fa20
Log.w shouldn't be wrapped in an "if debug" statement.
2010-01-03 20:34:22 +00:00
Jesse Vincent
6a8ea924c9
Further log cleanup
2010-01-03 02:07:21 +00:00
Jesse Vincent
eb54a99aab
EOLs got twisted by something. fixing
2010-01-03 02:07:14 +00:00
Jesse Vincent
0e273893bd
Further log tweaking
2010-01-03 02:00:20 +00:00
Jesse Vincent
a926911e7f
rerun astyle
2010-01-03 01:50:51 +00:00
Jesse Vincent
1c5073039a
Further debug/info/verbose logging cleanup
2010-01-03 01:50:41 +00:00
Jesse Vincent
875dc31d5a
Log message cleanup
2010-01-03 01:50:32 +00:00
Jesse Vincent
f9e8c877ff
Wrap looging in if (DEBUG) statements.
2010-01-03 01:50:25 +00:00
Jesse Vincent
953b784fb9
First pass at fixing Issue 963 (explosions when trying to iterate over a
...
remotely deleted message) introduced in r1204.
(Before my all-day meeting)
2009-12-29 17:06:13 +00:00
Jesse Vincent
fb6d11222a
Switch from old, scary message passing to more modern "run on ui thread" for Accounts.java
...
40 fewer lines of code.
2009-12-29 17:05:44 +00:00
Jesse Vincent
2ef3b15c87
make sure we don't accidentally open the context menu on a message when we're in multiselect mode.
2009-12-29 17:05:17 +00:00
Jesse Vincent
3e3b4d447d
Fix reversed color chip alpha
2009-12-28 12:56:59 +00:00
Daniel Applebaum
60b02909a3
Announce folder status changes when syncing gets updated unread count.
...
Adjust logging levels for folder sync.
2009-12-27 20:19:41 +00:00
Jesse Vincent
bbd9e56770
Actually display 250/500/1000 options for "number of messages to sync"
2009-12-27 17:47:30 +00:00
Jesse Vincent
794f515bc8
Numerous small fixes to search results
2009-12-27 17:22:57 +00:00
Jesse Vincent
a53e9d1b89
on search, only fire one start event and one end event
2009-12-27 17:22:51 +00:00
Jesse Vincent
6c383256a2
Remove duplicate code from onCompose. make starting message composition without an account actually work
2009-12-27 17:22:44 +00:00
Jesse Vincent
0a2d9b9c9f
make sure search results aren't updated incorrectly on incoming messages
2009-12-27 17:22:38 +00:00
Jesse Vincent
bfaba499fe
Fix the Search header on search results
2009-12-27 17:22:32 +00:00
Jesse Vincent
63b6f6bf62
Refactoring to better propagate "folder" along with messages as they're instantiated
2009-12-27 17:22:26 +00:00
Jesse Vincent
d60521f06f
further push down our "is this message for us" logic.
2009-12-27 17:20:56 +00:00
Jesse Vincent
6c7782b4bd
remove another alternate calling convention for addOrUpdateMessage. Code
...
will get still cleaner when we start propagating back message folders as objects
2009-12-27 17:20:50 +00:00
Jesse Vincent
c608ffb672
Eliminate a variant of addOrUpdateMessage that was only called once
2009-12-27 17:20:28 +00:00
Jesse Vincent
1c4a0be0da
enable searching of messages
2009-12-27 17:20:21 +00:00
Jesse Vincent
21238a3084
If we get a message from listLocalMessages and we're doing a search,
...
assume it's for us. Later, we may want to be smarter about that.
2009-12-27 17:20:13 +00:00
Jesse Vincent
a736a4267c
Only trigger our "loading" indicator if the account matches "our" account
2009-12-27 17:20:06 +00:00
Jesse Vincent
204289a4ff
when opening a message for display or edit, use its notion of account, not the folder's.
2009-12-27 17:19:56 +00:00
Jesse Vincent
f6756879ef
Temporarily disable "left-handed" controls if we're doing a search.
...
view configuration needs to move to be global for this to work right.
2009-12-27 17:19:49 +00:00
Jesse Vincent
bc61c90e1a
make the auto-open folder not trigger if we're doing a search
2009-12-27 17:15:46 +00:00
Jesse Vincent
81d72a2d8c
make the color chip genuinely calculated per message
2009-12-27 17:15:38 +00:00
Jesse Vincent
ed19a8284e
Propagate per-message account info into MessageInfoHolder and FolderInfoHolder
2009-12-27 16:54:23 +00:00
Jesse Vincent
302deea53e
addOrUpdateMessage calls now propagate the account of the found message
2009-12-27 16:54:12 +00:00
Jesse Vincent
3ad69c799d
When listing off messages, make sure that our "refresh the list" fires,
...
even if we didn't start off empty.
This could have prevented updated messages from showing up
2009-12-27 16:54:06 +00:00
Jesse Vincent
1b74c176a2
Add multi-account search to the MessagingController
2009-12-27 16:53:59 +00:00
Jesse Vincent
70f35a537e
If we loaded a message from the local store without an associated folder, load up its folder.
2009-12-27 16:53:51 +00:00
Jesse Vincent
da45b81866
minor query reformatting
2009-12-27 16:53:45 +00:00
Jesse Vincent
580a562085
Lift the generic getMessages and searchForMessages up to the "store"
...
level from the "folder" level so we can search for messages across
folders
2009-12-27 16:53:37 +00:00
Jesse Vincent
6dcb10add6
Lift our column list for "load messages" out to the LocalStore, as the
...
first part of lifting "get messages" out of "folder" for search
2009-12-27 16:53:31 +00:00
Jesse Vincent
ddd6db3a7c
Made our search activity actually exist
2009-12-27 16:53:24 +00:00
