Jesse Vincent
54633a4e16
Improvements to "more from this sender" - hopefully this should search
...
only on actual addresses, not their local parts.
2010-08-12 02:22:08 +00:00
Jesse Vincent
ece68bae5d
Off-by-one error in the recent IMAP fetch work :/
2010-08-12 02:21:56 +00:00
Jesse Vincent
de16b21124
Add debug logging when K-9 doesn't enable push because the user has
...
configured push to be off.
2010-08-11 03:36:49 +00:00
Jesse Vincent
0229d8a1fe
Implement windowing for IMAP UID FETCH
...
Our previous implementation of UID FETCH didn't ever take into account
maximum command line lengths. When fetching, say 800 messages from a
GMail IMAP server, we could easily overflow the max line length leading
to a fetch that didn't get all the messages we wanted to and was
truncated before the description of which fields we want. That caused
K-9 to fetch complete messages, exhaust memory and ultimately fail,
even when we were just trying to get message lengths.
An equivalent fix needs to be made to seach by UID.
2010-08-11 03:36:40 +00:00
Jesse Vincent
9ebf16e3d9
Finish removing the ThreadPool / ExecutorService Left over from when the
...
code was actually in the view class
2010-08-10 04:29:18 +00:00
Jesse Vincent
490ab6b8c0
Try harder to make message loading feel responsive and scroll correctly.
...
We're still not there.
2010-08-09 03:16:40 +00:00
Jesse Vincent
a724df79d4
To date, "loadMessageForView" competed for threads in a thread pool with
...
all of our mail syncing code. This led to very choppy UI experience.
This change doesn't entirely fix message load lag, but the _worst case_
I see is now better than the best case I saw last week.
2010-08-08 23:49:27 +00:00
cketti
2e6a67c2a7
Better text filter for ChooseFolder (folder is displayed if search term is found anywhere in the folder name, not just at the beginning)
...
Heavily based on a patch provided by Marcus.Wolschon
Fixes issue 2098
2010-08-08 20:27:39 +00:00
Jesse Vincent
1f725a2d5c
increment the new message count if the message is in a notifiable folder
...
and the account wants notifications. (even if we don't
notify for a message from ourselves, we DO increase the notification
count.)
2010-08-08 19:43:01 +00:00
Jesse Vincent
ce9a84e8fd
Quick updates from a code review pass by cketti
2010-08-08 19:35:18 +00:00
Jesse Vincent
d2e3061f20
Lift our initial unread counter up higher so that it happens before
...
called code starts resetting the unread count again.
2010-08-08 19:14:52 +00:00
Jesse Vincent
06a3d5985b
Avoid allocating two temp variables on sync
2010-08-08 19:14:47 +00:00
Jesse Vincent
f5a399f6c6
extract out "should we notify" from "notify";
...
rather than calculating the number of pre-existing new messages for this
sync twice, do it once, a bit earlier.
2010-08-08 18:50:31 +00:00
cketti
43fb202d43
Fixes issue 1522
...
Added option to automatically show images in message view (always, if sender is in contacts, never).
Patch by paulkilroy (thanks!)
Includes bugfix for the "Show pictures" on orientation change code introduced earlier.
2010-08-07 22:38:08 +00:00
cketti
9d45470b40
Fixes issue 1076
...
Remember "Show pictures" button state when changing orientation.
2010-08-07 21:37:57 +00:00
cketti
5c588992a0
Fixes Issue 2076
...
Remove german version of the "Re:" prefix when replying to messages. So instead of "Re: AW: subject" we get "Re: subject".
2010-08-07 19:25:47 +00:00
Fiouz
dfb8f9e0f2
Memory management optimisation: help garbage collection by avoiding repeated instantiations of immutable arrays (empty arrays of String, Message, Flag, Address)
2010-08-07 15:10:07 +00:00
Thialfihar
54e0ad5ce0
added some comments to explain some cryptography-related classes and to-dos
2010-08-05 10:55:59 +00:00
Thialfihar
11e28698e1
hide the decrypt signature layout in MessageView if no signature exists, fixes the wrong display of signatures from another message
2010-08-05 10:45:58 +00:00
Fiouz
380452355c
MessageListAdapter:
...
- Use of a single View.OnClickListener for all messages.
- Extracted method to bind message item views (from MessageInfoHolder to MessageViewHolder).
2010-08-03 07:46:31 +00:00
Fiouz
ad9c315cf4
No longer need to extend Handler since r1126: we're using Activity.runOnUiThread()
2010-08-03 06:09:39 +00:00
Fiouz
2a476dc92c
Additional @Override compile check
2010-08-03 05:46:35 +00:00
Jesse Vincent
f15101420e
Revert "I like this idea, but it's not ready for 3.000"
...
This reverts commit f812a3485445c7db4024f84865aaa5d8e6b7b3a0.
(Now that 3.0 is branched, this can be on trunk again for further work)
2010-08-02 22:34:21 +00:00
Jesse Vincent
58c5afc77b
I like this idea, but it's not ready for 3.000
...
Revert "It turns out that a big part of our perceptible message switching time"
This reverts commit 06f9bb5b7f3064e646b43148d188cec06cd14d11.
2010-08-02 22:32:57 +00:00
Fiouz
44cef83e0b
Use of constants for immutable empty arrays (prevent useless memory allocation)
2010-08-02 11:55:31 +00:00
Jesse Vincent
d4695636f3
It turns out that a big part of our perceptible message switching time
...
was loading the "loading..." file into the WebView. Since it doesn't
take that long to load the real content, replacing the "Loading..." file
with "blank the view" seems to actually feel a heck of a lot faster.
2010-08-02 03:03:58 +00:00
Jesse Vincent
f2729fc58b
Don't show "To: " if the only recipients were ccs and bccs.
2010-08-02 03:03:53 +00:00
Jesse Vincent
cd6b64d88f
Experimental changes to tell WebView that the HTML versions of messages
...
we generate from ascii are "mobile-optimized"
2010-08-02 01:27:50 +00:00
Jesse Vincent
d78e7a0d69
Switch from the incomplete (but compatible with java 1.3) mime4j charset
...
alias resolver to the core java nio version with a better charset
database;
rather than falling back to not showing the user a failing message, fall
back to showing the user the message as ascii -- it makes it possible
to get _something_ out of an unknown-charset message, rather than just a
"ha ha. no." error.
2010-08-02 01:27:46 +00:00
Jesse Vincent
7fc921c0b7
astyle
2010-08-02 01:27:40 +00:00
Jesse Vincent
a4381696f9
Support Emoji for DoCoMo.
...
Emoji icons are derived from http://start.typepad.jp/typecast/
2010-08-02 01:24:40 +00:00
Fiouz
3bbb6ae050
Don't display Archive/Spam batch operations when corresponding folders are unset
2010-07-30 09:58:26 +00:00
Jesse Vincent
d8a73b195d
Factor out the decision about whether a part is "viewable" for purposes
...
of fetching ; remove broken "inline" check from the same.
2010-07-30 00:58:33 +00:00
cketti
0c67f1f4cf
Only ask for POP3 capabilities before authorization if TLS should be used. Always ask after authorization.
2010-07-30 00:58:22 +00:00
cketti
91e55f6fa1
Don't log POP3 passwords by default.
2010-07-30 00:53:46 +00:00
Jesse Vincent
d8a757faaf
Try to avoid a bunch of reallocations as we grow the temporary output stream by defining its size if we can get it
2010-07-29 22:17:35 +00:00
Jesse Vincent
134c0b23dd
Backport a bit of memory efficiency I'm not sure I believe from AOSP
2010-07-29 22:17:32 +00:00
Jesse Vincent
0bb115ca42
Actually catch an OOM in getTextFromPart
...
Backport an update to getTextFromPart from AOSP as of 290348 - dealing with OOM as we import large messages
2010-07-29 22:17:29 +00:00
Jesse Vincent
c6aa505ffe
improve the method docs on getTextFromPart
...
Backport an update to getTextFromPart from AOSP as of 290348 - dealing with OOM as we import large messages
2010-07-29 22:17:26 +00:00
cketti
4c1060ecae
Only show "save or discard" dialog before leaving the message compose activity if the message needs saving.
2010-07-28 23:17:46 +00:00
Thialfihar
3d5fb524ef
set account setting crypto app to "APG" by default
2010-07-28 21:28:51 +00:00
Thialfihar
5e30c3dab1
removed two extra lines from the merge in r2055
2010-07-28 12:10:08 +00:00
Jesse Vincent
2ca76e3db0
Fix for Issue 1956
...
A race condition made the outgoing certificate being compared to the old
incoming mHost,
throwing an exception with an untrusted certificate dialogue to accept
or decline.
2010-07-27 18:59:41 +00:00
Jesse Vincent
7a4d12b53b
Merge from apg-integration
2010-07-27 12:10:09 +00:00
Jesse Vincent
bae8a9736d
Clean up some inverted logic
2010-07-27 01:28:03 +00:00
Jesse Vincent
b1fb92034a
clean up some weird inverted logic (as recommended by intellij)
2010-07-27 01:27:54 +00:00
Jesse Vincent
c541a07ed2
Don't fire off a notification about new mail before we finish
...
initializing an account.
2010-07-27 01:27:45 +00:00
Jesse Vincent
766a115155
Remove URLs from message previews. Suggested by Kevin Falcone
2010-07-24 02:09:12 +00:00
Jesse Vincent
19a06d39a1
With all the other performance work we've been doing, getting a message
...
into the messagelist is now much, much faster. Intentionally loading the
whole mailbox before we let the user interact with the list is
increasingly painful. A 250 message mailbox takes 2+ seconds to "unlock"
on a modern phone.
Consequently, this commit switches us _back_ to progressive loading of
mailboxes from the synchronous version.
Based on user feedback, we may or may not keep this for the production
release.
2010-07-22 04:17:13 +00:00
Jesse Vincent
80e134c03c
astyle
2010-07-22 03:40:30 +00:00