cketti
d3baa299f1
Use "reply after quoted text" value when editing drafts
2011-10-27 08:20:03 +02:00
Sven-Hendrik Haase
f4f726ae67
Fixed restoring drafts saved with "reply after quoted text" enabled
...
Fixes issue 2568
2011-10-27 07:23:01 +02:00
Andrew Chen
b6cdec43e9
Merge pull request #73 from andrewgaul/address-parse-npe
...
Fix NPE in Address.Parse
2011-10-26 18:15:40 -07:00
Andrew Gaul
ad5676ed28
Fix NPE in Address.Parse
...
Found by FindBugs. Also avoid an allocation in the uncommon case.
2011-10-25 21:24:38 -07:00
Andrew Gaul
e394924ce4
Prefer Random.nextInt over Math.random
...
Addresses a FindBugs complaint.
2011-10-25 21:21:23 -07:00
cketti
ae465789b7
Export default value for keys not found in preference storage
2011-10-26 05:13:22 +02:00
Andrew Gaul
a2d0f9ccb7
Remove unused literal methods
2011-10-25 13:56:07 -07:00
Andrew Gaul
844db81b8d
Optimize Utility.combine for length 1 arguments
2011-10-25 13:10:47 -07:00
Jesse Vincent
ae3f098b4a
Merge pull request #64 from andrewgaul/typesafe-set
...
Avoid type-unsafe Set
2011-10-20 05:34:48 -07:00
Jesse Vincent
ea384b40a1
Merge pull request #66 from andrewgaul/redundant-combine-flags
...
Remove duplicated combine flags code
2011-10-20 05:33:37 -07:00
Andrew Gaul
4c5f2e59a0
Remove unused Utility.readInputStream
...
Consider IOUtils.toString instead.
2011-10-19 23:11:03 -07:00
Andrew Gaul
5b9f542bd7
Avoid type-unsafe Set
2011-10-19 23:05:34 -07:00
Andrew Gaul
ce4b42f66b
Remove duplicated combine flags code
2011-10-19 22:04:57 -07:00
Andrew Gaul
80d9246130
Prefer unsynchronized Collection types
2011-10-19 21:56:20 -07:00
cketti
afd355f83c
Use Preferences.getAvailableAccounts() where appropriate
2011-10-18 05:09:20 +02:00
cketti
4d6946f47c
Start services and list folders after account has been activated
2011-10-18 05:06:32 +02:00
cketti
dd8cd33c5a
Fixed decoding of store URIs with empty passwords
2011-10-18 05:05:40 +02:00
cketti
9fa802afe2
Validate file format version and content version of settings file
2011-10-18 01:30:41 +02:00
cketti
e7ad0e296e
Validate account UUID on import
2011-10-17 23:33:32 +02:00
cketti
6b5b4e474e
Fixed store URI encoding/decoding in Pop3Store
2011-10-17 05:59:36 +02:00
cketti
d87e25dde1
Added new authentication methods to SmtpTransport.createUri()
2011-10-17 04:57:01 +02:00
cketti
75dc38a1c4
Added new settings to GlobalSettings
2011-10-17 04:52:33 +02:00
cketti
f08b1ef739
Added new settings to AccountSettings
2011-10-17 04:34:26 +02:00
cketti
3967654a3e
Show short message when moving accounts
2011-10-17 04:34:26 +02:00
cketti
52a92d93a1
Add dialog to ask for server passwords after import
2011-10-17 04:34:26 +02:00
cketti
849a4e37a0
Mark accounts as disabled on import
...
If the settings file doesn't contain passwords for the incoming and
outgoing servers we disable those accounts.
2011-10-16 19:24:31 +02:00
cketti
fc8d2e9979
Merge branch 'master' into issue549
...
Conflicts:
res/menu/accounts_context.xml
res/menu/accounts_option.xml
res/values/strings.xml
src/com/fsck/k9/Account.java
src/com/fsck/k9/activity/Accounts.java
src/com/fsck/k9/activity/AsyncUIProcessor.java
src/com/fsck/k9/activity/FolderList.java
src/com/fsck/k9/activity/ImportListener.java
src/com/fsck/k9/activity/K9Activity.java
src/com/fsck/k9/activity/K9ListActivity.java
src/com/fsck/k9/activity/MessageView.java
src/com/fsck/k9/mail/store/ImapStore.java
src/com/fsck/k9/mail/store/Pop3Store.java
src/com/fsck/k9/mail/store/WebDavStore.java
src/com/fsck/k9/mail/transport/SmtpTransport.java
2011-10-14 20:33:25 +02:00
cketti
effb45c463
Cleaned up success message after settings import
2011-10-14 06:19:30 +02:00
cketti
f5e684310e
Renamed StorageImportExportException to SettingsImportExportException
2011-10-14 06:00:10 +02:00
cketti
c835bb757a
Renamed StorageImporter to SettingsImporter
2011-10-14 05:58:55 +02:00
cketti
cf8bdef0a8
Renamed StorageExporter to SettingsExporter
2011-10-14 05:58:15 +02:00
cketti
0ae176bab3
Code/documentation cleanup. No functional changes.
2011-10-14 05:54:23 +02:00
cketti
470ba8bb03
Removed everything related to settings file encryption
...
The plan is to (re)add this feature later. With a proven method to
encrypt files; maybe OpenPGP.
2011-10-14 05:38:27 +02:00
cketti
fd16ff8fe6
Remove reference to NonConfigurationInstance when no longer needed
2011-10-14 04:15:45 +02:00
cketti
5b81dbc2ed
Use resource strings instead of hardcoding things
2011-10-14 03:42:04 +02:00
cketti
b146fcb2fd
Improved handling of object retention on configuration changes
2011-10-14 02:52:32 +02:00
cketti
b05750c245
Better input validation in *Store.createUri()
2011-10-13 02:35:08 +02:00
ashley willis
2058fc378d
Option to show next message after delete by default instead of previous.
2011-10-12 17:50:24 +02:00
cketti
a258415629
Merge pull request #60 from andrewgaul/builder-append-no-concatenation
...
Avoid concatenation in StringBuilder append
2011-10-12 08:28:32 -07:00
cketti
c34d896474
Merge pull request #59 from andrewgaul/immutable-sets
...
Make sets immutable
2011-10-12 08:26:43 -07:00
Marcus Wolschon
4c8ebb4bcd
added check for Null
2011-10-11 08:53:51 +02:00
cketti
7a9c747db9
Don't export incoming/outgoing server passwords
2011-10-11 03:12:18 +02:00
cketti
1de28150e2
Require accounts to at least have one identity when importing
2011-10-09 01:23:45 +02:00
cketti
13b74d0d9e
Added error logging
2011-10-09 01:14:59 +02:00
cketti
d791770154
Code cleanup
2011-10-09 00:31:33 +02:00
cketti
6714a7ec5a
Improved logging in StorageImporter
2011-10-09 00:04:00 +02:00
cketti
1ab7dbae54
Added input validation for folder settings
2011-10-08 21:30:45 +02:00
cketti
f21e14afc7
Added input validation for identity settings
2011-10-08 17:58:57 +02:00
cketti
060d21db3e
Make collections immutable
2011-10-07 21:20:12 +02:00
cketti
0920b0c14d
Changed the way SettingsDescription is used
...
Added ability to rewrite the string representation used internally to
something "pretty" on export.
Now only settings that have entries is GlobalSettings and
AccountSettings are exported. This prevents export of newer settings
that are left in the preference storage when downgrading.
2011-10-07 20:29:03 +02:00
Andrew Gaul
57be9e3ee3
Make sets immutable
...
Use final and unmodifiable and avoid anonymous inner classes.
2011-10-06 20:22:18 -07:00
Andrew Gaul
9b27aba2ba
Avoid concatenation in StringBuilder append
2011-10-06 09:20:11 -07:00
cketti
2e2428b093
Merge pull request #55 from andrewgaul/stringbuilder
...
Prefer StringBuilder over StringBuffer
2011-10-06 09:04:43 -07:00
cketti
31af4526ab
Merge pull request #58 from andrewgaul/spelling
...
Spelling corrections
2011-10-06 09:01:37 -07:00
Andrew Gaul
220e55603d
Spelling corrections
2011-10-05 22:04:39 -07:00
Andrew Gaul
dad0332667
Make an inner class static
2011-10-05 22:01:53 -07:00
Andrew Gaul
47eb0fa2e1
Prefer StringBuilder over StringBuffer
...
The former is unsynchronized and slightly faster.
2011-10-05 21:50:31 -07:00
cketti
83ee4253d5
Whitelist settings for export instead of blacklisting keys
...
Use GlobalSettings.SETTINGS an AccountSettings.SETTINGS to decide
which settings to export.
2011-10-04 05:13:17 +02:00
cketti
644571cfe5
Make sure the InputStream of the import file is always closed
2011-10-04 00:48:43 +02:00
cketti
f2a3752930
Added constants for (export) file format version and "settings version"
2011-10-04 00:09:38 +02:00
cketti
33ae5ff7d0
Added code to skip some account settings on export
2011-10-03 20:16:02 +02:00
cketti
0619eaf79c
Catch NumberFormatException when parsing disposition size parameter
...
Fixes issue 3712
2011-10-01 21:17:00 +02:00
cketti
88dc36da8a
Added a check to prevent an ArrayIndexOutOfBoundsException
...
Fixes issue 3683
2011-10-01 20:30:22 +02:00
cketti
dfa97cd878
Handle activity restarts due to configuration changes
...
Close existing dialogs before the activity is destroyed. Recreate them
and rewire AsyncTasks to the new activity instance after its creation.
2011-10-01 20:11:14 +02:00
cketti
6e1bf2965d
Fixed DateFormatValidator to handle placeholders SHORT and MEDIUM
2011-09-30 16:54:01 +02:00
cketti
cd72e197ec
Added code to skip certain settings on export
2011-09-30 16:47:59 +02:00
cketti
c76bec971b
Fixed compiler warning
...
Use new variable instead of overwriting an argument.
2011-09-30 14:58:13 +02:00
Jesse Vincent
defabdc20c
Additional service fixes from the original author of the issue 2777 fix
...
to stop the service from being shutdown when we have push enabled
2011-09-29 00:16:27 -04:00
Jesse Vincent
fd61b4f20b
Merge pull request #52 from andrewgaul/peekable-bad-offset
...
Fix bad offset in PeekableInputStream
2011-09-28 21:10:41 -07:00
Andrew Gaul
7cf1bfcc98
Fix bad offset in PeekableInputStream
2011-09-20 21:21:50 -07:00
Koji Arai
f3795f3df5
Search same sender from searchable folders instead of the unified inbox
2011-09-16 01:33:51 +09:00
Andrew Chen
dd1334b874
Add some JavaDoc to SearchAccount stuff; astyle.
2011-09-12 15:08:34 -07:00
Jesse Vincent
cbaa9f5b3d
Work around cases where mail was last checked in the future.
...
Sometimes, user devices will have their clock misset. Previously, K-9
would just stop checking mail until the device caught up with the
future.
2011-09-05 22:16:04 -04:00
danapple
7d5bb99dbd
Add progress indicator during account move.
2011-09-05 12:45:53 -05:00
danapple
2867a90286
Disable account move menu items when account is at an end of the list.
...
Conflicts:
src/com/fsck/k9/activity/Accounts.java
2011-09-05 12:45:33 -05:00
danapple
06cabdbde1
Working version of moving accounts within the Accounts view.
2011-09-05 12:38:03 -05:00
danapple
c67ac4735f
Fixes Issue 3177
...
Dynamically update the FolderList titlebar when the unread state of a
listed folder changes. This implementation applies the folder unread
count delta to the account-level unread count, to avoid the expense of
recomputing the entire account's unread count. If no FolderInfoHolder
for this folder already exists, skip the recomputation of the
account-level unread message count.
2011-09-05 11:20:57 -05:00
Jesse Vincent
50e6218c1d
Merge pull request #49 from senab/master
...
Expose SenderAddress through ContentProvider. Issue: 3665
2011-09-04 18:44:08 -07:00
Jesse Vincent
8223e4d4bf
Removed some doc annotations from chrisk's fix for the service stopping
...
issue (2777)
2011-09-04 16:13:19 -04:00
Christian Knecht
7cd6334c64
Stop service(s) if not in use - Fixes Issue 2777
2011-09-04 16:00:02 -04:00
Jesse Vincent
1b7481f854
optimize cketti's pop3 space-splitting code to not make lots of extra
...
copies of responses.
2011-09-04 15:53:12 -04:00
Chris Banes
b002f3178b
Move Sender Address to end of Default Projection
2011-09-02 11:33:20 +01:00
Chris Banes
caa02b16eb
Expose SenderAddress through ContentProvider. Issue: 3665
2011-09-01 11:57:06 +01:00
cketti
f6a647d7b0
Cosmetic changes
2011-08-31 02:17:45 +02:00
cketti
e9e9d5afcb
Removed unused method
2011-08-31 02:12:01 +02:00
cketti
dfc370c057
Merge pull request #42 from jca02266/wip-fix-activity-switching-for-message-view
...
Fix for message list opening the wrong message view
Fixes issue 3592
2011-08-30 17:09:11 -07:00
Andrew Chen
16c1f9c35b
Add the remaining two return receipt headers upon request.
2011-08-28 16:08:41 -07:00
Jesse Vincent
1ac652dc5f
Small bug introduced during a refactoring "Extracted POP3 commands and capabilities to constants" introduced a typo that broke interactions wit some POP3 servers.
2011-08-28 18:28:12 -04:00
Jesse Vincent
a1378789b2
Merge pull request #48 from rpimonitrbtch/master
...
Loosened the restrictions on the TLD to support custom private TLD's, as well as single label hostnames.
Resolves Issue 2784: Cannot set server hostname
2011-08-28 12:48:10 -07:00
rpimonitrbtch
bdcb19e344
Issue 2784: Cannot set server hostname
...
Loosened the restrictions on the TLD to support custom private TLD's, as well as single label hostnames. Removed the localhost and localhost.localdomain exceptions, as they are now redundant.
2011-08-28 15:24:52 -04:00
Alessandro Russo
f5c679fb95
Added support for requesting read receipts
2011-08-27 20:46:04 -04:00
Adam
be1be56e3a
Fixed bug where uid in response was truncated
...
The SAX parser returns chunks of text to the
WebDavHandler. Other tags were correctly appending
values while the special cased <uid> tag was
simply assigned the value it was given, which would
result in the last chunk assigned to it and not
the whole string of text.
2011-07-28 15:08:00 -04:00
Jesse Vincent
3679b31b12
Workaround for market-reported error:
...
java.lang.Error: org.apache.james.mime4j.io.MaxHeaderLimitException: Maximum header limit exceeded
at com.kaitenmail.mail.internet.MimeMessage.parse(MimeMessage.java:85)
at com.kaitenmail.mail.store.Pop3Store$Pop3Message.parse(Pop3Store.java:932)
at com.kaitenmail.mail.store.Pop3Store$Pop3Folder.fetchBody(Pop3Store.java:714)
at com.kaitenmail.mail.store.Pop3Store$Pop3Folder.fetch(Pop3Store.java:579)
at com.kaitenmail.controller.MessagingController.downloadSmallMessages(MessagingController.java:1562)
at com.kaitenmail.controller.MessagingController.downloadMessages(MessagingController.java:1288)
at com.kaitenmail.controller.MessagingController.synchronizeMailboxSynchronous(MessagingController.java:1031)
at com.kaitenmail.controller.MessagingController.access$400(MessagingController.java:81)
at com.kaitenmail.controller.MessagingController$8.run(MessagingController.java:823)
at com.kaitenmail.controller.MessagingController.run(MessagingController.java:276)
at java.lang.Thread.run(Thread.java:1096)
Caused by: org.apache.james.mime4j.io.MaxHeaderLimitException: Maximum header limit exceeded
at org.apache.james.mime4j.stream.AbstractEntity.parseField(AbstractEntity.java:153)
at org.apache.james.mime4j.stream.MimeEntity.advance(MimeEntity.java:120)
at org.apache.james.mime4j.stream.MimeTokenStream.next(MimeTokenStream.java:351)
at org.apache.james.mime4j.parser.MimeStreamParser.parse(MimeStreamParser.java:179)
at com.kaitenmail.mail.internet.MimeMessage.parse(MimeMessage.java:83)
... 10 more
2011-07-25 01:49:42 -04:00
Jesse Vincent
7b7601082b
the refactoring to combine batch and record logic added an extra check
...
that broke delete of single messages from message list.
2011-07-23 18:45:43 -04:00
Koji Arai
fda43206a3
Fixed the below issue for GalaxyS and S2.
...
When scrolling a ListView, all items turn black.
it was reproduced on FolderList, MessageList and Accounts, other views were not.
2011-07-20 22:13:20 +09:00
Jesse Vincent
0543183b11
Work around a weird NPE in WebDAV sync reported by Jon Blow
2011-07-19 22:43:32 -04:00
Koji Arai
8d264b159e
Workaround for below issue.
...
1. Show a message in MessageView.
2. Press HOME button to back home.
3. Re-launch the K-9 and select another message.
4. Show first selected message.
See also: https://github.com/k9mail/k-9/commit/fix_activity_stack
2011-07-18 00:59:30 +09:00
cketti
2acd55a9ef
Implemented work-around to handle malformed UIDL responses (POP3).
...
Fixes issue 3546
2011-07-17 14:37:21 +02:00
cketti
9f581cb6f3
Extracted POP3 commands and capabilities to constants
2011-07-17 14:13:04 +02:00
Koji Arai
45e29ccba4
Fixed issue 3530.
...
Should not HTMLify the message when it is sent without quoted message.
The problem is:
1. set MessageFormat in Account setting to the TEXT.
2. reply a message without quoted text.
3. it is sent with HTML tags.
2011-07-17 08:56:28 +09:00