Jesse Vincent
7623a02852
lift the "get display text" code out of the messageview and into
...
localmessage
2010-12-28 09:07:39 +00:00
Jesse Vincent
84f6e546d2
setLoadPictures sets mShowPictures. We don't need to set it again
2010-12-28 09:07:19 +00:00
Jesse Vincent
f292251b78
lift createUniqueFile to a Utility class
2010-12-28 09:06:57 +00:00
Jesse Vincent
570dbf7126
split apart onCreate into bite-sized pieces
2010-12-26 03:51:33 +00:00
Jesse Vincent
43e3e860f8
doc fix
2010-12-26 03:49:52 +00:00
Jesse Vincent
d352b8a4a5
whitespace
2010-12-26 03:49:23 +00:00
Jesse Vincent
f2b2fddd5a
onRefile removes code duplication
2010-12-26 03:49:20 +00:00
Jesse Vincent
db02383d4a
whitespace cleanups
2010-12-26 03:49:16 +00:00
Jesse Vincent
8488b55e09
remove some duplicated code
2010-12-26 03:49:13 +00:00
Jesse Vincent
8c6df94739
remove some temp variables
2010-12-26 03:49:09 +00:00
Jesse Vincent
877427f110
cut down a couple overly verbose conditionals
2010-12-26 03:49:06 +00:00
Jesse Vincent
daf5a9d704
lift emulateShiftHeld to our custom WebView subclass
2010-12-25 22:30:34 +00:00
Jesse Vincent
8e2e4e515f
simplify MessageView's setHeaders
2010-12-25 22:30:31 +00:00
Jesse Vincent
8b52aac135
remove unused imports
2010-12-25 22:30:27 +00:00
Jesse Vincent
76fd8e9939
extract animation code from MessageView
2010-12-25 22:30:22 +00:00
Jesse Vincent
5f9eae1580
Extract MessageWebView specific code into a new class
2010-12-25 22:30:16 +00:00
Jesse Vincent
ea4e0aa61f
remove a bunch of extraneous code and variables
2010-12-25 19:29:02 +00:00
Jesse Vincent
9f24ea2b03
minor code cleanup
2010-12-25 19:28:58 +00:00
Jesse Vincent
91ab617807
rename "hide buttons" to "scroll buttons" because that's what it does
2010-12-25 19:28:54 +00:00
Andrew Chen
77c01c65dd
Refactor network data blocking out of the main K9 class and into the MessageView class.
2010-12-25 01:26:47 +00:00
Jesse Vincent
f14c7ecd9b
doc & comment updates from achen.code
2010-12-25 00:27:09 +00:00
Jesse Vincent
c361c0e63c
Extract a method to set up our MessageView WebView
2010-12-25 00:27:05 +00:00
Jesse Vincent
4a97f4a1a0
astyle
2010-12-24 22:48:22 +00:00
Jesse Vincent
d64d9c460a
Disable webview cache and javascript. (Mail + Javascript == scary)
2010-12-24 22:48:17 +00:00
Jesse Vincent
9878b74379
astyle
2010-12-24 18:55:05 +00:00
Fiouz
64b5655d7c
Don't reference the enclosing type instance when it's not used (memory optimisation)
2010-12-14 19:26:31 +00:00
Jesse Vincent
5e7257492d
small cleanups to messageview code
2010-12-13 01:56:57 +00:00
Jesse Vincent
063bbb904f
Extract SizeFormatter into helpers
2010-12-13 01:02:39 +00:00
Jesse Vincent
23b57b4502
remove a duplicated and divergent size formatter
2010-12-13 01:02:35 +00:00
Jesse Vincent
2451dde1bc
simplify our "should we animate" checks in messageview (also, we now
...
honor the animation preference when using the volume keys to navigate)
2010-12-13 00:37:31 +00:00
Jesse Vincent
76b6fa696b
Move the ToggleScrollView into the view/ hierarchy
2010-12-13 00:17:54 +00:00
Jesse Vincent
f97d4289ca
Start moving custom views into the view/ hierarchy
2010-12-13 00:17:44 +00:00
Jesse Vincent
f5eb6e03af
astyle
2010-12-01 06:32:29 +00:00
Jesse Vincent
c79ea226a5
Remove "throws" declarations that didn't actually get thrown. Remove a
...
couple of try blocks that only caught throws we didn't throw. IntelliJ
optimization.
2010-12-01 03:02:13 +00:00
Jesse Vincent
43d9c0a6d4
Eliminate some redundant assignments
2010-12-01 03:00:36 +00:00
Jesse Vincent
1ce9021ecd
Fix pinch-to-zoom. Patch by achen.code. Fixes isue 2720
2010-11-30 01:42:00 +00:00
Jesse Vincent
f9981dcf7c
lift hasAttachments to LocalMessage
2010-11-27 04:02:56 +00:00
Jesse Vincent
14055691a3
Merge branch 'mail-on-sd'
...
* mail-on-sd: (40 commits)
Added more comments to explain how the locking mecanism works for LocalStore
Fixed wrong method being called during experimental provider initialization (since provider isn't enabled, that didn't harm)
Add more comments about how the various StorageProviders work and how they're enabled
find src/com/fsck/ -name \*.java|xargs astyle --style=ansi --mode=java --indent-switches --indent=spaces=4 --convert-tabs
French localization for storage related settings
Remove unused SD card strings (replaced with storage indirection)
Merge mail-on-sd branch from trunk
Reset mail service on storage mount (even if no account uses the storage, to be improved)
find src/com/fsck/ -name \*.java|xargs astyle --style=ansi --mode=java --indent-switches --indent=spaces=4 --convert-tabs
Migraion -> Migration
move the Storage location preference into preferences rather than the wizard.
Made LocalStore log less verbose Added @Override compile checks
Added ACTION_SHUTDOWN broadcast receiver to properly initiate shutdown sequence (not yet implemented) and cancel any scheduled Intent
Be more consistent about which SQLiteDatabase variable is used (from instance variable to argument variable) to make code more refactoring-friendly (class is already big, code extraction should be easier if not referencing the instance variable).
Added transaction timing logging
Factorised storage lock/transaction handling code for regular operations.
Use DB transactions to batch modifications (makes code more robust / could improve performances)
Merge mail-on-sd branch from trunk
Update issue 888 Added DB close on unmount / DB open on mount
Update issue 888 Back to account list when underlying storage not available/unmounting in MessageView / MessageList
...
2010-11-13 21:40:56 +00:00
cketti
5b88a99de0
Got rid of some compiler warnings.
2010-11-04 03:11:34 +00:00
Jesse Vincent
b9999878df
We care about eclair MR1, not eclair
2010-11-03 00:44:07 +00:00
Jesse Vincent
7db384fc08
Use a more backward compatible os version check, since the "current"
...
best practice is incompatible with 1.5
2010-10-29 22:35:27 +00:00
Jesse Vincent
e0d6a55d06
SINGLE_COLUMN layouts cause Android 1.0-2.1 to segfault.
2010-10-29 22:35:19 +00:00
Jesse Vincent
c216f42eb3
Exchange authenticaton and setup overhaul from Kris Wong
2010-10-24 01:03:29 +00:00
Jesse Vincent
62caa5ce76
Experimental change - ask android to try to make columns no wider than
...
the viewport. This change should NOT be backported to 3.2, but I'd like
folks to try it with real email.
2010-10-23 18:50:54 +00:00
Jesse Vincent
43cb54594b
Push the webview's renderpriority from NORMAL to HIGH - it's cargo-cult
...
performance improvement, but it certainly doesn't hurt
2010-10-23 18:50:24 +00:00
Jesse Vincent
e8756af4f1
astyle
2010-10-21 20:49:20 +00:00
Jesse Vincent
d07aca3008
"Preferences" -> "Settings" for consistency
2010-10-11 14:54:23 +00:00
Jesse Vincent
c5d68fb49d
Add preferences to enable pinch-to-zoom and single-column layout for
...
messages
2010-10-11 14:54:15 +00:00
cketti
7028a4c167
Fixes issue 2144
...
- Removed the contact names cache (memory leak)
- Changed Contacts.searchByAddress() to Contacts.getNameForAddress(). Cursor is now immediately closed.
- Only try to resolve contact names when "Global settings" -> "Show contact name" is checked
- Never resolve contact names if number of recipients exceeds a threshold
2010-10-09 00:24:43 +00:00
Jesse Vincent
6061c42ea9
find src/com/fsck/ -name \*.java|xargs astyle --style=ansi --mode=java --indent-switches --indent=spaces=4 --convert-tabs
2010-10-05 06:04:28 +00:00
Fiouz
9b285ae3fc
Fixes issue 939
...
Heavily inspired from Gmail implementation. Currently implemented only for MessageView delete operation.
2010-09-01 20:59:09 +00:00
Koji Arai
842a5ee123
Update issue 2144
...
Use setSpan() instead of Html.fromHtml()
Should clear cached name of contacts at MessageView#onClickSender().
2010-09-01 01:35:20 +00:00
Jesse Vincent
7030967fa7
astyle
2010-08-31 03:58:33 +00:00
Jesse Vincent
db1b86a296
Better visibility toggling as k-9 switches between messages in
...
MessageView
2010-08-31 03:55:30 +00:00
Koji Arai
b1074329e4
On the MessageList and the MessageView, prefer to use the display name registered in the Contacts rather than raw addresses.
...
Update issue 2144
2010-08-30 14:37:34 +00:00
Jesse Vincent
4bf233fba5
next and previous were reversed from K-9's standard interpretation of
...
them in the previous patch to add volume button navigation
2010-08-30 03:05:41 +00:00
Jesse Vincent
65f0d22355
Add Volume button navigation in MessageView, MessageList and all
...
K9ListActivity subclasses.
The MessageView code is a patch from paulkilroy@gmail.com .
Fixes Issue 2112
2010-08-30 02:16:20 +00:00
Jesse Vincent
4f0bce1569
Simplify many, many boolean conditions with help from IntelliJ
2010-08-29 23:39:26 +00:00
Thialfihar
a93da0ed80
decoupled PgpData from CryptoProvider, moved the crypto provider into Account
2010-08-22 09:51:17 +00:00
cketti
df0ae4e4bf
Update Issue 2168
...
Respect "Return to list after delete" after pressing on "Archive", "Move", or "Spam" button.
TODO: Change strings to reflect this change (e.g. "Return to list after move/delete")
2010-08-19 03:14:27 +00:00
Jesse Vincent
ff5024eaec
astyle
2010-08-18 02:48:55 +00:00
Jesse Vincent
86dc82f916
Merge branch 'ideal-screenreader'
...
* ideal-screenreader:
The IDEAL Group have joined the K-9 dogwalkers and submitted their code to be part of K-9!
Initial import of the Ideal K-9 branch which adds support for screenreaders.
2010-08-18 02:01:10 +00:00
cketti
da90792fa7
Don't call MimeUtility.unfoldAndDecode() on the message body when scanning for external image references. Also cleaned up the code a bit.
2010-08-15 04:05:39 +00:00
Jesse Vincent
73c3872dd0
Improve our display of inline images in HTML mail to not also offer
...
themselves up for download.
To do so, we need to start storing the original content-id and
content-disposition for attachments - this includes a database upgrade.
Based on a patch from @achen.code
2010-08-15 02:37:06 +00:00
cketti
0e4c1dfacb
Added helper class to access contacts. Uses the old contacts API for SDK/API 3+4 devices and the new API for SDK/API 5+ devices.
...
All places that accessed the contacts have been updated to use this helper class.
2010-08-14 13:59:33 +00:00
Jesse Vincent
490ab6b8c0
Try harder to make message loading feel responsive and scroll correctly.
...
We're still not there.
2010-08-09 03:16:40 +00:00
cketti
43fb202d43
Fixes issue 1522
...
Added option to automatically show images in message view (always, if sender is in contacts, never).
Patch by paulkilroy (thanks!)
Includes bugfix for the "Show pictures" on orientation change code introduced earlier.
2010-08-07 22:38:08 +00:00
cketti
9d45470b40
Fixes issue 1076
...
Remember "Show pictures" button state when changing orientation.
2010-08-07 21:37:57 +00:00
Thialfihar
54e0ad5ce0
added some comments to explain some cryptography-related classes and to-dos
2010-08-05 10:55:59 +00:00
Thialfihar
11e28698e1
hide the decrypt signature layout in MessageView if no signature exists, fixes the wrong display of signatures from another message
2010-08-05 10:45:58 +00:00
Jesse Vincent
f15101420e
Revert "I like this idea, but it's not ready for 3.000"
...
This reverts commit f812a3485445c7db4024f84865aaa5d8e6b7b3a0.
(Now that 3.0 is branched, this can be on trunk again for further work)
2010-08-02 22:34:21 +00:00
Jesse Vincent
58c5afc77b
I like this idea, but it's not ready for 3.000
...
Revert "It turns out that a big part of our perceptible message switching time"
This reverts commit 06f9bb5b7f3064e646b43148d188cec06cd14d11.
2010-08-02 22:32:57 +00:00
Jesse Vincent
d4695636f3
It turns out that a big part of our perceptible message switching time
...
was loading the "loading..." file into the WebView. Since it doesn't
take that long to load the real content, replacing the "Loading..." file
with "blank the view" seems to actually feel a heck of a lot faster.
2010-08-02 03:03:58 +00:00
Jesse Vincent
f2729fc58b
Don't show "To: " if the only recipients were ccs and bccs.
2010-08-02 03:03:53 +00:00
Jesse Vincent
7fc921c0b7
astyle
2010-08-02 01:27:40 +00:00
Jesse Vincent
7a4d12b53b
Merge from apg-integration
2010-07-27 12:10:09 +00:00
Jesse Vincent
bae8a9736d
Clean up some inverted logic
2010-07-27 01:28:03 +00:00
Jesse Vincent
b1fb92034a
clean up some weird inverted logic (as recommended by intellij)
2010-07-27 01:27:54 +00:00
Jesse Vincent
75b8487024
First bits of infrastructure for not showing HTML-mail inline images as
...
downloadable attachments
2010-07-19 06:13:41 +00:00
Jesse Vincent
f9a24cb123
astyle
2010-07-19 01:57:49 +00:00
Jesse Vincent
6ef923be91
After we download attachments, get rid of the "old" attachment views
2010-07-19 01:54:55 +00:00
Jesse Vincent
6d20c65778
remove the old "isdownloading" notification for the current message.
2010-07-19 01:53:49 +00:00
Jesse Vincent
ad7839e46e
remove debugging statement
2010-07-19 01:53:30 +00:00
Jesse Vincent
111e6f5109
First pass at a "download the rest of this message" button
2010-07-19 01:52:59 +00:00
Thialfihar
19ca87a2d5
removed the initiation of "select text" via long press again
...
Update issue 662
We tried out the long press for a bit and deemed it too sensitive for general usage. It can cause problems with gestures and such, so I removed it again. I hope using the option menu is not too much overhead.
If you want to include it in your custom build or anything, then r 1976 and r1977 should be enough.
2010-07-15 21:35:57 +00:00
Thialfihar
91599ae963
ignore gestures during text selection
...
Fixes issue 662
2010-07-14 18:20:10 +00:00
Thialfihar
510e9acc83
added text selection via "long press" in MessageView, also giving a notification for when text selection starts
...
Update issue 662
Added the long press initiation of text selection. I also noticed we'll have to make sure text selection is not recognized as a gesture (or at least ignored as gesture).
2010-07-14 18:12:40 +00:00
Jesse Vincent
1485502d47
Add a comment about the reason for a recent commit
2010-07-11 19:40:48 +00:00
Jesse Vincent
227ee95532
Disable the delete button after it's tapped (to try to prevent
...
accidental clicks)
2010-07-11 15:39:52 +00:00
Jesse Vincent
5d514c2ace
extract out "setup message buttons on message display.
2010-07-11 15:39:41 +00:00
Jesse Vincent
20e47991c3
astyle
2010-07-11 15:39:26 +00:00
Jesse Vincent
73da009409
Hide the message header while flipping messages, rather than displaying
...
the "wrong" thing during load.
2010-07-11 15:31:31 +00:00
Jesse Vincent
00199de3bb
Extract "disable buttons" on messageview and disable buttons before
...
shifting to the next message
2010-07-11 15:31:11 +00:00
Jesse Vincent
0a848d6526
Make the "header" section addressable in messageView (for later hiding)
2010-07-11 15:30:53 +00:00
Jesse Vincent
b3e6844e44
make the 'should we show animations' boolena actually 'showAnimations'
...
instead of isAnimations.
2010-07-11 15:30:40 +00:00
cketti
0c7d4825cc
Avoid NullPointerException when trying to move a message before it is fully loaded (in message view).
...
Fixes issue 1957
2010-07-11 14:57:00 +00:00
Jesse Vincent
ab8cdb3522
minor astyling
2010-07-10 16:41:48 +00:00
cketti
8bc42639c4
Fix market-reported NullPointerException
...
Fixes issue 1660
2010-07-08 01:09:43 +00:00
cketti
1eb37c2031
Added menu option to select & copy text in the message view.
...
The standard ScrollView causes problems when selecting text (and the message is long enough so scrolling is possible). The newly introduced ToggleScrollView can be set to disable scrolling via touch gestures thus making copying multi-line text sections possible.
Fixes issue 662
2010-07-07 22:14:45 +00:00
Thialfihar
5d4073072f
use "http://" as baseUrl in WebView instead of "email://", refs issue 267
2010-07-07 10:54:50 +00:00