moparisthebest/k-9
1
0
Fork 0
mirror of https://github.com/moparisthebest/k-9 synced 2024-08-13 17:03:48 -04:00
Code Issues Releases Wiki Activity
2,612 Commits 36 Branches 329 Tags 887 MiB
773f2e8870
Commit Graph

66 Commits

Author SHA1 Message Date
Andrew Gaul
47eb0fa2e1 Prefer StringBuilder over StringBuffer 
The former is unsynchronized and slightly faster.
 2011-10-05 21:50:31 -07:00
Jesse Vincent
31adcd2ed8 Revert "http://code.google.com/p/k9mail/issues/detail?id=3408&sort=-id&colspec=ID%20Product%20Type%20Status%20Priority%20Milestone%20Owner%20Summary" 
This reverts commit 0c2e06133c.

The patch would cause an extra SMTP connection on _any_ meesage with
attachments. Marcus is headed away on holiday and asked me to revert it
for him (after I asked him to revert it) - With luck, we'll talk through
a design to work around this issue on the list

Conflicts:

	src/com/fsck/k9/mail/transport/SmtpTransport.java
 2011-06-02 09:35:03 -04:00
Jesse Vincent
3d583da450 ant astyle 2011-06-01 16:03:56 -04:00
Marcus Wolschon
0c2e06133c http://code.google.com/p/k9mail/issues/detail?id=3408&sort=-id&colspec=ID%20Product%20Type%20Status%20Priority%20Milestone%20Owner%20Summary 
Issue 3408: 	SMTP timeouts while calculating message size
 2011-06-01 09:13:16 +02:00
Marcus Wolschon
0b6f0a09bb http://code.google.com/p/k9mail/issues/detail?id=3407&sort=-id&colspec=ID%20Product%20Type%20Status%20Priority%20Milestone%20Owner%20Summary 
Issue 3407: 	Handling of SMTP 5xx error codes unclean

fix part one: 5xx error codes are detected in SMTP-code and reported as permanent failures.
 2011-06-01 09:07:05 +02:00
cketti
2d7fad1fa9 Use InetAddress.getCanonicalHostName() instead of getHostName() 
This should always return a FQDN.
 2011-05-19 00:55:34 +02:00
Andrew Chen
3fcca67ae5 Preserve legacy SMTP authentication behavior for PLAIN by trying LOGIN if supported. 2011-05-04 23:34:02 -07:00
cketti
037b0ff64d Fix automatic authentication method selection for SMTP 
Only use automatic authentication method selection if none was
explicitly selected in outgoing server settings.
 2011-04-26 18:23:41 +02:00
cketti
e8a1a9a466 Restored semantics of auth*Supported in SMTP authentication code 
Also, display a debug message if a certain authentication method was
selected by the user but the server didn't advertise support for it in
the EHLO response.
 2011-04-26 17:49:40 +02:00
Jonas Hurrelmann
da38149091 Support for SMTP authentication methods that are not announced by the server. 
- Added AUTOMATIC as a new authentication method that will automatically choose the best authentication method (basically old behavior with CRAM_MD5). All other options will now enforce the selected authentication method.
- Added LOGIN as selectable option.
- Cleaned up code so strings to the different authentication methods are only defined once.
 2011-04-25 22:32:48 +02:00
Jesse Vincent
0174988d27 astyle 2011-04-12 22:16:22 +10:00
cketti
2cadff74b1 Extracted CRAM-MD5 computation into separate class. 
This gets rid of duplicated code in ImapStore, Pop3Store, and
SmtpTransport.
 2011-04-07 17:11:32 +02:00
DraSine on Rails
e698c78190 Fixed gcode #3182 
Sending mail (SMTP) doesn’t work is the SMTP server is picky about RFC
conformance of envelope dialogue.

k9mail:

MAIL FROM: <sender@dom.ain>
RCPT TO: <receiver@dom.ain>

rfc:

MAIL FROM:<sender@dom.ain>
RCPT TO:<receiver@dom.ain>
 2011-03-31 21:41:03 +08:00
Jesse Vincent
03d05e9331 If an SMTP server tells us how big the biggest message they accept is, 
don't even try to deliver it to them
 2011-03-27 23:09:41 +08:00
Jesse Vincent
c8d38da568 Pull out the maximum acceptable message size from SMTP servers that tell 
us when we EHLO.

Next step is to _use_ this data.
 2011-03-27 23:08:25 +08:00
cketti
83451cff10 Merge branch 'remove_non_api_dependencies' 2011-03-24 19:35:12 +01:00
cketti
766674c27c Code/comment cleanup 2011-02-26 23:04:49 +01:00
Jesse Vincent
c7a3b28289 Change our technique for sending \r\n at the end of smtp commands to 
deal with a weird failure on honeycomb
 2011-02-26 16:53:53 -05:00
cketti
6f90d791b5 Removed dependency on (external) commons-codec and commons-logging 2011-02-26 17:36:18 +01:00
Andrew Chen
a51daf9798 Use interface Map.Entry. 2011-02-09 11:06:01 -08:00
Jesse Vincent
12d1097a24 Big, scary massive "ant astyle" to get us back to something 
approximating AOSP coding standards.
 2011-02-06 17:09:48 -05:00
Jesse Vincent
3d090e9626 astyle 2011-01-31 23:45:23 +00:00
cketti
e5b172b7bb Fix warnings 2011-01-25 02:36:08 +00:00
Marcus Wolschon
ba24fdc742 update issue 2744 
try all addresses of a host.
(Fix is required for proper operation in IPv4-only/IPv6-only networks
 for IPv4/IPv6 dual-stack mail-hosts)
 2011-01-24 15:09:36 +00:00
Jesse Vincent
de806f7715 astyle 2011-01-06 16:55:08 +00:00
Jesse Vincent
2daf8eaec8 Allow emoji input. 
Signed-off-by: HIRANO Takahito <hiranotaka@zng.info>
 2011-01-04 13:25:59 +00:00
cketti
fe724c8c79 Changed SMTP code to handle reply codes without additional text. 
Fixes issue 2801
 2011-01-01 18:45:33 +00:00
Fiouz
47762a9baa Remove coupling between ImapStore and ImapConnection by adding an settings indirection interface. Purpose: use the IMAP connection code to validate credentials without having an actual ImapStore instance. 2010-12-30 21:57:59 +00:00
Andrew Chen
302339545b Try using IP address for EHLO if hostname is unavailable. Only use a default hostname if the IP address is unavailable. ref r2958, issue 2750. 2010-12-23 17:43:57 +00:00
Andrew Chen
6c52c8d927 Set a default hostname if we can't get the local hostname. Fixes issue 2750. 2010-12-23 17:15:20 +00:00
Jesse Vincent
c216f42eb3 Exchange authenticaton and setup overhaul from Kris Wong 2010-10-24 01:03:29 +00:00
Jesse Vincent
6061c42ea9 find src/com/fsck/ -name \*.java|xargs astyle --style=ansi --mode=java --indent-switches --indent=spaces=4 --convert-tabs 2010-10-05 06:04:28 +00:00
Jesse Vincent
4f0bce1569 Simplify many, many boolean conditions with help from IntelliJ 2010-08-29 23:39:26 +00:00
cketti
ba95150a31 Use IP address for SMTP EHLO if hostname contains invalid characters, e.g. underscore. 
Fixes issue 2143
 2010-08-15 19:26:44 +00:00
Thialfihar
014b6c19c3 svn:eol-style=LF for src and XML resources 
Fixes issue 1982
 2010-07-13 21:49:28 +00:00
Jesse Vincent
8ab165ef31 Allow per-protocol configuration of which wire protocols are 
debug-logged
 2010-07-13 21:16:42 +00:00
Jesse Vincent
a826f33eb3 find src/com/fsck/ -name \*.java|xargs astyle --style=ansi 
--mode=java --indent-switches --indent=spaces=4 --convert-tabs
--unpad=paren
 2010-07-06 10:29:26 +00:00
cketti
576078e778 Prefix IPv6-addresses with "IPV6:" in EHLO command. 
Fixes issue 1708
 2010-06-03 01:00:24 +00:00
cketti
64c7df60ab Don't log sensitive information in SMTP commands when "Log sensitive 
information" is unchecked. Applied patch by fiouzy with some small modifications.

Fixes issue 1387
 2010-06-02 13:14:30 +00:00
cketti
58b8479612 Code refactoring: 
- Created "controller" and "mail.filter" package
- Moved a lot of classes to new/other packages
- Removed unused classes: NoSuchProviderException, MessageDateComparator
 2010-05-19 18:17:06 +00:00
Jesse Vincent
8af7f4a7b6 find src/com/fsck/ -name \*.java|xargs astyle --style=ansi --mode=java --indent-switches --indent=spaces=4 --convert-tabs --unpad=paren 2010-04-29 04:59:14 +00:00
cketti
57cc4cd735 Code cleanup. Fixed lots of warnings reported by Eclipse. 
- Removed unused imports
- Removed unused variables/code
- Parametrized raw types
- Added @Override annotations
- Added hashCode() when equals() was overriden
 2010-04-16 12:20:10 +00:00
Daniel Applebaum
c0e4220b82 Fixes Issue 1116 
Fixes Issue 1278
Fixes Issue 119
Fixes Issue 1077
Fixes Issue 1238

Worked performed by danapple0 and cketti in
https://k9mail.googlecode.com/svn/k9mail/branches/issue1116

Add support for most batch ops (except move and copy) in search
results.  Add support for batch move and copy on real folders.

Increase efficiency of bulk IMAP moves and copies by doing as multiple
UID operations.

Eliminated serialization of Account objects.

Provide up-references in useful places to make all future code cleaner
and more efficient.

Fixed a bunch of draft handling

Merged from issue1116 branch, except for Account.java, which was
copied wholesale.  Account.java was manually merged in issue1116
branch at r1489

svn merge -r 1459:1489 https://k9mail.googlecode.com/svn/k9mail/branches/issue1116 .
cp ../issue1116/src/com/fsck/k9/Account.java src/com/fsck/k9/Account.java
 2010-03-04 04:00:30 +00:00
cketti
6fb59467b7 Changed SmtpTransport.writeLine() to only use one OutputStream.write() call. Apparently some servers got the "be liberal in what you accept from others" part of the robustness principle wrong. When we used multiple calls in writeLine() (command + CR + LF) a separate TCP packet was send each time. It appears that those broken servers accepted the DATA command after DATA + CR and interpreted the LF as part of the actual data. This caused our headers to become part of the body because that LF was interpreted as the empty line that separates headers and body. 
As a side effect of this fix sending mail could be slightly faster now due to less packets being sent.

Big thanks to Kevin Newland of Michigan Technological University for organizing a test account.

Fixes issue 799
 2010-03-02 02:48:52 +00:00
cketti
6d84f199c5 Enforce maximum line length for 8-bit encoded messages transmitted via SMTP (998 characters + CRLF). 
Fixes issue 1176
 2010-02-13 23:45:45 +00:00
cketti
14ee970b18 Fixed EOLConvertingOutputStream. 
write('\r');flush();write('\n'); would lead to "\r\n\r\n" instead of simply "\r\n";
 2010-02-05 02:36:52 +00:00
cketti
0422cae33e Implemented data stuffing. 2010-02-05 02:32:32 +00:00
cketti
45036ae5c8 Use 8bit transfer encoding for the text body if SMTP server advertises 8BITMIME. In all other cases base64 is still used (including saved copies in IMAP "Sent" folder). 
Feel free to revert this if anything breaks.
 2010-02-04 23:37:50 +00:00
cketti
c6d29cb10e Fixes issue 21 (All messages are turned into multipart messages) 2010-02-03 19:56:20 +00:00
Jesse Vincent
74aac85048 Use a real hostname rather than localhost.localdomain. 
Fixes Issue 45

Patch by cketti
 2010-02-02 02:06:35 +00:00