Commit Graph

971 Commits

Author SHA1 Message Date
Jan Berkel 6ed52ac551 Fix some warnings in ImapStore / Pop3Store / WebDavStore 2014-12-19 10:13:32 +01:00
Jan Berkel e214dbbd99 Tighten types in Folder#fetch(…) 2014-12-19 09:54:17 +01:00
Jan Berkel 98c1935c85 Reformat according to style 2014-12-19 09:48:02 +01:00
Jan Berkel 043df7e7c5 Decouple K9mail logging 2014-12-18 12:48:10 +01:00
Jan Berkel 714acabf83 Inverse dependencies 2014-12-18 12:22:01 +01:00
Jan Berkel 0a6920c63e Refactor IMAP code + tests 2014-12-18 11:24:43 +01:00
Jan Berkel 0f476978ce mail.store.* cleanups 2014-12-18 09:33:09 +01:00
Jan Berkel 51bc464449 Decouple AuthType / ConnectionSecurity from main app 2014-12-17 20:32:41 +01:00
Jan Berkel 2f30b3956d Dependency Inversion, remove K9.app references 2014-12-17 17:42:22 +01:00
Jan Berkel b36c788ce0 Move ImapConnection out 2014-12-17 17:16:18 +01:00
Jan Berkel 16f8a3ef14 Remove trusted socket factory statics 2014-12-17 16:43:55 +01:00
Jan Berkel 27e0c75021 Move exception error strings out of mail package 2014-12-17 16:24:52 +01:00
Jan Berkel ac33de6310 Fix EOLConvertingOutputStream + add test
Add test for another EOLConvertingOutputStream edge case

Fix bug in EOLConvertingOutputStream

Swap order

Simplify
2014-12-17 14:27:37 +01:00
Jan Berkel 231684936b break/centralize dependencies to K9 2014-12-16 12:54:12 +01:00
Jan Berkel 245a6330ed Move logic into MessageHelper and add tests 2014-12-16 12:17:25 +01:00
Jan Berkel 44f6a2479b Remove reference to K9#hideTimeZone() + test 2014-12-16 12:07:27 +01:00
cketti 946565347a Revert adding methods to Message and Part 2014-12-16 06:04:39 +01:00
cketti 23d9310c61 Remove getUuid() from StoreConfig 2014-12-16 03:32:57 +01:00
Jan Berkel 15a4c90f27 Update javadoc 2014-12-15 13:20:42 +01:00
Jan Berkel b443af43ae Cleanup 2014-12-15 13:01:13 +01:00
Jan Berkel 2a2e18e8b6 WS / visibility 2014-12-15 12:45:04 +01:00
Jan Berkel 36ef6df018 Remove unused method 2014-12-15 12:42:05 +01:00
Jan Berkel 7d6e6b8abe MimeUtility / Message refactor
* break MimeUtility class into manageable pieces (MessageExtractor/CharsetSupport)
 * move HTML related code out of the mail package
2014-12-15 12:26:06 +01:00
Jan Berkel 476cb1d4ce Tidy responsibilities 2014-12-14 15:58:08 +00:00
Jan Berkel 238c1650c5 Remove URLEncodingHelper dependency 2014-12-14 15:54:27 +00:00
Jan Berkel 54d62eb7b9 Naming 2014-12-12 15:19:13 +00:00
Jan Berkel b644194a3d Fix LocalMessage equality/hash 2014-12-12 15:16:38 +00:00
Jan Berkel 40041ac0e0 Move local message code to local package
+ cut some helper dependencies
2014-12-12 15:02:59 +00:00
Jan Berkel 2e98ff56e5 Break dependencies 2014-12-12 13:35:36 +00:00
Jan Berkel 0024f39bc6 Local messages 2014-12-12 13:04:59 +00:00
Jan Berkel 708fb57c04 Move things into local 2014-12-12 12:49:26 +00:00
Jan Berkel 6264527abc Remove Preferences dependency 2014-12-12 12:42:48 +00:00
Jan Berkel 9f16b9f465 Move SSL code into package 2014-12-12 12:35:17 +00:00
Jan Berkel 2536719749 Naming 2014-12-12 07:03:14 +00:00
Jan Berkel 5af649c271 Avoid cast 2014-12-12 06:54:34 +00:00
Jan Berkel 9fd722d7cd Split message code into Local/Remote
The remote network code does not need to be aware of concepts like
Accounts etc.
2014-12-12 06:47:26 +00:00
Jan Berkel 6f4610dd5b Fix visibility 2014-12-12 00:30:41 +00:00
Jan Berkel edfd20bf85 Fix visibility 2014-12-12 00:18:16 +00:00
Jan Berkel e59adf46c0 Package visibility 2014-12-12 00:08:25 +00:00
Jan Berkel 12291bceb5 Move database code into correct package 2014-12-11 23:56:02 +00:00
Jan Berkel ba4dd24bd5 Package visibility 2014-12-11 23:32:38 +00:00
Jan Berkel ca10e4d94a Use TextUtils.isEmpty 2014-12-11 21:56:26 +00:00
Danny Baumann aaf3963567 Don't throw CertificateValidationException for all SSLExceptions.
An interrupted connection attempt to the server yields an SSLException
as well, like this:

E/k9      ( 6937): Caused by: javax.net.ssl.SSLHandshakeException: Connection closed by peer
E/k9      ( 6937):      at com.android.org.conscrypt.NativeCrypto.SSL_do_handshake(Native Method)
E/k9      ( 6937):      at com.android.org.conscrypt.OpenSSLSocketImpl.startHandshake(OpenSSLSocketImpl.java:302)
E/k9      ( 6937):      at com.android.org.conscrypt.OpenSSLSocketImpl.waitForHandshake(OpenSSLSocketImpl.java:598)
E/k9      ( 6937):      at com.android.org.conscrypt.OpenSSLSocketImpl.getInputStream(OpenSSLSocketImpl.java:560)
E/k9      ( 6937):      at com.fsck.k9.mail.store.ImapStore$ImapConnection.open(ImapStore.java:2459)

We don't want the user to notify of 'certificate problems' in that case.
Fix it by checking whether the SSLException was actually triggered by a
CertificateException.
2014-12-04 13:16:33 +01:00
cketti 98b5d63909 Merge branch 'open_attachment_improvements'
Conflicts:
	src/com/fsck/k9/helper/Utility.java
2014-11-27 21:03:15 +01:00
cketti d9b6e10cbe Change the way the best view intent is determined
First we try the original MIME type unless it's application/octet-stream.
Then we try the MIME type inferred from the attachment's file extension.
Then we fall back to application/octet-stream.

In all cases we first try the content:// URI, then a file:// URI.
2014-11-18 22:55:51 +01:00
cketti 9e6fc7c7d1 Merge pull request #13 from k9mail/art/update-certificates-in-tests
Update certificates in tests
2014-11-12 16:30:53 +01:00
cketti bd4a236525 Merge pull request #11 from k9mail/art/fix-tests-on-jvm
fix tests on JVM
2014-11-11 19:46:58 +01:00
cketti 7211080415 Merge pull request #10 from k9mail/art/more-tidying-arrays
Replace many arrays with collections
2014-11-11 19:45:35 +01:00
cketti 34cfd8e5b4 Extract file related helper functions into separate class 2014-11-11 01:04:39 +01:00
Art O Cathain 438a350f55 remove unnecessary method parameters 2014-10-19 18:40:17 +01:00