unusualdiscrepancy
58c01c05b7
Fix for Issue 4164: Force close when moving an email to another folder
2012-03-18 21:45:33 +01:00
cketti
482ae352c1
Reverted most of the recent message header changes
...
Clicking the additional headers area still allows to hide that view
again.
2012-03-18 04:51:29 +01:00
cketti
69ee6a4818
Avoid NullPointerException in Accounts.onCreateDialog()
...
Also cleaned up code formatting of onCreateDialog() and
onPrepareDialog().
2012-03-17 21:28:54 +01:00
cketti
ef01dc906b
Use AlertDialog's ListView on import instead of creating our own
...
This fixes a display problem when using the dark theme.
2012-03-17 21:28:53 +01:00
Koji Arai
10c37942a6
Added two domains handle docomo emoji
2012-03-17 23:24:12 +09:00
Koji Arai
f9fb74241a
avoid NPE. address may be null when the parser is failed.
2012-03-17 23:23:27 +09:00
cketti
f9a35aeaee
Replace CRLF with LF when loading drafts
...
This is necessary because we save the offset and length of the user-
supplied text in the identity header. These values are then later used
to split the draft in user text and quoted message.
When calculating these values we operate on a string with LF line
endings. Ideally we want to do the reverse operation on the same
string, but when saving the message to the server LF is converted to
CRLF to create RFC-conforming messages.
This is only a hack and will probably be the cause of more trouble in
the future. A better solution would be to make the identity header more
robust or get rid of it entirely.
2012-03-17 04:15:30 +01:00
cketti
3fa8081e88
Fixed MimeUtility.extractTextual() when loading messages from the server
2012-03-17 03:19:09 +01:00
cketti
dbf38dae65
Fixed the change of the previous commit
2012-03-17 00:30:40 +01:00
cketti
a48adafbbc
Don't use null for 'text' and 'html' in ViewableContainer
2012-03-16 22:56:09 +01:00
cketti
f181e923ca
Don't modify draft messages when storing them in the database
2012-03-15 21:21:00 +01:00
Srinath Warrier
7a9ba4e0ad
Create implicit sort remembering setting2(minor indentation error)
2012-03-12 22:55:31 +05:30
cketti
aeb0220e56
Fixed MimeUtility.getHeaderParameter() to not crash on unexpected input
2012-03-12 17:45:34 +01:00
Srinath Warrier
3ebd3c1fc2
Create implicit sort remembering setting
2012-03-12 22:04:10 +05:30
ashley willis
f9a30d1822
added sort by arrival option.
2012-03-11 17:48:56 -05:00
cketti
0cb4207ef7
IMAP: don't create the destination folder when copying messages
2012-03-09 21:51:48 +01:00
cketti
7163d39091
Change ImapException to always be a permanent error
...
This way IMAP commands that get anything but an "OK" response are never
tried again (pending actions).
2012-03-09 21:50:26 +01:00
cketti
ee34344d30
Upgrade to SDK 15
2012-03-07 21:52:47 +01:00
cketti
4721d92e79
Avoid some instances of autoboxing
...
This will hopefully allow us to compile with "Android Java IDE".
2012-03-07 21:40:41 +01:00
cketti
a089fadd9a
Merge branch 'messageheader'
2012-03-06 05:26:11 +01:00
cketti
faf9dc6e02
Restored show/more less indicator in the message header
2012-03-06 04:38:08 +01:00
ashley willis
78615f878d
added From: addresses on reply all when Reply-To: is set. don't repeat address in To: field if it's already included in replyToAddresses.
2012-03-05 15:17:31 -06:00
Srinath Warrier
ff6e1f6c85
Create default sort setting by preference
2012-03-04 16:20:37 +05:30
m0viefreak
8d12244a9c
Message header changes
...
* remove expand/collapse arrows, instead use the background area of the header to toggle
* allow expanding of To: and Cc: texts when too long and cut off by clicking on them
2012-03-02 06:15:55 +01:00
m0viefreak
f1baa8f461
invalidate message content WebView when the message header changes
...
This fixes redraw issues where text appears doubled or is cut off
2012-03-02 05:16:58 +01:00
cketti
5591865f17
Merge branch 'uidplus'
2012-02-29 14:09:41 +01:00
cketti
f6ebe4d4e0
Deduplicated code to create SearchAccounts for special accounts
2012-02-29 03:03:20 +01:00
cketti
e72afc1641
Set content type of attachment even when no file name was found
2012-02-27 23:20:30 +01:00
cketti
ba979808fe
Use AttachmentView instance as onClick and onLongClick listener
2012-02-27 21:45:47 +01:00
cketti
206c559236
Don't handle exceptions in AttachmentView.populateFromPart()
...
We now catch exceptions in SingleMessageView.renderAttachments(). This
way we can avoid adding AttachmentViews that couldn't be properly
populated.
2012-02-27 21:45:47 +01:00
cketti
25dff5ae6a
Don't choke on invalid size parameters for attachment parts
2012-02-27 21:45:46 +01:00
cketti
2cb31a2fac
Added button to show unnamed and inline attachments
2012-02-27 21:45:46 +01:00
cketti
de2c6cdae3
Prevent users from changing special folder assignments for POP3 accounts
2012-02-25 05:05:21 +01:00
cketti
8e7950164b
Hide "Expunge" menu item for all folders in a POP3 account
...
Also hide "Check mail" for all folders except the Inbox (POP3).
2012-02-25 04:28:08 +01:00
cketti
1af5476b96
Hide refile batch actions in the message list for POP3 accounts
2012-02-25 04:19:27 +01:00
cketti
3632978b49
Don't animate the previous/next buttons in message view
2012-02-25 01:08:55 +01:00
cketti
7c97527d73
Allow message header to scroll when displaying the attachment list
2012-02-25 00:43:09 +01:00
cketti
c1d663b084
Save/restore instance state for MessageHeader
2012-02-24 04:07:29 +01:00
cketti
4e12dc154e
Save/restore instance state for SingleMessageView
2012-02-24 03:43:42 +01:00
cketti
2c09d75afa
Switch to "message view" when displayMessageBody() is called
2012-02-23 00:10:47 +01:00
cketti
18c96f94d6
Retain "show pictures" state on orientation change
2012-02-22 23:26:59 +01:00
cketti
4984a6b9e5
Keep current view state after having downloaded the complete message
...
If the attachment view was visible, keep it that way.
2012-02-22 23:07:48 +01:00
cketti
2b54599c2b
Small code cleanup
2012-02-22 22:56:05 +01:00
cketti
0ef9c516be
Moved click listener from MessageView to SingleMessageView
2012-02-22 22:44:31 +01:00
cketti
80cb0cce35
Changed the layout to include a color chip again
2012-02-21 23:38:43 +01:00
cketti
d44849d239
Restored previous/next animations
2012-02-21 16:54:35 +01:00
cketti
ec6645bf6a
Avoid creating new objects for handling click events
2012-02-21 16:21:47 +01:00
cketti
9f42ff61d3
Removed settings for scrolling buttons
2012-02-21 15:16:36 +01:00
cketti
309eeb72ac
Got rid of the ScrollView in MessageView
...
The ScrollView around the WebView caused all sorts of problems. This
change removes the ScrollView and uses the undocumented method
WebView.setEmbeddedTitleBar() to set the MessageHeader view as "title
bar" of the WebView. This allows MessageHeader to scroll away making
more room for the WebView.
All of the "magic title bar" code was originally implemented by Jesse
for Kaiten.
Because WebView doesn't support a scrolling footer we can no longer
support scrolling buttons or attachments at the end of the message. Now
users can switch from message view to attachment view via a button just
below the message headers.
I also copied some code for which I was too lazy to create a separate
commit. It allows to display attachments we didn't use to show by
clicking on a "More..." button in the attachment view. Those
attachments are mostly images referenced by the HTML part (e.g.
background images).
Fixes issue 3291
2012-02-21 05:07:01 +01:00
cketti
fbc187a3e2
IMAP: Send the Message-ID as quoted string in getUidFromMessageId()
2012-02-19 19:51:06 +01:00
cketti
8e32320f5d
Merge branch 'viewables'
2012-02-18 19:29:34 +01:00
cketti
4adfc51339
Use HtmlConverter.convertEmoji2Img() in LocalFolder.updateMessage()
2012-02-18 00:44:24 +01:00
cketti
b9803ece19
Fixed divider before text part with filename
2012-02-18 00:05:56 +01:00
cketti
8ce78408c2
Fixed HTML generation in MimeUtility.extractTextAndAttachments()
2012-02-17 19:42:35 +01:00
cketti
5083b8f1e8
Use newly imported AOSP code instead of ImapStore.parseSequenceSet()
2012-02-17 15:01:30 +01:00
cketti
deb01bcd16
Imported ImapUtility.java from AOSP Email
...
Modified it to fit our needs.
2012-02-17 14:59:50 +01:00
cketti
c1ed0c78a9
Introduced new pending command to retain upgradability
2012-02-17 01:59:04 +01:00
ashley willis
4db048343f
account setup changes:
...
added gmx.com.
set delete policy to DELETE_POLICY_ON_DELETE for IMAP on automatic setup like manual setup does.
set default names for Archive and Spam on manual config like automatic setup does.
2012-02-16 18:35:25 -06:00
cketti
f7299a69d4
Keep track of UIDs when moving messages to the trash folder
2012-02-17 00:43:35 +01:00
cketti
c3885bc475
Cleaned up LocalFolder.appendMessages() a bit
2012-02-16 23:52:44 +01:00
cketti
023c60513e
Fixed UID mapping return value of LocalStore.moveMessages()
2012-02-16 23:37:44 +01:00
cketti
4ed77c7a29
Avoid NullPointerException
2012-02-16 22:36:57 +01:00
cketti
89e0ed3c03
Notify listeners of UID changes after remote copy/move
2012-02-16 22:34:50 +01:00
cketti
3e4e6c72fd
Cleaned up ImapStore.ImapFolder.copyMessages()
2012-02-16 22:12:44 +01:00
cketti
396005974a
Cleaned up ImapStore.ImapFolder.appendMessages()
2012-02-16 21:33:53 +01:00
cketti
8e1627e1b9
Merge branch 'master' into uidplus
...
Conflicts:
src/com/fsck/k9/controller/MessagingController.java
src/com/fsck/k9/mail/store/WebDavStore.java
2012-02-16 19:57:24 +01:00
cketti
53ae9d7fe7
Avoid exception when a screen reader is installed but not active.
2012-02-16 14:52:56 +01:00
cketti
3ee0889529
Use the Androiod framework for the file manager error dialog
...
This will automatically recreate the dialog on configuration changes
(e.g. orientation change).
2012-02-16 14:43:38 +01:00
ashley willis
15ffaf301e
changed ANDROID_MARKET_URL to automatically search for OI File Manager.
2012-02-14 22:48:27 -06:00
Ashley Willis
8d5ad172c6
Merge pull request #125 from wilian-cb/issue-3945
...
3945: Handling error when there's no File Manager application used in import settings
2012-02-14 20:41:42 -08:00
wilian-cb
4c318d1727
3945: Treatment for errors related to not having a file manager application in Android to handle import configurations.
2012-02-14 21:11:15 -02:00
cketti
dfd47702bc
Fixed rare NullPointerException
2012-02-14 00:27:28 +01:00
cketti
cf9631d481
Changed the way we decide what message parts to display
2012-02-13 23:11:59 +01:00
cketti
485a505ca0
More tweaks to the unread widget
2012-02-13 12:25:03 +01:00
cketti
64f4f7e4a3
Use the new AccountList activity when creating launcher shortcuts
2012-02-13 12:25:03 +01:00
cketti
7a252bf002
Changed method to update the unread widget
2012-02-13 12:16:20 +01:00
cketti
98461e5a21
Notify listeners if unread count changed due to a copy/move operation
2012-02-13 12:16:19 +01:00
cketti
d4bc664c41
Removed unused method
2012-02-13 12:16:19 +01:00
cketti
e87f4cd98a
Code cleanup. No functional changes.
2012-02-13 12:16:19 +01:00
cketti
29e1a68288
Added widget to display the unread count for an account
2012-02-13 12:16:18 +01:00
cketti
328701e87e
Fixed JavaDoc
2012-02-13 00:57:06 +01:00
cketti
53604be914
Fixed NullPointerException
2012-02-13 00:56:34 +01:00
wilian-cb
e766f75da2
Creating and initializing special accounts in Accounts activity to avoid NullPointerException when it's resumed. Constant added to represent the number of special accounts.
2012-02-12 11:57:34 -06:00
wilian-cb
02b07f34a1
Issue 3280: Add launcher shortcuts for special accounts/folders ("Unified Inbox" and "All messages")
2012-02-10 00:24:32 -06:00
cketti
7ef5f9d37e
Set flagged and unread count to 0 when emptying the trash folder
2012-02-04 21:06:35 +01:00
cketti
898f65e081
Changed the way we set flags to update the original Message object
2012-02-04 21:06:34 +01:00
Nick Nikolaou
46bf2c5be7
Add discard confirmation dialog when pressing back
2012-02-02 19:33:49 -06:00
cketti
35b5aebdb3
Add debug message when saving an attachment to SD card fails
2012-02-03 01:22:37 +01:00
cketti
b1a1de8f7b
Restore mark as unread in message view
...
Fixes issue 3958
Fixes issue 3319
2012-01-27 08:39:10 +01:00
cketti
1165787129
Changed regular expression for invalid characters in a file name
2012-01-27 03:39:08 +01:00
cketti
6c23e204ba
Replace invalid characters in file name instead of removing them
2012-01-27 03:21:20 +01:00
cketti
68f5f009f1
Whitespace cleanup
2012-01-27 03:07:44 +01:00
wilian-cb
9a0f650cd9
3674: Displaying the final file name.
2012-01-27 02:44:01 +01:00
wilian-cb
193450cd63
3674: Illegal characters used in file names are being removed when saving them on the device.
2012-01-27 02:44:01 +01:00
cketti
e8eae37389
Reset unread/flagged count on "empty trash"
2012-01-27 00:51:18 +01:00
cketti
5a8ddaa039
Make sure draft id points to a valid message before deleting it
...
Avoids IllegalArgumentException in LocalStore.getMessage()
2012-01-26 00:37:25 +01:00
cketti
aae734c175
Don't Log.w() full stacktrace if file wasn't found
...
This happens regularly when AttachmentView tries to get a thumbnail for
attachments that haven't been downloaded yet.
2012-01-24 22:14:21 +01:00
cketti
4e5d116713
Delete attachment metadata and thumbnails when deleting attachments
2012-01-24 16:15:45 +01:00
cketti
c6696f632a
Code cleanup, fixed some warnings, rearranged some stuff
2012-01-24 16:15:44 +01:00
cketti
7a3cadbf1c
Refactored AttachmentProvider.openFile()
2012-01-24 16:15:44 +01:00
cketti
4bbc5de1ba
Code cleanup / fixed lots of warnings
2012-01-22 06:25:06 +01:00
cketti
45faad041e
Don't finish() MessageCompose in onPause()
2012-01-22 05:32:52 +01:00
cketti
bddacf6b64
Use database ID to keep track of the current draft
...
By using the database ID we avoid having to deal with the problem of
changing UIDs. First the message has a local UID, then, when the upload
to the server is completed, it gets a remote UID.
2012-01-22 05:20:41 +01:00
cketti
96f827d291
Modified LocalStore to use UPDATE when replacing existing messages
...
This way we can later use the database ID to keep track of drafts.
2012-01-22 05:20:41 +01:00
cketti
be2aac52a8
Reload accounts after writing imported account settings to storage
...
This makes sure that when the next account is imported it will see the
account just imported. That's necessary e.g. when going though all
accounts to find the next free account number, or when avoiding account
name conflicts.
2012-01-21 03:10:40 +01:00
cketti
0625e13380
Canceling notifications once should be enough
2012-01-20 23:32:55 +01:00
cketti
a8f91b0f70
Minor code cleanup
2012-01-20 23:32:12 +01:00
cketti
7eccc1701d
Merge branch 'issue3508'
2012-01-20 23:19:22 +01:00
cketti
2c5f640b9e
Minor cleanup
2012-01-20 23:15:11 +01:00
wcb
457e65010e
Issue 3139: notifications of new messages removed when unified inbox is selected
2012-01-20 11:55:04 -08:00
Nick Nikolaou
773d1e30f1
Simplied code and added curly brackets to if/else
2012-01-20 19:10:11 +00:00
cketti
32a29f131b
Make sure an IOException is always passed through as MessagingException
...
This is important for the code handling pending actions in
MessagingController. If a non-permantent MessagingException is
encountered, the pending action is retried later.
Fixes issue 3696
2012-01-20 19:50:07 +01:00
Nick Nikolaou
1a01c10fc5
Don't save to drafts if drafts folder is -NONE-
2012-01-20 17:02:35 +00:00
cketti
258b0039d5
IMAP: also get the Message-ID when fetching the message "envelope"
...
This should fix issue 3994
2012-01-14 06:30:22 +01:00
cketti
66b7805a57
Fixed a bug in the IMAP response parser
...
Also got rid of ImapResponse.more() which isn't necessary anymore.
2012-01-12 07:56:52 +01:00
cketti
ad8b025b6f
Fixed indentation
2012-01-12 02:20:22 +01:00
cketti
8e627834c1
Changed font size unit from DIP to SP
...
"Scale-independent Pixels - this is like the dp unit, but it is also
scaled by the user's font size preference. It is recommend you use this
unit when specifying font sizes, so they will be adjusted for both the
screen density and the user's preference." - Android Developer Docs
2012-01-12 02:18:41 +01:00
cketti
edf0361aab
Added font size setting for text input fields in MessageCompose
2012-01-12 01:05:01 +01:00
cketti
e7f29d429c
Fixed quoted text for plain text messages
2012-01-10 07:44:50 +01:00
cketti
0d8497b04b
Restructured and documented MessageCompose.buildText()
...
Also fixed a bug where the signature wasn't appended in the HTML part of
newly composed messages.
2012-01-10 01:47:23 +01:00
cketti
a191415860
Avoid using TreeMap methods introduced with API 9
2012-01-08 04:04:25 +01:00
Jesse Vincent
ec78c1e009
Save settings changes "on pause" rather than "on back" so we actually
...
save settings when a user hits home or menu or whatever.
2012-01-06 20:27:10 -05:00
Jesse Vincent
3d9f9c4ab4
Don't save account settings until after we save the updated push
...
settings.
2012-01-06 20:12:40 -05:00
Andrew Chen
beda7beac7
Use a constant for 18 hours.
2012-01-05 19:01:00 -08:00
cketti
7e8aede93d
Updated settings description with new default values (import/export)
2012-01-06 01:36:32 +01:00
Andrew Chen
06175888b9
Enable system zoom and disable gestures by default.
2012-01-05 16:10:23 -05:00
cketti
926406edd3
Be more careful when deleting an account
...
Fixes issue 3954
2012-01-05 20:24:18 +01:00
cketti
d848b434f5
Fall back to HELO command if the server doesn't know EHLO (SMTP)
...
Fixes issue 2704
2012-01-05 03:53:23 +01:00
Mark Baker
0e86fb2a80
Fixed whitespace
2012-01-04 19:58:19 +00:00
Andrew Chen
3c5a63adeb
Issue 3875: Revert to the old way of determining minimum swipe distance.
...
Fix my logic bug when determining left to right vs. right to left.
2012-01-03 21:58:36 -08:00
Andrew Chen
11ebc1b262
Issue 3875: Add a bit more debug data for swiping.
2012-01-03 21:19:59 -08:00
Andrew Chen
fc5ea05e48
Issue 3875: Add more debugging lines to figure out what might be wrong with the new swipe algorithm.
...
Fix some variable names.
2012-01-03 21:06:20 -08:00
Andrew Chen
81f0cb510a
Remove unused date formatter.
2012-01-03 21:04:27 -08:00
cketti
fec6434f08
Removed unused code
2012-01-04 03:57:54 +01:00
cketti
71174417ce
Clone Message object to avoid ConcurrentModificationExceptions
...
Fixes issue 3953
2012-01-04 03:57:53 +01:00
edpeur
daeedc2222
Close resources properly
2011-12-31 17:38:41 +00:00
cketti
0aa513429a
Show/hide ListView footer depending on message list type
...
Fixes issue 3946
2011-12-31 02:24:54 +01:00
Mark Baker
09c6cfb6e4
Remove TODO
2011-12-29 09:56:54 +00:00
wongk
fb3cd234fa
Merge branch 'master' of github.com:k9mail/k-9
2011-12-28 14:04:37 -05:00
wongk
b2d5ea3ce2
Fixed the parsing of response data for WebDAV requests.
2011-12-28 14:03:44 -05:00
Mark Baker
7ad5429e98
Merge remote-tracking branch 'upstream/master'
2011-12-26 19:17:05 +00:00
cketti
852dca4124
Removed unused import
2011-12-26 02:30:59 +01:00
András Veres-Szentkirályi
39ef1ae9a4
Removed overrides merely calling super()
2011-12-26 02:28:32 +01:00
András Veres-Szentkirályi
cea6f4468d
Removed unused private field
2011-12-26 02:28:31 +01:00
András Veres-Szentkirályi
1949067979
Removed unnecessary return statement
2011-12-26 02:28:30 +01:00
András Veres-Szentkirályi
de30c712f9
Removed duplicate import
2011-12-26 02:28:30 +01:00
András Veres-Szentkirályi
b9ea7db5da
Removed unneeded semicolons
2011-12-26 02:28:29 +01:00
Mark Baker
af1b9f83f2
Added batch buttons for Archive and Move. Made batch buttons configurable.
2011-12-24 18:17:12 +00:00
cketti
6de081c5b0
Minor cleanup
2011-12-19 02:21:27 +01:00
mwolschon
696666ca5e
Issue 1303: can't send mail get "no route to host" error
2011-12-19 02:10:17 +01:00