1
0
mirror of https://github.com/moparisthebest/k-9 synced 2024-12-20 22:58:48 -05:00
Commit Graph

1507 Commits

Author SHA1 Message Date
Andrew Gaul
844db81b8d Optimize Utility.combine for length 1 arguments 2011-10-25 13:10:47 -07:00
Jesse Vincent
ae3f098b4a Merge pull request #64 from andrewgaul/typesafe-set
Avoid type-unsafe Set
2011-10-20 05:34:48 -07:00
Jesse Vincent
ea384b40a1 Merge pull request #66 from andrewgaul/redundant-combine-flags
Remove duplicated combine flags code
2011-10-20 05:33:37 -07:00
Andrew Gaul
4c5f2e59a0 Remove unused Utility.readInputStream
Consider IOUtils.toString instead.
2011-10-19 23:11:03 -07:00
Andrew Gaul
5b9f542bd7 Avoid type-unsafe Set 2011-10-19 23:05:34 -07:00
Andrew Gaul
ce4b42f66b Remove duplicated combine flags code 2011-10-19 22:04:57 -07:00
Andrew Gaul
80d9246130 Prefer unsynchronized Collection types 2011-10-19 21:56:20 -07:00
ashley willis
2058fc378d Option to show next message after delete by default instead of previous. 2011-10-12 17:50:24 +02:00
cketti
a258415629 Merge pull request #60 from andrewgaul/builder-append-no-concatenation
Avoid concatenation in StringBuilder append
2011-10-12 08:28:32 -07:00
cketti
c34d896474 Merge pull request #59 from andrewgaul/immutable-sets
Make sets immutable
2011-10-12 08:26:43 -07:00
Marcus Wolschon
4c8ebb4bcd added check for Null 2011-10-11 08:53:51 +02:00
Andrew Gaul
57be9e3ee3 Make sets immutable
Use final and unmodifiable and avoid anonymous inner classes.
2011-10-06 20:22:18 -07:00
Andrew Gaul
9b27aba2ba Avoid concatenation in StringBuilder append 2011-10-06 09:20:11 -07:00
cketti
2e2428b093 Merge pull request #55 from andrewgaul/stringbuilder
Prefer StringBuilder over StringBuffer
2011-10-06 09:04:43 -07:00
cketti
31af4526ab Merge pull request #58 from andrewgaul/spelling
Spelling corrections
2011-10-06 09:01:37 -07:00
Andrew Gaul
220e55603d Spelling corrections 2011-10-05 22:04:39 -07:00
Andrew Gaul
dad0332667 Make an inner class static 2011-10-05 22:01:53 -07:00
Andrew Gaul
47eb0fa2e1 Prefer StringBuilder over StringBuffer
The former is unsynchronized and slightly faster.
2011-10-05 21:50:31 -07:00
cketti
0619eaf79c Catch NumberFormatException when parsing disposition size parameter
Fixes issue 3712
2011-10-01 21:17:00 +02:00
cketti
88dc36da8a Added a check to prevent an ArrayIndexOutOfBoundsException
Fixes issue 3683
2011-10-01 20:30:22 +02:00
Jesse Vincent
defabdc20c Additional service fixes from the original author of the issue 2777 fix
to stop the service from being shutdown when we have push enabled
2011-09-29 00:16:27 -04:00
Jesse Vincent
fd61b4f20b Merge pull request #52 from andrewgaul/peekable-bad-offset
Fix bad offset in PeekableInputStream
2011-09-28 21:10:41 -07:00
Andrew Gaul
7cf1bfcc98 Fix bad offset in PeekableInputStream 2011-09-20 21:21:50 -07:00
Koji Arai
f3795f3df5 Search same sender from searchable folders instead of the unified inbox 2011-09-16 01:33:51 +09:00
Andrew Chen
dd1334b874 Add some JavaDoc to SearchAccount stuff; astyle. 2011-09-12 15:08:34 -07:00
Jesse Vincent
cbaa9f5b3d Work around cases where mail was last checked in the future.
Sometimes, user devices will have their clock misset. Previously, K-9
would just stop checking mail until the device caught up with the
future.
2011-09-05 22:16:04 -04:00
danapple
7d5bb99dbd Add progress indicator during account move. 2011-09-05 12:45:53 -05:00
danapple
2867a90286 Disable account move menu items when account is at an end of the list.
Conflicts:

	src/com/fsck/k9/activity/Accounts.java
2011-09-05 12:45:33 -05:00
danapple
06cabdbde1 Working version of moving accounts within the Accounts view. 2011-09-05 12:38:03 -05:00
danapple
c67ac4735f Fixes Issue 3177
Dynamically update the FolderList titlebar when the unread state of a
listed folder changes.  This implementation applies the folder unread
count delta to the account-level unread count, to avoid the expense of
recomputing the entire account's unread count.  If no FolderInfoHolder
for this folder already exists, skip the recomputation of the
account-level unread message count.
2011-09-05 11:20:57 -05:00
Jesse Vincent
50e6218c1d Merge pull request #49 from senab/master
Expose SenderAddress through ContentProvider. Issue: 3665
2011-09-04 18:44:08 -07:00
Jesse Vincent
8223e4d4bf Removed some doc annotations from chrisk's fix for the service stopping
issue (2777)
2011-09-04 16:13:19 -04:00
Christian Knecht
7cd6334c64 Stop service(s) if not in use - Fixes Issue 2777 2011-09-04 16:00:02 -04:00
Jesse Vincent
1b7481f854 optimize cketti's pop3 space-splitting code to not make lots of extra
copies of responses.
2011-09-04 15:53:12 -04:00
Chris Banes
b002f3178b Move Sender Address to end of Default Projection 2011-09-02 11:33:20 +01:00
Chris Banes
caa02b16eb Expose SenderAddress through ContentProvider. Issue: 3665 2011-09-01 11:57:06 +01:00
cketti
f6a647d7b0 Cosmetic changes 2011-08-31 02:17:45 +02:00
cketti
e9e9d5afcb Removed unused method 2011-08-31 02:12:01 +02:00
cketti
dfc370c057 Merge pull request #42 from jca02266/wip-fix-activity-switching-for-message-view
Fix for message list opening the wrong message view

Fixes issue 3592
2011-08-30 17:09:11 -07:00
Andrew Chen
16c1f9c35b Add the remaining two return receipt headers upon request. 2011-08-28 16:08:41 -07:00
Jesse Vincent
1ac652dc5f Small bug introduced during a refactoring "Extracted POP3 commands and capabilities to constants" introduced a typo that broke interactions wit some POP3 servers. 2011-08-28 18:28:12 -04:00
Jesse Vincent
a1378789b2 Merge pull request #48 from rpimonitrbtch/master
Loosened the restrictions on the TLD to support custom private TLD's, as well as single label hostnames.

Resolves Issue 2784: Cannot set server hostname
2011-08-28 12:48:10 -07:00
rpimonitrbtch
bdcb19e344 Issue 2784: Cannot set server hostname
Loosened the restrictions on the TLD to support custom private TLD's, as well as single label hostnames. Removed the localhost and localhost.localdomain exceptions, as they are now redundant.
2011-08-28 15:24:52 -04:00
Alessandro Russo
f5c679fb95 Added support for requesting read receipts 2011-08-27 20:46:04 -04:00
Adam
be1be56e3a Fixed bug where uid in response was truncated
The SAX parser returns chunks of text to the
WebDavHandler. Other tags were correctly appending
values while the special cased <uid> tag was
simply assigned the value it was given, which would
result in the last chunk assigned to it and not
the whole string of text.
2011-07-28 15:08:00 -04:00
Jesse Vincent
3679b31b12 Workaround for market-reported error:
java.lang.Error: org.apache.james.mime4j.io.MaxHeaderLimitException: Maximum header limit exceeded
at com.kaitenmail.mail.internet.MimeMessage.parse(MimeMessage.java:85)
at com.kaitenmail.mail.store.Pop3Store$Pop3Message.parse(Pop3Store.java:932)
at com.kaitenmail.mail.store.Pop3Store$Pop3Folder.fetchBody(Pop3Store.java:714)
at com.kaitenmail.mail.store.Pop3Store$Pop3Folder.fetch(Pop3Store.java:579)
at com.kaitenmail.controller.MessagingController.downloadSmallMessages(MessagingController.java:1562)
at com.kaitenmail.controller.MessagingController.downloadMessages(MessagingController.java:1288)
at com.kaitenmail.controller.MessagingController.synchronizeMailboxSynchronous(MessagingController.java:1031)
at com.kaitenmail.controller.MessagingController.access$400(MessagingController.java:81)
at com.kaitenmail.controller.MessagingController$8.run(MessagingController.java:823)
at com.kaitenmail.controller.MessagingController.run(MessagingController.java:276)
at java.lang.Thread.run(Thread.java:1096)
Caused by: org.apache.james.mime4j.io.MaxHeaderLimitException: Maximum header limit exceeded
at org.apache.james.mime4j.stream.AbstractEntity.parseField(AbstractEntity.java:153)
at org.apache.james.mime4j.stream.MimeEntity.advance(MimeEntity.java:120)
at org.apache.james.mime4j.stream.MimeTokenStream.next(MimeTokenStream.java:351)
at org.apache.james.mime4j.parser.MimeStreamParser.parse(MimeStreamParser.java:179)
at com.kaitenmail.mail.internet.MimeMessage.parse(MimeMessage.java:83)
... 10 more
2011-07-25 01:49:42 -04:00
Jesse Vincent
7b7601082b the refactoring to combine batch and record logic added an extra check
that broke delete of single messages from message list.
2011-07-23 18:45:43 -04:00
Koji Arai
fda43206a3 Fixed the below issue for GalaxyS and S2.
When scrolling a ListView, all items turn black.
it was reproduced on FolderList, MessageList and Accounts, other views were not.
2011-07-20 22:13:20 +09:00
Jesse Vincent
0543183b11 Work around a weird NPE in WebDAV sync reported by Jon Blow 2011-07-19 22:43:32 -04:00
Koji Arai
8d264b159e Workaround for below issue.
1. Show a message in MessageView.
2. Press HOME button to back home.
3. Re-launch the K-9 and select another message.
4. Show first selected message.

See also: https://github.com/k9mail/k-9/commit/fix_activity_stack
2011-07-18 00:59:30 +09:00
cketti
2acd55a9ef Implemented work-around to handle malformed UIDL responses (POP3).
Fixes issue 3546
2011-07-17 14:37:21 +02:00
cketti
9f581cb6f3 Extracted POP3 commands and capabilities to constants 2011-07-17 14:13:04 +02:00
Koji Arai
45e29ccba4 Fixed issue 3530.
Should not HTMLify the message when it is sent without quoted message.

The problem is:
1. set MessageFormat in Account setting to the TEXT.
2. reply a message without quoted text.
3. it is sent with HTML tags.
2011-07-17 08:56:28 +09:00
Jesse Vincent
2e173150d5 Rather than disabling imap-specific preferences on POP3, hide em 2011-07-13 22:15:36 -04:00
Jesse Vincent
87640719dd Disable "download by date range" for webdav and pop3.
The previous behavior caused catastrophic network abuse, downloading
messages outside the date range over and over.
2011-07-12 22:05:49 -04:00
Jesse Vincent
b85c9b7b0e Work around the fact that when we can't get read status for a message,
we'd end up with an NPE as we then queried the hashmap
2011-07-11 11:08:20 -04:00
Jesse Vincent
98ae8cf2be refactoring to use the object we extracted from the array 2011-07-11 11:08:20 -04:00
Jesse Vincent
d7dfba15cf It appears that Exchange is returning responses
without a visiblecount element for empty folders
Which resulted in this code returning -1 (as that was
the previous default.)
-1 is an error condition. Now the default is empty
2011-07-09 17:00:35 -04:00
Jesse Vincent
220be75473 Add a bit of logging to find out what webdav servers tell us about how
many messages they have in debug mode
2011-07-09 16:24:18 -04:00
Jesse Vincent
8cffc5b682 Bullet proofing for user-reported exceptions in WebDAV sync:
E/k9      ( 5735): java.lang.NullPointerException
E/k9      ( 5735):      at
com.kaitenmail.mail.store.WebDavStore$WebDavMessage.setNewHeaders(WebDavStore.java:1903)
E/k9      ( 5735):      at
com.kaitenmail.mail.store.WebDavStore$WebDavFolder.fetchEnvelope(WebDavStore.java:1655)
E/k9      ( 5735):      at
com.kaitenmail.mail.store.WebDavStore$WebDavFolder.fetchEnvelope(WebDavStore.java:1627)
E/k9      ( 5735):      at
com.kaitenmail.mail.store.WebDavStore$WebDavFolder.fetchEnvelope(WebDavStore.java:1627)
E/k9      ( 5735):      at
com.kaitenmail.mail.store.WebDavStore$WebDavFolder.fetchEnvelope(WebDavStore.java:1627)
E/k9      ( 5735):      at
com.kaitenmail.mail.store.WebDavStore$WebDavFolder.fetchEnvelope(WebDavStore.java:1627)
E/k9      ( 5735):      at
com.kaitenmail.mail.store.WebDavStore$WebDavFolder.fetch(WebDavStore.java:1404)
E/k9      ( 5735):      at
com.kaitenmail.controller.MessagingController.fetchUnsyncedMessages(MessagingController.java:1418)
E/k9      ( 5735):      at
com.kaitenmail.controller.MessagingController.downloadMessages(MessagingController.java:1253)
E/k9      ( 5735):      at
com.kaitenmail.controller.MessagingController.synchronizeMailboxSynchronous(MessagingController.java:1031)
E/k9      ( 5735):      at
com.kaitenmail.controller.MessagingController.access$400(MessagingController.java:81)
E/k9      ( 5735):      at
com.kaitenmail.controller.MessagingController$30.run(MessagingController.java:3768)
E/k9      ( 5735):      at
com.kaitenmail.controller.MessagingController.run(MessagingController.java:276)
E/k9      ( 5735):      at java.lang.Thread.run(Thread.java:1096)
2011-07-09 15:26:30 -04:00
Jesse Vincent
c7e8969b01 remove a bunch of listener notification duplication that crept into the
code. this caused all attachments to be double-opened, among other
things
2011-07-09 00:27:56 -04:00
cketti
a60a2a4295 Changed code to show/hide the correct views for CC/BCC
Fixes issue 3509
2011-07-07 04:59:45 +02:00
cketti
d310167b99 Rewrite mime type image/pjpeg to image/jpeg
Fixes issue 1712
2011-07-07 03:05:12 +02:00
Jesse Vincent
b02b895aaf Add 2MB, 5MB and "All" message download options 2011-07-02 15:29:49 -04:00
Jesse Vincent
2a698f1ab9 ant astyle 2011-07-02 15:18:43 -04:00
Jesse Vincent
2f48309f82 We forgot to HTML markup the body of the message in cases where we
weren't quoting any text
2011-06-20 18:26:19 -07:00
cketti
1bdf7095a7 Delete the old localized outbox. Fixes the "two outboxes" problem.
Rename the "new" hardcoded outbox to "K9MAIL_INTERNAL_OUTBOX". This
is done to avoid collisions with folders named "OUTBOX" in a remote
store. See
https://groups.google.com/group/k-9-mail/browse_thread/thread/cbb1c77abba84695

Fixes issue 3411
2011-06-17 06:17:01 +02:00
cketti
222cd43c80 Some code cleanup. No functional changes. 2011-06-17 04:13:32 +02:00
Marcus Wolschon
5eec09d37a Merge branch 'refs/heads/master' of git@github.com:k9mail/k-9.git 2011-06-14 15:23:20 +02:00
Marcus Wolschon
b8f04b8a4f typo 2011-06-14 15:22:45 +02:00
Jesse Vincent
a558466c36 ant astyle 2011-06-13 19:49:06 -04:00
Jesse Vincent
379a8dfa9e It turns out that 79a96952f2 has caused a
lot of messages to be unreadable in K-9 3.8.  (see mailing list
threads)
2011-06-09 21:54:22 -04:00
Fiouz
c416f02d52 Improve BACK button handling for MessageView
Remove memory leak from referencing MessageView context from the
Intent that is created to go back to MessageList. MessageView is no
longer hardcoded to go back to MessageList, it instead uses an Intent
given at creation to get back to the originating Activity.

Try our best to restore the MessageList in its previous state when
"Manage BACK button" option is enabled:
Since MessageList lives in its own task, we look for the previous
active task and check whether its top activity matches it. If it does,
we just finish MessageView and Android will automatically restore the
previous task. If it doesn't, we launch the originating Intent (and
MessageList state will be lost).

If option is off, we get the regular Android behavior: got back to the
previous screen, whenever it's the MessageList or another application
if the user long-pressed HOME.

The consequence of this is the need for a new permission in order to
check the previous active task: android.permission.GET_TASKS
2011-06-08 22:53:23 +02:00
Fiouz
5ee63c47fe Implemented BACK handling for MessageView
Implemented because MessageList is now in singleInstance launchMode so
the default behavior may not match user options.
2011-06-08 08:42:40 +02:00
Fiouz
9b0ce3c75a Remove no longer used references on confirmation dialog disapproval 2011-06-07 01:25:38 +02:00
Fiouz
fc4dd077e4 Don't attempt to configure a dismissed dialog during Android activity
reloading

As part of automatic activity reloading following a configuration
change, Android invokes Activity#onPrepareDialog() even for dismissed
dialogs. Consequently, one can't make the assumption that this method
is only invoked by explicit calls to Activity#showDialog() from our
code.

The actual problem here was the mActiveMessages member being null
at such times.
2011-06-07 01:15:04 +02:00
Fiouz
72870174ce Pluralize the "Move to spam" confirmation dialog since code paths were
unified in MessageList and multi-selection is now subject to this
dialog.
2011-06-05 01:35:11 +02:00
Fiouz
de7b75a1df Properly keep selection in case of a
configuration change (orientation, keyboard, etc.) during user
interaction (e.g. a dialog)
2011-06-05 01:16:34 +02:00
Fiouz
5366a07f28 Add @Override compiler check 2011-06-04 23:55:48 +02:00
Fiouz
190d028669 Javadoc fix 2011-06-04 23:17:47 +02:00
Fiouz
821a00e727 MessageList refactoring to remove duplicate code paths.
Message operations should be more consistent now, regardless of how
the messages are selected (long click, checkbox+Menu, future group selection).

This is a backport of the modifications made on the issue258 branch,
without the threading specific features (no new feature introduced).
2011-06-04 23:01:34 +02:00
Fiouz
40546edcf7 Remove local.properties, new default projection column introduced by merge d3cf49a5e4 2011-06-02 20:30:10 +02:00
Fiouz
d3cf49a5e4 Merge remote-tracking branch 'refs/remotes/unread/master' into unread 2011-06-02 20:20:56 +02:00
João Pedro Taveira
503b88e2fd Merge remote branch 'k-9/master' 2011-06-02 14:39:58 +01:00
Jesse Vincent
31adcd2ed8 Revert "http://code.google.com/p/k9mail/issues/detail?id=3408&sort=-id&colspec=ID%20Product%20Type%20Status%20Priority%20Milestone%20Owner%20Summary"
This reverts commit 0c2e06133c.

The patch would cause an extra SMTP connection on _any_ meesage with
attachments. Marcus is headed away on holiday and asked me to revert it
for him (after I asked him to revert it) - With luck, we'll talk through
a design to work around this issue on the list

Conflicts:

	src/com/fsck/k9/mail/transport/SmtpTransport.java
2011-06-02 09:35:03 -04:00
Jesse Vincent
3d583da450 ant astyle 2011-06-01 16:03:56 -04:00
Marcus Wolschon
0c2e06133c http://code.google.com/p/k9mail/issues/detail?id=3408&sort=-id&colspec=ID%20Product%20Type%20Status%20Priority%20Milestone%20Owner%20Summary
Issue 3408: 	SMTP timeouts while calculating message size
2011-06-01 09:13:16 +02:00
Marcus Wolschon
0b6f0a09bb http://code.google.com/p/k9mail/issues/detail?id=3407&sort=-id&colspec=ID%20Product%20Type%20Status%20Priority%20Milestone%20Owner%20Summary
Issue 3407: 	Handling of SMTP 5xx error codes unclean

fix part one: 5xx error codes are detected in SMTP-code and reported as permanent failures.
2011-06-01 09:07:05 +02:00
Andrew Gaul
2fd9bd5a03 Cleanup Utility.combine()
Fix spelling mistakes, simplify adding separators, use unsynchronized
StringBuilder, and fix Javadoc.
2011-05-31 15:11:36 +02:00
cketti
c5342472f2 Load AbsoluteSizeSpan(int,boolean) constructor via reflection
This will allow us to run on Android 1.5/1.6 devices.
2011-05-26 23:43:35 -04:00
Jesse Vincent
a9b28d62d7 Fix a NPE 2011-05-26 22:59:50 -04:00
cketti
30d31c7074 Explicitly use Locale.US when dealing with dates in message headers 2011-05-26 04:32:26 +02:00
cketti
de4abf87cb Respect "move/copy destination folders" setting in ChooseFolder
Fixes issue 2664
2011-05-26 04:11:09 +02:00
Jesse Vincent
92239739b0 microoptimize peekableInputStream's peek method to not do an extra
method dispatch and boolean check on every peek.
2011-05-24 21:35:18 -04:00
Jesse Vincent
29117ae7a6 Switch a StringBuffer to StringBuilder, which replaced it 2011-05-24 21:21:03 -04:00
Koji Arai
b4f3712246 Should retrieve just visibleLimit messages when the local folder is cleared. 2011-05-25 00:37:51 +09:00
Koji Arai
cb46f170cd Should reset visibleLimit on clear messages. 2011-05-25 00:37:49 +09:00
Koji Arai
a4f7288d37 Avoid NullPointerException.
The name parameter in Content-Type may be not set.
2011-05-25 00:37:46 +09:00
Koji Arai
90a5ca8ec2 Merge pull request #34 from jca02266/possible-to-toggle-quoted-text-display
Possible to toggle quoted text display
2011-05-24 08:33:53 -07:00
Koji Arai
7f93cfcbca Refactoring 2011-05-25 00:25:23 +09:00