Art O Cathain
520e327775
remove duplication
2015-03-08 11:26:54 +00:00
Art O Cathain
810d0cf6b4
Move default port and default TLS port to a single location
2015-03-08 11:05:53 +00:00
cketti
147db8cc5e
Configure 'developer mode' via BuildConfig
2015-03-07 00:30:50 +01:00
cketti
2f832e5fa4
Merge pull request #562 from artbristol/art/tidy-check-settings-async-task
...
Refactor to make code more readable
2015-03-06 23:52:22 +01:00
cketti
46bac187d5
Merge pull request #557 from artbristol/art/account-creation-refactor-2
...
Remove duplication, enum-ify String
2015-03-06 23:47:46 +01:00
cketti
67404b1883
Merge pull request #553
...
Remove redundant variable assignments
Minimize scope of local variables
2015-03-06 23:13:54 +01:00
cketti
abd2b20850
Minimize scope of local variables
2015-03-06 23:12:28 +01:00
cketti
29f7552c3a
Merge pull request #548
...
Rename Searchfield to SearchField
2015-03-06 23:00:18 +01:00
cketti
b826d4e98d
Use imports for inner classes
2015-03-06 21:19:27 +01:00
Art O Cathain
d0fa82269f
review comments
2015-02-23 17:28:42 +00:00
cketti
dd20ff5aa3
Merge pull request #561
...
Reduce code duplication in AccountSetupAccountType
2015-02-23 03:39:07 +01:00
cketti
737e0d2ac8
Minor code style fixes
2015-02-23 03:36:34 +01:00
cketti
d443a6d4eb
Add more tests
2015-02-23 02:58:16 +01:00
cketti
a979accb54
Add helper methods to get more readable tests
2015-02-23 02:58:16 +01:00
cketti
af491fdb41
Remove comments
2015-02-23 02:23:00 +01:00
cketti
084e7a1687
Change names of test methods
2015-02-23 02:22:10 +01:00
cketti
8fbb3edd1c
Fix code style
2015-02-23 01:45:30 +01:00
Art O Cathain
5035e7e3d1
review comments, also use == in preference to equals for enums
2015-02-22 21:30:26 +00:00
Valentin CAULIER
23c01b0390
MessageReference class, method equals() unit tests
2015-02-22 21:11:13 +01:00
Art O Cathain
a656a61c65
tidy method
2015-02-22 17:01:14 +00:00
Art O Cathain
d5d42469b0
Avoid confusing reuse of local variables
2015-02-22 16:03:58 +00:00
Art O Cathain
492d65feed
reduce duplication
2015-02-22 15:52:16 +00:00
Art O Cathain
1a706c3113
formatting
2015-02-18 19:48:17 +00:00
Art O Cathain
583a637d79
Remove duplication, enum-ify String
2015-02-18 19:42:33 +00:00
cketti
ebef8eccb9
Add missing placeholder for application ID
2015-02-17 00:45:36 +01:00
Art O Cathain
ffb4507776
Enums instead of int/String constants ( #547 )
...
simplify and add logging
simplify
use == for enum comparison to avoid type mistakes
enum name needs to match previous constant
simplify
Address review comments - formatting, and remove superfluous comment
Shorten DeletePolicy values since not used in settings strings; import enums to reduce clutter
fix whitespace
remove comment per review
address review comment
review comments
remove another superfluous qualification
Last changes
2015-02-16 22:22:05 +00:00
cketti
24e6b39dc0
Stop using Intent.setClassName()
...
Use the type-safe Intent constructor to reference internal classes.
2015-02-16 22:44:55 +01:00
cketti
461778ed11
Merge branch 'configurable_application_id'
2015-02-16 21:53:44 +01:00
cketti
ebeed31705
Fix search for non-default application ID
2015-02-16 21:38:16 +01:00
cketti
d703ac9148
Revert substitution of "com.fsck.k9" in implementation details
...
We don't need to change strings that are not exposed to the system/users.
2015-02-16 21:02:52 +01:00
cketti
9f1ecf7220
Merge pull request #555 from BombTeam/UnusedImportsRemoval
...
Remove unused import
2015-02-16 19:47:38 +01:00
cketti
b4900cc6af
Merge pull request #551 from BombTeam/remove-redundant-cast
...
Remove redundant casts
2015-02-16 18:46:15 +01:00
cketti
62c2894fce
Merge pull request #544 from BombTeam/StringGlitchCorrection
...
Fix height of buttons in wizard screens
2015-02-16 18:30:51 +01:00
Valentin CAULIER
80f8e4a81d
Removing java.util.Arrays import
2015-02-16 17:37:15 +01:00
Levrifon
0d0b80f142
Added placeholder for application ID
2015-02-16 16:53:38 +01:00
Marine
c4e202ecd9
remove redundant assignment to FolderSettings
...
removed null affectation because it’s done automatically
2015-02-16 15:31:03 +01:00
Marine
9bf546b33b
removed redundant assignment to AccountSetupBasics
...
removed null affectation because it’s done automatically
2015-02-16 15:25:36 +01:00
Marine
f5cac2c71f
remove redundant cast Button to WelcomeMessage
...
findViewById(R.id.next) and
findViewById(R.id.import_settings)
are Button so it’s redundant to cast it to Button
2015-02-16 15:10:34 +01:00
Marine
63047e0ac6
remove redundant cast (Button)
...
findViewById(R.id.pop) ,
findViewById(R.id.imap) and
findViewById(R.id.webdav)
are Button so it’s redundant to cast it to Button
2015-02-16 15:03:11 +01:00
Marine
980d799087
Rename from Searchfield to SearchField
2015-02-16 14:07:41 +01:00
qvandekadsye
9b1a0b3614
Applying "match-parent" value to "next" buttons.
2015-02-16 13:48:31 +01:00
cketti
aae71125c6
Merge pull request #523
...
Make sure to keep font meta info on view recycling
2015-02-15 17:43:11 +01:00
cketti
9df1a3ee80
Potentially avoid creating new Typeface instances
2015-02-15 17:38:10 +01:00
cketti
9c3cab2354
Don't show changelog dialog during UI tests
...
This will hopefully make the UI tests more stable.
2015-02-14 04:23:54 +01:00
qvandekadsye
5013f36ba4
re-correcting String glitch by changing layout-height attribute
2015-02-13 15:21:09 +01:00
Gabriel Burca
9ba2725ab1
Fixes issue 6703
...
- onPrepareActionMode must be called before computeBatchDirection
because computeBatchDirection ends up referencing mMarkAsRead /
mMarkAsUnread and mFlag / mUnflag which could be null otherwise.
2015-02-12 21:27:44 -06:00
cketti
74fdbb7859
Update openpgp-api-library to latest version
2015-01-27 12:15:47 +01:00
Jan Berkel
ecd316d0af
Simplify ImapConnection#connect
2015-01-14 04:41:21 +01:00
Jan Berkel
9523a589fc
use @Test(expected =
2015-01-14 04:31:36 +01:00
Jan Berkel
dfb025033d
Convert remaining tests to JUnit4
2015-01-14 04:05:42 +01:00