moparisthebest
/
k-9
mirror of https://github.com/moparisthebest/k-9
1
0
Fork 0
Code Issues Releases Wiki Activity
2,576 Commits 36 Branches 329 Tags 887 MiB
Commit Graph

1450 Commits

Author SHA1 Message Date
Jesse Vincent d7dfba15cf It appears that Exchange is returning responses 
without a visiblecount element for empty folders
Which resulted in this code returning -1 (as that was
the previous default.)
-1 is an error condition. Now the default is empty
 2011-07-09 17:00:35 -04:00
Jesse Vincent 220be75473 Add a bit of logging to find out what webdav servers tell us about how 
many messages they have in debug mode
 2011-07-09 16:24:18 -04:00
Jesse Vincent 8cffc5b682 Bullet proofing for user-reported exceptions in WebDAV sync: 
E/k9      ( 5735): java.lang.NullPointerException
E/k9      ( 5735):      at
com.kaitenmail.mail.store.WebDavStore$WebDavMessage.setNewHeaders(WebDavStore.java:1903)
E/k9      ( 5735):      at
com.kaitenmail.mail.store.WebDavStore$WebDavFolder.fetchEnvelope(WebDavStore.java:1655)
E/k9      ( 5735):      at
com.kaitenmail.mail.store.WebDavStore$WebDavFolder.fetchEnvelope(WebDavStore.java:1627)
E/k9      ( 5735):      at
com.kaitenmail.mail.store.WebDavStore$WebDavFolder.fetchEnvelope(WebDavStore.java:1627)
E/k9      ( 5735):      at
com.kaitenmail.mail.store.WebDavStore$WebDavFolder.fetchEnvelope(WebDavStore.java:1627)
E/k9      ( 5735):      at
com.kaitenmail.mail.store.WebDavStore$WebDavFolder.fetchEnvelope(WebDavStore.java:1627)
E/k9      ( 5735):      at
com.kaitenmail.mail.store.WebDavStore$WebDavFolder.fetch(WebDavStore.java:1404)
E/k9      ( 5735):      at
com.kaitenmail.controller.MessagingController.fetchUnsyncedMessages(MessagingController.java:1418)
E/k9      ( 5735):      at
com.kaitenmail.controller.MessagingController.downloadMessages(MessagingController.java:1253)
E/k9      ( 5735):      at
com.kaitenmail.controller.MessagingController.synchronizeMailboxSynchronous(MessagingController.java:1031)
E/k9      ( 5735):      at
com.kaitenmail.controller.MessagingController.access$400(MessagingController.java:81)
E/k9      ( 5735):      at
com.kaitenmail.controller.MessagingController$30.run(MessagingController.java:3768)
E/k9      ( 5735):      at
com.kaitenmail.controller.MessagingController.run(MessagingController.java:276)
E/k9      ( 5735):      at java.lang.Thread.run(Thread.java:1096)
 2011-07-09 15:26:30 -04:00
Jesse Vincent c7e8969b01 remove a bunch of listener notification duplication that crept into the 
code. this caused all attachments to be double-opened, among other
things
 2011-07-09 00:27:56 -04:00
cketti a60a2a4295 Changed code to show/hide the correct views for CC/BCC 
Fixes issue 3509
 2011-07-07 04:59:45 +02:00
cketti d310167b99 Rewrite mime type image/pjpeg to image/jpeg 
Fixes issue 1712
 2011-07-07 03:05:12 +02:00
Jesse Vincent b02b895aaf Add 2MB, 5MB and "All" message download options 2011-07-02 15:29:49 -04:00
Jesse Vincent 2a698f1ab9 ant astyle 2011-07-02 15:18:43 -04:00
Jesse Vincent 2f48309f82 We forgot to HTML markup the body of the message in cases where we 
weren't quoting any text
 2011-06-20 18:26:19 -07:00
cketti 1bdf7095a7 Delete the old localized outbox. Fixes the "two outboxes" problem. 
Rename the "new" hardcoded outbox to "K9MAIL_INTERNAL_OUTBOX". This
is done to avoid collisions with folders named "OUTBOX" in a remote
store. See
https://groups.google.com/group/k-9-mail/browse_thread/thread/cbb1c77abba84695

Fixes issue 3411
 2011-06-17 06:17:01 +02:00
cketti 222cd43c80 Some code cleanup. No functional changes. 2011-06-17 04:13:32 +02:00
Marcus Wolschon 5eec09d37a Merge branch 'refs/heads/master' of git@github.com:k9mail/k-9.git 2011-06-14 15:23:20 +02:00
Marcus Wolschon b8f04b8a4f typo 2011-06-14 15:22:45 +02:00
Jesse Vincent a558466c36 ant astyle 2011-06-13 19:49:06 -04:00
Jesse Vincent 379a8dfa9e It turns out that 79a96952f2 has caused a 
lot of messages to be unreadable in K-9 3.8.  (see mailing list
threads)
 2011-06-09 21:54:22 -04:00
Fiouz c416f02d52 Improve BACK button handling for MessageView 
Remove memory leak from referencing MessageView context from the
Intent that is created to go back to MessageList. MessageView is no
longer hardcoded to go back to MessageList, it instead uses an Intent
given at creation to get back to the originating Activity.

Try our best to restore the MessageList in its previous state when
"Manage BACK button" option is enabled:
Since MessageList lives in its own task, we look for the previous
active task and check whether its top activity matches it. If it does,
we just finish MessageView and Android will automatically restore the
previous task. If it doesn't, we launch the originating Intent (and
MessageList state will be lost).

If option is off, we get the regular Android behavior: got back to the
previous screen, whenever it's the MessageList or another application
if the user long-pressed HOME.

The consequence of this is the need for a new permission in order to
check the previous active task: android.permission.GET_TASKS
 2011-06-08 22:53:23 +02:00
Fiouz 5ee63c47fe Implemented BACK handling for MessageView 
Implemented because MessageList is now in singleInstance launchMode so
the default behavior may not match user options.
 2011-06-08 08:42:40 +02:00
Fiouz 9b0ce3c75a Remove no longer used references on confirmation dialog disapproval 2011-06-07 01:25:38 +02:00
Fiouz fc4dd077e4 Don't attempt to configure a dismissed dialog during Android activity 
reloading

As part of automatic activity reloading following a configuration
change, Android invokes Activity#onPrepareDialog() even for dismissed
dialogs. Consequently, one can't make the assumption that this method
is only invoked by explicit calls to Activity#showDialog() from our
code.

The actual problem here was the mActiveMessages member being null
at such times.
 2011-06-07 01:15:04 +02:00
Fiouz 72870174ce Pluralize the "Move to spam" confirmation dialog since code paths were 
unified in MessageList and multi-selection is now subject to this
dialog.
 2011-06-05 01:35:11 +02:00
Fiouz de7b75a1df Properly keep selection in case of a 
configuration change (orientation, keyboard, etc.) during user
interaction (e.g. a dialog)
 2011-06-05 01:16:34 +02:00
Fiouz 5366a07f28 Add @Override compiler check 2011-06-04 23:55:48 +02:00
Fiouz 190d028669 Javadoc fix 2011-06-04 23:17:47 +02:00
Fiouz 821a00e727 MessageList refactoring to remove duplicate code paths. 
Message operations should be more consistent now, regardless of how
the messages are selected (long click, checkbox+Menu, future group selection).

This is a backport of the modifications made on the issue258 branch,
without the threading specific features (no new feature introduced).
 2011-06-04 23:01:34 +02:00
Fiouz 40546edcf7 Remove local.properties, new default projection column introduced by merge d3cf49a5e4 2011-06-02 20:30:10 +02:00
Fiouz d3cf49a5e4 Merge remote-tracking branch 'refs/remotes/unread/master' into unread 2011-06-02 20:20:56 +02:00
João Pedro Taveira 503b88e2fd Merge remote branch 'k-9/master' 2011-06-02 14:39:58 +01:00
Jesse Vincent 31adcd2ed8 Revert "http://code.google.com/p/k9mail/issues/detail?id=3408&sort=-id&colspec=ID%20Product%20Type%20Status%20Priority%20Milestone%20Owner%20Summary" 
This reverts commit 0c2e06133c.

The patch would cause an extra SMTP connection on _any_ meesage with
attachments. Marcus is headed away on holiday and asked me to revert it
for him (after I asked him to revert it) - With luck, we'll talk through
a design to work around this issue on the list

Conflicts:

	src/com/fsck/k9/mail/transport/SmtpTransport.java
 2011-06-02 09:35:03 -04:00
Jesse Vincent 3d583da450 ant astyle 2011-06-01 16:03:56 -04:00
Marcus Wolschon 0c2e06133c http://code.google.com/p/k9mail/issues/detail?id=3408&sort=-id&colspec=ID%20Product%20Type%20Status%20Priority%20Milestone%20Owner%20Summary 
Issue 3408: 	SMTP timeouts while calculating message size
 2011-06-01 09:13:16 +02:00
Marcus Wolschon 0b6f0a09bb http://code.google.com/p/k9mail/issues/detail?id=3407&sort=-id&colspec=ID%20Product%20Type%20Status%20Priority%20Milestone%20Owner%20Summary 
Issue 3407: 	Handling of SMTP 5xx error codes unclean

fix part one: 5xx error codes are detected in SMTP-code and reported as permanent failures.
 2011-06-01 09:07:05 +02:00
Andrew Gaul 2fd9bd5a03 Cleanup Utility.combine() 
Fix spelling mistakes, simplify adding separators, use unsynchronized
StringBuilder, and fix Javadoc.
 2011-05-31 15:11:36 +02:00
cketti c5342472f2 Load AbsoluteSizeSpan(int,boolean) constructor via reflection 
This will allow us to run on Android 1.5/1.6 devices.
 2011-05-26 23:43:35 -04:00
Jesse Vincent a9b28d62d7 Fix a NPE 2011-05-26 22:59:50 -04:00
cketti 30d31c7074 Explicitly use Locale.US when dealing with dates in message headers 2011-05-26 04:32:26 +02:00
cketti de4abf87cb Respect "move/copy destination folders" setting in ChooseFolder 
Fixes issue 2664
 2011-05-26 04:11:09 +02:00
Jesse Vincent 92239739b0 microoptimize peekableInputStream's peek method to not do an extra 
method dispatch and boolean check on every peek.
 2011-05-24 21:35:18 -04:00
Jesse Vincent 29117ae7a6 Switch a StringBuffer to StringBuilder, which replaced it 2011-05-24 21:21:03 -04:00
Koji Arai b4f3712246 Should retrieve just visibleLimit messages when the local folder is cleared. 2011-05-25 00:37:51 +09:00
Koji Arai cb46f170cd Should reset visibleLimit on clear messages. 2011-05-25 00:37:49 +09:00
Koji Arai a4f7288d37 Avoid NullPointerException. 
The name parameter in Content-Type may be not set.
 2011-05-25 00:37:46 +09:00
Koji Arai 90a5ca8ec2 Merge pull request #34 from jca02266/possible-to-toggle-quoted-text-display 
Possible to toggle quoted text display
 2011-05-24 08:33:53 -07:00
Koji Arai 7f93cfcbca Refactoring 2011-05-25 00:25:23 +09:00
Koji Arai 33a92b11a2 Use the Button instead of the ImageButton. 2011-05-22 04:12:41 +09:00
Koji Arai ce9b280746 Added account preference to display quoted text. 2011-05-22 03:56:51 +09:00
Koji Arai 5d6df85aac possible to toggle to display the quoted message to send. 2011-05-22 03:55:50 +09:00
cketti 4f67a6be24 Fixed counting of new unread messages 2011-05-21 00:33:43 +02:00
cketti 6c1b1ebf32 Moved checks from notifyAccount() to shouldNotifyForMessage() 
This should fix the "notification count" for cases where messages
passed the shouldNotifyForMessage() checks but not the ones in
notifyAccount().
 2011-05-20 23:00:48 +02:00
cketti 2d7fad1fa9 Use InetAddress.getCanonicalHostName() instead of getHostName() 
This should always return a FQDN.
 2011-05-19 00:55:34 +02:00
cketti 8fc714ac4a Don't show "null" for partially downloaded messages with empty text body 2011-05-16 00:36:46 +02:00
cketti 41b039b691 Fix bug introduced with commit b7a6dbd973 
Fixes issue 3297
 2011-05-15 16:23:53 +02:00
cketti 95288b37d7 Removed unnecessary method implementation 
Make Pop3Folder.setFlags(Flag[],boolean) throw an
UnsupportedOperationException instead of calling a method that does
just that.
 2011-05-14 23:46:26 +02:00
cketti dc96bf3186 Only mark all messages as read on the server if that's supported 
This change prevents K-9 Mail from establishing a connection to the
server when all messages are marked as read on a POP3 account.
 2011-05-14 23:30:47 +02:00
cketti ba9bc2f8e9 Added method Folder.isFlagSupported(Flag) 2011-05-14 23:19:24 +02:00
cketti e90a479384 Renamed member variables to match code style guidelines 2011-05-14 22:17:15 +02:00
cketti 92b17ec2e2 Hide "Show only subscribed folders" checkbox for POP3 accounts 2011-05-14 22:15:39 +02:00
cketti 86fca9c1f2 POP3: Check for support of the TOP command (if CAPA isn't supported) 
This will allow to download partial messages if the server doesn't
support the CAPA command but supports the TOP command (e.g. Hotmail).

Fixes issue 2042
 2011-05-14 21:40:21 +02:00
cketti 969e2d93fd Don't use the "owner name" as default value for the email name 
Get rid of Contacts.getOwnerName() and associated permissions.

Fixes issue 3331
 2011-05-14 04:53:17 +02:00
Andrew Chen e5d952bff4 Save and restore the cursor position when saving or loading a draft. This is the first step in making "resume composition on context switch" a reality. 2011-05-10 15:23:25 -07:00
Marcus Wolschon e0ef94f64b Issue 3319: unseen message count can add up to infinity 2011-05-09 11:21:24 +02:00
cketti 8e1c4acef9 Get rid of constant K9.OUTBOX 
Use Account.getOutboxFolderName() instead (still hardcoded, though)
 2011-05-08 02:22:38 +02:00
cketti f4931a3167 Get rid of constant K9.INBOX 
Use Account.getInboxFolderName() instead
 2011-05-08 02:17:23 +02:00
cketti 92ea452163 Restore hardcoded Outbox 2011-05-07 23:57:47 +02:00
cketti 33c0bf9e31 Avoid NullPointerException for messages with html_content = NULL in DB 
Fixes issue 3302
 2011-05-06 20:02:55 +02:00
Andrew Chen e12dd323f8 Issue 3105: Drop newlines in favor of preserving multiple spaces in htmlified text bodies. 2011-05-05 13:52:47 -07:00
Jesse Vincent cfd1ad7cdb comment some htmlifciation regexes 2011-05-05 12:50:45 -04:00
Jesse Vincent 8a907f9be7 remove a pointless extra assignment 2011-05-05 12:47:57 -04:00
Jesse Vincent 196a9c167d comment some preview regexes 2011-05-05 12:47:39 -04:00
Andrew Chen 1ea27d7020 Issue 3105: Generate proper HTML-ified versions of text messages so that textification of the HTMLified text message preserves the original newlines. 2011-05-05 00:17:34 -07:00
Andrew Chen 3fcca67ae5 Preserve legacy SMTP authentication behavior for PLAIN by trying LOGIN if supported. 2011-05-04 23:34:02 -07:00
cketti 71c5e3c611 Remove unnecessary null pointer check 2011-05-05 02:54:20 +02:00
cketti 141e2d2ad9 Make the "pick directory intent" array a constant 2011-05-05 02:52:47 +02:00
cketti 837b7da206 Changed order of pick directory intents 2011-05-05 02:36:15 +02:00
jmccabe 50b6d62169 Refactor of showFileBrowserActivity to add a couple of extra options 
to the list of possible file browser intents (ES File Explorer and
Blackmoon File Browser) and simplify possible future updates.
 2011-05-05 08:29:05 +08:00
Koji Arai 870791958f Refresh folder list when folder is cleared 2011-05-05 07:08:33 +09:00
Vitaly Polonetsky 37ae2e41f5 fixed displaying of "(null)" account description in notification at account setup wizard 2011-05-05 04:38:33 +08:00
João Pedro Taveira af7d57561f Message ContentProvider field rename from READED to UNREAD to maintain 
names consistency.
 2011-05-02 16:00:04 +01:00
cketti 01937d4ab8 Don't crash if "footer view" is clicked in search results 
Fixes issue 3071
 2011-05-01 05:34:17 +02:00
Bernhard Redl f2283aa91e Catch IllegalCharsetNameException causing force-close on unsupported japanese charsets (issue 3272) 2011-05-01 04:32:10 +02:00
cketti b7a6dbd973 Skip IMAP folders with names that are not correctly encoded. 
Configure the CharsetDecoder to throw an exception if malformed input
is encountered. Not doing this can cause an endless loop that
allocates memory until the application dies with an OutOfMemory error.
Until we have support for both a folder display name and a raw folder
name we simply ignore folders with names that aren't correctly encoded
with the modified UTF-7 variant.

Fixes issue 3268

Credits: Bernhard Redl (aatdark) analysed the problem and wrote the
initial version of the fix.
 2011-04-28 04:46:01 +02:00
cketti 037b0ff64d Fix automatic authentication method selection for SMTP 
Only use automatic authentication method selection if none was
explicitly selected in outgoing server settings.
 2011-04-26 18:23:41 +02:00
cketti e8a1a9a466 Restored semantics of auth*Supported in SMTP authentication code 
Also, display a debug message if a certain authentication method was
selected by the user but the server didn't advertise support for it in
the EHLO response.
 2011-04-26 17:49:40 +02:00
cketti 80f60a06ca Merged pull request #21 from jott/master. 
Support for SMTP authentication methods that are not announced by the server.
 2011-04-26 08:18:49 -07:00
Koji Arai 9b2e4c43a9 Fixed default sender color in the MessageList 2011-04-26 23:49:25 +09:00
Jonas Hurrelmann da38149091 Support for SMTP authentication methods that are not announced by the server. 
- Added AUTOMATIC as a new authentication method that will automatically choose the best authentication method (basically old behavior with CRAM_MD5). All other options will now enforce the selected authentication method.
- Added LOGIN as selectable option.
- Cleaned up code so strings to the different authentication methods are only defined once.
 2011-04-25 22:32:48 +02:00
Jesse Vincent c3480db129 Add missing file from the file chooser work 2011-04-25 13:17:18 +10:00
Bernhard Redl f90fccbfa7 fix NullPtr Exception when there is no Sent Mail folder on the imap server 2011-04-24 14:19:58 +10:00
Bernhard Redl ab4bae214f Make attachment saving respect the new preference. Allow long-press to 
choose a folder.

(new constant renamed from CHOOSE_FOLDER to CHOOSE directory for
clarity)
 2011-04-24 14:01:03 +10:00
Bernhard Redl 96842b3ce6 Unroll import statements in AttachmentView.java 2011-04-24 13:56:54 +10:00
Bernhard Redl e278ea23e9 Add a preference for selecting a default folder in which to save attachments 2011-04-24 13:55:25 +10:00
cketti 4b2fe6efab Removed unused imports 2011-04-21 00:00:16 +02:00
cketti 49308922d9 Refactored code to calculate number of unread messages some more 2011-04-20 23:58:10 +02:00
Bernhard Redl 92f7c3a19f Refactored the code to calculate the number of unread messages in an account 2011-04-20 23:35:02 +10:00
Bernhard Redl 415c11d712 "When calculating the number of unread messages shown in the account list, INBOX now is always counted, even if a "special" folder has been set to INBOX (issue 3074) 2011-04-20 23:09:02 +10:00
Bernhard Redl 120a39d5d6 * Fix Bug https://code.google.com/p/k9mail/issues/detail?id=3224 
12/24 timesetting is no based on the android system settings
 2011-04-20 10:12:59 +08:00
Marcus Wolschon 6f4bef3530 Issue 3259: Show SubjectAltNames in acceptKeyDialog 2011-04-19 10:46:17 +02:00
Marcus Wolschon 59399506df fixed very rare NullPointerException 2011-04-19 09:01:01 +02:00
Jesse Vincent 724b6eaaa5 For a while, it was possible for users to conifgure their outbox and 
drafts folders to be the same folder. This could result in drafts being
sent over and over.  This change uses the K-9 Identity header as a
shibboleth for drafts, as it's not actually set when a message is sent.
 2011-04-17 21:07:13 +10:00
Koji Arai 659a5d36b2 Fixed issue 2991: Should display colorized name in the message list. 2011-04-16 18:16:33 +09:00
mwolschon 7f5c18bd2b updated comments 2011-04-14 10:07:33 +02:00