Commit Graph

8 Commits

Author SHA1 Message Date
Joe Steele 927950b16c Change LocalKeyStore error reporting
The error reporting assures an exception is thrown if
setKeyStoreFile(null) is called without a prior call to
setKeyStoreLocation(String directory).

Also, fix TrustManagerFactoryTest indentation.
2013-12-17 02:37:38 +01:00
Joe Steele 8099aff8e7 Eliminate the need to pass a context to LocalKeyStore.getInstance
Instead, have K9.onCreate initialize the location of the key
store file (similar to what is done with
BinaryTempFileBody.setTempDirectory).

Also, LocalKeyStore.getInstance has been changed so that it
no longer needs to be synchronized.
2013-12-17 02:37:37 +01:00
Joe Steele 255bf1fb36 Don't delete certs. on account creation, & assure that only one instance of LocalKeyStore is created. 2013-12-17 02:37:37 +01:00
cketti 8d85fe7e9e Remove LocalKeyStore's dependency on K9.app 2013-12-17 02:37:37 +01:00
cketti 16aa119d65 Remove LocalKeyStore's dependency on Account to reduce coupling 2013-12-17 02:37:37 +01:00
Joe Steele 7296b67126 "upgrade" the LocalKeyStore
Implement an "upgrade" capability for the key store file,
and then use it to delete the old file.

The existing certs in the old file are not a security
risk, but they are now useless because the format of
their aliases was changed in commit a4440b4.  They now are
just taking up storage space and memory.

Users will need to re-accept *ALL* certificates that they had
previously accepted and are still using.  (Actually, this requirement
was effective with commit 4b57d79a.  Before that, certificates whose
Subject matched did not require re-accepting.)
2013-12-17 02:35:27 +01:00
Joe Steele 7a9663c4f9 Implement pruning of old certificates from LocalKeyStore
Certificates are deleted whenever server settings are changed
or an account is deleted.
2013-12-17 02:35:27 +01:00
Joe Steele fd9eb78aa3 Move some classes out of com.fsck.k9.mail.store
The classes are just as much related to com.fsck.k9.mail.transport
as com.fsck.k9.mail.store, so having them in
com.fsck.k9.mail.store doesn't seem appropriate.

Move LocalKeyStore to com.fsck.k9.security

Move TrustManagerFactory and TrustedSocketFactory to com.fsck.k9.net.ssl
2013-12-17 02:35:26 +01:00