moparisthebest
/
k-9
mirror of https://github.com/moparisthebest/k-9
1
0
Fork 0
Code Issues Releases Wiki Activity
2,493 Commits 36 Branches 329 Tags 887 MiB
Commit Graph

121 Commits

Author SHA1 Message Date
Jesse Vincent 3d583da450 ant astyle 2011-06-01 16:03:56 -04:00
cketti 41b039b691 Fix bug introduced with commit b7a6dbd973 
Fixes issue 3297
 2011-05-15 16:23:53 +02:00
cketti 8e1c4acef9 Get rid of constant K9.OUTBOX 
Use Account.getOutboxFolderName() instead (still hardcoded, though)
 2011-05-08 02:22:38 +02:00
cketti b7a6dbd973 Skip IMAP folders with names that are not correctly encoded. 
Configure the CharsetDecoder to throw an exception if malformed input
is encountered. Not doing this can cause an endless loop that
allocates memory until the application dies with an OutOfMemory error.
Until we have support for both a folder display name and a raw folder
name we simply ignore folders with names that aren't correctly encoded
with the modified UTF-7 variant.

Fixes issue 3268

Credits: Bernhard Redl (aatdark) analysed the problem and wrote the
initial version of the fix.
 2011-04-28 04:46:01 +02:00
bitblaster 20a9043a13 Replaced references to K9.INBOX with account.getInboxFolderName() 2011-04-12 22:17:11 +10:00
Jesse Vincent 0174988d27 astyle 2011-04-12 22:16:22 +10:00
cketti 2cadff74b1 Extracted CRAM-MD5 computation into separate class. 
This gets rid of duplicated code in ImapStore, Pop3Store, and
SmtpTransport.
 2011-04-07 17:11:32 +02:00
Jesse Vincent 97ec38d03f Move our IMAP Store to using a message's sizing method 2011-03-27 23:09:41 +08:00
cketti 83451cff10 Merge branch 'remove_non_api_dependencies' 2011-03-24 19:35:12 +01:00
cketti 330737c4c6 Fix length-check of BODYSTRUCTURE reply 
Fixes issue 3116
 2011-03-15 08:34:38 +01:00
cketti 171711fa9c Remove trailing space from IMAP command 
This could be the cause of the error reported in issue 3089.
 2011-03-04 03:36:52 +01:00
cketti 6f90d791b5 Removed dependency on (external) commons-codec and commons-logging 2011-02-26 17:36:18 +01:00
cketti 397d01d513 Fix bug with partitioning of IMAP FETCH commands 2011-02-21 21:07:56 +01:00
Matt Johnston d43f17ab94 Use java.util.zip for inflating 
Can't use it for deflating since it doesn't have Z_PARTIAL_FLUSH
 2011-02-21 04:57:46 +08:00
cketti 737cff0612 Hardcode folder name for (local) outbox and don't show outbox when 
only being allowed to select remote folders.
 2011-02-20 04:47:28 +01:00
Jesse Vincent 12d1097a24 Big, scary massive "ant astyle" to get us back to something 
approximating AOSP coding standards.
 2011-02-06 17:09:48 -05:00
Jesse Vincent 6550151684 Add serialVersionUID to Serializable classes to make eclipse happy 2011-01-31 23:45:14 +00:00
cketti 22834d6998 Removed unnecessary null pointer checks 2011-01-19 01:30:13 +00:00
Andrew Chen e56b044bbc Add support for HTML composition with text alternative. 
Revamp K9 Identity string.
Quote names in Address only when needed.
Remove quoted text bar and move button to quoted text area.
 2011-01-12 23:48:28 +00:00
Jesse Vincent 9c847d3e9d minor code cleanup 2011-01-06 16:55:34 +00:00
cketti f9f6160719 Correctly encode/escape strings when used in IMAP commands. 
Fixes issue 2832
 2011-01-06 00:39:09 +00:00
Jesse Vincent 9f4790088e Escape backslashes in IMAP mailbox names 2011-01-05 13:12:30 +00:00
Jesse Vincent 29fdb81f9b Fix for the "K9 skips every 101st message when fetching on IMAP" bug by 
e-t172 <e-t172@akegroup.org>. Fixes Issue 2819
 2010-12-30 23:57:41 +00:00
Fiouz 47762a9baa Remove coupling between ImapStore and ImapConnection by adding an settings indirection interface. Purpose: use the IMAP connection code to validate credentials without having an actual ImapStore instance. 2010-12-30 21:57:59 +00:00
Fiouz 05a8a31d4a Don't reference the enclosing type instance when it's not used (memory optimisation) 2010-12-14 19:26:51 +00:00
Jesse Vincent f5eb6e03af astyle 2010-12-01 06:32:29 +00:00
Jesse Vincent 78c900b5fe remove redundant ;s 2010-12-01 03:07:28 +00:00
Jesse Vincent cead5c7060 flip some loops to using java internals instead (per intellij) 2010-12-01 03:04:57 +00:00
Jesse Vincent c79ea226a5 Remove "throws" declarations that didn't actually get thrown. Remove a 
couple of try blocks that only caught throws we didn't throw. IntelliJ
optimization.
 2010-12-01 03:02:13 +00:00
Jesse Vincent 43cef54ad6 We don't cache positive DNS lokups. We shouldn't cache negative DNS lookups either 2010-11-21 02:10:59 +00:00
Marcus Wolschon b723769e65 translated "unable to connect". 2010-10-28 14:37:48 +00:00
Jesse Vincent 6061c42ea9 find src/com/fsck/ -name \*.java|xargs astyle --style=ansi --mode=java --indent-switches --indent=spaces=4 --convert-tabs 2010-10-05 06:04:28 +00:00
cketti 8cf2655dd8 Reverted r2332 and r2333 because the cause of the problem reported in issue 2078 seems to be different than initially thought. 2010-09-09 23:52:06 +00:00
cketti a85ea2ee53 - Reworked the previous patch with suggestions by jessev to be as runtime/memory efficient as possible without being useless. 
- Output debug message when invalid responses are encountered.
 2010-09-03 15:32:25 +00:00
cketti b9b15295cd Added yet another work-around for an IMAP server implementation with a creative interpretation of the specification. Sanity check results returned for a SEARCH command. 
Fixes issue 2078
 2010-09-03 13:58:09 +00:00
Jesse Vincent 7d2804549e Remove redundant "return" statements from the end of void methods (with 
help from intellij)
 2010-08-29 23:39:45 +00:00
Jesse Vincent 4f0bce1569 Simplify many, many boolean conditions with help from IntelliJ 2010-08-29 23:39:26 +00:00
Jesse Vincent ff5024eaec astyle 2010-08-18 02:48:55 +00:00
Jesse Vincent 8832933a60 It turns out that if you're only fetching the bodystructure, the mime4j 
parser can't parse the message.
 2010-08-17 04:21:22 +00:00
Jesse Vincent ece68bae5d Off-by-one error in the recent IMAP fetch work :/ 2010-08-12 02:21:56 +00:00
Jesse Vincent 0229d8a1fe Implement windowing for IMAP UID FETCH 
Our previous implementation of UID FETCH didn't ever take into account
maximum command line lengths. When fetching, say 800 messages from a
GMail IMAP server, we could easily overflow the max line length leading
to a fetch that didn't get all the messages we wanted to and was
truncated before the description of which fields we want. That caused
K-9 to fetch complete messages, exhaust memory and ultimately fail,
even when we were just trying to get message lengths.

An equivalent fix needs to be made to seach by UID.
 2010-08-11 03:36:40 +00:00
Fiouz dfb8f9e0f2 Memory management optimisation: help garbage collection by avoiding repeated instantiations of immutable arrays (empty arrays of String, Message, Flag, Address) 2010-08-07 15:10:07 +00:00
Jesse Vincent 7464a1527a Convert for loops to "enhanced" syntax per SDK performance guidelines 
(Automatic with Eclipse)
 2010-07-19 01:52:18 +00:00
Jesse Vincent 8ab165ef31 Allow per-protocol configuration of which wire protocols are 
debug-logged
 2010-07-13 21:16:42 +00:00
Jesse Vincent 5a43acff2a Rather than accidentally reusing a public API function name with a 
different signature, give the private command to pull a count
from the remote imap store its own name
 2010-07-11 15:41:20 +00:00
Jesse Vincent 20e47991c3 astyle 2010-07-11 15:39:26 +00:00
Jesse Vincent c359b2c6bf Comment out redundant logging of IMAP commands 
Each IMAP command was logged 3 times in normal operation. It seriously
clouds the logs and makes it much harder to read and debug ongoing
connections
 2010-07-11 12:31:47 +00:00
Jesse Vincent 7a543b45b1 Remove duplicate code between two message counting routines in ImapStore 2010-07-11 12:31:34 +00:00
Jesse Vincent 9321a045d9 When counting remote unseen/flagged messages, don't window to only the 
most recent 300 messages - Since we display this # to the user, the
"last 300" heuristic ends up confusing and _wrong_ on a regular basis.
 2010-07-11 12:31:22 +00:00
Jesse Vincent ae339f1ac8 Add a per-account setting to choose how much of each message to download automatically. 2010-07-11 11:59:14 +00:00