Commit Graph

3094 Commits

Author SHA1 Message Date
Andrew Chen 105948d78c Oops, checking wrong platform capability. 2014-12-04 19:14:22 -08:00
Andrew Chen 1fa6e117e1 Add Lollipop lock screen notifications.
Add vector versions for some notification icons (yay Illustrator)
Add comments reminding people to add their settings to GlobalSettings.
<plurals> support for notification_new_messages_title
Not sure why #ffffffff is resulting in black with targetSdk 17.
2014-12-04 18:54:22 -08:00
Danny Baumann aaf3963567 Don't throw CertificateValidationException for all SSLExceptions.
An interrupted connection attempt to the server yields an SSLException
as well, like this:

E/k9      ( 6937): Caused by: javax.net.ssl.SSLHandshakeException: Connection closed by peer
E/k9      ( 6937):      at com.android.org.conscrypt.NativeCrypto.SSL_do_handshake(Native Method)
E/k9      ( 6937):      at com.android.org.conscrypt.OpenSSLSocketImpl.startHandshake(OpenSSLSocketImpl.java:302)
E/k9      ( 6937):      at com.android.org.conscrypt.OpenSSLSocketImpl.waitForHandshake(OpenSSLSocketImpl.java:598)
E/k9      ( 6937):      at com.android.org.conscrypt.OpenSSLSocketImpl.getInputStream(OpenSSLSocketImpl.java:560)
E/k9      ( 6937):      at com.fsck.k9.mail.store.ImapStore$ImapConnection.open(ImapStore.java:2459)

We don't want the user to notify of 'certificate problems' in that case.
Fix it by checking whether the SSLException was actually triggered by a
CertificateException.
2014-12-04 13:16:33 +01:00
cketti 98b5d63909 Merge branch 'open_attachment_improvements'
Conflicts:
	src/com/fsck/k9/helper/Utility.java
2014-11-27 21:03:15 +01:00
Art O Cathain 552e552e88 Add unit tests for FileHelper.sanitizeFilename() 2014-11-18 23:50:14 +01:00
cketti 56c30095e2 Don't use dummy file path when resolving intents 2014-11-18 23:02:20 +01:00
cketti d9b6e10cbe Change the way the best view intent is determined
First we try the original MIME type unless it's application/octet-stream.
Then we try the MIME type inferred from the attachment's file extension.
Then we fall back to application/octet-stream.

In all cases we first try the content:// URI, then a file:// URI.
2014-11-18 22:55:51 +01:00
cketti a725099693 Merge pull request #499 from k9mail/remove_apg_interface
Remove APG legacy interface
2014-11-12 21:08:46 +01:00
cketti 9b61fe0f0e Merge remote-tracking branch 'k9mail_pgp_mime/master'
Conflicts:
	src/com/fsck/k9/activity/AccessibleEmailContentActivity.java
2014-11-12 19:22:53 +01:00
cketti 9e6fc7c7d1 Merge pull request #13 from k9mail/art/update-certificates-in-tests
Update certificates in tests
2014-11-12 16:30:53 +01:00
cketti 0f70d5db40 Merge pull request #12 from k9mail/art/warn-if-not-serializable
Art/warn if not serializable
2014-11-11 19:52:31 +01:00
cketti bd4a236525 Merge pull request #11 from k9mail/art/fix-tests-on-jvm
fix tests on JVM
2014-11-11 19:46:58 +01:00
cketti 7211080415 Merge pull request #10 from k9mail/art/more-tidying-arrays
Replace many arrays with collections
2014-11-11 19:45:35 +01:00
cketti 87ca0d3d2a Use TemporaryAttachmentStore when viewing attachments using file:// URI 2014-11-11 02:11:51 +01:00
cketti 34cfd8e5b4 Extract file related helper functions into separate class 2014-11-11 01:04:39 +01:00
cketti e64ca84f1b Simplify MediaScannerNotifier 2014-11-10 06:43:26 +01:00
cketti c3f1420ef6 Don't open the file after the media scanner added it to the media content provider 2014-11-10 06:43:00 +01:00
cketti dfd40659d1 Append file name to content:// URI
This allows intent filters with patterns for file extensions to match.
2014-11-10 05:46:38 +01:00
cketti 6a1905b7b7 If we can't find an app to view an attachment try again with a file:// URI
Sadly, some apps only support the 'file' scheme in their intent filters. Among
them is Android's own package installer.
2014-11-10 05:37:22 +01:00
cketti 44ecf5d588 Use MIME type used for intent resolution in content provider 2014-11-10 03:12:28 +01:00
cketti f87ab53b9b Try original and inferred MIME type to find best viewer for attachment
In order for Android to find apps that are capable of opening an attachment for
viewing the ACTION_VIEW Intent needs to contain an appropriate MIME type.
Ideally, we'd use the MIME type specified for the attachment in the message.
But often the supplied MIME type is wrong/useless. So we look at the file
extension to try to come up with a sensible MIME type on our own. We then go
on to ask Android which of the two MIME types leads to more apps claiming to
be able to open our attachment for viewing and use that one.
2014-11-10 03:10:09 +01:00
cketti 11a9eff109 Extract intent creation code to method 2014-11-09 20:46:46 +01:00
cketti 6cb3c991db No longer pretend there are attachment types we don't care about 2014-10-20 21:26:18 -04:00
cketti 3c4ad91614 Fix method names/visibility 2014-10-20 21:24:18 -04:00
cketti d3073be89a Rearrange fields/methods 2014-10-20 21:21:09 -04:00
cketti 83d876f246 Inline method 2014-10-20 21:16:31 -04:00
cketti f6822c973d Clean up comments 2014-10-20 21:13:58 -04:00
cketti 1e89314f3e Remove "m" prefix for field names 2014-10-20 21:09:23 -04:00
cketti b3bc85ba10 Split 'populateFromPart' into multiple methods 2014-10-20 21:06:31 -04:00
cketti ca88f59c05 Create named class for loading and displaying attachment thumbnails 2014-10-20 20:46:46 -04:00
cketti 4299eb9771 Rename method and improve documentation 2014-10-20 20:28:38 -04:00
cketti 4a6c52947d Make all fields of AttachmentView private 2014-10-20 20:14:04 -04:00
cketti 0ced8746af Remove old/unused code from click handler 2014-10-20 20:05:21 -04:00
cketti 187d760e5f Extract code to display error/status messages to a separate method 2014-10-20 19:50:41 -04:00
cketti dfe1771fcb Fix formatting 2014-10-20 19:39:16 -04:00
cketti b7a8c9b707 Remove unused code 2014-10-20 19:34:16 -04:00
Art O Cathain 438a350f55 remove unnecessary method parameters 2014-10-19 18:40:17 +01:00
Art O Cathain a9b0907c31 further simplification 2014-10-12 09:24:08 +01:00
Art O Cathain ba26cfce90 remove controversial methods 2014-10-12 08:54:44 +01:00
Art O Cathain 5dc1b82340 address review comments 2014-10-11 23:52:48 +01:00
Art O Cathain d980e49fd1 chain the exception 2014-10-11 16:11:12 +01:00
Art O Cathain c6df8f1ba1 warn if not serializable, also add basic unit test 2014-10-11 12:37:36 +01:00
Art O Cathain 668ee71b6c fix tests on JVM 2014-10-11 12:10:07 +01:00
Joe Steele a141457886 Revert "Implement SSL file-based session caching"
This reverts commit 43c38a047f.
2014-10-07 21:23:04 -04:00
Art O Cathain 40102d560d Set interface makes more sense for flags 2014-10-05 12:40:35 +01:00
Art O Cathain 195f28db00 Revert accidental change 2014-10-05 12:23:43 +01:00
Art O Cathain 444756839c EnumSet is more efficient than HashSet 2014-10-05 12:08:55 +01:00
Art O Cathain fe7c0ebfac simplify following code review 2014-10-05 11:57:11 +01:00
Art O Cathain 159017e91d removed unneeded variables and clarified names 2014-10-05 11:50:04 +01:00
Art O Cathain d38f21265d use isEmpty instead of size() == 0 for clarify 2014-10-05 10:37:50 +01:00