Andrew Gaul
2599bdcc75
Log Throwable instead of concatenating
2011-11-02 22:18:30 -07:00
Andrew Chen
66881c0f2b
Merge branch 'master' of git@github.com:k9mail/k-9.git
...
* 'master' of git@github.com:k9mail/k-9.git:
Optimize java.util.* imports.
2011-11-02 08:37:12 -07:00
Andrew Chen
f884e967c9
Use MimeHeader.* constants when referring to content headers. Minor whitespace changes.
2011-11-02 08:34:06 -07:00
Andrew Chen
406aae6e61
Optimize java.util.* imports.
...
Conflicts:
src/com/fsck/k9/mail/store/WebDavStore.java
2011-11-01 13:54:55 -07:00
Andrew Chen
ea05f3b5d0
Merge branch 'legacy-collections' of https://github.com/andrewgaul/k-9 into andrewgaul
...
* 'legacy-collections' of https://github.com/andrewgaul/k-9 :
Prefer unsynchronized Collection types
2011-11-01 13:26:54 -07:00
Andrew Chen
4395da270d
Merge pull request #77 from andrewgaul/findbugs-entryset
...
Prefer entrySet over keySet and get
2011-11-01 12:44:26 -07:00
Andrew Gaul
773f2e8870
Prefer Integer.valueOf over explicit boxing
...
Addresses a FindBugs complaint.
2011-10-31 21:58:32 -07:00
Andrew Gaul
bfd11c444f
Prefer entrySet over keySet and get
...
Addresses FindBugs complaints.
2011-10-31 21:42:12 -07:00
Andrew Chen
f24d4c9155
Merge pull request #72 from andrewgaul/remove-literal
...
Remove unused literal methods
2011-10-27 23:32:28 -07:00
cketti
e3f6561008
Don't crash when trying to connect to an non-SSL service using SSL
...
Fixes issue 3798
2011-10-28 04:59:08 +02:00
cketti
b69d6cb64c
Use Locale.US with toUpperCase() and toLowerCase() where appropriate
2011-10-27 17:17:43 +02:00
Andrew Gaul
a2d0f9ccb7
Remove unused literal methods
2011-10-25 13:56:07 -07:00
Jesse Vincent
ae3f098b4a
Merge pull request #64 from andrewgaul/typesafe-set
...
Avoid type-unsafe Set
2011-10-20 05:34:48 -07:00
Andrew Gaul
5b9f542bd7
Avoid type-unsafe Set
2011-10-19 23:05:34 -07:00
Andrew Gaul
ce4b42f66b
Remove duplicated combine flags code
2011-10-19 22:04:57 -07:00
Andrew Gaul
80d9246130
Prefer unsynchronized Collection types
2011-10-19 21:56:20 -07:00
Andrew Gaul
57be9e3ee3
Make sets immutable
...
Use final and unmodifiable and avoid anonymous inner classes.
2011-10-06 20:22:18 -07:00
cketti
2e2428b093
Merge pull request #55 from andrewgaul/stringbuilder
...
Prefer StringBuilder over StringBuffer
2011-10-06 09:04:43 -07:00
cketti
31af4526ab
Merge pull request #58 from andrewgaul/spelling
...
Spelling corrections
2011-10-06 09:01:37 -07:00
Andrew Gaul
220e55603d
Spelling corrections
2011-10-05 22:04:39 -07:00
Andrew Gaul
dad0332667
Make an inner class static
2011-10-05 22:01:53 -07:00
Andrew Gaul
47eb0fa2e1
Prefer StringBuilder over StringBuffer
...
The former is unsynchronized and slightly faster.
2011-10-05 21:50:31 -07:00
cketti
0619eaf79c
Catch NumberFormatException when parsing disposition size parameter
...
Fixes issue 3712
2011-10-01 21:17:00 +02:00
Jesse Vincent
1b7481f854
optimize cketti's pop3 space-splitting code to not make lots of extra
...
copies of responses.
2011-09-04 15:53:12 -04:00
Jesse Vincent
1ac652dc5f
Small bug introduced during a refactoring "Extracted POP3 commands and capabilities to constants" introduced a typo that broke interactions wit some POP3 servers.
2011-08-28 18:28:12 -04:00
Adam
be1be56e3a
Fixed bug where uid in response was truncated
...
The SAX parser returns chunks of text to the
WebDavHandler. Other tags were correctly appending
values while the special cased <uid> tag was
simply assigned the value it was given, which would
result in the last chunk assigned to it and not
the whole string of text.
2011-07-28 15:08:00 -04:00
Jesse Vincent
0543183b11
Work around a weird NPE in WebDAV sync reported by Jon Blow
2011-07-19 22:43:32 -04:00
cketti
2acd55a9ef
Implemented work-around to handle malformed UIDL responses (POP3).
...
Fixes issue 3546
2011-07-17 14:37:21 +02:00
cketti
9f581cb6f3
Extracted POP3 commands and capabilities to constants
2011-07-17 14:13:04 +02:00
Jesse Vincent
b85c9b7b0e
Work around the fact that when we can't get read status for a message,
...
we'd end up with an NPE as we then queried the hashmap
2011-07-11 11:08:20 -04:00
Jesse Vincent
98ae8cf2be
refactoring to use the object we extracted from the array
2011-07-11 11:08:20 -04:00
Jesse Vincent
d7dfba15cf
It appears that Exchange is returning responses
...
without a visiblecount element for empty folders
Which resulted in this code returning -1 (as that was
the previous default.)
-1 is an error condition. Now the default is empty
2011-07-09 17:00:35 -04:00
Jesse Vincent
220be75473
Add a bit of logging to find out what webdav servers tell us about how
...
many messages they have in debug mode
2011-07-09 16:24:18 -04:00
Jesse Vincent
8cffc5b682
Bullet proofing for user-reported exceptions in WebDAV sync:
...
E/k9 ( 5735): java.lang.NullPointerException
E/k9 ( 5735): at
com.kaitenmail.mail.store.WebDavStore$WebDavMessage.setNewHeaders(WebDavStore.java:1903)
E/k9 ( 5735): at
com.kaitenmail.mail.store.WebDavStore$WebDavFolder.fetchEnvelope(WebDavStore.java:1655)
E/k9 ( 5735): at
com.kaitenmail.mail.store.WebDavStore$WebDavFolder.fetchEnvelope(WebDavStore.java:1627)
E/k9 ( 5735): at
com.kaitenmail.mail.store.WebDavStore$WebDavFolder.fetchEnvelope(WebDavStore.java:1627)
E/k9 ( 5735): at
com.kaitenmail.mail.store.WebDavStore$WebDavFolder.fetchEnvelope(WebDavStore.java:1627)
E/k9 ( 5735): at
com.kaitenmail.mail.store.WebDavStore$WebDavFolder.fetchEnvelope(WebDavStore.java:1627)
E/k9 ( 5735): at
com.kaitenmail.mail.store.WebDavStore$WebDavFolder.fetch(WebDavStore.java:1404)
E/k9 ( 5735): at
com.kaitenmail.controller.MessagingController.fetchUnsyncedMessages(MessagingController.java:1418)
E/k9 ( 5735): at
com.kaitenmail.controller.MessagingController.downloadMessages(MessagingController.java:1253)
E/k9 ( 5735): at
com.kaitenmail.controller.MessagingController.synchronizeMailboxSynchronous(MessagingController.java:1031)
E/k9 ( 5735): at
com.kaitenmail.controller.MessagingController.access$400(MessagingController.java:81)
E/k9 ( 5735): at
com.kaitenmail.controller.MessagingController$30.run(MessagingController.java:3768)
E/k9 ( 5735): at
com.kaitenmail.controller.MessagingController.run(MessagingController.java:276)
E/k9 ( 5735): at java.lang.Thread.run(Thread.java:1096)
2011-07-09 15:26:30 -04:00
Jesse Vincent
b02b895aaf
Add 2MB, 5MB and "All" message download options
2011-07-02 15:29:49 -04:00
cketti
1bdf7095a7
Delete the old localized outbox. Fixes the "two outboxes" problem.
...
Rename the "new" hardcoded outbox to "K9MAIL_INTERNAL_OUTBOX". This
is done to avoid collisions with folders named "OUTBOX" in a remote
store. See
https://groups.google.com/group/k-9-mail/browse_thread/thread/cbb1c77abba84695
Fixes issue 3411
2011-06-17 06:17:01 +02:00
Jesse Vincent
379a8dfa9e
It turns out that 79a96952f2
has caused a
...
lot of messages to be unreadable in K-9 3.8. (see mailing list
threads)
2011-06-09 21:54:22 -04:00
Jesse Vincent
3d583da450
ant astyle
2011-06-01 16:03:56 -04:00
cketti
30d31c7074
Explicitly use Locale.US when dealing with dates in message headers
2011-05-26 04:32:26 +02:00
Jesse Vincent
29117ae7a6
Switch a StringBuffer to StringBuilder, which replaced it
2011-05-24 21:21:03 -04:00
Koji Arai
b4f3712246
Should retrieve just visibleLimit messages when the local folder is cleared.
2011-05-25 00:37:51 +09:00
Koji Arai
cb46f170cd
Should reset visibleLimit on clear messages.
2011-05-25 00:37:49 +09:00
Koji Arai
a4f7288d37
Avoid NullPointerException.
...
The name parameter in Content-Type may be not set.
2011-05-25 00:37:46 +09:00
cketti
8fc714ac4a
Don't show "null" for partially downloaded messages with empty text body
2011-05-16 00:36:46 +02:00
cketti
41b039b691
Fix bug introduced with commit b7a6dbd973
...
Fixes issue 3297
2011-05-15 16:23:53 +02:00
cketti
95288b37d7
Removed unnecessary method implementation
...
Make Pop3Folder.setFlags(Flag[],boolean) throw an
UnsupportedOperationException instead of calling a method that does
just that.
2011-05-14 23:46:26 +02:00
cketti
dc96bf3186
Only mark all messages as read on the server if that's supported
...
This change prevents K-9 Mail from establishing a connection to the
server when all messages are marked as read on a POP3 account.
2011-05-14 23:30:47 +02:00
cketti
ba9bc2f8e9
Added method Folder.isFlagSupported(Flag)
2011-05-14 23:19:24 +02:00
cketti
86fca9c1f2
POP3: Check for support of the TOP command (if CAPA isn't supported)
...
This will allow to download partial messages if the server doesn't
support the CAPA command but supports the TOP command (e.g. Hotmail).
Fixes issue 2042
2011-05-14 21:40:21 +02:00
cketti
8e1c4acef9
Get rid of constant K9.OUTBOX
...
Use Account.getOutboxFolderName() instead (still hardcoded, though)
2011-05-08 02:22:38 +02:00