cketti
d354905f21
Cosmetic changes
2011-02-20 19:18:17 +01:00
Jan Berkel
41378188f9
Updates to the view need to happen on the UI thread
...
Fixes downloading attachments (would just fail silently)
Also added a ProgressDialog since progress() just asks for
progress to displayed in the title bar. Since there is no title bar,
no progress is shown at all.
2011-02-20 18:49:55 +01:00
cketti
a79b7ea93c
Inlined methods that were extracted to use
...
@SuppressWarnings("unchecked"). That's now unnecessary after the
Serializable -> Parcelable switch
2011-02-20 06:23:06 +01:00
cketti
bb40049212
Remove unused imports
2011-02-20 05:31:35 +01:00
Jan Berkel
685df0ff67
Perf improvement: use parcels instead of serializable
...
Standard Java serialization is slow on Android. Replacing it w/
parcelable makes it around 10x faster (on a N1, with ~ 500 messages
in the list).
To avoid further confusion and potential bugs MessageReference was
made no longer implement Serializable.
2011-02-19 15:24:53 -05:00
Jesse Vincent
8a778a0222
reformatting
2011-02-14 20:45:08 -05:00
Jesse Vincent
fb663508e0
remove an unused method
2011-02-14 20:44:53 -05:00
Jesse Vincent
143ca4df26
replace redundant calls with a helper
2011-02-14 20:26:00 -05:00
Jesse Vincent
ea6e5e0e62
Lifting more of the "Show this message" over to the SingleMessageView
2011-02-14 13:40:49 -05:00
Jesse Vincent
dc1444d1ac
Rename a method that was confusingly similar to another method
2011-02-14 13:32:30 -05:00
Jesse Vincent
10da146e93
clean up unused imports
2011-02-14 13:32:25 -05:00
Jesse Vincent
5aad882976
Move the "isScreenReader" active code down into the MessageView
2011-02-14 13:32:14 -05:00
Jesse Vincent
04bc32db9e
move a call to setLoadPictures down
2011-02-14 13:31:43 -05:00
Jesse Vincent
043535f7a5
Migrate a method into SingleMessageView
2011-02-14 13:31:34 -05:00
Jesse Vincent
abc921093c
refactor display of the download button
2011-02-11 12:11:21 -05:00
Jesse Vincent
9deea33426
re-enable setOnFlagListener
2011-02-11 12:10:45 -05:00
Jesse Vincent
06baf3f602
simplify the "load a url for the message body" signature
2011-02-11 12:09:47 -05:00
Jesse Vincent
111b9a6305
remove a pointless indirection and an extra method call to set the
...
options menu when we didn't need to
2011-02-11 11:16:50 -05:00
Jesse Vincent
49b35f9236
More reshuffling toward having a reusable "Show a message" widget - what
...
should eventually be a Fragment.
Lifted part of the cryptoView back up to the activity since the
factoring felt forced.
2011-02-11 10:59:31 -05:00
Jesse Vincent
015baa06b4
Renamed "next" and "previous" buttons to match code style
2011-02-10 16:39:49 -05:00
Jesse Vincent
fe21d6951f
remove unused method
2011-02-10 16:39:49 -05:00
Jesse Vincent
98f3909ecc
Split out a "clear the current message view" method
2011-02-10 14:56:56 -05:00
Jesse Vincent
850aee9008
Move as much of the Apg code as possible to its own "view" class
...
(should eventually be a fragment?)
2011-02-10 14:02:21 -05:00
Jesse Vincent
12d1097a24
Big, scary massive "ant astyle" to get us back to something
...
approximating AOSP coding standards.
2011-02-06 17:09:48 -05:00
Jesse Vincent
4a558c5ac5
Revert the active part of "Update issue 848"
...
This reverts commit 9fc94115adb58dcd8a64227a93d0e6e707d7752d.
It turns out that disabling the "View attachment" button (rather than
giving a useful error message telling the user what mime type the app
needs to support) was confusing to users.
2011-01-28 03:33:49 +00:00
cketti
f5bb836087
Fix code that was broken when fixing warnings.
2011-01-19 21:00:28 +00:00
cketti
7119c7165f
Removed unnecessary type casts
2011-01-19 01:21:27 +00:00
cketti
365b106753
Fixed warnings about unchecked casts by extracting the code to methods and using the @SuppressWarnings annotation on them.
2011-01-19 00:36:15 +00:00
cketti
8279092070
Fixed lots of warnings (unused imports/variables, missing annotations, etc.)
2011-01-18 23:54:49 +00:00
Jesse Vincent
d59600653c
astyle
2011-01-18 00:04:11 +00:00
Marcus Wolschon
fc4b64c559
Update issue 848
...
"view" only enabled for attachments if there is an actual
application on the phone to view this kind of file.
2011-01-17 10:41:48 +00:00
Jesse Vincent
9d5704c0f5
Split the Header view out from the MessageView activity
2011-01-10 17:47:28 +00:00
Jesse Vincent
b2c44579d2
lift "displayMessage" out of a callback
2011-01-06 16:56:55 +00:00
Jesse Vincent
39ef6584a8
continue to extract attachment code out to AttachmentView
2011-01-06 16:56:37 +00:00
Jesse Vincent
19c5324316
Extract AttachmentView and MediaScannerNotifier into their own classes
2011-01-06 16:56:20 +00:00
Jesse Vincent
ed60cdfa5a
replace constant lookups of the MessagingController instance with a locally cached one
2011-01-06 16:56:02 +00:00
Jesse Vincent
299c057cd4
minor code cleanup
2011-01-06 16:55:48 +00:00
Jesse Vincent
9c847d3e9d
minor code cleanup
2011-01-06 16:55:34 +00:00
Jesse Vincent
de806f7715
astyle
2011-01-06 16:55:08 +00:00
Andrew Chen
605a0bdc93
Add more comments about LocalTextBody.
...
Display decrypted PGP data as text/plain (content type was being set, but not being passed to WebViews).
2010-12-29 07:34:57 +00:00
Jesse Vincent
8bc984f440
APG-related messageview bugfixes
2010-12-28 09:11:35 +00:00
Jesse Vincent
0c426c9c4b
Round our color chips, clean up color hcip rendering a bit
2010-12-28 09:11:10 +00:00
Jesse Vincent
4c9c478d8d
minor code and doc cleanups as recommended by IntelliJ
2010-12-28 09:10:50 +00:00
Jesse Vincent
b166cf03e8
split apart attachment view creation a bit
2010-12-28 09:09:52 +00:00
Jesse Vincent
3c9eb2c004
Further refactoring of message display
2010-12-28 09:09:33 +00:00
Jesse Vincent
9fe56831bf
finish removing setHeaders as a layer of indirection
2010-12-28 09:09:15 +00:00
Jesse Vincent
8116a0f39f
lift some gpg code into the crypto initializer
2010-12-28 09:08:58 +00:00
Jesse Vincent
3ffa28fa02
we import so we don't need to qualify
2010-12-28 09:08:40 +00:00
Jesse Vincent
85a7a08e9a
Rename our attachment view holder from Attachment to AttachmentViewHolder
2010-12-28 09:08:18 +00:00
Jesse Vincent
6a04afb758
extract "does it have html images" out of MessageView. really, it should
...
end up in LocalMessage somewhere
2010-12-28 09:07:59 +00:00
Jesse Vincent
7623a02852
lift the "get display text" code out of the messageview and into
...
localmessage
2010-12-28 09:07:39 +00:00
Jesse Vincent
84f6e546d2
setLoadPictures sets mShowPictures. We don't need to set it again
2010-12-28 09:07:19 +00:00
Jesse Vincent
f292251b78
lift createUniqueFile to a Utility class
2010-12-28 09:06:57 +00:00
Jesse Vincent
570dbf7126
split apart onCreate into bite-sized pieces
2010-12-26 03:51:33 +00:00
Jesse Vincent
43e3e860f8
doc fix
2010-12-26 03:49:52 +00:00
Jesse Vincent
d352b8a4a5
whitespace
2010-12-26 03:49:23 +00:00
Jesse Vincent
f2b2fddd5a
onRefile removes code duplication
2010-12-26 03:49:20 +00:00
Jesse Vincent
db02383d4a
whitespace cleanups
2010-12-26 03:49:16 +00:00
Jesse Vincent
8488b55e09
remove some duplicated code
2010-12-26 03:49:13 +00:00
Jesse Vincent
8c6df94739
remove some temp variables
2010-12-26 03:49:09 +00:00
Jesse Vincent
877427f110
cut down a couple overly verbose conditionals
2010-12-26 03:49:06 +00:00
Jesse Vincent
daf5a9d704
lift emulateShiftHeld to our custom WebView subclass
2010-12-25 22:30:34 +00:00
Jesse Vincent
8e2e4e515f
simplify MessageView's setHeaders
2010-12-25 22:30:31 +00:00
Jesse Vincent
8b52aac135
remove unused imports
2010-12-25 22:30:27 +00:00
Jesse Vincent
76fd8e9939
extract animation code from MessageView
2010-12-25 22:30:22 +00:00
Jesse Vincent
5f9eae1580
Extract MessageWebView specific code into a new class
2010-12-25 22:30:16 +00:00
Jesse Vincent
ea4e0aa61f
remove a bunch of extraneous code and variables
2010-12-25 19:29:02 +00:00
Jesse Vincent
9f24ea2b03
minor code cleanup
2010-12-25 19:28:58 +00:00
Jesse Vincent
91ab617807
rename "hide buttons" to "scroll buttons" because that's what it does
2010-12-25 19:28:54 +00:00
Andrew Chen
77c01c65dd
Refactor network data blocking out of the main K9 class and into the MessageView class.
2010-12-25 01:26:47 +00:00
Jesse Vincent
f14c7ecd9b
doc & comment updates from achen.code
2010-12-25 00:27:09 +00:00
Jesse Vincent
c361c0e63c
Extract a method to set up our MessageView WebView
2010-12-25 00:27:05 +00:00
Jesse Vincent
4a97f4a1a0
astyle
2010-12-24 22:48:22 +00:00
Jesse Vincent
d64d9c460a
Disable webview cache and javascript. (Mail + Javascript == scary)
2010-12-24 22:48:17 +00:00
Jesse Vincent
9878b74379
astyle
2010-12-24 18:55:05 +00:00
Fiouz
64b5655d7c
Don't reference the enclosing type instance when it's not used (memory optimisation)
2010-12-14 19:26:31 +00:00
Jesse Vincent
5e7257492d
small cleanups to messageview code
2010-12-13 01:56:57 +00:00
Jesse Vincent
063bbb904f
Extract SizeFormatter into helpers
2010-12-13 01:02:39 +00:00
Jesse Vincent
23b57b4502
remove a duplicated and divergent size formatter
2010-12-13 01:02:35 +00:00
Jesse Vincent
2451dde1bc
simplify our "should we animate" checks in messageview (also, we now
...
honor the animation preference when using the volume keys to navigate)
2010-12-13 00:37:31 +00:00
Jesse Vincent
76b6fa696b
Move the ToggleScrollView into the view/ hierarchy
2010-12-13 00:17:54 +00:00
Jesse Vincent
f97d4289ca
Start moving custom views into the view/ hierarchy
2010-12-13 00:17:44 +00:00
Jesse Vincent
f5eb6e03af
astyle
2010-12-01 06:32:29 +00:00
Jesse Vincent
c79ea226a5
Remove "throws" declarations that didn't actually get thrown. Remove a
...
couple of try blocks that only caught throws we didn't throw. IntelliJ
optimization.
2010-12-01 03:02:13 +00:00
Jesse Vincent
43d9c0a6d4
Eliminate some redundant assignments
2010-12-01 03:00:36 +00:00
Jesse Vincent
1ce9021ecd
Fix pinch-to-zoom. Patch by achen.code. Fixes isue 2720
2010-11-30 01:42:00 +00:00
Jesse Vincent
f9981dcf7c
lift hasAttachments to LocalMessage
2010-11-27 04:02:56 +00:00
Jesse Vincent
14055691a3
Merge branch 'mail-on-sd'
...
* mail-on-sd: (40 commits)
Added more comments to explain how the locking mecanism works for LocalStore
Fixed wrong method being called during experimental provider initialization (since provider isn't enabled, that didn't harm)
Add more comments about how the various StorageProviders work and how they're enabled
find src/com/fsck/ -name \*.java|xargs astyle --style=ansi --mode=java --indent-switches --indent=spaces=4 --convert-tabs
French localization for storage related settings
Remove unused SD card strings (replaced with storage indirection)
Merge mail-on-sd branch from trunk
Reset mail service on storage mount (even if no account uses the storage, to be improved)
find src/com/fsck/ -name \*.java|xargs astyle --style=ansi --mode=java --indent-switches --indent=spaces=4 --convert-tabs
Migraion -> Migration
move the Storage location preference into preferences rather than the wizard.
Made LocalStore log less verbose Added @Override compile checks
Added ACTION_SHUTDOWN broadcast receiver to properly initiate shutdown sequence (not yet implemented) and cancel any scheduled Intent
Be more consistent about which SQLiteDatabase variable is used (from instance variable to argument variable) to make code more refactoring-friendly (class is already big, code extraction should be easier if not referencing the instance variable).
Added transaction timing logging
Factorised storage lock/transaction handling code for regular operations.
Use DB transactions to batch modifications (makes code more robust / could improve performances)
Merge mail-on-sd branch from trunk
Update issue 888 Added DB close on unmount / DB open on mount
Update issue 888 Back to account list when underlying storage not available/unmounting in MessageView / MessageList
...
2010-11-13 21:40:56 +00:00
cketti
5b88a99de0
Got rid of some compiler warnings.
2010-11-04 03:11:34 +00:00
Jesse Vincent
b9999878df
We care about eclair MR1, not eclair
2010-11-03 00:44:07 +00:00
Jesse Vincent
7db384fc08
Use a more backward compatible os version check, since the "current"
...
best practice is incompatible with 1.5
2010-10-29 22:35:27 +00:00
Jesse Vincent
e0d6a55d06
SINGLE_COLUMN layouts cause Android 1.0-2.1 to segfault.
2010-10-29 22:35:19 +00:00
Jesse Vincent
c216f42eb3
Exchange authenticaton and setup overhaul from Kris Wong
2010-10-24 01:03:29 +00:00
Jesse Vincent
62caa5ce76
Experimental change - ask android to try to make columns no wider than
...
the viewport. This change should NOT be backported to 3.2, but I'd like
folks to try it with real email.
2010-10-23 18:50:54 +00:00
Jesse Vincent
43cb54594b
Push the webview's renderpriority from NORMAL to HIGH - it's cargo-cult
...
performance improvement, but it certainly doesn't hurt
2010-10-23 18:50:24 +00:00
Jesse Vincent
e8756af4f1
astyle
2010-10-21 20:49:20 +00:00
Jesse Vincent
d07aca3008
"Preferences" -> "Settings" for consistency
2010-10-11 14:54:23 +00:00
Jesse Vincent
c5d68fb49d
Add preferences to enable pinch-to-zoom and single-column layout for
...
messages
2010-10-11 14:54:15 +00:00
cketti
7028a4c167
Fixes issue 2144
...
- Removed the contact names cache (memory leak)
- Changed Contacts.searchByAddress() to Contacts.getNameForAddress(). Cursor is now immediately closed.
- Only try to resolve contact names when "Global settings" -> "Show contact name" is checked
- Never resolve contact names if number of recipients exceeds a threshold
2010-10-09 00:24:43 +00:00
Jesse Vincent
6061c42ea9
find src/com/fsck/ -name \*.java|xargs astyle --style=ansi --mode=java --indent-switches --indent=spaces=4 --convert-tabs
2010-10-05 06:04:28 +00:00