Commit Graph

115 Commits

Author SHA1 Message Date
cketti 0ef9c516be Moved click listener from MessageView to SingleMessageView 2012-02-22 22:44:31 +01:00
cketti 80cb0cce35 Changed the layout to include a color chip again 2012-02-21 23:38:43 +01:00
cketti ec6645bf6a Avoid creating new objects for handling click events 2012-02-21 16:21:47 +01:00
cketti 309eeb72ac Got rid of the ScrollView in MessageView
The ScrollView around the WebView caused all sorts of problems. This
change removes the ScrollView and uses the undocumented method
WebView.setEmbeddedTitleBar() to set the MessageHeader view as "title
bar" of the WebView. This allows MessageHeader to scroll away making
more room for the WebView.
All of the "magic title bar" code was originally implemented by Jesse
for Kaiten.

Because WebView doesn't support a scrolling footer we can no longer
support scrolling buttons or attachments at the end of the message. Now
users can switch from message view to attachment view via a button just
below the message headers.

I also copied some code for which I was too lazy to create a separate
commit. It allows to display attachments we didn't use to show by
clicking on a "More..." button in the attachment view. Those
attachments are mostly images referenced by the HTML part (e.g.
background images).

Fixes issue 3291
2012-02-21 05:07:01 +01:00
cketti 53ae9d7fe7 Avoid exception when a screen reader is installed but not active. 2012-02-16 14:52:56 +01:00
cketti 35b5aebdb3 Add debug message when saving an attachment to SD card fails 2012-02-03 01:22:37 +01:00
cketti 1165787129 Changed regular expression for invalid characters in a file name 2012-01-27 03:39:08 +01:00
cketti 6c23e204ba Replace invalid characters in file name instead of removing them 2012-01-27 03:21:20 +01:00
cketti 68f5f009f1 Whitespace cleanup 2012-01-27 03:07:44 +01:00
wilian-cb 9a0f650cd9 3674: Displaying the final file name. 2012-01-27 02:44:01 +01:00
wilian-cb 193450cd63 3674: Illegal characters used in file names are being removed when saving them on the device. 2012-01-27 02:44:01 +01:00
cketti 8e627834c1 Changed font size unit from DIP to SP
"Scale-independent Pixels - this is like the dp unit, but it is also
scaled by the user's font size preference. It is recommend you use this
unit when specifying font sizes, so they will be adjusted for both the
screen density and the user's preference." - Android Developer Docs
2012-01-12 02:18:41 +01:00
András Veres-Szentkirályi 1949067979 Removed unnecessary return statement 2011-12-26 02:28:30 +01:00
András Veres-Szentkirályi de30c712f9 Removed duplicate import 2011-12-26 02:28:30 +01:00
cketti fe727f8b20 Merge pull request #98 from cketti/remove_legacy_code
Remove legacy code
2011-11-15 20:07:23 -08:00
Jesse Vincent a8ef6594ec Preserve header order (with the exception of duplicate headers like
"received" they all show up where the first one did
2011-11-15 00:00:42 -05:00
cketti 07fa0c7264 Use Build.VERSION.SDK_INT instead of parsing Build.VERSION.SDK 2011-11-10 05:39:04 +01:00
Andrew Chen ef631e21d1 Merge pull request #83 from andrewachen/messageview_save_location
Restore position in MessageView after rotation screen.
2011-11-07 09:57:18 -08:00
Jesse Vincent 7ca72b9d0f Work around broken office suites by sending an explicit mime type with files we open 2011-11-06 17:00:25 -05:00
Andrew Chen f6eea9f014 Move the listener logic out of the Activity and into the View.
Change variable naming in ToggleScrollView to meet standard.
Cache the result of computeVerticalScrollRange() in ToggleScrollView.
2011-11-03 09:14:42 -07:00
Andrew Chen 763ff2752d Scroll to the last known position in the MessageView when rotating the screen. 2011-11-02 16:39:23 -07:00
Andrew Chen f884e967c9 Use MimeHeader.* constants when referring to content headers. Minor whitespace changes. 2011-11-02 08:34:06 -07:00
Andrew Gaul 220e55603d Spelling corrections 2011-10-05 22:04:39 -07:00
cketti 88dc36da8a Added a check to prevent an ArrayIndexOutOfBoundsException
Fixes issue 3683
2011-10-01 20:30:22 +02:00
Bernhard Redl ab4bae214f Make attachment saving respect the new preference. Allow long-press to
choose a folder.

(new constant renamed from CHOOSE_FOLDER to CHOOSE directory for
clarity)
2011-04-24 14:01:03 +10:00
Bernhard Redl 96842b3ce6 Unroll import statements in AttachmentView.java 2011-04-24 13:56:54 +10:00
cketti 0aa03ccdc4 Extract MIME type fixup code to method MimeUtility.getMimeTypeForViewing() 2011-03-25 00:37:53 +01:00
cketti 522634fba7 Extend AttachmentProvider to be able to get "raw" attachment
AttachmentProvider can now return an attachment with an unmodified
MIME type. However, when viewing attachments this is not desirable. So
we try hard to return a sensible MIME type (use extension to look up
a MIME type if it's originally "application/octet-stream"; or replace
with canonical MIME type if it's known to be wrong, e.g.
"image/jpg" -> "image/jpeg")
2011-03-24 23:36:59 +01:00
Jesse Vincent ea6e5e0e62 Lifting more of the "Show this message" over to the SingleMessageView 2011-02-14 13:40:49 -05:00
Jesse Vincent 5aad882976 Move the "isScreenReader" active code down into the MessageView 2011-02-14 13:32:14 -05:00
Jesse Vincent 04bc32db9e move a call to setLoadPictures down 2011-02-14 13:31:43 -05:00
Jesse Vincent 043535f7a5 Migrate a method into SingleMessageView 2011-02-14 13:31:34 -05:00
Jesse Vincent 7cbbd72fac Astyle 2011-02-13 21:20:21 -05:00
Jesse Vincent 0d0415e705 use a single layout inflater for loading attachments 2011-02-11 12:13:18 -05:00
Jesse Vincent e099337c52 remove dead code 2011-02-11 12:12:52 -05:00
Jesse Vincent 20623dc18a slight clean up to cryptoprovider view interface 2011-02-11 12:12:09 -05:00
Jesse Vincent abc921093c refactor display of the download button 2011-02-11 12:11:21 -05:00
Jesse Vincent 9deea33426 re-enable setOnFlagListener 2011-02-11 12:10:45 -05:00
Jesse Vincent 06baf3f602 simplify the "load a url for the message body" signature 2011-02-11 12:09:47 -05:00
Jesse Vincent 49b35f9236 More reshuffling toward having a reusable "Show a message" widget - what
should eventually be a Fragment.

Lifted part of the cryptoView back up to the activity since the
factoring felt forced.
2011-02-11 10:59:31 -05:00
Jesse Vincent d634bcb381 Switch the Message view to our new SingleMessageView 2011-02-10 19:31:15 -05:00
Jesse Vincent 850aee9008 Move as much of the Apg code as possible to its own "view" class
(should eventually be a fragment?)
2011-02-10 14:02:21 -05:00
Jesse Vincent 7cd99bdfd2 When some message has an Application/octet-stream .jpg attachment, be a
bit more lenient and treat it as application/octet-stream, so we can
look up the content type by file extension
2011-02-07 20:34:08 -05:00
Jesse Vincent 12d1097a24 Big, scary massive "ant astyle" to get us back to something
approximating AOSP coding standards.
2011-02-06 17:09:48 -05:00
Andrew Chen fe8ba6078e Propagate the ACTION_DOWN event to the ScrollView so we can stop scrolling after a fling. Fixes issue 2892. 2011-01-30 22:05:47 +00:00
Jesse Vincent 4a558c5ac5 Revert the active part of "Update issue 848"
This reverts commit 9fc94115adb58dcd8a64227a93d0e6e707d7752d.

It turns out that disabling the "View attachment" button (rather than
giving a useful error message telling the user what mime type the app
needs to support) was confusing to users.
2011-01-28 03:33:49 +00:00
Jesse Vincent 098851684f astyle 2011-01-23 00:56:01 +00:00
Andrew Chen b1d8e49d72 Be a little more graceful when scrolling horizontally in a (vertical) scroll view.
Not quite to the point of diagonal scrolling, but hopefully closer.
2011-01-19 17:05:56 +00:00
cketti 8279092070 Fixed lots of warnings (unused imports/variables, missing annotations, etc.) 2011-01-18 23:54:49 +00:00
Jesse Vincent d59600653c astyle 2011-01-18 00:04:11 +00:00
Jesse Vincent bd66315375 Visual cleanup of messageview. Clean up of icon display codepaths 2011-01-17 17:25:00 +00:00
Marcus Wolschon fc4b64c559 Update issue 848
"view" only enabled for attachments if there is an actual
application on the phone to view this kind of file.
2011-01-17 10:41:48 +00:00
Andrew Chen a17c21f0cd Add null check in header view to prevent NPE. 2011-01-11 22:25:06 +00:00
Jesse Vincent 9d5704c0f5 Split the Header view out from the MessageView activity 2011-01-10 17:47:28 +00:00
Jesse Vincent 39ef6584a8 continue to extract attachment code out to AttachmentView 2011-01-06 16:56:37 +00:00
Jesse Vincent 19c5324316 Extract AttachmentView and MediaScannerNotifier into their own classes 2011-01-06 16:56:20 +00:00
Jesse Vincent de806f7715 astyle 2011-01-06 16:55:08 +00:00
Andrew Chen 731ea27a24 Minor formatting cleanup. 2010-12-31 08:56:05 +00:00
cketti cb97c312fc Move ColorChip to the correct directory 2010-12-28 23:37:47 +00:00
Jesse Vincent daf5a9d704 lift emulateShiftHeld to our custom WebView subclass 2010-12-25 22:30:34 +00:00
Jesse Vincent 5f9eae1580 Extract MessageWebView specific code into a new class 2010-12-25 22:30:16 +00:00
Jesse Vincent 26712ed84a reshuffle color views into view/ 2010-12-13 00:18:00 +00:00
Jesse Vincent 76b6fa696b Move the ToggleScrollView into the view/ hierarchy 2010-12-13 00:17:54 +00:00
Jesse Vincent aa2960eb04 move the AccessibleEmailContentActivity into activity/ 2010-12-13 00:17:49 +00:00
Jesse Vincent f97d4289ca Start moving custom views into the view/ hierarchy 2010-12-13 00:17:44 +00:00