Daniel Applebaum
29947ef3c9
Delete obsolete commented out code.
2010-01-06 03:40:24 +00:00
Jesse Vincent
a4510696aa
It turns out that blindly enabling/disabling views is _Very_ expensive.
...
Now we only do it when switching messageview entries if it's actually
necessary
2010-01-04 02:11:33 +00:00
Jesse Vincent
a926086f4b
Replace old message passing code with more modern runonuithread code
2010-01-04 02:06:40 +00:00
Daniel Applebaum
60a2ceb604
Fixes Issue 934 by removing excess calls to finish()
2010-01-04 00:50:19 +00:00
Daniel Applebaum
d58d1c60c0
Proper super call
2010-01-04 00:48:33 +00:00
Daniel Applebaum
c86a46deb1
Preparatory for more BroadcastReceivers
2010-01-04 00:47:11 +00:00
Daniel Applebaum
33495135ac
Respect account ring setting for notifications
2010-01-04 00:41:26 +00:00
Daniel Applebaum
41729af9b2
Add explicit ring setting for notifications
2010-01-04 00:40:41 +00:00
Jesse Vincent
6caec1100c
Incorrect (and ancient code) would accidentally clobber the wrong attachment
...
(and only one, rather than all) when deleting a message.
2010-01-03 23:23:13 +00:00
Jesse Vincent
483655fa20
Log.w shouldn't be wrapped in an "if debug" statement.
2010-01-03 20:34:22 +00:00
Jesse Vincent
6a8ea924c9
Further log cleanup
2010-01-03 02:07:21 +00:00
Jesse Vincent
eb54a99aab
EOLs got twisted by something. fixing
2010-01-03 02:07:14 +00:00
Jesse Vincent
0e273893bd
Further log tweaking
2010-01-03 02:00:20 +00:00
Jesse Vincent
a926911e7f
rerun astyle
2010-01-03 01:50:51 +00:00
Jesse Vincent
1c5073039a
Further debug/info/verbose logging cleanup
2010-01-03 01:50:41 +00:00
Jesse Vincent
875dc31d5a
Log message cleanup
2010-01-03 01:50:32 +00:00
Jesse Vincent
f9e8c877ff
Wrap looging in if (DEBUG) statements.
2010-01-03 01:50:25 +00:00
Jesse Vincent
953b784fb9
First pass at fixing Issue 963 (explosions when trying to iterate over a
...
remotely deleted message) introduced in r1204.
(Before my all-day meeting)
2009-12-29 17:06:13 +00:00
Jesse Vincent
fb6d11222a
Switch from old, scary message passing to more modern "run on ui thread" for Accounts.java
...
40 fewer lines of code.
2009-12-29 17:05:44 +00:00
Jesse Vincent
2ef3b15c87
make sure we don't accidentally open the context menu on a message when we're in multiselect mode.
2009-12-29 17:05:17 +00:00
Jesse Vincent
3e3b4d447d
Fix reversed color chip alpha
2009-12-28 12:56:59 +00:00
Daniel Applebaum
60b02909a3
Announce folder status changes when syncing gets updated unread count.
...
Adjust logging levels for folder sync.
2009-12-27 20:19:41 +00:00
Jesse Vincent
bbd9e56770
Actually display 250/500/1000 options for "number of messages to sync"
2009-12-27 17:47:30 +00:00
Jesse Vincent
794f515bc8
Numerous small fixes to search results
2009-12-27 17:22:57 +00:00
Jesse Vincent
a53e9d1b89
on search, only fire one start event and one end event
2009-12-27 17:22:51 +00:00
Jesse Vincent
6c383256a2
Remove duplicate code from onCompose. make starting message composition without an account actually work
2009-12-27 17:22:44 +00:00
Jesse Vincent
0a2d9b9c9f
make sure search results aren't updated incorrectly on incoming messages
2009-12-27 17:22:38 +00:00
Jesse Vincent
bfaba499fe
Fix the Search header on search results
2009-12-27 17:22:32 +00:00
Jesse Vincent
63b6f6bf62
Refactoring to better propagate "folder" along with messages as they're instantiated
2009-12-27 17:22:26 +00:00
Jesse Vincent
d60521f06f
further push down our "is this message for us" logic.
2009-12-27 17:20:56 +00:00
Jesse Vincent
6c7782b4bd
remove another alternate calling convention for addOrUpdateMessage. Code
...
will get still cleaner when we start propagating back message folders as objects
2009-12-27 17:20:50 +00:00
Jesse Vincent
c608ffb672
Eliminate a variant of addOrUpdateMessage that was only called once
2009-12-27 17:20:28 +00:00
Jesse Vincent
1c4a0be0da
enable searching of messages
2009-12-27 17:20:21 +00:00
Jesse Vincent
21238a3084
If we get a message from listLocalMessages and we're doing a search,
...
assume it's for us. Later, we may want to be smarter about that.
2009-12-27 17:20:13 +00:00
Jesse Vincent
a736a4267c
Only trigger our "loading" indicator if the account matches "our" account
2009-12-27 17:20:06 +00:00
Jesse Vincent
204289a4ff
when opening a message for display or edit, use its notion of account, not the folder's.
2009-12-27 17:19:56 +00:00
Jesse Vincent
f6756879ef
Temporarily disable "left-handed" controls if we're doing a search.
...
view configuration needs to move to be global for this to work right.
2009-12-27 17:19:49 +00:00
Jesse Vincent
bc61c90e1a
make the auto-open folder not trigger if we're doing a search
2009-12-27 17:15:46 +00:00
Jesse Vincent
81d72a2d8c
make the color chip genuinely calculated per message
2009-12-27 17:15:38 +00:00
Jesse Vincent
ed19a8284e
Propagate per-message account info into MessageInfoHolder and FolderInfoHolder
2009-12-27 16:54:23 +00:00
Jesse Vincent
302deea53e
addOrUpdateMessage calls now propagate the account of the found message
2009-12-27 16:54:12 +00:00
Jesse Vincent
3ad69c799d
When listing off messages, make sure that our "refresh the list" fires,
...
even if we didn't start off empty.
This could have prevented updated messages from showing up
2009-12-27 16:54:06 +00:00
Jesse Vincent
1b74c176a2
Add multi-account search to the MessagingController
2009-12-27 16:53:59 +00:00
Jesse Vincent
70f35a537e
If we loaded a message from the local store without an associated folder, load up its folder.
2009-12-27 16:53:51 +00:00
Jesse Vincent
da45b81866
minor query reformatting
2009-12-27 16:53:45 +00:00
Jesse Vincent
580a562085
Lift the generic getMessages and searchForMessages up to the "store"
...
level from the "folder" level so we can search for messages across
folders
2009-12-27 16:53:37 +00:00
Jesse Vincent
6dcb10add6
Lift our column list for "load messages" out to the LocalStore, as the
...
first part of lifting "get messages" out of "folder" for search
2009-12-27 16:53:31 +00:00
Jesse Vincent
ddd6db3a7c
Made our search activity actually exist
2009-12-27 16:53:24 +00:00
Jesse Vincent
09ecd2bc9a
Make it possible to instantiate a localFolder by id.
2009-12-27 16:53:16 +00:00
Jesse Vincent
4cec247699
Make it possible to populate a MessageInfoHolder without a FolderInfoHolder
2009-12-27 16:53:09 +00:00
Jesse Vincent
fe67f0a40c
temporarily disable new unfinished search code
2009-12-27 16:53:03 +00:00
Jesse Vincent
47b338fb94
Move message population to the message class.
2009-12-27 16:52:57 +00:00
Jesse Vincent
0005a8ea60
Remove lies from a comment
2009-12-27 16:52:50 +00:00
Jesse Vincent
54ad16edb8
Push a "is this the right folder?" check into our "add/remove messages from the message list, to better support search
2009-12-27 16:52:45 +00:00
Jesse Vincent
81a5820e5d
swap the order of two methods for readability
2009-12-27 16:52:39 +00:00
Jesse Vincent
7c8a7b1f27
Remove an old comment/obsolete code
2009-12-27 16:52:33 +00:00
Jesse Vincent
2a77001acc
First steps toward adding search results
2009-12-27 16:52:26 +00:00
Jesse Vincent
9a40457a2a
Remove giant commented out method - that's what we have version control history for
2009-12-27 16:52:17 +00:00
Jesse Vincent
854da2664c
Unify our "guard" against syncing the outbox or errors folder
2009-12-27 16:52:06 +00:00
Jesse Vincent
e2f84c4fa8
wrap a debug message in a debug-mode check; eliminate a temporary variable
2009-12-27 16:51:59 +00:00
Jesse Vincent
94e61ab62c
Extract out the listener we're using when we ask for new messages.
...
It may eventually get further extracted.
2009-12-27 16:51:45 +00:00
Jesse Vincent
9d417133b5
reduce duplication of code
2009-12-27 16:51:38 +00:00
Jesse Vincent
c953ff2c1b
Bulletproof MessageList against not having a folder loaded
2009-12-27 16:51:32 +00:00
Jesse Vincent
5c8a0a908c
Remove a lie from a comment
2009-12-27 16:51:25 +00:00
Jesse Vincent
5e0bbf18aa
Extract parts of title setting code into their own methods
2009-12-27 16:51:19 +00:00
Jesse Vincent
5b907c2d94
Remove an overridden subroutine that's now a noop
2009-12-27 16:51:13 +00:00
Jesse Vincent
c8bcad6a21
Refactor and reverse logic to be a bit cleaner
2009-12-27 16:51:06 +00:00
Jesse Vincent
721e298542
Invert some logic to clean up MessageList a bit
2009-12-27 16:51:00 +00:00
Jesse Vincent
56cdfa88c9
tiny grammar fix
2009-12-27 16:50:44 +00:00
Jesse Vincent
151ae5a2a3
First pass at adding "Searchable" infrastructure
2009-12-27 16:50:37 +00:00
Jesse Vincent
9ba102599f
Fix SQL statmeent
2009-12-27 16:50:28 +00:00
Jesse Vincent
9bcc991ec8
Extract out the code to "load mesages from SQL" from inside our "load messages in this folder" code
2009-12-27 16:50:21 +00:00
Jesse Vincent
9796cb6487
First rouind of extracting the "load messages from the db" column list
2009-12-27 16:50:14 +00:00
Daniel Applebaum
1ea96796d6
Add a global preference for enabling animations, beyond those that are
...
necessary. Defaults to "enabled."
2009-12-27 00:54:19 +00:00
Daniel Applebaum
ea65007b99
Disable inter-message animations, except when initiated by a swipe.
...
Fixes Issue 926.
2009-12-26 18:31:55 +00:00
Daniel Applebaum
070fd635d4
Allow user to set a limit on the number of folders to be handled with
...
push technology. This provide a layer of safety in case of
misconfiguration (accidentally setting too many folders to push using
classes), which can bog down the device till it is unusable. On a G1,
25 folders is a very large load. Fixes Issue 871.
Also, move some pending commands to the background to make way for
more important user interface activity.
2009-12-24 18:08:23 +00:00
Jesse Vincent
8fca99bef4
Fixes to unbreak incoming account setup after CRAM_MD5 implementation
2009-12-21 17:49:16 +00:00
Daniel Applebaum
4859ff7e8f
Add wakelocks for calling between MailService and Push/PollServices.
...
I don't know if these are truly necessary, but they should not be
harmful and might be a big reliability boost.
2009-12-21 01:48:15 +00:00
Daniel Applebaum
41d7ca51a3
Implementation of complete IMAP two-phase "delete/expunge" behavior.
...
On each IMAP account, the expunge behavior can be set to expunge
messages in a folder as soon as a move or delete is performed on the
folder ("immediately"), each time the folder is polled, or only when
executed manually.
In the Message List, there is now an Expunge action in the option
menu.
In the Folder List, there is now an Expunge action in the context
menu (long-press on the folder).
For IMAP accounts, it is also possible to disable the copying of deleted messages to the
Trash folder, by setting the Trash folder to -NONE-.
Fixes Issue 536.
Separately, in WebDAV accounts, the user can now choose the
server-side equivalents of the special folders, just like for IMAP.
2009-12-20 23:13:49 +00:00
Jesse Vincent
e82bb72a97
non-downloaded messages once again have a grey background.
...
Fixes Issue 899
2009-12-20 06:54:30 +00:00
Jesse Vincent
7e967c6110
removed now-unused subject coloring code
2009-12-20 06:54:23 +00:00
Jesse Vincent
b8b9e20e81
Hang onto our messaging controller rather than constantly reacquiring
...
it.
2009-12-20 06:14:10 +00:00
Jesse Vincent
2c9fc8b997
Backwards compatibility for the CRAM-MD5 implementation
2009-12-20 06:14:04 +00:00
Jesse Vincent
3914a78b53
xargs astyle --style=ansi --mode=java --indent-switches \
...
--indent=spaces=4 --convert-tabs --unpad=paren
2009-12-20 05:41:43 +00:00
Jesse Vincent
5a85446779
Initial implementation of CRAM-MD5 support for IMAP and SMTP.
...
Patch contributed by Russ Weeks <rweeks@gmail.com> in
<605ac1c0-808a-4f67-8c4d-736eec9587f8@e27g2000yqd.googlegroups.com>
2009-12-20 05:15:20 +00:00
Daniel Applebaum
921b022fb5
Enhanced header in Accounts, MessageList and Folder to show the unread
...
count, scoped for the Activity, the in-progress operation, the account
on which the operation is in progress, the folder for the operation,
when appropriate, and the progress of the operation, when it applies
to multiple items. For the MessageList, also use the determinate
progress bar to show progress for synchronization of the folder being
displayed.
Fixes Issue 924.
Also, a minor change that might help with Issue 913, by putting the
insertion of the pending command into a background thread.
2009-12-20 00:02:46 +00:00
Jesse Vincent
4f42907315
preferences doesn't actually tie to an account. it shouldn't be in the account context menu
2009-12-18 03:49:52 +00:00
Jesse Vincent
462d4098e0
Removed debugging log messages that clutter and slow the runtime app
2009-12-18 03:49:19 +00:00
Jesse Vincent
91ad70cd5d
Killed a bunch of debug logging that clutters (and slows) production apps
2009-12-18 03:48:24 +00:00
Jesse Vincent
83409d78fa
remove a bunch of debug logging that was cluttering production logs
2009-12-18 03:46:46 +00:00
Jesse Vincent
3f841d1494
removing debugging messages
2009-12-18 03:46:05 +00:00
Jesse Vincent
f94823cba4
Enable the new synchronous messagelist population. Perhaps
...
counter-intuitive, but it's a whole lot faster
2009-12-18 02:39:41 +00:00
Jesse Vincent
25306fad83
unify the synchronous and asynchronous codepaths for listlocalmessages
2009-12-18 02:36:37 +00:00
Jesse Vincent
157455f26b
As part of a refactoring move the "start" callback into the subthread.
2009-12-18 02:35:46 +00:00
Jesse Vincent
dc543fa9e3
now that we have more messages coming out of the database faster,
...
there's less use in special-casing the first 5
2009-12-18 02:34:50 +00:00
Jesse Vincent
c3e903942d
we no longer need to check the deleted flag at this layer as we do it further in.
2009-12-18 02:34:13 +00:00
Jesse Vincent
5789b385a8
first pass at working around messaging controller perf insanity
...
port listLocalMessagesSynchronous back into the MessagingController
revert some stuff
2009-12-18 02:33:18 +00:00
Jesse Vincent
48e1f31b43
Revert commit 829 @gcode - it was a performance optimization which added
...
nontrivial code complexity for what's now a nil performance gain
2009-12-18 02:32:17 +00:00
Jesse Vincent
c8bd377e76
minor refactoring to cut down on repeated method calls
2009-12-17 05:24:48 +00:00
Jesse Vincent
ce44165634
Fix our auto-expand folder behavior - Fixes issue 918
2009-12-17 03:45:37 +00:00
