cketti
6af48bd262
Restore TCP port value in incoming/outgoing server settings screens
...
Special thanks to zjw for the detailed analysis of this bug:
https://github.com/k9mail/k-9/pull/193
2012-10-21 20:04:53 +02:00
cketti
93ef3a7b0f
Fix message list when no search condition is given (All messages)
2012-10-21 19:18:57 +02:00
cketti
f093b84142
Make (de)serialization work when LocalSearch has no search conditions
2012-10-21 19:17:01 +02:00
cketti
1d655f5bc2
Added ability to display special folders combining multiple accounts
2012-10-18 05:15:40 +02:00
cketti
20ed1ebe61
Code style cleanup
2012-10-17 20:52:03 +02:00
cketti
fff94956f4
Fixed LocalSearch.addAllowedFolder()
...
We need to use the node returned by add() as new root node.
2012-10-16 22:51:01 +02:00
cketti
502771dd0e
Revert changing the default value for debug logging
2012-10-16 22:48:31 +02:00
cketti
f1e433e6df
Whitespace cleanup
2012-10-16 22:42:51 +02:00
cketti
83d5102f3d
Merge branch 'new_search_framework' into content_provider
...
Conflicts:
src/com/fsck/k9/fragment/MessageListFragment.java
2012-10-16 20:57:47 +02:00
cketti
cc74a2ad2e
Switched to ContentProvider and CursorLoader to display the message list
2012-10-16 15:46:40 +02:00
Sander Bogaert
49197b4f1c
First attempt at making the fragmented messagelist and remote search play nice with the new search framework. Works partially.
2012-10-13 15:07:28 -04:00
Sander Bogaert
bf82d0af7c
Changed all the calls to MessageList to work using the new LocalSearch class. These are all tested and working changes.
2012-10-13 15:06:57 -04:00
Sander Bogaert
f01f2f15cd
Add static methods to create unifiedInbox and allMessages accounts.
2012-10-13 14:19:50 -04:00
Sander Bogaert
a3d227649f
Change visibility of SearchModifier class and members.
2012-10-13 14:12:52 -04:00
Sander Bogaert
f550aaefb5
Add new SearchAccount class and move it together with SearchModifier to the search package ( refactor ).
2012-10-13 14:03:40 -04:00
Sander Bogaert
235e1f913b
Avoid needless nullpointers.
2012-10-13 10:40:13 -04:00
Sander Bogaert
bdfc9d6852
Added two convenience methods to avoid dealing with exceptions all the time.
2012-10-13 10:08:39 -04:00
Sander Bogaert
9883148b2f
Fixed wrong construction of leaf sets and unrightfully ignored exceptions.
2012-10-13 10:03:19 -04:00
Sander Bogaert
442805fe62
Made thread_root a searchable field of the message table. This can be used to display threads.
2012-10-13 09:28:19 -04:00
Sander Bogaert
d27f909600
Add new search logic to the MessagingController and LocalStore classes.
2012-10-13 08:53:00 -04:00
Sander Bogaert
5c6552cbf3
Adding the 3 core classes for the search framework. ConditionsTreeNode, LocalSearch and SearchSpecification.
2012-10-13 05:57:25 -04:00
Sander Bogaert
611bae3fb4
Created search package to hold the framework and moved over the SearchSpecification class ( refactor ).
2012-10-12 12:30:26 +02:00
cketti
c2bb451712
Don't display thread count in thread view
2012-10-10 04:32:48 +02:00
cketti
3413cbebf5
Worked around NPEs when the activity has been detached
2012-10-10 04:30:19 +02:00
Jesse Vincent
4e6453e7bb
remove vestiges of a deleted setting
2012-10-09 21:31:19 -04:00
cketti
16d2326033
Nasty hack to retain threads in MessageListFragment when polling
2012-10-10 03:02:36 +02:00
Jesse Vincent
e9ae328164
Bring back the checkboxes option for messagelist
2012-10-09 18:22:00 -04:00
cketti
63b6b497a0
Early version of message threading
...
Missing:
- UI support for threading when polling
- code to upgrade existing installations
- UI elements to switch from/to threaded display mode
- threading of messages with same subject
2012-10-08 22:51:29 +02:00
cketti
e66dd3d521
Fixed unit tests
2012-10-08 14:43:34 +02:00
cketti
d3f9633378
Merge branch 'fragments'
2012-10-08 14:33:33 +02:00
Jesse Vincent
f62ac401a0
make the stroke border on our color chips a bit wider to make them easier to see
2012-10-06 17:31:24 -04:00
cketti
93b13362b4
Converted message list to a fragment
2012-10-06 03:41:32 +02:00
cketti
12e9dce1d8
Renamed MessageList to MessageListFragment
2012-10-05 18:14:07 +02:00
cketti
8a226972a5
Extracted functionality common to most activities to K9ActivityCommon
2012-10-05 18:14:07 +02:00
cketti
bbcc4988ba
Converted message view to a fragment
...
The fragment should be fully functional. The only thing missing is the
animation when showing the next/previous message.
2012-10-05 18:14:07 +02:00
cketti
c6bea2e6ab
Copied ...activity.MessageView to fragment.MessageViewFragment
...
This commit breaks all sorts of things but should retain the Git
history of MessageView.
2012-10-05 18:14:06 +02:00
Andrew Chen
41756802a1
Move hasConnectivity() method into a helper method.
...
It's now used in multiple places, so unify the logic into one place.
2012-10-05 09:07:16 -07:00
Jesse Vincent
7b23704bd5
Add "cc Me" and "from me" color chips. Uprez the chips 10x so we get crisp views rather than awful bitmappy stuff
2012-10-03 21:56:28 -04:00
Jesse Vincent
0c34a21ff0
Add a fromMe method on messages
2012-10-03 21:56:28 -04:00
Andrew Chen
ecd4e0b001
Use the default date format if pulling from Preferences fails for any reason.
2012-10-03 10:06:40 -07:00
cketti
952c40710e
Added setting to disable using the background as (un)read indicator
2012-10-02 22:56:06 +02:00
cketti
fad52e6dac
Hide 'mark as (un)read' and '(un)flag' in the message list context menu
2012-10-02 19:59:08 +02:00
Andrew Chen
1491935465
Prevent remote search if we have no network connectivity.
2012-09-30 10:44:20 -07:00
Andrew Chen
3861e7ca35
Log NumberFormatExceptions. Fix whitespace.
2012-09-29 07:53:34 -07:00
Andrew Chen
5a487f154c
Merge pull request #185 from chamonkey/issue3714
...
Add number format handling to Storage.java
2012-09-29 07:51:48 -07:00
Andrew Chen
6b10451b79
Whitespace; no functional changes.
2012-09-29 07:48:58 -07:00
Andrew Chen
1d0ad3cb38
Enable remote search by default.
2012-09-29 07:48:49 -07:00
chamonkey
6e27a90905
Addition of number format handling to Storage.java
2012-09-28 14:48:16 +01:00
Andrew Chen
39e2a973a1
Merge branch 'imapsearch'
...
* imapsearch:
Change settings version to 18 to match what's currrently on master.
Handle aborted imap searches by nuking in-progress connections.
Move IMAP search into the Folder level.
Remove duplicate notification on remote search start.
Rename variables
changed PREFERENCE_CLOUD_SEARCH_ENABLED from "cloud_search_enabled" to "remote_search_enabled" in activity/setup/AccountSettings.java to resolve FC.
Add cloud search icon to local search result screen. Implement pull-to-remote-search.
Log remote search exceptions in addition to toasting them.
Add settings export for remote search settings.
Whitespace; no functional changes.
Handle implicit vs. explicit searches in ActionBar home button behavior.
Whitespace fix; no functional changes.
Add remote search actionbar icons.
IMAP Search: log exceptions on remote search, properly dispatch MessageList changes.
modified loadMessageForView() to dowload message if neither X_DOWNLOADED_FULL nor X_DOWNLOADED_PARTIAL.
Add remote IMAP search support.
Conflicts:
res/menu/message_list_option.xml
res/values/attrs.xml
res/values/themes.xml
src/com/fsck/k9/activity/MessageList.java
src/com/fsck/k9/preferences/Settings.java
2012-09-25 16:01:52 -07:00
Andrew Chen
d88a275840
Change settings version to 18 to match what's currrently on master.
2012-09-25 15:50:47 -07:00
Andrew Chen
2541753aff
Handle aborted imap searches by nuking in-progress connections.
2012-09-25 15:46:30 -07:00
Andrew Chen
9f96cd36a7
Move IMAP search into the Folder level.
...
Should also consider moving the LocalStore search into the folder level and have the store call the folder level searches.
2012-09-25 14:34:59 -07:00
Andrew Chen
270d948edb
Remove duplicate notification on remote search start.
2012-09-25 08:16:48 -07:00
Andrew Chen
5b59511c12
Rename variables
2012-09-25 07:50:10 -07:00
Jesse Vincent
0e3f87f77f
Chip updates based on work by m0vie
2012-09-24 19:25:34 -04:00
Jesse Vincent
2c486e31b6
option to put the sender of a message above the subject
2012-09-24 19:11:21 -04:00
Jesse Vincent
83c5783442
Remove the "make this the default account" checkbox from the account setup flow.
...
If you're adding a new account, it's less likely to be your default than your first was.
No reason for this in initial flow
2012-09-24 12:34:55 -04:00
Jesse Vincent
7c0d47a493
switch back from an itemmenu ot a context menu in messagelist.
2012-09-24 12:11:34 -04:00
Jesse Vincent
6e3ac2317e
Fix a bug that caused accounts to not have a color on initial load
...
(and now caused a crash on inital load)
2012-09-24 12:11:07 -04:00
ashley willis
6ee0548b71
changed PREFERENCE_CLOUD_SEARCH_ENABLED from "cloud_search_enabled" to "remote_search_enabled" in
...
activity/setup/AccountSettings.java to resolve FC.
2012-09-22 14:23:06 -05:00
Andrew Chen
360b3f1be8
Add cloud search icon to local search result screen. Implement pull-to-remote-search.
2012-09-22 09:40:46 -07:00
Andrew Chen
7631af1572
Log remote search exceptions in addition to toasting them.
2012-09-22 09:37:50 -07:00
Jesse Vincent
8df55d069d
make the checkmarks a bit more prominent
2012-09-21 17:27:59 -04:00
Jesse Vincent
48785f52bf
Remove the message list stars preference now that stars are in the chip
2012-09-21 17:27:58 -04:00
Jesse Vincent
158c98b5af
replace checkboxes with a variant of the chip.
2012-09-21 17:27:58 -04:00
Jesse Vincent
baf99b114b
refactor chip code to be a little less ugly
2012-09-21 17:27:58 -04:00
dzan
950940ca3a
Merge pull request #183 from dzan/fix_swipe_select
...
Revert to swipe to enter multi select mode.
2012-09-21 10:26:05 -07:00
Sander Bogaert
b76be539b8
Fix a bug pull-to-refresh exposed in our swipe to select code.
2012-09-21 13:24:53 -04:00
Jesse Vincent
b9395da6be
slight tweaks to chip shape
2012-09-21 00:50:00 -04:00
Jesse Vincent
9a8c050539
slight tweak to the new chip formats
2012-09-21 00:12:09 -04:00
Jesse Vincent
e55b1e0738
Move the message star into the chip. (Also, the "to me" information)
2012-09-20 23:30:52 -04:00
Sander Bogaert
e0a687dba4
Revert "remove our swipe to select/deselect code now that we have long-press to select and check box to select"
...
This reverts commit cd98875729
.
2012-09-20 16:50:56 -04:00
Andrew Chen
d50e07bf55
Add settings export for remote search settings.
2012-09-18 20:04:48 -07:00
cketti
42e0b3e045
Code cleanup and simplification
2012-09-18 04:16:01 +02:00
cketti
de59725743
Exit action mode when a message list item context menu is displayed
2012-09-18 04:05:13 +02:00
cketti
0334ba88c5
Removed 'compact layout' for now
...
See issue 4556
2012-09-18 03:43:54 +02:00
cketti
7bb11c09b2
Display concrete action instead of "Toggle (un)read" & "(Un)star"
2012-09-18 03:33:37 +02:00
cketti
f22801e9d6
Changed the way we handle menu item clicks using MenuPopupHelper
...
Overriding onItemClick() doesn't allow us to get the MenuItem that was
clicked when at least one menu item is hidden. This is because the
position in the list of visible menu items is returned. But that value
can't be used to retrieve the corresponding MenuItem (getItem() uses
the position as index into the list of all menu items).
2012-09-18 03:07:43 +02:00
Sander Bogaert
d06ec162b6
Have consistent scrollbar style on the FolderList and get rid of the strange whitespace on the right.
2012-09-17 14:08:16 -04:00
cketti
d5b9aec39f
Display a dark-themed "Send as" dialog when using the dark theme on HC+
2012-09-16 03:24:40 +02:00
cketti
163557ae8a
Use ContextThemeWrapper for "Send as" dialog
...
The old code changed the theme of the activity by wrongly using
ContextWrapper + setTheme().
2012-09-16 03:16:29 +02:00
cketti
9afaaa1e6e
Use workaround for PreferenceScreen display bug on Honeycomb too
...
Fixes issue 4569
2012-09-16 02:45:50 +02:00
m0viefreak
771b5122d6
MessageView theme toggle: change the theme of the whole activity and not just the background of the WebView
...
Using dark theme with white WebView background looks very ugly,
especially when a "download complete message" or a "show images"
button is present.
This change applies the theme to the whole activity.
Also changed the text for the toggle menu. It's also shorter now,
and isn't cut off anymore on hdpi/480px wide devices.
2012-09-15 07:22:25 +02:00
Andrew Chen
b81fc8ea90
Merge pull request #176 from aatdark/aatdark_issuedarkwhite
...
+toggle option in message view to change message display theme (dark,lig...
2012-09-14 20:07:29 -07:00
Andrew Chen
3e71453e71
Handle implicit vs. explicit searches in ActionBar home button behavior.
2012-09-14 19:46:28 -07:00
Andrew Chen
2ffa3243b3
Whitespace fix; no functional changes.
2012-09-14 19:46:27 -07:00
Andrew Chen
55ebcf8b8c
Handle implicit vs. explicit searches in ActionBar home button behavior.
2012-09-14 19:45:04 -07:00
Andrew Chen
57a6dfd61f
Whitespace fix; no functional changes.
2012-09-14 19:24:49 -07:00
cketti
1155324df0
Retain visibility state of "Add Cc/Bcc" menu item on orientation change
2012-09-14 04:26:57 +02:00
cketti
ba0c530c7b
Avoid NullPointerException
...
Fixes issue 4557
2012-09-14 04:09:18 +02:00
cketti
8018be3e16
Some code cleanup
2012-09-14 04:08:17 +02:00
Bernhard Redl
76d8e11703
+toggle option in message view to change message display theme (dark,light) permanently (Issue 1674)
2012-09-14 03:16:36 +02:00
cketti
2ee3378eef
Use executeSimpleCommand() for UID COPY so the response type is checked
...
The previous code never failed e.g. on a "NO" response. That lead to
messages being deleted for a move action.
2012-09-14 02:08:39 +02:00
cketti
93be25bf37
Make sure ActivityListener.getOperation() never returns null
2012-09-14 01:28:52 +02:00
cketti
0878de5936
Go back to the old behavior for batch mark as (un)read, (un)flag
...
If there is at least one unread message among the selected messages the
action is "mark as read". Otherwise, "mark as unread".
If there is at least one unstarred message among the selected messages
the action is "add star". Otherwise, "remove star".
2012-09-14 00:34:25 +02:00
cketti
95c748c183
Removed hack that is no longer necessary after fixing the activity stack
2012-09-13 23:22:14 +02:00
Andrew Chen
1ef930090e
IMAP Search: log exceptions on remote search, properly dispatch MessageList changes.
2012-09-13 09:10:39 -07:00
ashley willis
df75a9fbfa
modified loadMessageForView() to dowload message if neither X_DOWNLOADED_FULL nor X_DOWNLOADED_PARTIAL.
2012-09-13 09:10:38 -07:00
Rob Bayer
fdb1267cb1
Add remote IMAP search support.
...
* rbayer/IMAPsearch: (21 commits)
More cleanup
Code Cleanup getRemoteSearchFullText -> isRemoteSearchFullText line wraps for preference items
Refactor to allow fetching of extra search results beyond original request. Most code moved out of ImapStore and ImapFolder and into MessagingController.searchRemoteMessagesSynchronous. Should make it easier to add remoteSearch for other server types.
Prevent delete of search results while search results open
remove duplicated code block
Don't hide Crypto when IMAPsearch disabled
Code Style Cleanup: Tabs -> 4 spaces Remove trailing whitespace from blank lines
tabs -> spaces (my bad...)
Fix opening of folders to be Read-Write when necessary, even if they were previously opened Read-Only.
add missing file
Working IMAP search, with passable UI.
UI improvements
Simple help info when enabling Remote Search
Dependency for preferences
Basic IMAP search working
2012-09-13 09:10:37 -07:00
Jesse Vincent
3a68360e30
remove lots of duplicate menu ui, particularly cutting down on context menu stuff.
2012-09-12 23:30:27 -07:00
Jesse Vincent
5d4a2132d8
Remove "mark all as read" from the UI. (leaving the backend support for now)
...
User-facing "select all, mark as read" is slightly different but less confusing and cluttered than the duplicated option
2012-09-12 23:30:27 -07:00
cketti
5a29c8a415
Get rid of incomplete code to toggle a message's selection state
2012-09-13 06:46:32 +02:00
cketti
997943a521
Update action mode title when necessary
2012-09-13 06:46:32 +02:00
cketti
d9fad383eb
Added "select all" to action mode menu
2012-09-13 06:46:32 +02:00
Andrew Chen
ea04339ca6
Add Android-PullToRefresh to about screen.
2012-09-12 21:31:26 -07:00
Jesse Vincent
3799ecfb21
Check message uids first when comparing messages. message uids are less likely to be the same than folders, so it's a slight optimization
2012-09-12 21:56:17 -05:00
Jesse Vincent
1b7af9270e
Make the message item popup menu work
2012-09-12 20:58:44 -04:00
Jesse Vincent
7b40e5b14a
remove single message items from the Action bar
2012-09-12 20:47:24 -04:00
Jesse Vincent
d876a16893
Add a helper helper so we can get click events on message list menu items
2012-09-12 20:44:57 -04:00
Jesse Vincent
593569f4ad
Bullet-proof an NPE I ran into on a 2.2 test emulator while on an airplane
2012-09-12 18:54:06 -04:00
cketti
2a05bc0caa
Use ActionBarSherlock's MenuBuilder for the "more" menu
2012-09-12 18:26:51 -04:00
Andrew Chen
c574088f57
Add basic pull to refresh support to MessageList.
2012-09-12 01:59:55 -07:00
Jesse Vincent
4eff1a25e9
Temporarily disable our messagelist item backgrounds so we can see list item selection.
...
They'll return as a preference
2012-09-12 00:54:20 -04:00
Jesse Vincent
ff52affed9
Make the menu button trigger the existing single-select action mode (until we can make the proper context menu go.)
2012-09-12 00:52:39 -04:00
Jesse Vincent
b5d887728a
Cleanups to our MessageList item select/deselect code.
...
Fixes bugs where the action mode wouldn't trigger if the first item was checked with the checkbox
2012-09-11 18:47:32 -04:00
cketti
3060fd063e
Don't display "0" in the action bar if there are no unread messages
2012-09-11 04:38:03 +02:00
cketti
ac8d1aa162
Cleanup
2012-09-11 04:33:20 +02:00
Jesse Vincent
cd98875729
remove our swipe to select/deselect code now that we have long-press to select and check box to select
2012-09-10 18:32:24 -04:00
Jesse Vincent
d5f739030a
Always save all headers. Not doing so is kind of a crazy space microoptimization and can get a little messy
2012-09-10 12:07:35 -04:00
cketti
20a608e1a0
Removed "Manage back button" setting
2012-09-10 17:54:27 +02:00
Jesse Vincent
8d928d20fa
get rid of the non-touchable version of the message list items. (The real difference was the capability to show previews)
2012-09-10 11:52:00 -04:00
cketti
f9630a3826
Don't display "up" arrow in action bar of Accounts activity
2012-09-10 17:24:35 +02:00
cketti
d8e9c48177
Changed the way we use the activity stack
...
- removed launchMode attributes for all activities
- only use one activity task
- got rid of "managed back button" behavior
2012-09-10 17:24:34 +02:00
Jesse Vincent
8daea241af
Cache the read and unread color chip variants per account.
2012-09-10 11:11:40 -04:00
Jesse Vincent
86c9aab7a8
default touchable views and checkboxes to on
2012-09-10 11:06:45 -04:00
Jesse Vincent
c9897a5c84
Indicate read state in chips
2012-09-10 11:01:51 -04:00
cketti
185d6b8538
Changed scrollbar style in message list
2012-09-10 16:48:54 +02:00
cketti
0b977c9e9b
Tweaked background colors for (un)read messages in the message list
2012-09-10 16:48:54 +02:00
Jesse Vincent
78cf804aca
first pass of converting chips to colored circles
2012-09-10 10:40:20 -04:00
Jesse Vincent
46edd8f793
Revert "Context actionbar for the account screen."
...
We're not ready for this sort of living in the futre yet.
This reverts commit 0f51eb54c1
.
Conflicts:
res/drawable-hdpi/ic_action_settings_light.png
res/drawable-ldpi/ic_action_settings_light.png
res/drawable-mdpi/ic_action_settings_light.png
res/drawable-xhdpi/ic_action_settings_light.png
res/menu/accounts_context.xml
res/values/strings.xml
src/com/fsck/k9/activity/Accounts.java
2012-09-10 07:56:35 -04:00
Jesse Vincent
297e859b90
Revert "Add context action bar on FolderList activity." - We are not ready for this
...
sort of future yet ;)
This reverts commit a5b8ce8064
.
Conflicts:
res/drawable-hdpi/ic_action_read_light.png
res/drawable-ldpi/ic_action_read_light.png
res/drawable-mdpi/ic_action_read_light.png
res/drawable-xhdpi/ic_action_read_light.png
res/menu/folder_context.xml
2012-09-10 07:41:37 -04:00
ashley willis
7d4152fdd4
re Bernhard's Issue 4543 fix: only set as read if account.isMarkMessageAsReadOnView()
2012-09-09 21:15:37 -05:00
Bernhard Redl
7c9b42091a
Fixes 4517: Junk special folder not autoconfigured (rfc6154 implementation was incomplete)
2012-09-09 21:11:08 -05:00
Bernhard Redl
ee0e558f4d
Fixed Issue 4543: Msg UnRead after "Download Complete" pressed
2012-09-09 21:11:08 -05:00
Bernhard Redl
611cf2e192
fixed download complete message button
2012-09-09 21:11:08 -05:00
Andrew Chen
891dde2baf
Set (un)read toggle title based on current message state.
2012-09-09 15:11:54 -07:00
Andrew Chen
e4d2830ec7
Rename some one-letter variables.
2012-09-09 15:11:13 -07:00
Andrew Chen
3e261568ae
Fix whitespace; no functional changes.
2012-09-09 14:46:34 -07:00
Andrew Chen
38c4f24111
Move message selection functionality into the MessageAdapter.
2012-09-09 14:09:35 -07:00
Jesse Vincent
3ef22ca094
When we're at the end of the message list, dim the next or prev button instead of making it vanish
2012-09-09 13:45:35 -07:00
Jesse Vincent
20e3335bc1
Remove "flag" as a meessage view menu option (duplicates tapping on the star)
2012-09-09 13:45:34 -07:00
Jesse Vincent
87e437b388
Move "move" and "copy" out of a submenu
2012-09-09 13:45:33 -07:00
Andrew Chen
9fbb2b4836
Show the subject line in the MessageHeader if the ActionBar title was truncated.
2012-09-09 13:45:33 -07:00
Andrew Chen
31461bc657
Set abs title to (no subject) if the message has no subject.
2012-09-09 13:45:31 -07:00
Andrew Chen
ed693fc01a
Hide the unread message count in the actionbar when doing an explicit search.
2012-09-09 13:45:30 -07:00
Andrew Chen
4a416f7acd
Hide subject line in MessageView since it's now displayed in the actionbar.
...
Now that the subject line is gone, the right side of the header is now the tallest part of the header.
Put date and time on the same line to keep the header compact.
2012-09-09 13:41:49 -07:00
Sander Bogaert
cbfe353378
Remove fading edges.
2012-09-09 13:39:12 -07:00
Sander Bogaert
a5b8ce8064
Add context action bar on FolderList activity.
2012-09-09 13:39:11 -07:00
Sander Bogaert
c0e483d2b9
Have a dynamic subtitle for the MessageList action bar too.
2012-09-09 13:39:10 -07:00
Sander Bogaert
1036fe531d
Split folder action bar and use the same top view as we use for Accounts and MessageList.
2012-09-09 13:37:15 -07:00