Jesse Vincent
0bdb02dc24
Minor reformatting
2010-01-09 23:49:44 +00:00
Jesse Vincent
e49fdc9913
Added a comment about why we're setting a click handler
2010-01-09 23:49:36 +00:00
Jesse Vincent
fb223ea61d
rename a paremeter to better reflect its use: nextWidget->showWidget
2010-01-09 23:49:31 +00:00
Jesse Vincent
553625b72b
Comment an attribute
2010-01-09 23:49:25 +00:00
Jesse Vincent
497ca01586
swap the order of compared values for a bit more logical sanity
2010-01-09 23:25:15 +00:00
Jesse Vincent
5802b84e16
Reorder methods for better logical grouping
2010-01-09 23:25:10 +00:00
Jesse Vincent
9db97e214d
Restore Bao-long's original design for "widgets on the left" being a
...
global config option rather than a per-account one. (But with a new
implementation.) - As we now have views that show messages across
accounts, this needed to become a global)
2010-01-09 23:02:40 +00:00
Daniel Applebaum
56a4b94748
Put the color chip with read/unread controlled brightness at all
...
levels except MessageView
2010-01-06 05:23:32 +00:00
Daniel Applebaum
a5166e3c2d
Fixes Issue 963
...
MessagingController was calling the MessagingListener twice for
deleted messages. By the time the second call was made, some
Activities already had removed the message holder, so a null holder
was being put on the list.
This change should prevent the double calls, and adds protection
against have the MessageList MessagingListener called with a message
that is no longer in the MessageList.
Also, some logical cleanups.
2010-01-06 04:54:24 +00:00
Daniel Applebaum
d58d1c60c0
Proper super call
2010-01-04 00:48:33 +00:00
Jesse Vincent
a926911e7f
rerun astyle
2010-01-03 01:50:51 +00:00
Jesse Vincent
953b784fb9
First pass at fixing Issue 963 (explosions when trying to iterate over a
...
remotely deleted message) introduced in r1204.
(Before my all-day meeting)
2009-12-29 17:06:13 +00:00
Jesse Vincent
2ef3b15c87
make sure we don't accidentally open the context menu on a message when we're in multiselect mode.
2009-12-29 17:05:17 +00:00
Jesse Vincent
3e3b4d447d
Fix reversed color chip alpha
2009-12-28 12:56:59 +00:00
Jesse Vincent
794f515bc8
Numerous small fixes to search results
2009-12-27 17:22:57 +00:00
Jesse Vincent
0a2d9b9c9f
make sure search results aren't updated incorrectly on incoming messages
2009-12-27 17:22:38 +00:00
Jesse Vincent
bfaba499fe
Fix the Search header on search results
2009-12-27 17:22:32 +00:00
Jesse Vincent
63b6f6bf62
Refactoring to better propagate "folder" along with messages as they're instantiated
2009-12-27 17:22:26 +00:00
Jesse Vincent
d60521f06f
further push down our "is this message for us" logic.
2009-12-27 17:20:56 +00:00
Jesse Vincent
6c7782b4bd
remove another alternate calling convention for addOrUpdateMessage. Code
...
will get still cleaner when we start propagating back message folders as objects
2009-12-27 17:20:50 +00:00
Jesse Vincent
c608ffb672
Eliminate a variant of addOrUpdateMessage that was only called once
2009-12-27 17:20:28 +00:00
Jesse Vincent
1c4a0be0da
enable searching of messages
2009-12-27 17:20:21 +00:00
Jesse Vincent
21238a3084
If we get a message from listLocalMessages and we're doing a search,
...
assume it's for us. Later, we may want to be smarter about that.
2009-12-27 17:20:13 +00:00
Jesse Vincent
a736a4267c
Only trigger our "loading" indicator if the account matches "our" account
2009-12-27 17:20:06 +00:00
Jesse Vincent
204289a4ff
when opening a message for display or edit, use its notion of account, not the folder's.
2009-12-27 17:19:56 +00:00
Jesse Vincent
f6756879ef
Temporarily disable "left-handed" controls if we're doing a search.
...
view configuration needs to move to be global for this to work right.
2009-12-27 17:19:49 +00:00
Jesse Vincent
bc61c90e1a
make the auto-open folder not trigger if we're doing a search
2009-12-27 17:15:46 +00:00
Jesse Vincent
81d72a2d8c
make the color chip genuinely calculated per message
2009-12-27 17:15:38 +00:00
Jesse Vincent
ed19a8284e
Propagate per-message account info into MessageInfoHolder and FolderInfoHolder
2009-12-27 16:54:23 +00:00
Jesse Vincent
302deea53e
addOrUpdateMessage calls now propagate the account of the found message
2009-12-27 16:54:12 +00:00
Jesse Vincent
3ad69c799d
When listing off messages, make sure that our "refresh the list" fires,
...
even if we didn't start off empty.
This could have prevented updated messages from showing up
2009-12-27 16:54:06 +00:00
Jesse Vincent
4cec247699
Make it possible to populate a MessageInfoHolder without a FolderInfoHolder
2009-12-27 16:53:09 +00:00
Jesse Vincent
fe67f0a40c
temporarily disable new unfinished search code
2009-12-27 16:53:03 +00:00
Jesse Vincent
0005a8ea60
Remove lies from a comment
2009-12-27 16:52:50 +00:00
Jesse Vincent
54ad16edb8
Push a "is this the right folder?" check into our "add/remove messages from the message list, to better support search
2009-12-27 16:52:45 +00:00
Jesse Vincent
81a5820e5d
swap the order of two methods for readability
2009-12-27 16:52:39 +00:00
Jesse Vincent
7c8a7b1f27
Remove an old comment/obsolete code
2009-12-27 16:52:33 +00:00
Jesse Vincent
2a77001acc
First steps toward adding search results
2009-12-27 16:52:26 +00:00
Jesse Vincent
9d417133b5
reduce duplication of code
2009-12-27 16:51:38 +00:00
Jesse Vincent
c953ff2c1b
Bulletproof MessageList against not having a folder loaded
2009-12-27 16:51:32 +00:00
Jesse Vincent
5c8a0a908c
Remove a lie from a comment
2009-12-27 16:51:25 +00:00
Jesse Vincent
5e0bbf18aa
Extract parts of title setting code into their own methods
2009-12-27 16:51:19 +00:00
Jesse Vincent
5b907c2d94
Remove an overridden subroutine that's now a noop
2009-12-27 16:51:13 +00:00
Jesse Vincent
c8bcad6a21
Refactor and reverse logic to be a bit cleaner
2009-12-27 16:51:06 +00:00
Jesse Vincent
721e298542
Invert some logic to clean up MessageList a bit
2009-12-27 16:51:00 +00:00
Jesse Vincent
56cdfa88c9
tiny grammar fix
2009-12-27 16:50:44 +00:00
Daniel Applebaum
41d7ca51a3
Implementation of complete IMAP two-phase "delete/expunge" behavior.
...
On each IMAP account, the expunge behavior can be set to expunge
messages in a folder as soon as a move or delete is performed on the
folder ("immediately"), each time the folder is polled, or only when
executed manually.
In the Message List, there is now an Expunge action in the option
menu.
In the Folder List, there is now an Expunge action in the context
menu (long-press on the folder).
For IMAP accounts, it is also possible to disable the copying of deleted messages to the
Trash folder, by setting the Trash folder to -NONE-.
Fixes Issue 536.
Separately, in WebDAV accounts, the user can now choose the
server-side equivalents of the special folders, just like for IMAP.
2009-12-20 23:13:49 +00:00
Jesse Vincent
e82bb72a97
non-downloaded messages once again have a grey background.
...
Fixes Issue 899
2009-12-20 06:54:30 +00:00
Jesse Vincent
7e967c6110
removed now-unused subject coloring code
2009-12-20 06:54:23 +00:00
Jesse Vincent
b8b9e20e81
Hang onto our messaging controller rather than constantly reacquiring
...
it.
2009-12-20 06:14:10 +00:00
