cketti
0f70d5db40
Merge pull request #12 from k9mail/art/warn-if-not-serializable
...
Art/warn if not serializable
2014-11-11 19:52:31 +01:00
cketti
bd4a236525
Merge pull request #11 from k9mail/art/fix-tests-on-jvm
...
fix tests on JVM
2014-11-11 19:46:58 +01:00
cketti
7211080415
Merge pull request #10 from k9mail/art/more-tidying-arrays
...
Replace many arrays with collections
2014-11-11 19:45:35 +01:00
Art O Cathain
438a350f55
remove unnecessary method parameters
2014-10-19 18:40:17 +01:00
Art O Cathain
a9b0907c31
further simplification
2014-10-12 09:24:08 +01:00
Art O Cathain
ba26cfce90
remove controversial methods
2014-10-12 08:54:44 +01:00
Art O Cathain
5dc1b82340
address review comments
2014-10-11 23:52:48 +01:00
Art O Cathain
c6df8f1ba1
warn if not serializable, also add basic unit test
2014-10-11 12:37:36 +01:00
Art O Cathain
668ee71b6c
fix tests on JVM
2014-10-11 12:10:07 +01:00
Art O Cathain
40102d560d
Set interface makes more sense for flags
2014-10-05 12:40:35 +01:00
Art O Cathain
195f28db00
Revert accidental change
2014-10-05 12:23:43 +01:00
Art O Cathain
444756839c
EnumSet is more efficient than HashSet
2014-10-05 12:08:55 +01:00
Art O Cathain
fe7c0ebfac
simplify following code review
2014-10-05 11:57:11 +01:00
Art O Cathain
159017e91d
removed unneeded variables and clarified names
2014-10-05 11:50:04 +01:00
Art O Cathain
d38f21265d
use isEmpty instead of size() == 0 for clarify
2014-10-05 10:37:50 +01:00
Art O Cathain
02c0b5f2a3
Use collections instead of arrays to enable stronger typing and reduce cruft
2014-10-05 10:37:36 +01:00
Art O Cathain
203dcfe2c3
use interfaces, not implementions
2014-10-04 12:00:48 +01:00
tobiasbaum
dadf5e0865
Merge pull request #7 from artbristol/art/tidying
...
Art/tidying
2014-09-29 22:15:59 +02:00
Art O Cathain
010d8c9f7e
always use import for UrlEncodingHelper
2014-09-29 18:06:21 +01:00
Art O Cathain
2226ae6a8e
fix IDE error
2014-09-28 12:48:46 +01:00
Art O Cathain
c438bc1222
remove some more catches
2014-09-28 12:09:34 +01:00
Art O Cathain
afb65d5ad7
remove some try-catch cruft
2014-09-28 11:39:32 +01:00
Art O Cathain
46d083bcad
fix warnings
2014-09-28 11:19:33 +01:00
Tobias Baum
2be10febf9
Added (still rather shallow) missing Javadocs for classes in BinaryAttachmentBody hierarchy
2014-09-22 21:55:08 +02:00
Tobias Baum
547eb74774
Changed access to mParts in MimeMultipart so that it can be private too
2014-09-22 21:54:02 +02:00
Tobias Baum
b6079d6460
UCDetector warnings: Made things private, deleted unused methods and fields
2014-09-22 21:52:59 +02:00
Tobias Baum
1ea34d2378
Flagged some code with TODOs, added Javadoc for Body
2014-09-14 11:20:18 +02:00
Tobias Baum
be954d729c
Whitespace, Tabs to Spaces
2014-09-14 11:18:57 +02:00
Tobias Baum
7d32b3d462
Removed unnecessary overriding methods
2014-09-14 11:17:02 +02:00
Tobias Baum
a9aa4645af
Removed unused methods
2014-09-14 11:15:44 +02:00
Tobias Baum
545dd0db06
Added a getBodyparts method to Multipart so that foreach loops can be used. Removed unnecessary mutators from Multipart.
2014-09-14 11:13:34 +02:00
Tobias Baum
5513d5a99b
Pulled down getSize from Part to Message which makes ImapBodyPart superfluous
2014-09-14 11:11:48 +02:00
Tobias Baum
d467dca32c
Added testcases for parsing and removed unused methods for parsing
2014-09-14 11:05:55 +02:00
cketti
601e2880ac
Merge remote-tracking branch 'upstream/master'
...
Conflicts:
src/com/fsck/k9/mail/transport/SmtpTransport.java
2014-09-12 07:11:32 +02:00
cketti
a6fc06f7f9
Fix code style
2014-09-12 06:35:07 +02:00
cketti
3e4beae631
Remove unused 'check mark' color chip
2014-09-12 06:26:03 +02:00
Christian Frommeyer
9dba60c997
Some minor code cleanings and logging for LockableDatabase
2014-09-11 20:26:40 +02:00
Christian Frommeyer
eced036d69
Extracting Database Setup Schema definition form LocalStore.
2014-09-11 20:26:40 +02:00
Christian Frommeyer
91ef5fa816
Extracted LocalFolder and LocalMessage definition from LocalStore
2014-09-11 20:26:40 +02:00
Christian Frommeyer
89ba2c510b
More nested classes extracted from LocalStore.
2014-09-11 20:26:40 +02:00
Christian Frommeyer
f92da3af59
Extracting local attachment classes from LocalStore to reduce file size.
2014-09-11 20:26:39 +02:00
Christian Frommeyer
038fceabf0
Move LocalStore to new subpackage to prepare decomposition of nested
...
classes.
2014-09-11 20:26:39 +02:00
Joe Steele
0f6719387c
Re-enable TLSv1.1/1.2 support
...
Was disabled in 3fd7470d.
Issue 6238.
Related Android change for API 20:
1f63d2c223
2014-09-10 11:42:14 -04:00
cketti
a10b9ae452
Merge pull request #493 from zjw/ssl_changes
...
SSL changes
2014-09-10 01:44:44 +02:00
Joe Steele
094feced0c
Remove unused imports
2014-09-09 18:56:36 -04:00
cketti
9e203b75cc
Remove gallery bug work-around
...
This bug was present in the Gallery app shipped with Android 2.0.
The time has come to say good-bye. We will never forget you! But only because you're part of our Git history.
2014-09-07 23:35:18 +02:00
Joe Steele
43c38a047f
Implement SSL file-based session caching
...
Caching is beneficial because it can eliminate redundant cryptographic
computations and network traffic when re-establishing a connection to
the same server, thus saving time and conserving power.
2014-09-06 19:32:06 -04:00
Joe Steele
7dfbd906c9
Eliminate DomainNameChecker
...
There's no need to maintain our own implementation when comparable
classes already exist in the Android API.
StrictHostnameVerifier is used instead.
2014-09-06 19:32:03 -04:00
Joe Steele
6f14294164
Remove SslHelper. Don't use SecureRandom.
...
SslHelper has been removed, and its functionality has been transferred
into TrustedSocketFactory. The added layer of indirection wasn't really
simplifying anything. It's now easier to see what happens when
createSocket() is invoked.
A new instance of SecureRandom is no longer passed to SSLContext.init().
Instead, null is passed.
The (default) provider of the TLS SSLContext used is OpenSSLProvider,
which provides an SSLSocket instance of type OpenSSLSocketImpl. The only
use of SecureRandom is in OpenSSLSocketImpl.startHandshake(), where it is
used to seed the OpenSSL PRNG with additional random data. But if
SecureRandom is null, then /dev/urandom is used for seeding instead.
Meanwhile, the default provider for the SecureRandom service is
OpenSSLRandom, which uses the OpenSSL PRNG as its data source. So we were
effectively seeding the OpenSSL PRNG with itself. That's probably okay
(we trust that the OpenSSL PRNG was properly initialized with random data
before first use), but using /dev/urandom would seem like a better source
(or at least as good a source) for the additional seed data added with
each new connection.
Note that our PRNGFixes class replaces the default SecureRandom service
with one whose data source is /dev/urandom for certain vulnerable API
levels anyway. (It also makes sure that the OpenSSL PRNG is properly
seeded before first use for certain vulnerable API levels.)
2014-09-06 18:15:25 -04:00
cketti
5f0f4e9c21
Merge pull request #485 from haselwarter
...
Conflicts:
src/com/fsck/k9/preferences/Settings.java
2014-09-04 23:55:30 +02:00
