Commit Graph

705 Commits

Author SHA1 Message Date
Jan Berkel 0f476978ce mail.store.* cleanups 2014-12-18 09:33:09 +01:00
Jan Berkel 2f30b3956d Dependency Inversion, remove K9.app references 2014-12-17 17:42:22 +01:00
Jan Berkel b36c788ce0 Move ImapConnection out 2014-12-17 17:16:18 +01:00
Jan Berkel 16f8a3ef14 Remove trusted socket factory statics 2014-12-17 16:43:55 +01:00
Jan Berkel 27e0c75021 Move exception error strings out of mail package 2014-12-17 16:24:52 +01:00
Jan Berkel 231684936b break/centralize dependencies to K9 2014-12-16 12:54:12 +01:00
cketti 23d9310c61 Remove getUuid() from StoreConfig 2014-12-16 03:32:57 +01:00
Jan Berkel 476cb1d4ce Tidy responsibilities 2014-12-14 15:58:08 +00:00
Jan Berkel 238c1650c5 Remove URLEncodingHelper dependency 2014-12-14 15:54:27 +00:00
Jan Berkel 40041ac0e0 Move local message code to local package
+ cut some helper dependencies
2014-12-12 15:02:59 +00:00
Jan Berkel 2e98ff56e5 Break dependencies 2014-12-12 13:35:36 +00:00
Jan Berkel 0024f39bc6 Local messages 2014-12-12 13:04:59 +00:00
Jan Berkel 708fb57c04 Move things into local 2014-12-12 12:49:26 +00:00
Jan Berkel 6264527abc Remove Preferences dependency 2014-12-12 12:42:48 +00:00
Jan Berkel 9f16b9f465 Move SSL code into package 2014-12-12 12:35:17 +00:00
Jan Berkel 2536719749 Naming 2014-12-12 07:03:14 +00:00
Jan Berkel 5af649c271 Avoid cast 2014-12-12 06:54:34 +00:00
Jan Berkel 9fd722d7cd Split message code into Local/Remote
The remote network code does not need to be aware of concepts like
Accounts etc.
2014-12-12 06:47:26 +00:00
Jan Berkel 12291bceb5 Move database code into correct package 2014-12-11 23:56:02 +00:00
Jan Berkel ba4dd24bd5 Package visibility 2014-12-11 23:32:38 +00:00
Jan Berkel ca10e4d94a Use TextUtils.isEmpty 2014-12-11 21:56:26 +00:00
Danny Baumann aaf3963567 Don't throw CertificateValidationException for all SSLExceptions.
An interrupted connection attempt to the server yields an SSLException
as well, like this:

E/k9      ( 6937): Caused by: javax.net.ssl.SSLHandshakeException: Connection closed by peer
E/k9      ( 6937):      at com.android.org.conscrypt.NativeCrypto.SSL_do_handshake(Native Method)
E/k9      ( 6937):      at com.android.org.conscrypt.OpenSSLSocketImpl.startHandshake(OpenSSLSocketImpl.java:302)
E/k9      ( 6937):      at com.android.org.conscrypt.OpenSSLSocketImpl.waitForHandshake(OpenSSLSocketImpl.java:598)
E/k9      ( 6937):      at com.android.org.conscrypt.OpenSSLSocketImpl.getInputStream(OpenSSLSocketImpl.java:560)
E/k9      ( 6937):      at com.fsck.k9.mail.store.ImapStore$ImapConnection.open(ImapStore.java:2459)

We don't want the user to notify of 'certificate problems' in that case.
Fix it by checking whether the SSLException was actually triggered by a
CertificateException.
2014-12-04 13:16:33 +01:00
cketti 98b5d63909 Merge branch 'open_attachment_improvements'
Conflicts:
	src/com/fsck/k9/helper/Utility.java
2014-11-27 21:03:15 +01:00
cketti 7211080415 Merge pull request #10 from k9mail/art/more-tidying-arrays
Replace many arrays with collections
2014-11-11 19:45:35 +01:00
cketti 34cfd8e5b4 Extract file related helper functions into separate class 2014-11-11 01:04:39 +01:00
Art O Cathain 438a350f55 remove unnecessary method parameters 2014-10-19 18:40:17 +01:00
Art O Cathain 40102d560d Set interface makes more sense for flags 2014-10-05 12:40:35 +01:00
Art O Cathain 195f28db00 Revert accidental change 2014-10-05 12:23:43 +01:00
Art O Cathain 444756839c EnumSet is more efficient than HashSet 2014-10-05 12:08:55 +01:00
Art O Cathain 159017e91d removed unneeded variables and clarified names 2014-10-05 11:50:04 +01:00
Art O Cathain d38f21265d use isEmpty instead of size() == 0 for clarify 2014-10-05 10:37:50 +01:00
Art O Cathain 02c0b5f2a3 Use collections instead of arrays to enable stronger typing and reduce cruft 2014-10-05 10:37:36 +01:00
Art O Cathain 203dcfe2c3 use interfaces, not implementions 2014-10-04 12:00:48 +01:00
tobiasbaum dadf5e0865 Merge pull request #7 from artbristol/art/tidying
Art/tidying
2014-09-29 22:15:59 +02:00
Art O Cathain 010d8c9f7e always use import for UrlEncodingHelper 2014-09-29 18:06:21 +01:00
Art O Cathain 2226ae6a8e fix IDE error 2014-09-28 12:48:46 +01:00
Art O Cathain c438bc1222 remove some more catches 2014-09-28 12:09:34 +01:00
Art O Cathain afb65d5ad7 remove some try-catch cruft 2014-09-28 11:39:32 +01:00
Art O Cathain 46d083bcad fix warnings 2014-09-28 11:19:33 +01:00
Tobias Baum 2be10febf9 Added (still rather shallow) missing Javadocs for classes in BinaryAttachmentBody hierarchy 2014-09-22 21:55:08 +02:00
Tobias Baum b6079d6460 UCDetector warnings: Made things private, deleted unused methods and fields 2014-09-22 21:52:59 +02:00
Tobias Baum 7d32b3d462 Removed unnecessary overriding methods 2014-09-14 11:17:02 +02:00
Tobias Baum a9aa4645af Removed unused methods 2014-09-14 11:15:44 +02:00
Tobias Baum 5513d5a99b Pulled down getSize from Part to Message which makes ImapBodyPart superfluous 2014-09-14 11:11:48 +02:00
cketti 601e2880ac Merge remote-tracking branch 'upstream/master'
Conflicts:
	src/com/fsck/k9/mail/transport/SmtpTransport.java
2014-09-12 07:11:32 +02:00
Christian Frommeyer 9dba60c997 Some minor code cleanings and logging for LockableDatabase 2014-09-11 20:26:40 +02:00
Christian Frommeyer eced036d69 Extracting Database Setup Schema definition form LocalStore. 2014-09-11 20:26:40 +02:00
Christian Frommeyer 91ef5fa816 Extracted LocalFolder and LocalMessage definition from LocalStore 2014-09-11 20:26:40 +02:00
Christian Frommeyer 89ba2c510b More nested classes extracted from LocalStore. 2014-09-11 20:26:40 +02:00
Christian Frommeyer f92da3af59 Extracting local attachment classes from LocalStore to reduce file size. 2014-09-11 20:26:39 +02:00