1
0
mirror of https://github.com/moparisthebest/k-9 synced 2024-12-04 15:02:20 -05:00
Commit Graph

1039 Commits

Author SHA1 Message Date
cketti
3b6cccdf7a Use Reflection to call WebSettings.setBlockNetworkLoads() to prevent info leaks via external resource loading.
Fixes issue 1183
2010-02-08 03:23:41 +00:00
Daniel Applebaum
164ee7cbfd Fixes Issue 1059
Only reschedule polling and setup pushing when necessary due to
particular setting changes.  Makes the K-9 Mail UI much more
responsive to setting changes that do not affect polling and pushing.

The poll schedule is deliberately only rescheduled when the period is
decreased.  An increase in period will still allow the next scheduled
check to happen as originally scheduled.
2010-02-07 21:23:33 +00:00
Daniel Applebaum
2f8f52fb0b Fixes Issue 1112
Fixes Issue 1034

Refresh Account from Preferences, so that it'll have a fresh copy of
all information.  Failure to do this caused the AccountSettings
Activity to show stale information when invoked repeatedly from the
same prior Activity.
2010-02-07 16:05:29 +00:00
Bao-Long Nguyen-Trong
c497485b2f Better message flag management so that we don't end up with (POP3) messages having both X_DOWNLOADED_FULL and X_DOWNLOADED_PARTIAL 2010-02-07 06:05:11 +00:00
Bao-Long Nguyen-Trong
46bff831d1 Using X_DOWNLOADED_FULL flag instead of the X_DOWNLOADED_PARTIAL on to determine if we need to show the downloading icon. Some POP3 messages carry both flags. 2010-02-07 06:00:28 +00:00
Bao-Long Nguyen-Trong
131280c3f2 Still init LocalStore.mExternalAttachmentsDir even if sd card is not ready so that the object does not end up in a bad state 2010-02-07 05:58:04 +00:00
Daniel Applebaum
1fb03a45a0 Fixes Issue 1059
Provides for menu items to quickly change the mode of displayed
folders.  Also, reorganizes the menu to have an Advanced sub-menu,
like Accounts page has.

Desparately needs a new icon for the Folders menu item.
2010-02-06 23:23:22 +00:00
Daniel Applebaum
4fa4f22f2c Fixes Issue 494
Allow for setting the Outbox to have any name, as tying it to a server
side folder does not make sense.  It is never synced.
2010-02-06 22:36:22 +00:00
Bao-Long Nguyen-Trong
8403a265d9 We still need to be able to instanciate the LocalStore when the sd card is not mounted. So we do no throw an exception then. Exception will be thrown when we try to do attachment related things 2010-02-06 15:44:21 +00:00
Bao-Long Nguyen-Trong
55dac7ee4e Added option to have attachments store on sd card
(this is still a rough implementation)
2010-02-06 15:22:59 +00:00
Bao-Long Nguyen-Trong
49b223e20c Fixed issue 140 and issue 950: for partially downloaded messages, displaying what we already have while downloading the full message in the background
TODO: Need better icon indicating that the message is being fetched
2010-02-06 14:49:36 +00:00
Daniel Applebaum
6f064e1193 Partial implementation for Issue 1059. Doesn't help those without
physical keyboards, though, and should be modified to only re-setup
pushers.  Current implementation causes a wasteful reschedule of
polling.

Also gets the help Toast for the folder up-to-date after the
FolderList/MessageList split.
2010-02-06 05:55:40 +00:00
Daniel Applebaum
9ec77a9f9a Fixes Issue 1182
Never set up K9mail-errors or the Outbox for pushing
2010-02-06 05:35:15 +00:00
cketti
c64c0a1c30 Replaced base64 as default encoding for text bodies with quoted-printable. Please use issue 1176 for discussion. 2010-02-05 14:26:09 +00:00
cketti
14ee970b18 Fixed EOLConvertingOutputStream.
write('\r');flush();write('\n'); would lead to "\r\n\r\n" instead of simply "\r\n";
2010-02-05 02:36:52 +00:00
cketti
0422cae33e Implemented data stuffing. 2010-02-05 02:32:32 +00:00
cketti
45036ae5c8 Use 8bit transfer encoding for the text body if SMTP server advertises 8BITMIME. In all other cases base64 is still used (including saved copies in IMAP "Sent" folder).
Feel free to revert this if anything breaks.
2010-02-04 23:37:50 +00:00
cketti
6480e78b97 r1396 caused trouble for some clients due to a missing "MIME-Version" header. This should fix the problem. 2010-02-04 17:28:35 +00:00
Jesse Vincent
a9b538fd09 stop views from "resetting" to previous intents on rotate. 2010-02-04 02:38:30 +00:00
Jesse Vincent
5ce80cadaa Move FolderList initialization a bit earlier so as to not explode on reuse of the activity.
Fixes issue 1164
2010-02-04 01:49:56 +00:00
cketti
88854f4123 Fixes issue 1171. 2010-02-03 23:27:33 +00:00
cketti
c6d29cb10e Fixes issue 21 (All messages are turned into multipart messages) 2010-02-03 19:56:20 +00:00
cketti
8049e90b8c Changed IMAP command "UID SEARCH (HEADER MESSAGE-ID %s)" to "UID SEARCH HEADER MESSAGE-ID %s"
Fixes issue 1031.
2010-02-03 17:25:15 +00:00
Jesse Vincent
74aac85048 Use a real hostname rather than localhost.localdomain.
Fixes Issue 45

Patch by cketti
2010-02-02 02:06:35 +00:00
Jesse Vincent
a58095aae1 URLEncode username and password for accounts, so as to not fall apart on
nice simple characters like ':' in passwords.

Patch by cketti

Fixes Issue 1155.
2010-02-02 02:06:29 +00:00
Bao-Long Nguyen-Trong
5566c79e07 Fixed issue 1143: Calling finish() on Accounts activity when auto jumping to the only one existing account 2010-02-01 15:24:27 +00:00
Daniel Applebaum
ef1abffa26 Revert r1386 because it will break many folks email sending. 2010-01-31 19:11:51 +00:00
Daniel Applebaum
d114fa1bc3 Fixes Issue 1058
Add 's' hotkey for Select/deselect
2010-01-31 15:41:26 +00:00
Daniel Applebaum
a91e3e10e2 May have some beneficial impact on Issue 21 and Issue 799.
Just removes the base64 encoding on the text/plain body parts.  Does
not make the sent messages non-multipart.
2010-01-31 15:26:02 +00:00
Jesse Vincent
c38384e134 Further refactoring to MessageList and FolderList to (hopefully) address
force-closes and inconsistent data on activity reuse. Also, removing
broken/unused code to preserve activity state across invocations.
across invocations.
2010-01-30 03:26:45 +00:00
Jesse Vincent
22e1a3f574 Rather than manually managing the back button, try to give android better back button hinting
fix our notification -> intent behavior
2010-01-29 03:57:37 +00:00
Bao-Long Nguyen-Trong
e2edcd6d66 Fixed issue 1066: Better handling on mailto URI. Code adapted from AOSP. 2010-01-28 06:25:10 +00:00
Jesse Vincent
1945dc4ad4 Clean up our back button support to be actually consistent and to not leak nearly as many activities. 2010-01-28 00:29:27 +00:00
Jesse Vincent
3ffad03e9b Fix a force-quit by going to the Accounts page after creating an account 2010-01-28 00:29:18 +00:00
Jesse Vincent
cd7432b663 astyle 2010-01-28 00:29:12 +00:00
Jesse Vincent
68efec3782 Improve our "got mail" notifications to include "To:" when they're for messages we've sent 2010-01-26 02:48:22 +00:00
Jesse Vincent
c237ffc803 Tweak our message swipes to be a little harder to accidentally trigger 2010-01-25 04:28:11 +00:00
Jesse Vincent
7fb17b889e Fix a number of assumptions about accounts in MessageLists.
Fixes Issue 1079
2010-01-24 22:26:21 +00:00
Jesse Vincent
ff390b388a Bullet-proofing for database upgrades and better fallback for failures 2010-01-24 20:41:04 +00:00
Daniel Applebaum
a68168d55e Only alert once for each poll or push, even if multiple new unread
messages are found.
2010-01-23 23:44:03 +00:00
Daniel Applebaum
ac14826485 Store push state whether or not the messages arrived already deleted. 2010-01-23 17:54:11 +00:00
Daniel Applebaum
4f65b4270e Fixes Issue 1060
Don't show messages that are already deleted on the server when we
first download them.

Also, correct item 1 from my comments on r1355.  No longer notify for
mails I sent when I selected not to be notified for mails I sent.
2010-01-23 17:39:28 +00:00
Daniel Applebaum
9cd52d5ef3 Change WakeLock management logging to verbose level (now that it is
working)
2010-01-22 05:55:58 +00:00
Daniel Applebaum
4ced2fa0e1 Only cause MailService refresh when changing a setting that needs it.
Addresses part of Issue 1059.
2010-01-22 05:54:52 +00:00
Jesse Vincent
c59aeb2c78 Patch from Scott Kister to give us better new-message notifications,
somewhat worked over by me
2010-01-21 18:49:11 +00:00
Jesse Vincent
c6058686b3 Fix a crash on swipe in the message list. Thanks to cketti.
Fixes issue 1054
2010-01-20 22:10:10 +00:00
Bao-Long Nguyen-Trong
08e570d40f Fixed issue 1046 bu ending FolderList activity after auto-opening the default folder 2010-01-20 00:21:48 +00:00
Jesse Vincent
c5fa25151a unselect->deselect 2010-01-19 02:58:17 +00:00
Jesse Vincent
2c406a58b0 When disconnecting from an SMTP server, send a quit command to be a
better internet citizen. Fixes Issue 1044.
2010-01-19 02:20:24 +00:00
Jesse Vincent
a145d3c616 "Deselect all" -> "Unselect all" (at a code level)
"Deslect all" -> "Done" (at a UI level)
2010-01-19 00:51:02 +00:00
Jesse Vincent
ae029762cf Add a new preference to always show multiselect checkboxes. 2010-01-19 00:43:52 +00:00
Jesse Vincent
23af9f3e6d Guard against fling events that only have one motionevent defined 2010-01-19 00:15:21 +00:00
Jesse Vincent
4493044340 astyle pass 2010-01-18 00:11:02 +00:00
Jesse Vincent
9301aabc8c CRAM-MD5 for SMTP is now configurable 2010-01-18 00:10:49 +00:00
Jesse Vincent
22e771ef2a Disable our not-so-hot preview generation as part of database upgrade
for now. it took a long time and got mediocre results.
2010-01-17 22:54:08 +00:00
Jesse Vincent
591ca5bc5e Fix batch operations menu
* Add an explicit configuration option for stars
* Replace now-outdated "left handed" widgets config option, now that
  select widgets are always on the left.
* since the multi-modality of the message list was now only a "toggle
  stars" option, kill that, as it was lots of code and rather redundant
2010-01-17 22:49:03 +00:00
Daniel Applebaum
4aca44c1aa Hide the explicit "ring enabled" boolean behind the ringtone selection. 2010-01-17 18:14:17 +00:00
Jesse Vincent
f3275a8473 When we've entered "selection mode" actually make sure we _show_ the
selected-item check mark.
2010-01-17 05:52:22 +00:00
Jesse Vincent
591a3af6dc Eliminate "select" mode in favor of a unified swipe and context menu -based
always-available select action.  For the moment, this means
that widgets_on_left does nothing at all. based on feedback, I may kill
the preference and multi-mode behaviour entirely in favor of "show stars?"
(and possibly "show stars on left"

Stars, "checkboxes" and color bars updated to actually fit in wide mode.
2010-01-17 04:20:39 +00:00
Jesse Vincent
0de7b15aa1 Swipe to select/deselect from touchmode 2010-01-17 04:20:22 +00:00
Daniel Applebaum
64552e2ebe Fixes Issue 977 by correcting defect introduced in r1195. 2010-01-16 16:33:23 +00:00
Daniel Applebaum
f4ceb8d2bc Fixes Issue 673
Fixes Issue 806

Make sure to close opened folders in finally blocks in
MessagingController.

Don't make another connection when deleting or copying a
message.  (Nicely speeds up copy and delete, as well.)

Another connection is still created for creating a folder while
copying or deleting (a pretty rare event), and the IMAP IDLE
connections are not re-used for user initiated activity.
2010-01-16 16:22:20 +00:00
Daniel Applebaum
a89bd8e081 Only use the IDLE timeout for the folder while actually in IDLE state.
May help with Issue 1022, Issue 952, Issue 895
2010-01-16 14:14:12 +00:00
Daniel Applebaum
f3e06b4ef5 Adjust imports for new location of remote control classes 2010-01-15 05:05:41 +00:00
Daniel Applebaum
d245e81679 Reorganize remote control pieces.
Automatically build jar file for external applications.
Create convenience functions in K9RemoteControl so that external
applications do not need to know the details of handling the Intents
and broadcasts.
Send a permission string in the broadcasts so that unauthorized
applications cannot intercept communication to authorized
applications, such as K-9 Mail.
2010-01-15 05:02:27 +00:00
Daniel Applebaum
6c22507dfb Implementation of a Receiver and Service to provide for the capability
to accept control from other Android applications.  Allows for
changing both Account-level and global settings.  Account-level
settings can be applied to a single Account or to all Accounts.

The file class file derived from src/com/fsck/k9/K9RemoteControl.java
will be bundled into a JAR file for use by external applications.

This facility will be used for:
Issue 215
Issue 730
Issue 864
Issue 884
2010-01-14 04:33:50 +00:00
Jesse Vincent
d95705af4d Speed up the page-flip animation now that we load message views so much faster. 2010-01-14 01:26:09 +00:00
Jesse Vincent
64469e4b4e ran artistic style against src/com/fsck/k9/ 2010-01-14 01:07:28 +00:00
Jesse Vincent
34379dc9be Improved batch button behavior for touch view 2010-01-14 01:07:13 +00:00
Jesse Vincent
25b9f41491 Don't automatically show the batch buttons when entering multiselect mode 2010-01-14 00:33:13 +00:00
Jesse Vincent
e7807e0cf7 "Advanced" account context menu now works right 2010-01-14 00:00:38 +00:00
Jesse Vincent
9bfc01ca32 Add a preference for the new "touch friendly" view. 2010-01-13 03:37:13 +00:00
Jesse Vincent
d5c185545b Add a "done" to the batch buttons.
Make the "done" entry in batch buttons only show up in touch mode
2010-01-13 03:37:04 +00:00
Jesse Vincent
6343f3af5a If we're in touch mode and have selected items, any item click is now a select 2010-01-13 03:36:49 +00:00
Jesse Vincent
7ab9b8ee3c Added a first-pass view optimized for high-rez devices with both select and star 2010-01-13 03:36:43 +00:00
Jesse Vincent
5617b629d3 Added a "preview" column to messages containing a brief summary of the message 2010-01-13 03:36:36 +00:00
Jesse Vincent
23e46b82ce Batch-update buttons now show up when you actually have selected items. 2010-01-13 03:36:30 +00:00
Bao-Long Nguyen-Trong
1c5d240564 Made batch op button's text sensitive to which messages are selected 2010-01-12 19:39:20 +00:00
Daniel Applebaum
14587c3f30 Eliminate pointless, useless, deprecated, NOOP, incorrectly commented call. 2010-01-12 19:28:21 +00:00
Daniel Applebaum
64525028de Move execute into a re-usable location 2010-01-12 14:09:30 +00:00
Bao-Long Nguyen-Trong
11b7157772 Guess mime type (when not specified) of attachments of received messages using file name extension so that we can open them 2010-01-12 02:06:46 +00:00
Bao-Long Nguyen-Trong
f965417479 Exclude deleted messages from search results 2010-01-12 00:59:13 +00:00
Bao-Long Nguyen-Trong
230428d16a Fixed issue 1017: Added 'Search' menu option in account list screen 2010-01-12 00:56:51 +00:00
Jesse Vincent
0bdb02dc24 Minor reformatting 2010-01-09 23:49:44 +00:00
Jesse Vincent
e49fdc9913 Added a comment about why we're setting a click handler 2010-01-09 23:49:36 +00:00
Jesse Vincent
fb223ea61d rename a paremeter to better reflect its use: nextWidget->showWidget 2010-01-09 23:49:31 +00:00
Jesse Vincent
553625b72b Comment an attribute 2010-01-09 23:49:25 +00:00
Jesse Vincent
497ca01586 swap the order of compared values for a bit more logical sanity 2010-01-09 23:25:15 +00:00
Jesse Vincent
5802b84e16 Reorder methods for better logical grouping 2010-01-09 23:25:10 +00:00
Jesse Vincent
9db97e214d Restore Bao-long's original design for "widgets on the left" being a
global config option rather than a per-account one. (But with a new
implementation.) - As we now have views that show messages across
accounts, this needed to become a global)
2010-01-09 23:02:40 +00:00
Jesse Vincent
512177cded Remove more of the old messagepassing ui update code in favor of 'runonuithread' 2010-01-09 21:47:10 +00:00
Daniel Applebaum
e0b98cac21 Correct Exception text 2010-01-09 19:49:54 +00:00
Jesse Vincent
19adadae11 actually specify the size of our BufferedOutputStream as 1k to parallel
other implementations and quiet down a consistent warning in our android
logs
2010-01-08 23:47:34 +00:00
Jesse Vincent
e1c686d40d Fix NullPointerException when the user clicks on a "new mail"
notification.  Resolves Issue 1001
2010-01-08 23:18:44 +00:00
Daniel Applebaum
81fd4749cc Properly synchronize some new methods 2010-01-08 16:55:36 +00:00
Daniel Applebaum
f29f5adc4b Eliminate carriage returns from reply and forward text.
Fixes Issue 518
2010-01-08 04:27:58 +00:00
Jesse Vincent
8285766506 Now that messageview is faster, don't start displaying the new message
until _after_ we flip.
2010-01-07 01:29:59 +00:00
Daniel Applebaum
57acd3232e Don't show account-level chips until unread count is known. 2010-01-06 14:12:19 +00:00
Daniel Applebaum
9c761419c9 Preparatory code for providing move/delete/copy/setFlag capabilities
across multiple folders.
2010-01-06 05:41:19 +00:00
Daniel Applebaum
56a4b94748 Put the color chip with read/unread controlled brightness at all
levels except MessageView
2010-01-06 05:23:32 +00:00
Daniel Applebaum
a5166e3c2d Fixes Issue 963
MessagingController was calling the MessagingListener twice for
deleted messages.  By the time the second call was made, some
Activities already had removed the message holder, so a null holder
was being put on the list.

This change should prevent the double calls, and adds protection
against have the MessageList MessagingListener called with a message
that is no longer in the MessageList.

Also, some logical cleanups.
2010-01-06 04:54:24 +00:00
Daniel Applebaum
2b37fe6864 Restore long-lost debugging line 2010-01-06 03:44:23 +00:00
Daniel Applebaum
29947ef3c9 Delete obsolete commented out code. 2010-01-06 03:40:24 +00:00
Jesse Vincent
a4510696aa It turns out that blindly enabling/disabling views is _Very_ expensive.
Now we only do it when switching messageview entries if it's actually
necessary
2010-01-04 02:11:33 +00:00
Jesse Vincent
a926086f4b Replace old message passing code with more modern runonuithread code 2010-01-04 02:06:40 +00:00
Daniel Applebaum
60a2ceb604 Fixes Issue 934 by removing excess calls to finish() 2010-01-04 00:50:19 +00:00
Daniel Applebaum
d58d1c60c0 Proper super call 2010-01-04 00:48:33 +00:00
Daniel Applebaum
c86a46deb1 Preparatory for more BroadcastReceivers 2010-01-04 00:47:11 +00:00
Daniel Applebaum
33495135ac Respect account ring setting for notifications 2010-01-04 00:41:26 +00:00
Daniel Applebaum
41729af9b2 Add explicit ring setting for notifications 2010-01-04 00:40:41 +00:00
Jesse Vincent
6caec1100c Incorrect (and ancient code) would accidentally clobber the wrong attachment
(and only one, rather than all) when deleting a message.
2010-01-03 23:23:13 +00:00
Jesse Vincent
483655fa20 Log.w shouldn't be wrapped in an "if debug" statement. 2010-01-03 20:34:22 +00:00
Jesse Vincent
6a8ea924c9 Further log cleanup 2010-01-03 02:07:21 +00:00
Jesse Vincent
eb54a99aab EOLs got twisted by something. fixing 2010-01-03 02:07:14 +00:00
Jesse Vincent
0e273893bd Further log tweaking 2010-01-03 02:00:20 +00:00
Jesse Vincent
a926911e7f rerun astyle 2010-01-03 01:50:51 +00:00
Jesse Vincent
1c5073039a Further debug/info/verbose logging cleanup 2010-01-03 01:50:41 +00:00
Jesse Vincent
875dc31d5a Log message cleanup 2010-01-03 01:50:32 +00:00
Jesse Vincent
f9e8c877ff Wrap looging in if (DEBUG) statements. 2010-01-03 01:50:25 +00:00
Jesse Vincent
953b784fb9 First pass at fixing Issue 963 (explosions when trying to iterate over a
remotely deleted message) introduced in r1204.

(Before my all-day meeting)
2009-12-29 17:06:13 +00:00
Jesse Vincent
fb6d11222a Switch from old, scary message passing to more modern "run on ui thread" for Accounts.java
40 fewer lines of code.
2009-12-29 17:05:44 +00:00
Jesse Vincent
2ef3b15c87 make sure we don't accidentally open the context menu on a message when we're in multiselect mode. 2009-12-29 17:05:17 +00:00
Jesse Vincent
3e3b4d447d Fix reversed color chip alpha 2009-12-28 12:56:59 +00:00
Daniel Applebaum
60b02909a3 Announce folder status changes when syncing gets updated unread count.
Adjust logging levels for folder sync.
2009-12-27 20:19:41 +00:00
Jesse Vincent
bbd9e56770 Actually display 250/500/1000 options for "number of messages to sync" 2009-12-27 17:47:30 +00:00
Jesse Vincent
794f515bc8 Numerous small fixes to search results 2009-12-27 17:22:57 +00:00
Jesse Vincent
a53e9d1b89 on search, only fire one start event and one end event 2009-12-27 17:22:51 +00:00
Jesse Vincent
6c383256a2 Remove duplicate code from onCompose. make starting message composition without an account actually work 2009-12-27 17:22:44 +00:00
Jesse Vincent
0a2d9b9c9f make sure search results aren't updated incorrectly on incoming messages 2009-12-27 17:22:38 +00:00
Jesse Vincent
bfaba499fe Fix the Search header on search results 2009-12-27 17:22:32 +00:00
Jesse Vincent
63b6f6bf62 Refactoring to better propagate "folder" along with messages as they're instantiated 2009-12-27 17:22:26 +00:00
Jesse Vincent
d60521f06f further push down our "is this message for us" logic. 2009-12-27 17:20:56 +00:00
Jesse Vincent
6c7782b4bd remove another alternate calling convention for addOrUpdateMessage. Code
will get still cleaner when we start propagating back message folders as objects
2009-12-27 17:20:50 +00:00
Jesse Vincent
c608ffb672 Eliminate a variant of addOrUpdateMessage that was only called once 2009-12-27 17:20:28 +00:00
Jesse Vincent
1c4a0be0da enable searching of messages 2009-12-27 17:20:21 +00:00
Jesse Vincent
21238a3084 If we get a message from listLocalMessages and we're doing a search,
assume it's for us. Later, we may want to be smarter about that.
2009-12-27 17:20:13 +00:00
Jesse Vincent
a736a4267c Only trigger our "loading" indicator if the account matches "our" account 2009-12-27 17:20:06 +00:00
Jesse Vincent
204289a4ff when opening a message for display or edit, use its notion of account, not the folder's. 2009-12-27 17:19:56 +00:00
Jesse Vincent
f6756879ef Temporarily disable "left-handed" controls if we're doing a search.
view configuration needs to move to be global for this to work right.
2009-12-27 17:19:49 +00:00
Jesse Vincent
bc61c90e1a make the auto-open folder not trigger if we're doing a search 2009-12-27 17:15:46 +00:00
Jesse Vincent
81d72a2d8c make the color chip genuinely calculated per message 2009-12-27 17:15:38 +00:00
Jesse Vincent
ed19a8284e Propagate per-message account info into MessageInfoHolder and FolderInfoHolder 2009-12-27 16:54:23 +00:00
Jesse Vincent
302deea53e addOrUpdateMessage calls now propagate the account of the found message 2009-12-27 16:54:12 +00:00
Jesse Vincent
3ad69c799d When listing off messages, make sure that our "refresh the list" fires,
even if we didn't start off empty.

This could have prevented updated messages from showing up
2009-12-27 16:54:06 +00:00
Jesse Vincent
1b74c176a2 Add multi-account search to the MessagingController 2009-12-27 16:53:59 +00:00
Jesse Vincent
70f35a537e If we loaded a message from the local store without an associated folder, load up its folder. 2009-12-27 16:53:51 +00:00
Jesse Vincent
da45b81866 minor query reformatting 2009-12-27 16:53:45 +00:00
Jesse Vincent
580a562085 Lift the generic getMessages and searchForMessages up to the "store"
level from the "folder" level so we can search for messages across
folders
2009-12-27 16:53:37 +00:00
Jesse Vincent
6dcb10add6 Lift our column list for "load messages" out to the LocalStore, as the
first part of lifting "get messages" out of "folder" for search
2009-12-27 16:53:31 +00:00
Jesse Vincent
ddd6db3a7c Made our search activity actually exist 2009-12-27 16:53:24 +00:00
Jesse Vincent
09ecd2bc9a Make it possible to instantiate a localFolder by id. 2009-12-27 16:53:16 +00:00
Jesse Vincent
4cec247699 Make it possible to populate a MessageInfoHolder without a FolderInfoHolder 2009-12-27 16:53:09 +00:00
Jesse Vincent
fe67f0a40c temporarily disable new unfinished search code 2009-12-27 16:53:03 +00:00
Jesse Vincent
47b338fb94 Move message population to the message class. 2009-12-27 16:52:57 +00:00
Jesse Vincent
0005a8ea60 Remove lies from a comment 2009-12-27 16:52:50 +00:00
Jesse Vincent
54ad16edb8 Push a "is this the right folder?" check into our "add/remove messages from the message list, to better support search 2009-12-27 16:52:45 +00:00
Jesse Vincent
81a5820e5d swap the order of two methods for readability 2009-12-27 16:52:39 +00:00
Jesse Vincent
7c8a7b1f27 Remove an old comment/obsolete code 2009-12-27 16:52:33 +00:00
Jesse Vincent
2a77001acc First steps toward adding search results 2009-12-27 16:52:26 +00:00
Jesse Vincent
9a40457a2a Remove giant commented out method - that's what we have version control history for 2009-12-27 16:52:17 +00:00
Jesse Vincent
854da2664c Unify our "guard" against syncing the outbox or errors folder 2009-12-27 16:52:06 +00:00
Jesse Vincent
e2f84c4fa8 wrap a debug message in a debug-mode check; eliminate a temporary variable 2009-12-27 16:51:59 +00:00
Jesse Vincent
94e61ab62c Extract out the listener we're using when we ask for new messages.
It may eventually get further extracted.
2009-12-27 16:51:45 +00:00
Jesse Vincent
9d417133b5 reduce duplication of code 2009-12-27 16:51:38 +00:00
Jesse Vincent
c953ff2c1b Bulletproof MessageList against not having a folder loaded 2009-12-27 16:51:32 +00:00
Jesse Vincent
5c8a0a908c Remove a lie from a comment 2009-12-27 16:51:25 +00:00
Jesse Vincent
5e0bbf18aa Extract parts of title setting code into their own methods 2009-12-27 16:51:19 +00:00
Jesse Vincent
5b907c2d94 Remove an overridden subroutine that's now a noop 2009-12-27 16:51:13 +00:00
Jesse Vincent
c8bcad6a21 Refactor and reverse logic to be a bit cleaner 2009-12-27 16:51:06 +00:00
Jesse Vincent
721e298542 Invert some logic to clean up MessageList a bit 2009-12-27 16:51:00 +00:00
Jesse Vincent
56cdfa88c9 tiny grammar fix 2009-12-27 16:50:44 +00:00
Jesse Vincent
151ae5a2a3 First pass at adding "Searchable" infrastructure 2009-12-27 16:50:37 +00:00
Jesse Vincent
9ba102599f Fix SQL statmeent 2009-12-27 16:50:28 +00:00
Jesse Vincent
9bcc991ec8 Extract out the code to "load mesages from SQL" from inside our "load messages in this folder" code 2009-12-27 16:50:21 +00:00
Jesse Vincent
9796cb6487 First rouind of extracting the "load messages from the db" column list 2009-12-27 16:50:14 +00:00
Daniel Applebaum
1ea96796d6 Add a global preference for enabling animations, beyond those that are
necessary.  Defaults to "enabled."
2009-12-27 00:54:19 +00:00
Daniel Applebaum
ea65007b99 Disable inter-message animations, except when initiated by a swipe.
Fixes Issue 926.
2009-12-26 18:31:55 +00:00
Daniel Applebaum
070fd635d4 Allow user to set a limit on the number of folders to be handled with
push technology.  This provide a layer of safety in case of
misconfiguration (accidentally setting too many folders to push using
classes), which can bog down the device till it is unusable.  On a G1,
25 folders is a very large load.  Fixes Issue 871.

Also, move some pending commands to the background to make way for
more important user interface activity.
2009-12-24 18:08:23 +00:00
Jesse Vincent
8fca99bef4 Fixes to unbreak incoming account setup after CRAM_MD5 implementation 2009-12-21 17:49:16 +00:00
Daniel Applebaum
4859ff7e8f Add wakelocks for calling between MailService and Push/PollServices.
I don't know if these are truly necessary, but they should not be
harmful and might be a big reliability boost.
2009-12-21 01:48:15 +00:00
Daniel Applebaum
41d7ca51a3 Implementation of complete IMAP two-phase "delete/expunge" behavior.
On each IMAP account, the expunge behavior can be set to expunge
messages in a folder as soon as a move or delete is performed on the
folder ("immediately"), each time the folder is polled, or only when
executed manually.

In the Message List, there is now an Expunge action in the option
menu.

In the Folder List, there is now an Expunge action in the context
menu (long-press on the folder).

For IMAP accounts, it is also possible to disable the copying of deleted messages to the
Trash folder, by setting the Trash folder to -NONE-.

Fixes Issue 536.

Separately, in WebDAV accounts, the user can now choose the
server-side equivalents of the special folders, just like for IMAP.
2009-12-20 23:13:49 +00:00
Jesse Vincent
e82bb72a97 non-downloaded messages once again have a grey background.
Fixes Issue 899
2009-12-20 06:54:30 +00:00
Jesse Vincent
7e967c6110 removed now-unused subject coloring code 2009-12-20 06:54:23 +00:00
Jesse Vincent
b8b9e20e81 Hang onto our messaging controller rather than constantly reacquiring
it.
2009-12-20 06:14:10 +00:00
Jesse Vincent
2c9fc8b997 Backwards compatibility for the CRAM-MD5 implementation 2009-12-20 06:14:04 +00:00
Jesse Vincent
3914a78b53 xargs astyle --style=ansi --mode=java --indent-switches \
--indent=spaces=4 --convert-tabs --unpad=paren
2009-12-20 05:41:43 +00:00
Jesse Vincent
5a85446779 Initial implementation of CRAM-MD5 support for IMAP and SMTP.
Patch contributed by Russ Weeks <rweeks@gmail.com> in
<605ac1c0-808a-4f67-8c4d-736eec9587f8@e27g2000yqd.googlegroups.com>
2009-12-20 05:15:20 +00:00
Daniel Applebaum
921b022fb5 Enhanced header in Accounts, MessageList and Folder to show the unread
count, scoped for the Activity, the in-progress operation, the account
on which the operation is in progress, the folder for the operation,
when appropriate, and the progress of the operation, when it applies
to multiple items.  For the MessageList, also use the determinate
progress bar to show progress for synchronization of the folder being
displayed.

Fixes Issue 924.

Also, a minor change that might help with Issue 913, by putting the
insertion of the pending command into a background thread.
2009-12-20 00:02:46 +00:00
Jesse Vincent
4f42907315 preferences doesn't actually tie to an account. it shouldn't be in the account context menu 2009-12-18 03:49:52 +00:00
Jesse Vincent
462d4098e0 Removed debugging log messages that clutter and slow the runtime app 2009-12-18 03:49:19 +00:00
Jesse Vincent
91ad70cd5d Killed a bunch of debug logging that clutters (and slows) production apps 2009-12-18 03:48:24 +00:00
Jesse Vincent
83409d78fa remove a bunch of debug logging that was cluttering production logs 2009-12-18 03:46:46 +00:00
Jesse Vincent
3f841d1494 removing debugging messages 2009-12-18 03:46:05 +00:00
Jesse Vincent
f94823cba4 Enable the new synchronous messagelist population. Perhaps
counter-intuitive, but it's a whole lot faster
2009-12-18 02:39:41 +00:00
Jesse Vincent
25306fad83 unify the synchronous and asynchronous codepaths for listlocalmessages 2009-12-18 02:36:37 +00:00
Jesse Vincent
157455f26b As part of a refactoring move the "start" callback into the subthread. 2009-12-18 02:35:46 +00:00
Jesse Vincent
dc543fa9e3 now that we have more messages coming out of the database faster,
there's less use in special-casing the first 5
2009-12-18 02:34:50 +00:00
Jesse Vincent
c3e903942d we no longer need to check the deleted flag at this layer as we do it further in. 2009-12-18 02:34:13 +00:00
Jesse Vincent
5789b385a8 first pass at working around messaging controller perf insanity
port listLocalMessagesSynchronous back into the MessagingController

revert some stuff
2009-12-18 02:33:18 +00:00
Jesse Vincent
48e1f31b43 Revert commit 829 @gcode - it was a performance optimization which added
nontrivial code complexity for what's now a nil performance gain
2009-12-18 02:32:17 +00:00
Jesse Vincent
c8bd377e76 minor refactoring to cut down on repeated method calls 2009-12-17 05:24:48 +00:00
Jesse Vincent
ce44165634 Fix our auto-expand folder behavior - Fixes issue 918 2009-12-17 03:45:37 +00:00
Jesse Vincent
9ae7934cad improve the MessageList->FolderList flow. Should fix Issue 916 2009-12-16 05:26:43 +00:00
Jesse Vincent
85b4c43e10 Revert "Initial implementation of loading only 25 rows from the message list"
This reverts commit 7056cb918e3bc71465053bff4070b8d3b28761a7.
2009-12-16 05:26:21 +00:00
Bao-Long Nguyen-Trong
18ea30d00f More fix for issue 810: Delete intents are not also broadcasted when we delete a message because it was deleted on the server 2009-12-15 19:43:46 +00:00
Jesse Vincent
dc2f752f11 Bulletproofing against running IMAP Copy/Move commands with null messagelists. Fixes Issue 914 2009-12-15 17:40:04 +00:00
Jesse Vincent
bf4e37d3b5 Revert "An attempt to make message lists start displaying messages earlier by precomputing a list item."
Sadly, it caused explosions
This reverts commit 5b321f4d0893ad5538d229b1c84f6806d0d8cbfe.
2009-12-15 04:26:53 +00:00
Jesse Vincent
34c111eb47 Kill the no-op Welcome activity to improve startup performance 2009-12-15 04:06:32 +00:00
Jesse Vincent
a1302afe75 Initial implementation of loading only 25 rows from the message list
from SQLite at once. The hope is that this will improve perceived
performance on large folders by starting message display sooner.

In the case of a background sync while we're loading, we _may_ end up
doing more work than necessary, since we implement paging by "date
received"
2009-12-15 02:52:01 +00:00
Jesse Vincent
aa4f3535eb When we load up the "Accounts" activity as K-9 starts up, jump straight
to either the FolderList or the MessageList rather than always going
through the FolderList
2009-12-15 02:51:52 +00:00
Jesse Vincent
5d34ef2f19 An attempt to make message lists start displaying messages earlier by precomputing a list item. 2009-12-15 02:51:44 +00:00
Jesse Vincent
e82bbc25ab formatting from astyle 2009-12-15 02:51:34 +00:00
Jesse Vincent
647dc827d8 Replace MessageList's outdated message-passing mechanism with runOnUiThread for improved code clarity and performance. 2009-12-15 02:51:25 +00:00
Jesse Vincent
7b811e45a1 lazify loading of message headers in LocalFolder, since they're not needed in most of our use cases. 2009-12-15 02:51:18 +00:00
Jesse Vincent
f31b2702a4 Massive rename to K9, step 1.
Conflicts:

	src/com/android/email/Email.java
2009-12-15 02:50:53 +00:00
Bao-Long Nguyen-Trong
1cd67f8e16 Fixed issue 810: Implemented delete intent broadcast using a modified patch from stephane.lajeunesse 2009-12-15 00:03:22 +00:00
Daniel Applebaum
0cd2dfb77d Implements new "Batch ops" option menu in Message List. Provides for
flag/unflag, mark as read/unread and delete.  Also provides explicit
mode changing, and select/deselect all.  Move and copy are partially
implemented, but disabled.

Desperately needs a new icon.

The "Sort by..." menu now toggles ascending/descending when the
currently selected sort mode is clicked.

Also, an ineffective change to setting the title in the Message List.
A bit more work is in order on that.
2009-12-10 05:26:16 +00:00
Jesse Vincent
5b1c5b2289 Basic code style cleanups suggested by IntelliJ 2009-12-10 03:16:51 +00:00
Jesse Vincent
54c7d93f78 Let IntelliJ optimize our import statements 2009-12-10 03:16:42 +00:00
Jesse Vincent
cd7de68186 reimplement the "list widgets on the left?" preference I'd previously complained about as an account preference 2009-12-08 07:08:05 +00:00
Jesse Vincent
6fdf69d45b Revert "Fixed issue 858: Added option to choose which side the widgets in message list will be on"
This reverts commit b334e397431225280f30e5297f73392f331f2dc3.
2009-12-08 07:07:03 +00:00
Jesse Vincent
dc61614443 Switch to UUIDs for message-id generation. They're just as unique and lighter weight to calculate 2009-12-08 04:58:33 +00:00
Jesse Vincent
95159d8121 Defer creation of a MessageId until we actually need it. This was ~75% of our message load-from-db time 2009-12-08 04:58:10 +00:00
Bao-Long Nguyen-Trong
4117175b0f Fixed issue 858: Added option to choose which side the widgets in message list will be on 2009-12-08 01:32:59 +00:00
Jesse Vincent
3ffc447302 LocalMessage doesn't bother to populate the headers of the MimeMessage backing it until writeTo is called 2009-12-07 04:46:42 +00:00
Jesse Vincent
08588779f7 Added a setMessageId method to MimeMessage rather than just explicitly setting a header 2009-12-07 04:46:36 +00:00
Jesse Vincent
244bad1115 Cleaned up style drift using astyle 1.23
find  src/com/android/email/ -name \*.java|xargs astyle --style=ansi --mode=java  --indent-switches --indent=spaces=4 --convert-tabs --unpad=paren
2009-12-07 00:56:06 +00:00
Jesse Vincent
88e6c59e7e Get K-9 building on Java 1.5 again 2009-12-06 22:41:19 +00:00
Daniel Applebaum
b47ee0b492 Fixes Issue 860
By reinstating obsolete methods that should eventually be removed.
2009-12-05 14:17:32 +00:00
Daniel Applebaum
fe01446af6 Fixes Issue 856 2009-12-05 13:47:28 +00:00
Daniel Applebaum
514b4cf121 Fixes Issue 844
Definitely, some optimizations could be made

Also, reliably display the folder name at the top of the MessageList
Activity
2009-12-04 19:13:29 +00:00
Daniel Applebaum
2c7853c539 Fixes Issue 870 2009-12-04 04:22:07 +00:00
Daniel Applebaum
8a79690c42 Fixes Issue 850
Don't try to move, copy, or delete a K9mail-errors message on the
server-side.
2009-12-02 04:09:51 +00:00
Jesse Vincent
bb3d6f352b Updated regexes for text->html
Tested to not break unix logfiles ;)

Comment #7 on issue 819 by jessev: Hide empty CC: lines in Message View
http://code.google.com/p/k9mail/issues/detail?id=819

My intent is to default to showing Subject. Date and From or To (depending   on whether you're the sender) with a button/widget/hyperlink/something to fold down   and show more detail.

--
You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

Dec  1 19:15:48 mar-adentro kernel: [ 4291.016228] usb 1-6: reset high speed USB device using ehci_hcd and address 4
Dec  1 19:15:48 mar-adentro kernel: [ 4291.308225] usb 2-5: reset high speed USB device using ehci_hcd and address 2
Dec  1 19:15:48 mar-adentro kernel: [ 4291.552221] usb 3-1: reset full speed USB device using uhci_hcd and address 2
Dec  1 19:15:48 mar-adentro kernel: [ 4292.136224] usb 5-1: reset full speed USB device using uhci_hcd and address 2
Dec  1 19:15:48 mar-adentro kernel: [ 4292.425282] usb 3-1.1: reset full speed USB device using uhci_hcd and address 3
Dec  1 19:15:48 mar-adentro kernel: [ 4292.613282] usb 3-1.2: reset full speed USB device using uhci_hcd and address 4
Dec  1 19:15:48 mar-adentro kernel: [ 4292.780373] Restarting tasks ... done.
Dec  1 19:15:48 mar-adentro kernel: [ 4292.784292] usb 3-1.3: USB disconnect, address 7
Dec  1 19:15:49 mar-adentro kernel: [ 4293.230042] ADDRCONF(NETDEV_UP): eth0: link is not ready
Dec  1 19:15:49 mar-adentro kernel: [ 4293.987736] usb 3-1.3: new full speed USB device using uhci_hcd and address 8
Dec  1 19:15:50 mar-adentro kernel: [ 4294.141687] usb 3-1.3: configuration #1 chosen from 1 choice
Dec  1 19:15:54 mar-adentro pulseaudio[1548]: ratelimit.c: 82 events suppressed
Dec  1 19:16:06 mar-adentro kernel: [ 4310.825436] Registered led device: iwl-phy0::radio
Dec  1 19:16:06 mar-adentro kernel: [ 4310.825459] Registered led device: iwl-phy0::assoc
Dec  1 19:16:06 mar-adentro kernel: [ 4310.825479] Registered led device: iwl-phy0::RX
Dec  1 19:16:06 mar-adentro kernel: [ 4310.825500] Registered led device: iwl-phy0::TX
Dec  1 19:16:06 mar-adentro kernel: [ 4310.879827] ADDRCONF(NETDEV_UP): wlan0: link is not ready
Dec  1 19:16:20 mar-adentro kernel: [ 4324.261675] ADDRCONF(NETDEV_CHANGE): wlan0: link becomes ready
Dec  1 19:16:22 mar-adentro kernel: [ 4326.254795] padlock: VIA PadLock not detected.
Dec  1 19:44:22 mar-adentro kernel: [ 6006.712166] usb 2-4: new high speed USB device using ehci_hcd and address 5
Dec  1 19:44:22 mar-adentro kernel: [ 6006.865987] usb 2-4: configuration #1 chosen from 1 choice
Dec  1 19:44:22 mar-adentro kernel: [ 6006.869856] scsi7 : SCSI emulation for USB Mass Storage devices
Dec  1 19:44:27 mar-adentro kernel: [ 6011.871419] scsi 7:0:0:0: Direct-Access     HTC      Android Phone    0100 PQ: 0 ANSI: 2
Dec  1 19:44:27 mar-adentro kernel: [ 6011.873138] sd 7:0:0:0: Attached scsi generic sg2 type 0
Dec  1 19:44:27 mar-adentro kernel: [ 6011.906600] sd 7:0:0:0: [sdb] Attached SCSI removable disk
Dec  1 19:44:34 mar-adentro kernel: [ 6018.102244] sd 7:0:0:0: [sdb] 3862528 512-byte logical blocks: (1.97 GB/1.84 GiB)
Dec  1 19:44:34 mar-adentro kernel: [ 6018.110282]  sdb: sdb1
Dec  1 20:00:57 mar-adentro pulseaudio[1548]: ratelimit.c: 1 events suppressed
Dec  1 20:28:13 mar-adentro pulseaudio[1548]: ratelimit.c: 2 events suppressed
2009-12-02 03:16:31 +00:00
Jesse Vincent
bd09b880e9 Cache the message subject in a localMessage, rather than roundtripping through a MIME message 2009-12-01 13:45:28 +00:00
Bao-Long Nguyen-Trong
e354ba17b6 Added unset functionality to batch 'Read' and 'Flag' buttons. We are giving priority to setting the flags. So unsetting only happens if all selected messages do not have the flag set. 2009-12-01 00:50:19 +00:00
Daniel Applebaum
1593678cfe Fixes Issue 847 2009-11-30 23:37:46 +00:00
Jesse Vincent
c796897f36 Fix focus of flag/read toggles in bulk-update mode 2009-11-30 23:23:27 +00:00
Daniel Applebaum
87673c91a5 Implement Bao-Long's suggestion to modify
LocalStore.purgeToVisibleLimit only to work on undeleted messages.

Convert LocalStore.clear() to use the new DELETED column.

Make markAllAsRead only work on undeleted messages.
2009-11-30 04:57:29 +00:00
Jesse Vincent
b54dab0c7f remembering next/prev will work better if they don't use the same constant 2009-11-30 04:14:24 +00:00
Jesse Vincent
9552114075 actually set the deleted flag when purging a message. should help perf a bit 2009-11-30 04:03:16 +00:00
Jesse Vincent
2c1dad5554 when we go into a folder for the first time, jump to the first message being displayed rather than the widget at the end of the list 2009-11-30 04:03:08 +00:00
Jesse Vincent
da8ad69366 deleting messages in messageView now preserves the direction the user was "travelling" in before the delete 2009-11-30 04:03:00 +00:00
Jesse Vincent
4f5c9c8b3c Now that our not-deleted-messages mode works, actually use it in messagelists 2009-11-30 04:02:51 +00:00
Jesse Vincent
299cd9a07c add "deleted" to our default database indexes. (wants some query analysis at the SQLite level) 2009-11-30 04:02:43 +00:00
Jesse Vincent
ed4685e82d we need to generate valid sql in the not-yet-used "not deleted" mode. Thanks to danapple0++ 2009-11-30 04:02:34 +00:00
Daniel Applebaum
3126298b46 Bulk delete for WebDAV 2009-11-29 18:33:42 +00:00
Daniel Applebaum
1b3d0eb992 The closest thing to bulk delete for POP3. Stupid POP3 has no
multiple delete command, but at least we can index UIDs in one shot.
2009-11-29 18:18:52 +00:00
Daniel Applebaum
c7e7b9beda Bulk deletion for IMAP and stub for other Stores. 2009-11-29 18:07:34 +00:00
Daniel Applebaum
f1abdbb769 Bulk flagging (read/unread, flag/unflag) implemented.
Message List batch ops wired to bulk flagging.

Manage batch button state when messages are deleted (from outside
agents) while in batch mode.

Remove throws clause from Folder.close() to make it easier to close
folders where necessary.

Eliminate some cruft from MessageList

Consolidate unreadMessageCount fetching in notifyAccount
2009-11-29 16:55:35 +00:00
Daniel Applebaum
61319d8c21 Fixes Issue 835 2009-11-29 06:25:03 +00:00
Daniel Applebaum
d871d2d2ee Fixes Issue 827
Fixes Issue 734

On reconnection, IMAP IDLE folders will now fetch up to the most
recent 10 message that arrived while a IDLE connection was not
available.

Fixes Issue 232

A serving of NAMESPACE-based auto-configuration on the side.  If the
IMAP prefix is empty, and the IMAP server supports NAMESPACE, use the
IMAP prefix supplied by NAMESPACE.  Also, if the user manually puts
the separator as the last character in the prefix, don't append the
separator.

Also:
Improved reliability of IMAP IDLE incoming message and flag state
change handling.  Reduction (but not elimination) of multiple
connections under startup conditions.
2009-11-28 14:51:44 +00:00
Jesse Vincent
900bcb434c Now that we have multiselect mode, kill the "quick delete" mode. 2009-11-28 05:09:28 +00:00
Jesse Vincent
96958569b0 huge improvements to render quality of plaintext messages. 2009-11-28 04:56:58 +00:00
Jesse Vincent
46ddc7d8e5 text->html now does a better job converting
---------------------------------------------------------
2009-11-28 04:56:47 +00:00
Jesse Vincent
cdf0693e27 remove unused constants 2009-11-28 01:59:52 +00:00
Jesse Vincent
8216640fe8 if chain -> switch 2009-11-27 23:45:30 +00:00
Jesse Vincent
7707270b31 Remove 100loc of custom date formatting code which worked around a deficiency in the android 1.0 API 2009-11-27 21:52:48 +00:00
Jesse Vincent
5727cb3c3b remove a temp variable 2009-11-27 21:52:36 +00:00
Jesse Vincent
e2fd488e66 Fix multiselect so that one can use touch or the dpad or scroll ball to select
TODO: a preference to disable this behavior for folks who don't think like me
2009-11-27 03:28:26 +00:00
Jesse Vincent
ae33aab57a only making the buttons active on the first click leads to weird race
conditions.
2009-11-27 03:28:16 +00:00
Jesse Vincent
769985dd48 cleaned up enable/disable activate/deactivate of multi-select action widgets. 2009-11-26 19:51:54 +00:00
Jesse Vincent
ab706b6b31 abstract out the batch-button visibility settings 2009-11-26 17:43:51 +00:00
Bao-Long Nguyen-Trong
3525337075 1st wired up version of multi-select + delete button (still rough on the edges) 2009-11-26 15:47:58 +00:00
Daniel Applebaum
69e7243480 Naive, untested, bulk operations for the new multi-select
user-interface work.

Performance optimizations to be done later.
2009-11-26 05:30:13 +00:00
Daniel Applebaum
fc91603429 Major IMAP IDLE rework:
1) Actual message sync on MessagingController uses same connection as
   IDLE for faster and more efficient push operation.  Uses fewer
   connections to the server.

2) More aggressive handling of untagged responses should more reliably
   get flag changes and new messages when many events happen at once.

3) Simplification of new mail notification

4) Push mail now respects the folder visible limit

5) When multiple untagged FETCH responses arrive en bloc, the actual
   message flags and UIDs are fetched with a single request
2009-11-26 05:10:12 +00:00
Jesse Vincent
e4427f4f17 Added a "show no widgets" entry into the widgets rotation.
Eventually, we should have a preference per account for whether listview
starts in no-widgets or flag mode.
2009-11-25 16:21:01 +00:00
Jesse Vincent
0f85f22495 remove a useless focus handler 2009-11-25 15:41:40 +00:00
Jesse Vincent
ae26b0eb0c better dpad left/right to cycle widgets 2009-11-25 15:35:25 +00:00
Jesse Vincent
0e821f575a first pass at toggling all widgets at once 2009-11-25 02:52:33 +00:00
Jesse Vincent
622155a57a make the Delete, Select and Star buttons share the same screenspace.
right now we toggle per row. next up is toggle all at once
2009-11-25 02:25:56 +00:00
Jesse Vincent
695aa42347 added code for inline delete buttons 2009-11-25 02:25:44 +00:00
Jesse Vincent
9cac2cd5b7 applied compromise code reformatting:
find  src/com/android/email/ -name \*java|xargs astyle --style=ansi \
    --mode=java  --indent-switches --indent=spaces=4 --convert-tabs \
    --unpad=paren
2009-11-25 00:40:29 +00:00
Bao-Long Nguyen-Trong
e3727e1d91 Very early shot at batch message action UI 2009-11-24 18:05:53 +00:00
Daniel Applebaum
9971b9e8c5 Fix notifications for messages that arrive via IDLE 2009-11-23 03:17:03 +00:00
Daniel Applebaum
694ba471d4 Eliminate race condition which causes multiple connections to IDLE
simultaneously
2009-11-23 03:16:44 +00:00
Jesse Vincent
ee463b32ff Overhaul our setup wizard to have a more reasonable bottom bar and to reuse that layout code where possible; standardize the id of the 'next' button 2009-11-23 00:23:34 +00:00
Jesse Vincent
8e0655d915 add double-tap at top or bottom to jump to the top or bottom of the message 2009-11-22 21:23:49 +00:00
Jesse Vincent
30459125aa Add a message-flip animation. Long-term, we want a ViewSwitcher instead 2009-11-22 21:23:36 +00:00
Jesse Vincent
027e213bb2 With this change, K-9 does a better job of loading embedded images by default for me. 2009-11-22 21:23:27 +00:00
Jesse Vincent
47cbf87e6d Disable built-in zoom controls for now. they make flipping way too hard. 2009-11-22 21:23:09 +00:00
Jesse Vincent
7a46a584c6 When flipping messages, be sure we jump to the top as we display 2009-11-22 21:23:00 +00:00
Daniel Applebaum
3f98e3204b Fixes Issue 784 2009-11-22 19:42:44 +00:00
Daniel Applebaum
0f24c6a28b Fix defect in r996
Prepare for disabling notification on messages the account identities sent.
2009-11-22 19:02:57 +00:00
Daniel Applebaum
5977809fe0 Fixes Issue 657
The Nays have it.
2009-11-22 17:34:29 +00:00
Daniel Applebaum
c732f14c3d Fixes Issue 801 2009-11-22 17:15:11 +00:00
Daniel Applebaum
2e50cc5444 Log when attachment viewer cannot be found 2009-11-22 17:13:06 +00:00
Daniel Applebaum
b551850827 Fixes Issue 188
Fixes Issue 394
Fixes Issue 763

Completely new Services architecture providing proper Service
lifecycle management.
  Long running tasks in MailService are executed in a separate thread,
  but the service is not stopped until the tasks are complete.

  SleepService for providing synchronous sleeps with proper WakeLock
  integration.

  Mail polling logic moved from MailService to PollService

  PushService to keep application from being killed while push is
  running.

Improved logging of IMAP protocol, including logging folder name,
thread and connection hashcode.

Don't put a failed connection back into the IMAP mConnections
storage. 

IMAP IDLE uses new SleepService for delaying between failed connection
attempts (allows phone to sleep and provides better reliability)

Use a ThreadLocal for ImapPusher wakelocks

Component enablement/disablement in Email is done only when components
are out of phase with desired state. (Issue 188)
2009-11-22 17:01:04 +00:00
Jesse Vincent
c6b15012e0 tidied activity code: astyle --style=java -s4 --brackets=attach --convert-tabs 2009-11-21 22:45:39 +00:00
Jesse Vincent
094215ebe0 Reindent MessageView.java in advance of refactoring 2009-11-21 22:45:14 +00:00
Bao-Long Nguyen-Trong
04717b817a Fixed error handling code when trying to view a message that does not exists
This code was lost during the merge of issue4-1.x branch
2009-11-21 00:11:57 +00:00
Jesse Vincent
8a6180fa21 Swap swipes based on people with real devices pointing out that I got em backwards. 2009-11-19 15:26:45 +00:00
Daniel Applebaum
a7a46ac6fa Fixes Issue 673 2009-11-19 15:19:23 +00:00
Jesse Vincent
031c1e5358 left and right swipes in message view. 2009-11-19 06:03:59 +00:00
Bao-Long Nguyen-Trong
59bc0ac467 Merge from 2.0-MAINT branch 2009-11-19 00:42:27 +00:00
Jesse Vincent
1e57188f38 First pass at stopping the "Sending messages" notification when there's nothing to send
A better fix would take into account not sending flagged messages
2009-11-18 03:06:23 +00:00
Jesse Vincent
582682b99d make docs lie a little less 2009-11-18 03:06:14 +00:00
Jesse Vincent
b91aad8f59 FolderUids -> MessageUids (working to remove assumptions about folders) 2009-11-18 03:06:05 +00:00
Jesse Vincent
c392e778e6 Add "starring" to MessageView 2009-11-18 01:59:41 +00:00
Jesse Vincent
fcd8ee9aeb Implement References/In-Reply-To/X-User-Agen. Fixes issue 42. Patch from e.w.stemle 2009-11-17 21:13:29 +00:00
Jesse Vincent
35ab566f43 Cleanup of the LocalFolder perf optimization from last night. 2009-11-17 19:25:46 +00:00
Jesse Vincent
c6b5a626bd Merge branch 'skip-deleted-in-sqlite'
* skip-deleted-in-sqlite:
  Create branch skip-deleted-in-sqlite
  First pass at doing our "don't show deleted messages in lists" filtering in SQL
2009-11-17 16:54:50 +00:00
Jesse Vincent
b328cbe991 A first implementation of "starred" messages in portrait list views 2009-11-17 16:52:23 +00:00
Jesse Vincent
3bc8a0a8d4 Make item-clicks in MessageList a little less convoluted 2009-11-17 16:52:10 +00:00
Bao-Long Nguyen-Trong
3f4c4a97cf Added file missed in r948 2009-11-17 00:04:10 +00:00
Bao-Long Nguyen-Trong
1a64826e32 Fixed issue 44
. Added content-type detection using file name extension
. This adds better integration with OI File Manager which implements the ACTION_GET_CONTENT intent
2009-11-16 20:51:34 +00:00
Bao-Long Nguyen-Trong
aa18be9c96 Fixed issue 762
+ more draft handling fixes
2009-11-16 20:47:27 +00:00
Jesse Vincent
4cc22f8208 Remove duplicated "make this account the default" option during setup 2009-11-16 19:33:23 +00:00
Jesse Vincent
84ab290046 Give the user the choice of whether to enable Push as they create a new IMAP account.
TODO: explanatory prose underneath
2009-11-16 19:33:01 +00:00
Jesse Vincent
849a1de91e rephrase the status message to put Push back to first with the space I so desperately craved 2009-11-16 19:32:39 +00:00
Bao-Long Nguyen-Trong
8557cefabc Fixed issue 761 2009-11-16 19:27:57 +00:00
Jesse Vincent
ae4af71379 remove dead code that someone commented out rather than delete. 2009-11-16 18:35:16 +00:00
Jesse Vincent
1c5289f412 Make the status messages for folders that are being synced with push a bit prettier 2009-11-16 18:34:46 +00:00
Jesse Vincent
b9509e73f2 Fix Issue 774 - Don't show folder choosers before we have a working account 2009-11-16 18:23:56 +00:00
Jesse Vincent
21481af667 Slightly better MessageView fit-to-screen and scrollbar flow 2009-11-16 16:42:15 +00:00
Daniel Applebaum
f14ecdd66e Fixes Issue 574 2009-11-15 15:19:39 +00:00
Jesse Vincent
6596fb901d First pass attempt at fixing the "Android 2.0 breaks contacts lookup" issue 2009-11-15 05:59:16 +00:00
Daniel Applebaum
eec4a96617 Fixes Issue 587
"Delete from server" is now the default delete policy for IMAP and
WebDAV accounts.  POP3 accounts still default to "Do not delete from
server"
2009-11-15 01:21:19 +00:00
Daniel Applebaum
730352c08c Fixes Issue 752 2009-11-15 01:12:26 +00:00
Daniel Applebaum
133964fbf3 Fixes Issue 59 (provides 2 - 24 poll check periods)
Improves Issue 742 (makes push settings more obvious)
2009-11-14 15:07:12 +00:00
Daniel Applebaum
84a1e0647d Fixes Issue 742 2009-11-14 14:25:09 +00:00
Daniel Applebaum
4a2c94938a Record permanent failures into K9mail-errors 2009-11-13 13:52:09 +00:00
Bao-Long Nguyen-Trong
27caf93e11 Fixed issue 589 2009-11-13 08:14:10 +00:00
Bao-Long Nguyen-Trong
ff2be7e643 Fixed issue 753 2009-11-13 07:36:05 +00:00
Jesse Vincent
df16bb2766 Add the German version of "re:" to our reply regex 2009-11-13 04:03:36 +00:00
Jesse Vincent
719f7dcd2d Enable fast scroll from "pick a folder" dialogs 2009-11-13 03:20:40 +00:00
Jesse Vincent
6daeb6b749 Sort the "NONE" folder to the top of the auto-expand folder list 2009-11-13 03:20:31 +00:00
Jesse Vincent
393519d352 Now that we are 1.5+, untodo the 1.5 style quick-sliders in message and list views 2009-11-13 00:55:52 +00:00
Daniel Applebaum
eb7fd69ed6 Fixes Issue 747. 2009-11-11 00:45:19 +00:00
Bao-Long Nguyen-Trong
cf143cda86 Fixed issue with reply icon in subject in message view screen not being set properly when navigating around using up and down arrows 2009-11-09 06:02:46 +00:00
Bao-Long Nguyen-Trong
5f96961cd6 Fixed bug where intent is broadcasted for non new emails 2009-11-09 03:52:59 +00:00
Daniel Applebaum
22bfa74ddf Fixes Issue 733 2009-11-07 20:27:30 +00:00
Daniel Applebaum
0baf9d6134 Fixes Issue 722 2009-11-07 20:16:15 +00:00
Daniel Applebaum
90198382a4 Increase chance of Push mail picking up messages when connectivity is
restored.
2009-11-07 16:51:08 +00:00
Daniel Applebaum
b9642ee5f3 Fixes Issue 738
Fixes Issue 133

Really, just displays a Toast and allows K-9 to continue in some
situations that otherwise cause a crash.  Will hopefully allow users
of Android 2.0 to use K-9, but may just provide better info about what
is going wrong.
2009-11-07 16:21:47 +00:00
Daniel Applebaum
2f4b9a1178 Issue 737
Don't crash if unable to find the owner name.  The actual owner name
fetching code will need to be updated for Android 2.0, but this will
help for now.
2009-11-07 15:32:05 +00:00
Daniel Applebaum
1983a7e2a7 Correct unread message counts for stores (like Pop3Store) which are
unable to provide a server-side tracked unread message count.
2009-11-03 03:21:42 +00:00
Daniel Applebaum
eabc9af9b3 Fixes Issue 668
Fixes Issue 577

K-9 has earned its Canine Good Citizen.

K-9 now respects the Android-global Background data preference, by
default.  However, there is an override, allowing K-9 to ignore the
global preference, by either always running around and synchronizing
in the background, or staying put and not synchronizing.

A user can now elect to turn off mail synchronization across all
accounts in either the K-9 Preferences page by setting Background
synchronization to Never, or leaving that value as "When 'Background
data' is checked" and deselecting the Android-global Background data
preference.
2009-10-31 18:51:59 +00:00
Daniel Applebaum
581486fbd5 Eliminate secret debug preferences activity. Add debug preferences to
global preferences.
2009-10-31 17:10:54 +00:00
Daniel Applebaum
8951363442 Fixes Issue 448
Fixes Issue 651
2009-10-28 12:45:22 +00:00
Daniel Applebaum
25e36da75d Fixes Issue 712. 2009-10-25 23:56:25 +00:00
Daniel Applebaum
ffe930442f Fixes Issue 573
Patch from mpredosin, supplied in Issue 573 on Aug 05, 2009.
2009-10-25 13:58:08 +00:00
Daniel Applebaum
f43b13446e Comment out intended comment. 2009-10-25 13:47:59 +00:00
Daniel Applebaum
75868b5aa4 Enhancements to WebDAV (Exchange) capabilities:
1) Automatically add / separators if not supplied by user.  Fixes
   Issue 290

2) Enable Move and Copy.

3) Enable setting a message to unread state.

4) Set authentication header for downloading and sending messages, so
   that those functions work with sites using Basic authentication.

5) Don't swallow log Exceptions.  Instead, allow Exceptions to
   percolate up to higher levels so that they can be logged into
   K9mail-errors.

6) Provide appendMessages function, so that Drafts get stored on the
   server.

7) Enable server-side message deletion, using user-selected Trash
   folder.
2009-10-25 02:58:26 +00:00
Daniel Applebaum
ec25d145d6 Added Account Settings to the message list option menu. Did this
because a user that has auto-open set to a particular folder might
never get to the actual folder list which contains the option menu
containing Account Settings.  (There's been one comment in the Market
pertaining to this.)
2009-10-24 17:10:02 +00:00
Daniel Applebaum
99b239fa71 Issue 675
Prevent a crash, and puts up a Toast, but you have to start over
setting up the account again.

This page needs an effective Back button.
2009-10-23 01:20:12 +00:00
Daniel Applebaum
e315ee9156 Issue 708
Basically, patch submitted by themaninthesuitcase in Issue 708, but
consolidated into a single method.
2009-10-23 01:03:51 +00:00
Bao-Long Nguyen-Trong
09fa19affa Fixed issue 556 2009-10-22 15:54:49 +00:00
Daniel Applebaum
959404cc68 Issue 4: Implements Push Mail for IMAP accounts using IMAP IDLE
This commit contains the entirety of the changes performed in the
issue4-1.X branch from revision 718 through revision 851.  Because the
issue4-1.X branch was up-to-date with trunk revision 847 at revision
849, the source of this commit was not an "svn merge".  Instead, it is
merely a copy of all changed files from the issue4-1.X branch to my
trunk working copy and a straight commit.

Also:
Issue 551
Issue 628
Issue 650
Issue 654
Issue 656
Issue 682
Issue 696
2009-10-22 00:41:06 +00:00
Bao-Long Nguyen-Trong
78da963031 . MessageListener.synchronizeMailboxNewMessage() does not requires a context to be passed anymore.
. We use the application as context when broadcasting message received intents
2009-10-21 04:48:28 +00:00
Bao-Long Nguyen-Trong
4ffe75fa85 Refactored intent constant classes 2009-10-20 05:27:06 +00:00
Bao-Long Nguyen-Trong
7323fe67fd Minor cleanup so that we only broadcast the message received intent once 2009-10-20 04:59:02 +00:00
Bao-Long Nguyen-Trong
a59fcf3e89 . Fixed issue 607
. Added intent for viewing individial messages
2009-10-19 19:35:31 +00:00
Bao-Long Nguyen-Trong
5186c3610f Fixed issue 331: Now delete temporary draft created by screen rotation when email is sent or discarded 2009-10-18 03:34:54 +00:00
Bao-Long Nguyen-Trong
b8f4fdb882 Fixed issue 684: Only accept callbacks if the message uid of the callback is the same one we invoked the controller with. 2009-10-18 03:30:42 +00:00
Bao-Long Nguyen-Trong
4e2ba837aa Fixed issue 663: The source message of the reply was re-loaded every time the screen is rotated populating all fields on top of the framework handling the screen rotation 2009-10-18 03:22:17 +00:00
Bao-Long Nguyen-Trong
b3616e379d Moving a few more things to UI thread as message are not displayed reliably 2009-10-07 18:19:56 +00:00
Bao-Long Nguyen-Trong
791d99fc7a Putting the switch from loading... to downloading.. to the UI thread for this to happen more reliably 2009-10-07 17:23:34 +00:00
Bao-Long Nguyen-Trong
82491ab42b Fixed issue 671 by reverting the part of r788 that introduced it 2009-10-05 04:41:26 +00:00
Daniel Applebaum
b414e4d77d svn merge -c 806 ../issue4-1.X/ .
r806 merged to trunk from issue4-1.X
2009-10-03 16:08:42 +00:00
Daniel Applebaum
02889cfe37 svn merge -c 794 ../issue4-1.X/ .
svn merge -c 800 ../issue4-1.X/ .
svn merge -c 803 ../issue4-1.X/ .

Issue 654
2009-10-03 06:11:29 +00:00
Bao-Long Nguyen-Trong
3bb0d08855 Fixed issue 620
+ removed some dead code in the way

Note: K9 crashed once over ~48hrs so we may need to rework how we use message listener in general
2009-10-03 04:26:22 +00:00
Bao-Long Nguyen-Trong
02e41e6da0 Minor perf optimization using addHeader() instead of setHeader() 2009-09-26 22:47:13 +00:00
Bao-Long Nguyen-Trong
41563f1d64 Minor changes to help with issue 636 2009-09-25 21:06:10 +00:00
Bao-Long Nguyen-Trong
931cc4c243 Minor changes to help with issue 636 2009-09-25 21:02:25 +00:00
Bao-Long Nguyen-Trong
ac022ce467 . Fixed issue 626 and issue 528:
Date header was  not set properly
2009-09-25 19:12:37 +00:00
Bao-Long Nguyen-Trong
c2ca739293 . Added defensive code against empty self BCC address
This fixed issues 639 & 646
2009-09-25 17:02:50 +00:00
Daniel Applebaum
f3312eb064 Eliminate failing Toast. Perhaps it can be restored, if the Toast is
generated in the message handling thread.
2009-09-24 02:09:57 +00:00
Daniel Applebaum
b4b1b081a7 Issue 624
Don't bother going to server while creating an ImapMessage from a UID
2009-09-24 01:06:24 +00:00
Bao-Long Nguyen-Trong
75636b697c Display 'Downloading...' instead of 'Loading...' when we are fetching a message from remote store 2009-09-17 17:40:05 +00:00
Daniel Applebaum
08cd19e5a8 svn merge -x -w -c 760 ../issue4-1.X/ .
Improve reliability of message viewing and composing while still using
MessagingController worker queues

svn merge -x -w -c 761 ../issue4-1.X/ .

Put loading a message from the LocalStore into a ThreadPool executor,
like was done previously in MessageView.  Remote loading still goes
through the work queue.
2009-09-17 03:43:02 +00:00
Daniel Applebaum
5d5c65bee3 svn merge -x -w -c 756 ../issue4-1.X/ .
Increase reliability of MessageView when it is paused then resumed
2009-09-16 12:31:52 +00:00
Bao-Long Nguyen-Trong
d61c7a192c Removed some logging (too verbose) 2009-09-15 05:20:12 +00:00
Daniel Applebaum
ac6358ec5c svn merge -c 749 ../issue4-1.X .
ImapStore.ImapFolder is not thread-safe, so all access to the remote
folders must be done through the work processing of the
MessagingController.
2009-09-15 04:28:37 +00:00
Bao-Long Nguyen-Trong
a4965f042c Fixed issue with encoding of email addresses in the header with non ascii characters. The way were doing it was only compatible with certain email clients (Thunderbird) but not with K-9 itself 2009-09-10 17:33:19 +00:00
Bao-Long Nguyen-Trong
736d330e38 Fixed issue 560: This was happening only when the user has only one account 2009-09-10 17:31:11 +00:00
Bao-Long Nguyen-Trong
c11c484718 Fixed issue 261:Commas within diplay names were considered as delimiters
--> Using built in Rfc822Tokenizer
2009-09-08 07:31:02 +00:00
Daniel Applebaum
3ca12e2bb9 Issue 478 2009-09-03 16:13:00 +00:00
Daniel Applebaum
e9a17ada17 Prevent crashes if user attempts to sort while folder is loading. 2009-08-29 23:08:07 +00:00
Daniel Applebaum
44a52d54a7 Don't crash when no suitable intent found 2009-08-29 22:55:14 +00:00
Daniel Applebaum
d50a16c6b4 Issue 530 2009-08-29 22:40:52 +00:00
Daniel Applebaum
65d7f2180a Issue 505 2009-08-29 22:17:49 +00:00
Daniel Applebaum
8785762986 Issue 575
Partially the patch supplied by mpredosin.

Partially restoration of other lost code.
2009-08-29 22:11:13 +00:00
Daniel Applebaum
033632b3ba Issue 503
Restore lost confirmation dialog.
2009-08-29 21:49:19 +00:00
Daniel Applebaum
280ed0dadd Issue 530
This new method will be useful later.
2009-07-24 05:12:17 +00:00
Daniel Applebaum
f6c6012e11 Issue 553 2009-07-24 03:55:54 +00:00
Daniel Applebaum
f1232a119a Addresses mpredosin's comments on r420 2009-07-24 03:48:49 +00:00
Jesse Vincent
16a31428b5 patch from typester to fix UTF8 headers (such as subject) Resolves issue 534 2009-07-02 05:49:09 +00:00
Bao-Long Nguyen-Trong
6c820c9f75 Removed image/gif from exclusion list so that the images can be viewed and save to SD card 2009-07-02 00:27:17 +00:00
Bao-Long Nguyen-Trong
a912f7aed5 Cleaned up message loading threading solving issues 249 and 524 2009-07-01 21:31:51 +00:00
Bao-Long Nguyen-Trong
2521e032a7 Fixed issue 522 and some minor navigation issue 2009-06-26 18:15:41 +00:00
Bao-Long Nguyen-Trong
c1ec077720 Added comment to document why we override MimeMessage.setRecipients() 2009-06-26 07:03:25 +00:00
Bao-Long Nguyen-Trong
6f8c83e8e3 Restored LocalMessage.setRecipients() and added checks for null and empty address list that allow to unset a recipient list 2009-06-26 06:55:32 +00:00
Bao-Long Nguyen-Trong
99562b8e01 Fixed issue 499 by removing LocalMessage.setRecipients() method to use the super implementation instead.
Anyone knows why was this method overridden in the first place?
2009-06-25 20:25:05 +00:00
Bao-Long Nguyen-Trong
b572c8e065 Fixed issue 497 2009-06-25 17:05:50 +00:00
Bao-Long Nguyen-Trong
3707e0e666 Fixed issue 519 and more navigation issues 2009-06-24 17:51:41 +00:00
Bao-Long Nguyen-Trong
9bf3c9b45a . Fixed navigation issue when going back from message 2009-06-23 16:48:08 +00:00
Bao-Long Nguyen-Trong
e6132286a0 FIxed issue 501 2009-06-23 14:57:16 +00:00
Bao-Long Nguyen-Trong
13cc3899d6 . Fixed issue 504: Added feedback (spinning progress on top right) when checking email in message list
. Added error message toast when checking email fails in message list
2009-06-21 17:20:37 +00:00
Bao-Long Nguyen-Trong
47a8537f08 . Clicking on the new mail notification gets you to the default folder if any else to the folder list 2009-06-20 04:06:44 +00:00