From e0ce5fc4ce9f200270ad0e949afa0f4b974653a3 Mon Sep 17 00:00:00 2001 From: Joe Steele Date: Sun, 23 Mar 2014 11:17:11 -0400 Subject: [PATCH] Eliminate superclass callbacks Service components don't need to call super.onCreate() and super.onDestroy() --- src/com/fsck/k9/service/CoreService.java | 3 --- src/com/fsck/k9/service/DatabaseUpgradeService.java | 2 -- 2 files changed, 5 deletions(-) diff --git a/src/com/fsck/k9/service/CoreService.java b/src/com/fsck/k9/service/CoreService.java index 5f7c1f26f..4f1aadd7a 100644 --- a/src/com/fsck/k9/service/CoreService.java +++ b/src/com/fsck/k9/service/CoreService.java @@ -195,7 +195,6 @@ public abstract class CoreService extends Service { } mThreadPool = Executors.newFixedThreadPool(1); // Must be single threaded - super.onCreate(); } @Override @@ -407,8 +406,6 @@ public abstract class CoreService extends Service { // Shut down thread pool mShutdown = true; mThreadPool.shutdown(); - - super.onDestroy(); } /** diff --git a/src/com/fsck/k9/service/DatabaseUpgradeService.java b/src/com/fsck/k9/service/DatabaseUpgradeService.java index db3b444e9..249af1e66 100644 --- a/src/com/fsck/k9/service/DatabaseUpgradeService.java +++ b/src/com/fsck/k9/service/DatabaseUpgradeService.java @@ -111,8 +111,6 @@ public class DatabaseUpgradeService extends Service { @Override public void onCreate() { - super.onCreate(); - mLocalBroadcastManager = LocalBroadcastManager.getInstance(this); }