moparisthebest/k-9
1
0
Fork 0
mirror of https://github.com/moparisthebest/k-9 synced 2025-02-21 05:01:54 -05:00
Code Issues Releases Wiki Activity

Added yet another work-around for an IMAP server implementation with a creative interpretation of the specification. Sanity check results returned for a SEARCH command.

Browse Source 
Fixes issue 2078
This commit is contained in:
cketti 2010-09-03 13:58:09 +00:00
parent 9d9e669d65
commit b9b15295cd
1 changed files with 28 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
src/com/fsck/k9/mail/store/ImapStore.java
View File

@ -928,7 +928,34 @@ public class ImapStore extends Store
{ {
if (ImapResponseParser.equalsIgnoreCase(response.get(0), "SEARCH")) if (ImapResponseParser.equalsIgnoreCase(response.get(0), "SEARCH"))
{ {
count += response.size() - 1; /*
* At least one server software decided it'd be a nice challenge for
* client implementations to return a message sequence number of 0 when
* no matches were found. So we're doing some sanity checks on the
* returned values before adding them to our message count.
*
* See issue 2078
*/
for (int i = 1, length = response.size(); i < length; i++)
{
Object item = response.get(i);
if (item instanceof String)
{
try
{
// Message sequence number is an unsigned 32-bit number.
long msgSeqNum = Long.parseLong((String)item);
// TODO: Make sure the number isn't larger than the number of
// messages in the folder rather than < 2^32.
if ((msgSeqNum > 0) && (msgSeqNum < (1L << 32)))
{
count++;
}
}
catch (NumberFormatException e) {}
}
}
} }
} }
return count; return count;