moparisthebest/k-9
1
0
Fork 0
mirror of https://github.com/moparisthebest/k-9 synced 2024-11-24 02:12:15 -05:00
Code Issues Releases Wiki Activity

Issue 624

Browse Source 
Don't bother going to server while creating an ImapMessage from a UID
This commit is contained in:
Daniel Applebaum 2009-09-24 01:06:24 +00:00
parent 0b33462ade
commit b4b1b081a7
2 changed files with 1 additions and 27 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/com/android/email/MessagingController.java
View File

@ -1380,8 +1380,6 @@ public class MessagingController implements Runnable {
Message remoteMessage = null; Message remoteMessage = null;
if (!uid.startsWith(Email.LOCAL_UID_PREFIX)) { if (!uid.startsWith(Email.LOCAL_UID_PREFIX)) {
// Why bother with this, perhaps just pass the UID to the store to save a roundtrip? And check for error returns, of course
// Same applies for deletion
remoteMessage = remoteSrcFolder.getMessage(uid); remoteMessage = remoteSrcFolder.getMessage(uid);
} }
if (remoteMessage == null) { if (remoteMessage == null) {

24
src/com/android/email/mail/store/ImapStore.java
View File

@ -585,32 +585,8 @@ public class ImapStore extends Store {
@Override @Override
public Message getMessage(String uid) throws MessagingException { public Message getMessage(String uid) throws MessagingException {
checkOpen();
try {
try {
List<ImapResponse> responses =
executeSimpleCommand(String.format("UID SEARCH UID %S", uid));
for (ImapResponse response : responses) {
// Log.d(Email.LOG_TAG, "Got search response: " + response.get(0) + ", size " + response.size());
if (response.mTag == null && response.get(0).equals("SEARCH")) {
for (int i = 1, count = response.size(); i < count; i++) {
if (uid.equals(response.get(i))) {
return new ImapMessage(uid, this); return new ImapMessage(uid, this);
} }
}
}
}
}
catch (MessagingException me) {
return null;
}
}
catch (IOException ioe) {
throw ioExceptionHandler(mConnection, ioe);
}
return null;
}
@Override @Override
public Message[] getMessages(int start, int end, MessageRetrievalListener listener) public Message[] getMessages(int start, int end, MessageRetrievalListener listener)