From ad5676ed28d94f3ac7e7485249c521852e0cadef Mon Sep 17 00:00:00 2001 From: Andrew Gaul Date: Tue, 25 Oct 2011 20:33:18 -0700 Subject: [PATCH] Fix NPE in Address.Parse Found by FindBugs. Also avoid an allocation in the uncommon case. --- src/com/fsck/k9/mail/Address.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/com/fsck/k9/mail/Address.java b/src/com/fsck/k9/mail/Address.java index 451035b9d..7fbd44aba 100644 --- a/src/com/fsck/k9/mail/Address.java +++ b/src/com/fsck/k9/mail/Address.java @@ -131,10 +131,10 @@ public class Address { * @return An array of 0 or more Addresses. */ public static Address[] parse(String addressList) { - ArrayList
addresses = new ArrayList
(); - if ((addressList == null) && !("".equals(addressList))) { + if (addressList == null || addressList.isEmpty()) { return EMPTY_ADDRESS_ARRAY; } + List
addresses = new ArrayList
(); try { MailboxList parsedList = AddressBuilder.parseAddressList(addressList).flatten(); for (int i = 0, count = parsedList.size(); i < count; i++) {