moparisthebest
/
k-9
mirror of https://github.com/moparisthebest/k-9
1
0
Fork 0
Code Issues Releases Wiki Activity

Make MessageReference fields private

This commit is contained in:
cketti 2015-04-03 20:43:49 +02:00
parent 9275bb2943
commit a3375d7030
3 changed files with 14 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
k9mail/src/androidTest/java/com/fsck/k9/activity/MessageReferenceTest.java
View File

@ -36,27 +36,27 @@ public class MessageReferenceTest {
public void parseIdentityStringWithoutFlag() throws MessagingException {
MessageReference messageReference = new MessageReference("!:byBoYWkh:Zm9sZGVy:MTAxMDEwMTA=");
assertEquals("o hai!", messageReference.accountUuid);
assertEquals("folder", messageReference.folderName);
assertEquals("10101010", messageReference.uid);
assertNull(messageReference.flag);
assertEquals("o hai!", messageReference.getAccountUuid());
assertEquals("folder", messageReference.getFolderName());
assertEquals("10101010", messageReference.getUid());
assertNull(messageReference.getFlag());
}
@Test
public void parseIdentityStringWithFlag() throws MessagingException {
MessageReference messageReference = new MessageReference("!:byBoYWkh:Zm9sZGVy:MTAxMDEwMTA=:ANSWERED");
assertEquals("o hai!", messageReference.accountUuid);
assertEquals("folder", messageReference.folderName);
assertEquals("10101010", messageReference.uid);
assertEquals(Flag.ANSWERED, messageReference.flag);
assertEquals("o hai!", messageReference.getAccountUuid());
assertEquals("folder", messageReference.getFolderName());
assertEquals("10101010", messageReference.getUid());
assertEquals(Flag.ANSWERED, messageReference.getFlag());
}
@Test
public void parseIdentityStringContainingBadVersionNumber() throws MessagingException {
MessageReference messageReference = new MessageReference("@:byBoYWkh:Zm9sZGVy:MTAxMDEwMTA=:ANSWERED");
assertNull(messageReference.accountUuid);
assertNull(messageReference.getAccountUuid());
}
@Test(expected = MessagingException.class)

2
k9mail/src/main/java/com/fsck/k9/activity/MessageCompose.java
View File

@ -2942,7 +2942,7 @@ public class MessageCompose extends K9Activity implements OnClickListener,
@Override
public void loadMessageForViewFinished(Account account, String folder, String uid, LocalMessage message) {
if ((mMessageReference == null) || !mMessageReference.uid.equals(uid)) {
if ((mMessageReference == null) || !mMessageReference.getUid().equals(uid)) {
return;
}

8
k9mail/src/main/java/com/fsck/k9/activity/MessageReference.java
View File

@ -17,10 +17,10 @@ import com.fsck.k9.mail.filter.Base64;
import java.util.StringTokenizer;
public class MessageReference implements Parcelable {
protected final String accountUuid;
protected final String folderName;
protected final String uid;
protected final Flag flag;
private final String accountUuid;
private final String folderName;
private final String uid;
private final Flag flag;
/**