From 2599bdcc752e2e4b98533b167ccc7192eabfc3c8 Mon Sep 17 00:00:00 2001 From: Andrew Gaul Date: Wed, 2 Nov 2011 22:18:30 -0700 Subject: [PATCH] Log Throwable instead of concatenating --- src/com/fsck/k9/K9.java | 2 +- src/com/fsck/k9/activity/setup/FolderSettings.java | 2 +- src/com/fsck/k9/mail/Message.java | 4 ++-- src/com/fsck/k9/mail/store/LocalStore.java | 8 ++++---- src/com/fsck/k9/mail/transport/SmtpTransport.java | 2 +- 5 files changed, 9 insertions(+), 9 deletions(-) diff --git a/src/com/fsck/k9/K9.java b/src/com/fsck/k9/K9.java index 3acd6ecec..fd43cfc6a 100644 --- a/src/com/fsck/k9/K9.java +++ b/src/com/fsck/k9/K9.java @@ -599,7 +599,7 @@ public class K9 extends Application { catch (Exception e) { // Discard , as it means we're not running on a device with strict mode - Log.v(K9.LOG_TAG, "Failed to turn on strict mode " + e); + Log.v(K9.LOG_TAG, "Failed to turn on strict mode", e); } } diff --git a/src/com/fsck/k9/activity/setup/FolderSettings.java b/src/com/fsck/k9/activity/setup/FolderSettings.java index cd48f0475..a461fd083 100644 --- a/src/com/fsck/k9/activity/setup/FolderSettings.java +++ b/src/com/fsck/k9/activity/setup/FolderSettings.java @@ -156,7 +156,7 @@ public class FolderSettings extends K9PreferenceActivity { try { saveSettings(); } catch (MessagingException e) { - Log.e(K9.LOG_TAG, "Saving folder settings failed " + e); + Log.e(K9.LOG_TAG, "Saving folder settings failed", e); } } return super.onKeyDown(keyCode, event); diff --git a/src/com/fsck/k9/mail/Message.java b/src/com/fsck/k9/mail/Message.java index 2a8ee2c57..1afa5ba91 100644 --- a/src/com/fsck/k9/mail/Message.java +++ b/src/com/fsck/k9/mail/Message.java @@ -217,9 +217,9 @@ public abstract class Message implements Part, Body { eolOut.flush(); return out.getCount(); } catch (IOException e) { - Log.e(K9.LOG_TAG, "Failed to calculate a message size: " + e); + Log.e(K9.LOG_TAG, "Failed to calculate a message size", e); } catch (MessagingException e) { - Log.e(K9.LOG_TAG, "Failed to calculate a message size: " + e); + Log.e(K9.LOG_TAG, "Failed to calculate a message size", e); } return 0; } diff --git a/src/com/fsck/k9/mail/store/LocalStore.java b/src/com/fsck/k9/mail/store/LocalStore.java index 6131f74c5..6700ee585 100644 --- a/src/com/fsck/k9/mail/store/LocalStore.java +++ b/src/com/fsck/k9/mail/store/LocalStore.java @@ -299,14 +299,14 @@ public class LocalStore extends Store implements Serializable { String name = cursor.getString(1); update41Metadata(db, prefs, id, name); } catch (Exception e) { - Log.e(K9.LOG_TAG, " error trying to ugpgrade a folder class: " + e); + Log.e(K9.LOG_TAG, " error trying to ugpgrade a folder class", e); } } } catch (SQLiteException e) { - Log.e(K9.LOG_TAG, "Exception while upgrading database to v41. folder classes may have vanished " + e); + Log.e(K9.LOG_TAG, "Exception while upgrading database to v41. folder classes may have vanished", e); } finally { if (cursor != null) { @@ -420,7 +420,7 @@ public class LocalStore extends Store implements Serializable { inTopGroup = prefs.getBoolean(uUid + "." + name + ".inTopGroup", inTopGroup); integrate = prefs.getBoolean(uUid + "." + name + ".integrate", integrate); } catch (Exception e) { - Log.e(K9.LOG_TAG, " Throwing away an error while trying to upgrade folder metadata: " + e); + Log.e(K9.LOG_TAG, " Throwing away an error while trying to upgrade folder metadata", e); } if (displayClass == Folder.FolderClass.NONE) { @@ -1003,7 +1003,7 @@ public class LocalStore extends Store implements Serializable { i++; } } catch (Exception e) { - Log.d(K9.LOG_TAG, "Got an exception " + e); + Log.d(K9.LOG_TAG, "Got an exception", e); } finally { if (cursor != null) { cursor.close(); diff --git a/src/com/fsck/k9/mail/transport/SmtpTransport.java b/src/com/fsck/k9/mail/transport/SmtpTransport.java index 06bcbf53b..e7546190a 100644 --- a/src/com/fsck/k9/mail/transport/SmtpTransport.java +++ b/src/com/fsck/k9/mail/transport/SmtpTransport.java @@ -254,7 +254,7 @@ public class SmtpTransport extends Transport { mLargestAcceptableMessage = Integer.parseInt(result.substring(result.lastIndexOf(' ') + 1)); } catch (Exception e) { if (K9.DEBUG && K9.DEBUG_PROTOCOL_SMTP) { - Log.d(K9.LOG_TAG, "Tried to parse " + result + " and get an int out of the last word: " + e); + Log.d(K9.LOG_TAG, "Tried to parse " + result + " and get an int out of the last word", e); } } }