moparisthebest/k-9
1
0
Fork 0
mirror of https://github.com/moparisthebest/k-9 synced 2024-11-30 13:12:25 -05:00
Code Issues Releases Wiki Activity

Don't create (throw-away) Message objects when starting action mode

Browse Source
This commit is contained in:
cketti 2012-11-02 09:30:23 +01:00
parent c686284a77
commit 966794f169
1 changed files with 30 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

40
src/com/fsck/k9/fragment/MessageListFragment.java
View File

@ -6,8 +6,10 @@ import java.util.Collections;
import java.util.Comparator; import java.util.Comparator;
import java.util.Date; import java.util.Date;
import java.util.EnumMap; import java.util.EnumMap;
import java.util.HashSet;
import java.util.List; import java.util.List;
import java.util.Map; import java.util.Map;
import java.util.Set;
import java.util.concurrent.Future; import java.util.concurrent.Future;
import android.app.Activity; import android.app.Activity;
@ -2218,23 +2220,41 @@ public class MessageListFragment extends SherlockFragment implements OnItemClick
menu.findItem(R.id.spam).setVisible(true); menu.findItem(R.id.spam).setVisible(true);
menu.findItem(R.id.copy).setVisible(true); menu.findItem(R.id.copy).setVisible(true);
// hide uncapable Set<String> accountUuids = getAccountUuidsForSelected();
/*
* TODO think of a better way then looping over all
* messages.
*/
Message[] messages = getCheckedMessages();
Account account;
for (Message message : messages) { for (String accountUuid : accountUuids) {
account = message.getFolder().getAccount(); Account account = mPreferences.getAccount(accountUuid);
setContextCapabilities(account, menu); if (account != null) {
setContextCapabilities(account, menu);
}
} }
} }
return true; return true;
} }
/**
* Get the set of account UUIDs for the selected messages.
*/
private Set<String> getAccountUuidsForSelected() {
int maxAccounts = mAccountUuids.length;
Set<String> accountUuids = new HashSet<String>(maxAccounts);
for (int position = 0, end = mAdapter.getCount(); position < end; position++) {
if (mSelected.get(position, false)) {
Cursor cursor = (Cursor) mAdapter.getItem(position);
String accountUuid = cursor.getString(ACCOUNT_UUID_COLUMN);
accountUuids.add(accountUuid);
if (accountUuids.size() == mAccountUuids.length) {
break;
}
}
}
return accountUuids;
}
@Override @Override
public void onDestroyActionMode(ActionMode mode) { public void onDestroyActionMode(ActionMode mode) {
mActionMode = null; mActionMode = null;