moparisthebest/k-9
1
0
Fork 0
mirror of https://github.com/moparisthebest/k-9 synced 2025-02-12 05:00:20 -05:00
Code Issues Releases Wiki Activity

Make sure settings import doesn't degrade connection security

Browse Source 
Rewrite the now obsolete values "SSL_TLS_OPTIONAL" and "STARTTLS_OPTIONAL"
 to their "*_REQUIRED" counterparts before import.
This commit is contained in:
cketti 2014-03-05 05:32:00 +01:00
parent 0a63466704
commit 75fc76773d
1 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/com/fsck/k9/preferences/SettingsImporter.java
View File

@ -1110,6 +1110,16 @@ public class SettingsImporter {
private static ConnectionSecurity convertConnectionSecurity(String connectionSecurity) { private static ConnectionSecurity convertConnectionSecurity(String connectionSecurity) {
try { try {
/*
* TODO:
* Add proper settings validation and upgrade capability for server settings.
* Once that exists, move this code into a SettingsUpgrader.
*/
if ("SSL_TLS_OPTIONAL".equals(connectionSecurity)) {
return ConnectionSecurity.SSL_TLS_REQUIRED;
} else if ("STARTTLS_OPTIONAL".equals(connectionSecurity)) {
return ConnectionSecurity.STARTTLS_REQUIRED;
}
return ConnectionSecurity.valueOf(connectionSecurity); return ConnectionSecurity.valueOf(connectionSecurity);
} catch (Exception e) { } catch (Exception e) {
return ConnectionSecurity.NONE; return ConnectionSecurity.NONE;